zhengruifeng commented on code in PR #47464:
URL: https://github.com/apache/spark/pull/47464#discussion_r1692601307
##
connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##
@@ -1893,33 +1855,6 @@ class SparkConnectPlanner(
val
yaooqinn commented on PR #47485:
URL: https://github.com/apache/spark/pull/47485#issuecomment-2252246044
cc @cloud-fan @dongjoon-hyun @HyukjinKwon thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
LuciferYang opened a new pull request, #47496:
URL: https://github.com/apache/spark/pull/47496
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
stefankandic opened a new pull request, #47497:
URL: https://github.com/apache/spark/pull/47497
### What changes were proposed in this pull request?
When deserializing map/array that is not part of the struct field, the key
in collation map should just be `{"element": collatio
Fokko opened a new pull request, #47498:
URL: https://github.com/apache/spark/pull/47498
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was t
zhengruifeng commented on PR #47477:
URL: https://github.com/apache/spark/pull/47477#issuecomment-2252444974
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zhengruifeng closed pull request #47477: [SPARK-48998][ML] Meta algorithms
save/load model with SparkSession
URL: https://github.com/apache/spark/pull/47477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nikolamand-db opened a new pull request, #47499:
URL: https://github.com/apache/spark/pull/47499
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### H
nebojsa-db commented on code in PR #47331:
URL: https://github.com/apache/spark/pull/47331#discussion_r1692937421
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##
@@ -892,132 +892,108 @@ case class MapFromEntries(child: Expr
stefankandic commented on PR #47497:
URL: https://github.com/apache/spark/pull/47497#issuecomment-2252576861
@HyukjinKwon Please take a look if you can as you have the context from the
same pyspark change.
--
This is an automated message from the Apache Git Service.
To respond to the mess
pan3793 opened a new pull request, #47500:
URL: https://github.com/apache/spark/pull/47500
### What changes were proposed in this pull request?
Currently, structured logging is constantly activated no matter value of
`spark.log.structuredLogging.enabled`.
### Why are th
ilicmarkodb closed pull request #47486: [SPARK-49003][SQL][COLLATION] Fix
calculating hash value of collated strings
URL: https://github.com/apache/spark/pull/47486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mihailom-db opened a new pull request, #47501:
URL: https://github.com/apache/spark/pull/47501
### What changes were proposed in this pull request?
Fix for multiple parameters support.
### Why are the changes needed?
The use of multiple parameters with identifiers were broken
wayneguow commented on PR #47481:
URL: https://github.com/apache/spark/pull/47481#issuecomment-2252714575
cc @cloud-fan @miland-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
miland-db commented on PR #47481:
URL: https://github.com/apache/spark/pull/47481#issuecomment-2252797606
What happens in non-codegen path if we pass `null` as a parameter? Does it
also fail?
Change for codegen path looks good. What happens if we pass some other
string value instead
LuciferYang commented on PR #47496:
URL: https://github.com/apache/spark/pull/47496#issuecomment-2252872110
cc @HyukjinKwon @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wayneguow commented on code in PR #47481:
URL: https://github.com/apache/spark/pull/47481#discussion_r1693164370
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##
@@ -356,6 +356,8 @@ class StringExpressionsSuite extends Spa
pan3793 commented on PR #47500:
URL: https://github.com/apache/spark/pull/47500#issuecomment-2252881716
cc @gengliangwang @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
wayneguow commented on code in PR #47481:
URL: https://github.com/apache/spark/pull/47481#discussion_r1693171507
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##
@@ -356,6 +356,8 @@ class StringExpressionsSuite extends Spa
ilicmarkodb opened a new pull request, #47502:
URL: https://github.com/apache/spark/pull/47502
### What changes were proposed in this pull request?
Changed hash function to be collation aware.
### Why are the changes needed?
We were getting the wrong hash for collated str
LuciferYang commented on PR #47496:
URL: https://github.com/apache/spark/pull/47496#issuecomment-2252885983
https://github.com/apache/spark/blob/5ccf9ba958f492c1eb4dde22a647ba75aba63d8e/pom.xml#L3165-L3166
https://github.com/apache/spark/blob/5ccf9ba958f492c1eb4dde22a647ba75aba63d8e/
viktorluc-db opened a new pull request, #47503:
URL: https://github.com/apache/spark/pull/47503
### What changes were proposed in this pull request?
Fix for approx_count_distinct not working correctly with collated strings.
### Why are the changes needed?
approx_count_distinc
LuciferYang opened a new pull request, #47504:
URL: https://github.com/apache/spark/pull/47504
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
LuciferYang commented on code in PR #47504:
URL: https://github.com/apache/spark/pull/47504#discussion_r1693195055
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcEncryptionSuite.scala:
##
@@ -21,12 +21,18 @@ import java.util.Random
import org.apa
dongjoon-hyun commented on PR #47496:
URL: https://github.com/apache/spark/pull/47496#issuecomment-2252916931
I agree with adding this because it looks correct. However, let's figure out
why this causes a problem from yesterday, @LuciferYang and @yaooqinn . If you
don't mind, let's hold on
LuciferYang commented on PR #47496:
URL: https://github.com/apache/spark/pull/47496#issuecomment-2252926189
@dongjoon-hyun As I mentioned in the PR description:
1. `sql-on-files.sql` added `CREATE TABLE sql_on_files.test_orc USING ORC AS
SELECT 1;` yesterday
2. we have configured `hado
dongjoon-hyun commented on PR #47496:
URL: https://github.com/apache/spark/pull/47496#issuecomment-2252925497
I updated my comment. I'm going to merge this right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dongjoon-hyun closed pull request #47496: [SPARK-49012][SQL][BUILD] Add
bouncycastle-related test dependencies to the `hive-thriftserver` module to fix
the Maven daily test
URL: https://github.com/apache/spark/pull/47496
--
This is an automated message from the Apache Git Service.
To respond
dongjoon-hyun commented on PR #47496:
URL: https://github.com/apache/spark/pull/47496#issuecomment-2252930370
Thank you, @LuciferYang and @yaooqinn .
To @LuciferYang , yes, what I asked is why `CREATE TABLE
sql_on_files.test_orc USING ORC AS SELECT 1;` is special in the
`FakeKeyProvi
wayneguow commented on code in PR #47481:
URL: https://github.com/apache/spark/pull/47481#discussion_r1693214038
##
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:
##
@@ -424,6 +424,29 @@ class StringFunctionsSuite extends QueryTest with
SharedSparkSess
LuciferYang commented on PR #47496:
URL: https://github.com/apache/spark/pull/47496#issuecomment-2252940141
Yes, that's a good question, but it seems that no other test cases in the
`hive-thriftserver` module have created and written data in Orc format before
yestoday ...

.set(...)
.where(...)
.execute()
```
The reason for having th
allisonwang-db closed pull request #47479: [SPARK-48999][SS] Divide
PythonStreamingDataSourceSimpleSuite
URL: https://github.com/apache/spark/pull/47479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
allisonwang-db commented on PR #47479:
URL: https://github.com/apache/spark/pull/47479#issuecomment-2253214804
Thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
dongjoon-hyun opened a new pull request, #26:
URL: https://github.com/apache/spark-kubernetes-operator/pull/26
### What changes were proposed in this pull request?
This PR aims to avoid `raw` type usage.
### Why are the changes needed?
We need to use use generic types lik
dongjoon-hyun commented on PR #26:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/26#issuecomment-2253225023
Could you review this, @jiangzho and @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
ueshin commented on PR #47495:
URL: https://github.com/apache/spark/pull/47495#issuecomment-2253293672
The failure seems not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ueshin commented on PR #47495:
URL: https://github.com/apache/spark/pull/47495#issuecomment-2253293999
Thanks! merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
ueshin closed pull request #47495: [SPARK-49009][SQL][PYTHON] Make Column APIs
and functions accept Enums
URL: https://github.com/apache/spark/pull/47495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
asfgit closed pull request #47466: [SPARK-48986][CONNECT][SQL] Add ColumnNode
Intermediate Representation
URL: https://github.com/apache/spark/pull/47466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
riyaverm-db opened a new pull request, #47507:
URL: https://github.com/apache/spark/pull/47507
### What changes were proposed in this pull request?
Updating migration doc for #47393
### Why are the changes needed?
Better visibility of the change.
#
riyaverm-db commented on PR #47393:
URL: https://github.com/apache/spark/pull/47393#issuecomment-2253457933
@HeartSaVioR Updated the migration doc here.
https://github.com/apache/spark/pull/47507
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
bogao007 commented on PR #47133:
URL: https://github.com/apache/spark/pull/47133#issuecomment-2253557239
@HyukjinKwon I got some other dependency errors for tests running in yarn
and k8s
```
[info] - run Python application in yarn-client mode *** FAILED *** (4
seconds, 30 milliseconds
riyaverm-db commented on PR #47507:
URL: https://github.com/apache/spark/pull/47507#issuecomment-2253604118
@HeartSaVioR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ericm-db opened a new pull request, #47508:
URL: https://github.com/apache/spark/pull/47508
### What changes were proposed in this pull request?
Implementing validation for the TransformWithStateExec operator, so that it
can't restart with a different TimeMode and OutputMode,
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1693683286
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##
@@ -425,7 +432,10 @@ case class TransformWithStateExec(
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1693683616
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##
@@ -301,17 +301,32 @@ class DriverStatefulProcessorHandle
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1693683837
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##
@@ -301,17 +301,32 @@ class DriverStatefulProcessorHandle
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1693684522
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateVariableUtils.scala:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Softw
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1693684652
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreErrors.scala:
##
@@ -173,8 +173,51 @@ object StateStoreErrors {
StateStore
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1693685002
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreErrors.scala:
##
@@ -173,8 +173,51 @@ object StateStoreErrors {
StateStore
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1693685832
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##
@@ -441,6 +451,66 @@ case class TransformWithStateExec(
n
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1693686472
##
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##
@@ -983,6 +1006,77 @@ class TransformWithStateSuite extends
StateStore
anishshri-db closed pull request #47238: [DO-NOT-MERGE][SPARK-47047][SS] Add
changes to support reading transformWithState value state variables
URL: https://github.com/apache/spark/pull/47238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
anishshri-db commented on PR #47238:
URL: https://github.com/apache/spark/pull/47238#issuecomment-2253643239
Will cover the changes as part of Jing's PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dongjoon-hyun opened a new pull request, #47509:
URL: https://github.com/apache/spark/pull/47509
…
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
dongjoon-hyun commented on PR #26:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/26#issuecomment-2253660716
Thank you, @viirya .
Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
dongjoon-hyun closed pull request #26: [SPARK-49020] Avoid `raw` type usage
URL: https://github.com/apache/spark-kubernetes-operator/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] commented on PR #46085:
URL: https://github.com/apache/spark/pull/46085#issuecomment-2253671372
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
github-actions[bot] closed pull request #45446: [SPARK-47320][SQL] : The
behaviour of Datasets involving self joins is inconsistent, unintuitive, with
contradictions
URL: https://github.com/apache/spark/pull/45446
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] closed pull request #45385: [SPARK-47279][CORE]When the
messageLoop encounter a fatal exception, such as oom, exit the JVM to avoid the
driver hanging forever
URL: https://github.com/apache/spark/pull/45385
--
This is an automated message from the Apache Git Service.
To r
dongjoon-hyun commented on PR #47509:
URL: https://github.com/apache/spark/pull/47509#issuecomment-2253676008
Could you review this when you have some time, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
anishshri-db opened a new pull request, #47510:
URL: https://github.com/apache/spark/pull/47510
### What changes were proposed in this pull request?
Add schema path in metadata table entry, verify expected version and add
operator metadata related test for operator metadata format v2
anishshri-db commented on PR #47510:
URL: https://github.com/apache/spark/pull/47510#issuecomment-2253686033
@ericm-db @HeartSaVioR - could you PTAL ? thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dongjoon-hyun commented on PR #47509:
URL: https://github.com/apache/spark/pull/47509#issuecomment-2253711762
Could you review this PR when you have some time, @yaooqinn ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
viirya commented on code in PR #47509:
URL: https://github.com/apache/spark/pull/47509#discussion_r1693781033
##
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala:
##
@@ -174,6 +174,13 @@ private[rest] class StandaloneSubmitRequestServlet(
conf: Sp
dongjoon-hyun commented on code in PR #47509:
URL: https://github.com/apache/spark/pull/47509#discussion_r1693782472
##
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala:
##
@@ -174,6 +174,13 @@ private[rest] class StandaloneSubmitRequestServlet(
c
dongjoon-hyun commented on PR #47509:
URL: https://github.com/apache/spark/pull/47509#issuecomment-2253752891
Thank you, @viirya . It's removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dongjoon-hyun commented on code in PR #47509:
URL: https://github.com/apache/spark/pull/47509#discussion_r1693797107
##
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala:
##
@@ -216,6 +221,7 @@ private[rest] class StandaloneSubmitRequestServlet(
//
viirya commented on code in PR #47509:
URL: https://github.com/apache/spark/pull/47509#discussion_r1693788302
##
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala:
##
@@ -216,6 +221,7 @@ private[rest] class StandaloneSubmitRequestServlet(
// Filter
1 - 100 of 111 matches
Mail list logo