ilicmarkodb commented on code in PR #47502:
URL: https://github.com/apache/spark/pull/47502#discussion_r1693311745
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala:
##########
@@ -620,6 +620,33 @@ class HashExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkHiveHashForDecimal("123456.123456789012345678901234567890", 38, 31,
1728235666)
}
+ for (collation <- Seq("UTF8_LCASE", "UNICODE_CI")) {
+ test(s"hash equality for collated $collation strings") {
+ val s1 = "aaa"
+ val s2 = "AAA"
+
+ // Interpreted hash value for s1
+ val hash = Murmur3Hash(Seq(Collate(Literal(s1), collation)), 42).eval()
+
+ // Check if interpreted hash value is same as codegen for s1
Review Comment:
yes, but my didn't want to write something like 'Check if interpreted hash
value is same as interpreted and codegen for s1'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
