wayneguow commented on code in PR #47481:
URL: https://github.com/apache/spark/pull/47481#discussion_r1693164370
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##########
@@ -356,6 +356,8 @@ class StringExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
// scalastyle:on
checkEvaluation(
SubstringIndex(Literal("www||apache||org"), Literal( "||"), Literal(2)),
"www||apache")
+ checkEvaluation(SubstringIndex(
+ Literal("www.apache.org"), Literal("."), Literal.create(null,
IntegerType)), null)
Review Comment:
@miland-db For question 1, if we pass null as a parameter without `codegen`,
it does not fail. Current master code with this test case passed(check logic of
`checkEvaluation` will do `checkEvaluationWithoutCodegen`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
