aokolnychyi commented on PR #50137:
URL: https://github.com/apache/spark/pull/50137#issuecomment-2707494998
@cloud-fan, I don't have a strong opinion on this one and can go either way.
One point to keep in mind that Spark will not have the guarantee that the
newly added information to
cloud-fan commented on PR #50137:
URL: https://github.com/apache/spark/pull/50137#issuecomment-2705425290
> Would we deprecate the existing create/replace Table() methods (In
TableCatalog and StagingTableCatalog) for a new one that takes in TableInfo
instead?
Yea this is expected. In
gengliangwang commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1983880092
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##
@@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throw
anoopj commented on PR #50137:
URL: https://github.com/apache/spark/pull/50137#issuecomment-2704514930
> I think we just need to have an interface to hold all table information,
and let createTable/replaceTable take it instead of many parameters.
Thanks for the feedback. Your suggest
cloud-fan commented on PR #50137:
URL: https://github.com/apache/spark/pull/50137#issuecomment-2703005083
From a user's point of view, I feel the new API is a bit cumbersome as I
need to implement my own `TableBuilder`, and then implement `buildTable` to
return it. `TableBuilder` has quite
anoopj commented on PR #50137:
URL: https://github.com/apache/spark/pull/50137#issuecomment-2701473872
> Can we put the new API spec in the PR description? and also mention how
replace table will be supported. It's still not very clear to me what users
need to implement.
Done. PTAL i
cloud-fan commented on PR #50137:
URL: https://github.com/apache/spark/pull/50137#issuecomment-2701218191
Can we put the new API spec in the PR description? and also mention how
replace table will be supported. It's still not very clear to me what users
need to implement.
--
This is an a
cloud-fan commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1981592239
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
beliefer commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1981172203
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##
@@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throws
Un
aokolnychyi commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1980111091
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (
anoopj commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1980076364
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##
@@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throws
Unsu
aokolnychyi commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1980124261
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (
aokolnychyi commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1980125783
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (
anoopj commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1980110293
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
aokolnychyi commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1980111812
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (
anoopj commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1980084846
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##
@@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throws
Unsu
anoopj commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1980002481
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
anoopj commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1979992466
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##
@@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throws
Unsu
beliefer commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1978917410
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##
@@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throws
Un
beliefer commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1978922356
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
beliefer commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1978906318
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##
@@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throws
Un
21 matches
Mail list logo
