anoopj commented on code in PR #50137:
URL: https://github.com/apache/spark/pull/50137#discussion_r1980084846
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throws
UnsupportedOperationExceptio
*/
void renameTable(Identifier oldIdent, Identifier newIdent)
throws NoSuchTableException, TableAlreadyExistsException;
+
+ /**
+ * Instantiate a builder to create a table in the catalog.
+ *
+ * @param ident a table identifier.
+ * @param columns the columns of the new table.
+ * @return the TableBuilder to create a table.
+ */
+ default TableBuilder buildTable(Identifier ident, Column[] columns) {
+ return new TableBuilderImpl(this, ident, columns);
+ }
+
+ /**
+ * Builder used to create tables.
+ *
+ * <p>Call {@link #buildTable(Identifier, Column[])} to create a new builder.
+ */
+ interface TableBuilder {
+ /**
+ * Sets the partitions for the table.
+ *
+ * @param partitions Partitions for the table.
+ * @return this for method chaining
+ */
+ TableBuilder withPartitions(Transform[] partitions);
+
+ /**
+ * Adds key/value properties to the table.
+ *
+ * @param properties key/value properties
+ * @return this for method chaining
+ */
+ TableBuilder withProperties(Map<String, String> properties);
Review Comment:
I am inclined towards just making the API not additive. Most call sites
already have the table properties already materialized as a map. Updating the
PR and the Javadoc accordingly. Please let me know if that sounds reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
