anoopj commented on PR #50137:
URL: https://github.com/apache/spark/pull/50137#issuecomment-2704514930
> I think we just need to have an interface to hold all table information,
and let createTable/replaceTable take it instead of many parameters.
Thanks for the feedback. Your suggestion seems simpler.
@aokolnychyi What do you think?
> ```
> interface TableInfo {
> Column[] columns;
> Transform[] partitions;
> ...
> }
This could just be an inheritable POJO instead?
>
> interface TableCatalog ... {
> Table createTable(Identifier ident, TableInfo t);
> }
> ```
Would we deprecate the existing `create/replace Table()` methods (In
`TableCatalog` and `StagingTableCatalog`) for a new one that takes in
`TableInfo` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
