@kcne pushed 2 commits.
d93f4bf014a33ecd57d2bde4511489102e18a8bf Add heatmap data caching and query
for user contributions
33dcb66b3a04a5f00fd011cba8d603f35ce70173 Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
@AntonKhorev commented on this pull request.
> +:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+)}
+ }.freeze
+
+ NO_USERNAME_PLATFORMS = %w[discord line skype slack].freeze
+
+ def parsed
+URL_PATTERNS.each do |platform, pattern|
+ names = url.match(patter
@HolgerJeromin commented on this pull request.
> @@ -189,6 +192,20 @@ OSM.Directions = function (map) {
turnByTurnTable.append(row);
});
+ const download = exportGroup.toGeoJSON();
+ for (const i in endpoints) {
+download.features[i].properties["marker-color"]
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5402)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
@kcne pushed 2 commits.
766d131acf65f26cce3e26c00ceb4c10acb920b7 Add heatmap data caching and query
for user contributions
1618add8068ed0a2eed38b49f3482234479daf7e Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
@kcne commented on this pull request.
> @@ -4,24 +4,24 @@
"@aashutoshrathi/word-wrap@^1.2.3":
version "1.2.6"
- resolved
"https://registry.yarnpkg.com/@aashutoshrathi/word-wrap/-/word-wrap-1.2.6.tgz#bd9154aec9983f77b3a034ecaa015c2e4201f6cf";
+ resolved
"https://registry.npmjs.org/@aash
@hlfan pushed 1 commit.
bc3abc403aa23bac3ec3e871981da716cf6715d3 Split directions engine select into
modes and providers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/1b5ef5568774abb5988e6098887d4f7c77f5d997..bc3abc403aa23bac3ec3e871981da716cf6715
@AntonKhorev pushed 3 commits.
ab681e56ecc2d30545fcc861de7ba5c3de1b32bc Use follow_redirect! in account
update tests
9929c1b585bd0e0b088cc785af06720d46f2dcce Test account destroy route
d1de8462d6a3b6828c63952e34079739e28823c4 Move edit account action to show
--
View it on GitHub:
https://git
Closed #5356 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5356#event-16337401672
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,8 @@
+<% social_links.each do |social_link| %>
+
+<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ?
'other' : social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil?
@nertc commented on this pull request.
> +# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :messag
@AntonKhorev commented on this pull request.
> +
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:discord => %r{\Ahttps?://(?:www\.)?discord\.com/users/(\d+)},
+:facebook => %r{\Ahttps?://(?:www\.)?facebook\.com/([a-zA
@nertc commented on this pull request.
> @@ -0,0 +1,8 @@
+<% social_links.each do |social_link| %>
+
+<%= image_tag
"/assets/social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' :
social_link.parsed[:platform]}.svg",
Was fixed accordingly, `/assets/` was removed.
--
Reply
@nertc commented on this pull request.
> @@ -10,6 +10,35 @@ $(document).ready(function () {
var defaultHomeZoom = 12;
var map, marker, deleted_lat, deleted_lon;
+ if ($("#social_links").length) {
+$("#add-social-link").click(function (event) {
+ event.preventDefault();
+ c
@nertc pushed 1 commit.
a2918b517d7c610ab0fc5c74fc19c6e5f828d8a9 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/50b63a40f2c2842c1f802845dd52edaf507a8cc0..a2918b517d7c610ab0fc5c74fc19c6e5f828d8a9
You are receiving this becaus
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,8 @@
+<% social_links.each do |social_link| %>
+
+<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ?
'other' : social_link.parsed[:platform]}.svg",
If all images are of the same size, you can add `:size => "16
kcne left a comment (openstreetmap/openstreetmap-website#5298)
After some consideration, we’ve decided that directly querying the data from
the database is a better approach for this feature. I’ve updated the original
issue to reflect these changes.
Additionally, here is the new design we came
@nertc pushed 1 commit.
50b63a40f2c2842c1f802845dd52edaf507a8cc0 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/9301c3723675c94f70a3c2d66176aa6a5e9c779b..50b63a40f2c2842c1f802845dd52edaf507a8cc0
You are receiving this becaus
@nertc commented on this pull request.
> +#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:discord => %r{\Ahttps?://(?:www\.)?discord\.com/users/(\d+)},
+
@nertc commented on this pull request.
> + URL_PATTERNS = {
+:discord => %r{\Ahttps?://(?:www\.)?discord\.com/users/(\d+)},
+:facebook => %r{\Ahttps?://(?:www\.)?facebook\.com/([a-zA-Z0-9.]+)},
+:github => %r{\Ahttps?://(?:www\.)?github\.com/([a-zA-Z0-9_-]+)},
+:gitlab => %r{\Ah
@AntonKhorev commented on this pull request.
> +# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :
@nertc commented on this pull request.
> @@ -0,0 +1,10 @@
+class CreateSocialLinks < ActiveRecord::Migration[7.2]
+ def change
+create_table :social_links do |t|
+ t.references :user, :null => false, :foreign_key => true
+ t.string :url
I agree with you, was fixed accordingly.
-
@AntonKhorev commented on this pull request.
> + URL_PATTERNS = {
+:discord => %r{\Ahttps?://(?:www\.)?discord\.com/users/(\d+)},
+:facebook => %r{\Ahttps?://(?:www\.)?facebook\.com/([a-zA-Z0-9.]+)},
+:github => %r{\Ahttps?://(?:www\.)?github\.com/([a-zA-Z0-9_-]+)},
+:gitlab =>
@AntonKhorev commented on this pull request.
> +# Table name: note_tags
+#
+# note_id :bigint(8)not null, primary key
+# k :string default(""), not null, primary key
+# v :string default(""), not null
+#
+# Foreign Keys
+#
+# note_tags_id_fkey (note_i
@nertc pushed 1 commit.
6d3d9316d353ab824a9046f2c92dc94039fd23b4 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/a2918b517d7c610ab0fc5c74fc19c6e5f828d8a9..6d3d9316d353ab824a9046f2c92dc94039fd23b4
You are receiving this becaus
@AntonKhorev commented on this pull request.
> scope :module => :accounts do
resource :terms, :only => [:show, :update]
resource :pd_declaration, :only => [:show, :create]
resource :deletion, :only => :show
resource :home, :only => :show
end
end
+ get "/
@nertc pushed 1 commit.
9301c3723675c94f70a3c2d66176aa6a5e9c779b Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/698c29697dcf468035de2d270c8f0359e30f4609..9301c3723675c94f70a3c2d66176aa6a5e9c779b
You are receiving this becaus
@AntonKhorev commented on this pull request.
> +
+<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ?
'other' : social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil? ? "other" :
social_link.parsed[:platform],
+
@AntonKhorev commented on this pull request.
> + URL_PATTERNS = {
+:discord => %r{\Ahttps?://(?:www\.)?discord\.com/users/(\d+)},
+:facebook => %r{\Ahttps?://(?:www\.)?facebook\.com/([a-zA-Z0-9.]+)},
+:github => %r{\Ahttps?://(?:www\.)?github\.com/([a-zA-Z0-9_-]+)},
+:gitlab =>
@AntonKhorev commented on this pull request.
> +
+<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ?
'other' : social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil? ? "other" :
social_link.parsed[:platform],
+
@hlfan pushed 3 commits.
e0a0180fa3d5b9651613d57ffa0a944e615a4045 Split engine id into mode and provider
86fde88d7babbc13ec0454f743b11b98aaef0c57 Split engine translations
c51531dda9970891d2e1c7b4530e896ec423050b Split directions engine select into
modes and providers
--
View it on GitHub:
h
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,8 @@
+<% social_links.each do |social_link| %>
+
+<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ?
'other' : social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil?
tyrasd left a comment (openstreetmap/openstreetmap-website#5632)
> fix to uninitialized variables
yeah, but the previous version of the code used the _uninitialized_ state
explicitly to encode the case for when the `#map` parameter should explicitly
be absent in the url of the iD iframe. :wink:
hlfan left a comment (openstreetmap/openstreetmap-website#5698)
> in this case, params.set("map", …) must not be called!
Why would you not want to use the coordinates for nodes, ways and notes if
these are already loaded in the
[site_controller](https://github.com/openstreetmap/openstreetmap-we
@tomhughes commented on this pull request.
> scope :module => :accounts do
resource :terms, :only => [:show, :update]
resource :pd_declaration, :only => [:show, :create]
resource :deletion, :only => :show
resource :home, :only => :show
end
end
+ get "/ac
tomhughes left a comment (openstreetmap/openstreetmap-website#5696)
Thanks. I don't know what the answer is on the redirects but I'll merge this -
we can always remove those later if we can confirm they're not being used.
--
Reply to this email directly or view it on GitHub:
https://github.com/
tomhughes left a comment (openstreetmap/openstreetmap-website#5699)
So just installing those packages (even though we don't use them) somehow
changes vscode's behaviour? Not really sure I like forcing everybody to install
unused packages :-(
--
Reply to this email directly or view it on GitHub
@mmd-osm commented on this pull request.
> +# Table name: note_tags
+#
+# note_id :bigint(8)not null, primary key
+# k :string default(""), not null, primary key
+# v :string default(""), not null
+#
+# Foreign Keys
+#
+# note_tags_id_fkey (note_id =>
@tyrasd pushed 1 commit.
e56340b3ea6024738d03af3c1647019584a09bc3 drop superfluous semicolon
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5698/files/1599c360b0517ac0f6d15d514e0afc7509983c66..e56340b3ea6024738d03af3c1647019584a09bc3
You are receiving this bec
hlfan left a comment (openstreetmap/openstreetmap-website#5632)
The map parameter would always be set. But that was even before the _"stylistic
change without clear improvements"_.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
Fixes https://github.com/openstreetmap/iD/issues/10779, closes #5698
Before the regression from #5632, the location source table was:
typ | | | hash-loc | !hash-loc
:-: | :--: | :-: | :--: | :--:
n/w | data-loc | map-obj | hash-loc | nil
rel | !data-loc | ma
@tomhughes commented on this pull request.
> +# Table name: note_tags
+#
+# note_id :bigint(8)not null, primary key
+# k :string default(""), not null, primary key
+# v :string default(""), not null
+#
+# Foreign Keys
+#
+# note_tags_id_fkey (note_id
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5696)
Squashed everything after the main commit.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5696#issuecomment-2663305878
You are receiving this because you are s
@tomhughes commented on this pull request.
> @@ -10,6 +10,35 @@ $(document).ready(function () {
var defaultHomeZoom = 12;
var map, marker, deleted_lat, deleted_lon;
+ if ($("#social_links").length) {
+$("#add-social-link").click(function (event) {
+ event.preventDefault();
+
Merged #5696 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5696#event-16338749427
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5453)
Superseded by #5689 and #5696.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5453#issuecomment-2664048441
You are receiving this because you are subscribed to t
Closed #5453.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5453#event-16338753154
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Merged #5699 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5699#event-16339554244
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5699)
I guess there's no harm from having a few extra modules...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5699#issuecomment-2664178190
You are receiving this bec
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5699)
> So just installing those packages (even though we don't use them) somehow
> changes vscode's behaviour?
Yes.
The editor searches known files in `node_modules/@types`.
In the past you needed include comments, but this is (
tyrasd left a comment (openstreetmap/openstreetmap-website#5698)
ehrm…
Given that:
* `mapParams.center/.zoom` get the location via different means (either via the
URL's hash, `mlat/mlon` query parameters or the previously last visited
location that's stored in a cookie)
* iD will not auto-cent
tyrasd left a comment (openstreetmap/openstreetmap-website#5698)
> idData already has the coordinates
This one is also a bit confusing. Normally, `idData.lat/.lon` are not present.
If I see this correctly, `idData.lat/.lon` are only set when the editor is
loaded using a `…?note=xxx` link, see 6
tyrasd left a comment (openstreetmap/openstreetmap-website#5698)
> The map parameter would always be set.
not in the iframe's `src` parameter before 5310c5b :shrug:
> Why would you not want to use the coor
@tomhughes commented on this pull request.
I'm not sure there's a good reason for the step by step change of
`edit_account_path` to `account_path` here... I'd be inclined to squash all
that down into the main commit (which already changes some uses) and just have
the two preparatory commits and
@nenad-vujicic pushed 1 commit.
5c9355fccc335eacb870c47498165324bd16f467 Copies description, user_id and
user_ip to notes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5667/files/dbd15559df90af44f226d8843b9ca312a8672649..5c9355fccc335eacb870c47498165324bd16f
Merged #3767 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3767#event-16329980409
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
hlfan left a comment (openstreetmap/openstreetmap-website#5632)
This bug was introduced with [this
fix](https://github.com/openstreetmap/openstreetmap-website/compare/f359a73d5b64e046ab7f783aa37b685ebc65c052..5310c5b9dd67f7d416ee778a36f43c21126a1575)
to uninitialized variables. Making the remain
At least vscode (derivates) provide first class intellisense support out of the
box with that.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreet
tomhughes left a comment (openstreetmap/openstreetmap-website#3767)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3767#issuecomment-2662452085
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5224)
> It's the difference between being a closed source and open source website.
The point is that it is explicitly not the goal of openstreetmap.org to be an
open source replacement for google maps for end users - features on
open
hlfan left a comment (openstreetmap/openstreetmap-website#5698)
idData already has the coordinates, so why can't this be used here?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2662635062
You are receiving thi
tomhughes left a comment (openstreetmap/openstreetmap-website#5697)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5697#issuecomment-2662385149
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5656)
Thanks for the update - this looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5656#issuecomment-2662396259
You are receiving this because you
Merged #5656 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5656#event-16329613549
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5697 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5697#event-16329613565
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan pushed 1 commit.
3939f24460b6c32c25a5432764ff5f4ff5e8dea6 Enable exporting direction paths
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694/files/00d44580539494b7e85b56b294eafe523c6a4338..3939f24460b6c32c25a5432764ff5f4ff5e8dea6
You are receiving thi
fixes https://github.com/openstreetmap/iD/issues/10779 (a regression introduced
in #5632)
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5698
-- Commit Summary --
* don't set map coords if mapParams contains object
tyrasd left a comment (openstreetmap/openstreetmap-website#5632)
FYI, this added a small bug, see
https://github.com/openstreetmap/iD/issues/10779 / #5698
I really appreciate the cleanup efforts of the iD integration code. :+1:
Nevertheless, it would have been nice to tag me in this (and the o
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5667)
> I would also interested in what the next step will be.
At the moment, the plan is following:
1. Perform data migration
2. If we succeeded to migrate all notes, remove optional using records from
first special comment, oth
@hlfan commented on this pull request.
> @@ -36,6 +36,9 @@ OSM.Directions = function (map) {
OSM.DirectionsEndpoint(map, $("input[name='route_to']"), OSM.MARKER_RED,
endpointDragCallback, endpointChangeCallback)
];
+ const exportGroup = L.layerGroup([...endpoints.map(m => m.marker),
@tomhughes commented on this pull request.
> @@ -36,6 +36,9 @@ OSM.Directions = function (map) {
OSM.DirectionsEndpoint(map, $("input[name='route_to']"), OSM.MARKER_RED,
endpointDragCallback, endpointChangeCallback)
];
+ const exportGroup = L.layerGroup([...endpoints.map(m => m.marke
matkoniecz left a comment (openstreetmap/openstreetmap-website#5490)
https://github.com/openstreetmap/openstreetmap-website/pull/5524 seems related
> Add a page to view active blocks
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/iss
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694#pullrequestreview-2620792037
You are receiving this because you are subscribed to this thread.
Message ID:
__
73 matches
Mail list logo
