@tomhughes commented on this pull request.
I'm not sure there's a good reason for the step by step change of
`edit_account_path` to `account_path` here... I'd be inclined to squash all
that down into the main commit (which already changes some uses) and just have
the two preparatory commits and the one main commit.
> scope :module => :accounts do
resource :terms, :only => [:show, :update]
resource :pd_declaration, :only => [:show, :create]
resource :deletion, :only => :show
resource :home, :only => :show
end
end
+ get "/account/edit", :to => redirect(:path => "/account"), :as => nil
Do we actually need this redirect? Are we expecting sites outside
openstreetmap.org to have direct links to the account edit page?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5696#pullrequestreview-2620378439
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5696/review/2620378...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
