@HolgerJeromin commented on this pull request.
> @@ -99,22 +99,18 @@
language: I18n.currentLocale()
}
})
-};
-return $.ajax({
- url: OSM.FOSSGIS_VALHALLA_URL,
- data,
- dataType: "json",
- success: functio
Found some that improve legibility.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5643
-- Commit Summary --
* Enable sort-keys for eslint.js
* Enable more linting rules
-- File Changes --
M app/assets/javas
This pushes json parsing off the js main thread. Hurray
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642#issuecomment-2647180475
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan commented on this pull request.
> @@ -99,22 +99,18 @@
language: I18n.currentLocale()
}
})
-};
-return $.ajax({
- url: OSM.FOSSGIS_VALHALLA_URL,
- data,
- dataType: "json",
- success: function ({ tri
@hlfan pushed 1 commit.
14f5e6345dc4ea14af774d33b41a039483aa8877 Return empty after callback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642/files/b4f0af369d005b15525b775d750cf83838077ffe..14f5e6345dc4ea14af774d33b41a039483aa8877
You are receiving this bec
Merged #5636 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5636#event-16239614619
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5636#issuecomment-2646644395
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
@AntonKhorev pushed 13 commits.
f2ed3c1935610e0409a78c9d4d77b82513048fb4 Make api old element show paths
resourceful
a72199a79183c66684a35e40ce95eb77217035f3 Move api node version test to
integration tests
4c5f7b8913eb4c0c71ecc9dbf9848e6567ca56e7 Test api old node show action without
integra
Start to move from $.ajax to fetch with the thing I recently restructured.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5642
-- Commit Summary --
* Get directions using fetch
-- File Changes --
M app/assets/
This doesn't seem to be an authentication issue?
You seem to be reaching the API endpoint (which I don't believe needs
authentication) and you're getting a redirect to S3 which is not something we
can avoid unless we build our own proxy.
The problem is that the redirect is being rejected by COR
Declares `versions` resources with `show` action on these API paths:
`node/:id/:version`, `way/:id/:version`, `relation/:id/:version`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5641
-- Commit Summary --
* Make
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5640#issuecomment-2646580394
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5640 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5640#event-16239310120
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
>} else if (id.data("lat") && id.data("lon")) {
-params.set("map", "16/" + id.data("lat") + "/" + id.data("lon"));
+map = [null, id.data("lat"), id.data("lon")];
Did you intend to change the zoom from 16 to 17 here?
--
Reply to this email
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5626#issuecomment-2646346208
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634#issuecomment-2646345077
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5633#issuecomment-2646349452
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5634 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634#event-16238524313
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -11,7 +11,7 @@ OSM.Search = function (map) {
e.preventDefault();
var query = $(this).closest("form").find("input[name=query]").val();
if (query) {
- OSM.router.route("/directions?from=" + encodeURIComponent(query) +
OSM.formatH
Merged #5626 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5626#event-16238524312
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5633 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5633#event-16238524325
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan pushed 1 commit.
0a63e7cb90f0535a948c5768cb05f07ba87c54f4 Add button for directions from
location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5635/files/17699d3bfc0895f1a2c2417ca6e383e65c7056e4..0a63e7cb90f0535a948c5768cb05f07ba87c54f4
You are recei
@AntonKhorev pushed 5 commits.
8b60b0236c0b0b51d6921df2cf31731108c331fb Add show_redactions checks to api old
element index tests
d3652e7909255105ef185eea82c7059926f514b3 Test redacted element state after
redaction action
f268d3393f06786e9958fae2a60d7297581ab2ed Test api old element index acc
How is adding another *show location* button better than integrating directions
with the existing button?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5635#issuecomment-2646369474
You are receiving this because you are subscrib