@hlfan commented on this pull request.


>    } else if (id.data("lat") && id.data("lon")) {
-    params.set("map", "16/" + id.data("lat") + "/" + id.data("lon"));
+    map = [null, id.data("lat"), id.data("lon")];

Yes, the secondary default value that was introduced in 
https://github.com/openstreetmap/openstreetmap-website/commit/6494747882358cc1506ae442c89eed3db1de94a4
 seemed like an arbitrary deviation IMO.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5632#discussion_r1948144455
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5632/review/2604308...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to