We added support for Docker-based development in
[2021](https://github.com/openstreetmap/openstreetmap-website/pull/2409) (based
on a PR started in 2019). At this time there were no clear conventions for
setting up docker-based development environments, so we did our own thing.
Nowadays, a numb
@AntonKhorev pushed 1 commit.
45bbc3bbc6c615cb2509e08e36de018fabf987fe Remove classic pagination
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205/files/1c414a44d49d43389b814e9ed1b3de4dab9f8135..45bbc3bbc6c615cb2509e08e36de018fabf987fe
You are receiving this
@kcne pushed 1 commit.
d88ec3046dd0257e856010720417226ffe64e8aa Add tests to note controller and
handle edge cases
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/d87609f00fd6ed04514f08f0dde2ec7279d8df30..d88ec3046dd0257e856010720417226ffe64e8aa
You
@gravitystorm pushed 1 commit.
33d6580f414714408f74872ab9ef5b73c4b92972 Rephrase translation label, and fix
link to docs
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4988/files/e307b9037a05fb6ea0a8790cb6f6e0824781e949..33d6580f414714408f74872ab9ef5b73c4b929
@gravitystorm commented on this pull request.
> @@ -280,8 +280,8 @@
resource :profile, :only => [:edit, :update]
# friendships
- match "/user/:display_name/make_friend" => "friendships#make_friend", :via
=> [:get, :post], :as => "make_friend"
- match "/user/:display_name/remove_friend
@kcne commented on this pull request.
> @@ -27,19 +27,19 @@
- <%= t ".my friends" %>
+ <%= t ".followed users" %>
Maybe use "Following" instead of "Followed users" for better clarity. It aligns
with the common terminology users are familiar with, like "Following" and
"
> These are good reasons why the paginator doesn't have to be cursor-based, but
> they aren't reasons why it can't be cursor-based. So I think the
> simplification of only having one type of pagination is worthwhile.
Those were reasons for why this place is different, why it might be feasible
n
@kcne pushed 1 commit.
84a01a3174d1383e85584f0d6689d4e07a4b6bed Use turbo for filtering on select
without refreshing the whole page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/d88ec3046dd0257e856010720417226ffe64e8aa..84a01a3174d1383e85584f0d668
Thank you for the detailed background and context, Anton. I agree that using
date pickers makes sense if we’re filtering notes by dates, especially since
the current setup isn’t relying on standard pagination.
As for the next steps, I’m not sure whether it’s better to get this PR merged
as is
> About the date pickers:
>
> I wanted to add them to our standard pagination because we already have date
> indexes. Then we wouldn't need them here, specifically in this notes filer.
> But this plan haven't worked so far because:
>
> * I wanted to first add a simpler thing to the standard
@kcne commented on this pull request.
> <% else %>
+ <%= form_tag(url_for("controller" => "notes", "action" => "index"), "method"
=> :get, "data" => { "turbo" => true, "turbo-frame" => "pagination",
"turbo-action" => "advance" }) do %>
+
+
+<%= label_tag :status, t(".status
@kcne commented on this pull request.
> <% else %>
+ <%= form_tag(url_for("controller" => "notes", "action" => "index"), "method"
=> :get, "data" => { "turbo" => true, "turbo-frame" => "pagination",
"turbo-action" => "advance" }) do %>
+
+
+<%= label_tag :status, t(".status
@kcne pushed 1 commit.
7851e30c263079c28a13e18005339c1cdf00e537 Add tests to note controller and
handle edge cases
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/721f8d52810673783b48341ecfbb9b7305ae4134..7851e30c263079c28a13e18005339c1cdf00e537
You
@kcne commented on this pull request.
>
-friends_heading = find :element, "h2", :text => "My friends"
+friends_heading = find :element, "h2", :text => "Followed users"
Maybe use "Following" instead of "Followed users" for better clarity. It
aligns with the common terminology users a
Fixed by @kcne in #5216
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2595#issuecomment-2417317079
You are receiving this because you are subscribed to this thread.
Message ID:
___
Closed #2595 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2595#event-14684076309
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
I've merged both these PRs, so this issue can be closed.
If anyone has ideas for how to automate more aspects of reviewing pull
requests, please open an issue! The more that we can do automatically, the
quicker that contributors will get feedback, and the more likely they are to
update their P
Merged #4919 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4919#event-14684006832
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@kcne pushed 6 commits.
c49aaf4b0256f0c1904b16ec7a71a7176c36b7b4 Add filter and sort scopes to note
model
0117a279264b962663c529c5cb49b14aa2933e4a Add tests for filtering and sort
scopes inside note model
0f1045e9480989d54c2fe6fa7fa37fad1adbfd3f Integrate filtering and sorting
methods into n
Thanks for the suggestion @rkoeze and for making changes based on the feedback.
I've merged this now, let's see how it goes!
Thanks also to @tordans and @nenad-vujicic for reviewing this PR, it's
appreciated.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetma
Closed #4912 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4912#event-14684034773
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
We have a router.js file, which allows page navigation without full page
reloads. However, this functionality is also provided, along with a lot more
things, by Turbo.
We should figure out how to remove our router.js. This would ideally be done
incrementally, but if necessary could be implement