@kcne commented on this pull request.
>
- friends_heading = find :element, "h2", :text => "My friends"
+ friends_heading = find :element, "h2", :text => "Followed users"
Maybe use "Following" instead of "Followed users" for better clarity. It
aligns with the common terminology users are familiar with, like "Following"
and "Followers," which may feel more intuitive.
> - heading: "Unfriend %{user}?"
- button: "Unfriend"
- success: "%{name} was removed from your friends."
- not_a_friend: "%{name} is not one of your friends."
+ follow_user:
+ heading: "Do you want to follow %{user}?"
+ button: "Follow User"
+ success: "You are now following %{name}!"
+ failed: "Sorry, failed to follow %{name}."
+ already_followed: "You already follow %{name}."
+ limit_exceeded: "You have followed a lot of users recently. Please wait
a while before trying to follow any more."
+ unfollow_user:
+ heading: "Do you want to unfollow %{user}?"
+ button: "Unfollow"
+ success: "%{name} was unfollowed by you."
+ not_followed: "%{name} is not followed by you."
A bit more active voicing alternative would be "You are not following %{name}".
> - remove_friend:
- heading: "Unfriend %{user}?"
- button: "Unfriend"
- success: "%{name} was removed from your friends."
- not_a_friend: "%{name} is not one of your friends."
+ follow_user:
+ heading: "Do you want to follow %{user}?"
+ button: "Follow User"
+ success: "You are now following %{name}!"
+ failed: "Sorry, failed to follow %{name}."
+ already_followed: "You already follow %{name}."
+ limit_exceeded: "You have followed a lot of users recently. Please wait
a while before trying to follow any more."
+ unfollow_user:
+ heading: "Do you want to unfollow %{user}?"
+ button: "Unfollow"
+ success: "%{name} was unfollowed by you."
This sound a bit passive to me, altough I'm not sure. Alternative could be
something like "You successfully unfollowed %{name}."
> - heading: "Add %{user} as a friend?"
- button: "Add as friend"
- success: "%{name} is now your friend!"
- failed: "Sorry, failed to add %{name} as a friend."
- already_a_friend: "You are already friends with %{name}."
- limit_exceeded: "You have friended a lot of users recently. Please wait
a while before trying to friend any more."
- remove_friend:
- heading: "Unfriend %{user}?"
- button: "Unfriend"
- success: "%{name} was removed from your friends."
- not_a_friend: "%{name} is not one of your friends."
+ follow_user:
+ heading: "Do you want to follow %{user}?"
+ button: "Follow User"
+ success: "You are now following %{name}!"
+ failed: "Sorry, failed to follow %{name}."
Suggesting one more alternative: "Sorry, your request for following %{name} has
failed." Wording sounds a bit unnatural here imho
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2372819677
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5261/review/2372819...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
