Re: [openstreetmap/openstreetmap-website] Add older/newer links in front of diary, comment, issue, block pages (PR #5262)
@nenad-vujicic approved this pull request. This works great on my side, thank you very much! Wild idea: since we already have decision procedure, which answers the question "do we have multiple pages?", why don't we use it for hiding pagination buttons when they are not required / usable? --
Re: [openstreetmap/openstreetmap-website] Add sorting and filtering functionality to user notes page (PR #5255)
@AntonKhorev commented on this pull request. > <% else %> + <%= form_tag(url_for("controller" => "notes", "action" => "index"), "method" => :get, "data" => { "turbo" => true, "turbo-frame" => "pagination", "turbo-action" => "advance" }) do %> + + +<%= label_tag :status, t("
Re: [openstreetmap/openstreetmap-website] Add sorting and filtering functionality to user notes page (PR #5255)
About the date pickers: I wanted to add them to our standard pagination because we already have date indexes. Then we wouldn't need them here, specifically in this notes filer. But this plan haven't worked so far because: - I wanted to first add a simpler thing to the standard pagination, namel
Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)
@mmd-osm approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3715#pullrequestreview-2370327606 You are receiving this because you are subscribed to this thread. Message ID:
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@AntonKhorev commented on this pull request. > @@ -91,7 +91,7 @@ en: support_url: Support URL allow_read_prefs: read their user preferences allow_write_prefs: modify their user preferences -allow_write_diary: create diary entries, comments and make friends +
Re: [openstreetmap/openstreetmap-website] Add sorting and filtering functionality to user notes page (PR #5255)
@AntonKhorev commented on this pull request. > <% else %> + <%= form_tag(url_for("controller" => "notes", "action" => "index"), "method" => :get, "data" => { "turbo" => true, "turbo-frame" => "pagination", "turbo-action" => "advance" }) do %> + + +<%= label_tag :status, t("
[openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
This PR addresses "Modify the way 'Friends' are added" issue mentioned in https://github.com/openstreetmap/openstreetmap-website/issues/3310 This PR replaces all occurrences of "friends" to "followers", including texts, tests and URLs. This PR was not broken down to smaller pieces to maintain c
Re: [openstreetmap/openstreetmap-website] Remove Nominatim prefixes mention in contributors guide (PR #5260)
Merged #5260 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5260#event-14655708047 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Remove Nominatim prefixes mention in contributors guide (PR #5260)
Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5260#issuecomment-2413622660 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev
Re: [openstreetmap/openstreetmap-website] Share button should preserve the node/way/relation id when creating the URL (Issue #5252)
How do you want the html embed to behave in this case? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5252#issuecomment-2413995449 You are receiving this because you are subscribed to this thread. Message ID: _
[openstreetmap/openstreetmap-website] Add older/newer links in front of diary, comment, issue, block pages (PR #5262)
 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5262 -- Commit Summary -- * Add older/newer links in front of diary, comment,
Re: [openstreetmap/openstreetmap-website] Add older/newer links in front of diary, comment, issue, block pages (PR #5262)
@AntonKhorev pushed 1 commit. 74be3f8b7c4fa192b8f08dcc6d11d88afbcf3c1a Add older/newer links in front of diary, comment, issue, block pages -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5262/files/53fb10f9cc28a7017e423baa5a09b5376ea2ed47..74be3f8b7c4fa192b8f
Re: [openstreetmap/openstreetmap-website] Add older/newer links in front of diary, comment, issue, block pages (PR #5262)
@AntonKhorev pushed 1 commit. 0b053314fd7f427f2b5c8a0c35b583bda43ce0f3 Add older/newer links in front of diary, comment, issue, block pages -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5262/files/74be3f8b7c4fa192b8f08dcc6d11d88afbcf3c1a..0b053314fd7f427f2b5
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@tomhughes commented on this pull request. > @@ -280,8 +280,8 @@ resource :profile, :only => [:edit, :update] # friendships - match "/user/:display_name/make_friend" => "friendships#make_friend", :via => [:get, :post], :as => "make_friend" - match "/user/:display_name/remove_friend" =
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@mmd-osm commented on this pull request. > @@ -1603,12 +1603,12 @@ en: footer_html: "You can also read the message at %{readurl} and you can send a message to the author at %{replyurl}" friendship_notification: hi: "Hi %{to_user}," - subject: "[OpenStreetMap] %{user} add
Re: [openstreetmap/openstreetmap-website] Share button should preserve the node/way/relation id when creating the URL (Issue #5252)
> How do you want the html embed to behave in this case? Naturally it should look just like the picture I posted. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5252#issuecomment-2415783536 You are receiving this because you ar
[openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.0 to 2.3.2 (PR #5263)
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.0 to 2.3.2.Release notes
Sourced from coverallsapp/github-action's releases.
Re: [openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.0 to 2.3.1 (PR #5256)
Closed #5256. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5256#event-14665707249 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.0 to 2.3.1 (PR #5256)
Superseded by #5263. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5256#issuecomment-2415330100 You are receiving this because you are subscribed to this thread. Message ID: ___ rails
Re: [openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.0 to 2.3.2 (PR #5263)
Merged #5263 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5263#event-14665786455 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
