About the date pickers:
I wanted to add them to our standard pagination because we already have date
indexes. Then we wouldn't need them here, specifically in this notes filer. But
this plan haven't worked so far because:
- I wanted to first add a simpler thing to the standard pagination, namely
links to first/last pages. I made several versions of this feature - #4710
#4729 #4733 #4734 - but none of them got much attention from the maintainers. I
can still choose to add date pickers, but this will give me one more pull
request that's going to be in conflict with the others which I'll have to
maintain.
- As you can see this notes list doesn't even use the standard pagination. I
tried doing that too #4532. That wasn't convincing enough because it was too
complicated. The complications were there because I used note ids as a cursor
but I couldn't sort by them, this wouldn't get notes in the last updated order.
The suggested solution by one of the maintainers is to use last comment ids
instead, but it's currently being undermined by another maintainer who wants to
remove opening comments.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5255#issuecomment-2413857393
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5255/c2413857...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
