@AntonKhorev commented on this pull request.


>  <% else %>
+  <%= form_tag(url_for("controller" => "notes", "action" => "index"), "method" 
=> :get, "data" => { "turbo" => true, "turbo-frame" => "pagination", 
"turbo-action" => "advance" }) do %>
+    <div class="row gx-2">
+      <div class="col-md-auto mb-3">
+        <%= label_tag :status, t(".status") %>
+        <%= select_tag  :status,
+                        options_for_select([[t(".all"), "all"], [t(".open"), 
"open"], [t(".closed"), "closed"]], params[:status]),
+                        :include_blank => t(".select_status"),

Why do you need `:include_blank`s? You have labels that say what these selects 
are and the filter acts as if the first options are selected, but you don't 
show them as selected.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5255#pullrequestreview-2369155421
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5255/review/2369155...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to