Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 2 commits. f2e302c6a8c57b6f1902c7bf869b185b0a7f25d5 Suppress writing xml parse errors to stderr 81bac0b09b2d03de76c8885f6d77c9297a3ead34 Don't include stack backtraces on xml errors when importing traces -- View it on GitHub: https://github.com/openstreetmap/openstreetmap

Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)

2024-09-20 Thread Gregory Igelmund via rails-dev
@grekko pushed 1 commit. 3ca9e112922a791e1b8033349d6a605b6b3d5fb9 Ditch Note#comments_with_extra_open_comment -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/33b0cc147b6b7647cac3d4b1e5f99b55d11c5c1a..3ca9e112922a791e1b8033349d6a605b6b3d5fb9 You are

Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)

2024-09-20 Thread Gregory Igelmund via rails-dev
@grekko pushed 1 commit. 297f640e6c0503a23ba8ec72957479d24df05931 Ditch Note#comments_with_extra_open_comment -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/3ca9e112922a791e1b8033349d6a605b6b3d5fb9..297f640e6c0503a23ba8ec72957479d24df05931 You are

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Nenad Vujicic via rails-dev
@nenad-vujicic approved this pull request. This works great on my side, thanks! Regarding detecting file types, it's very hard to do it quickly and efficiently (e.g. xmllint can check if it is valid XML file, but we will pay with higher execution time). /usr/bin/file returns XML file type only

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Anton Khorev via rails-dev
I'm thinking about detecting the filetype after an xml error happens. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2363683587 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Allow exporting direction path tracks (Issue #5224)

2024-09-20 Thread Anton Khorev via rails-dev
> Is there a valid editing use case for this? For links to routing engines I guess it's the same as with Nominatim, which we have. Hopefully they provide more information about why the route was build this way. For exporting from the osm website, you can use the trace as a guide for downloadin

Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)

2024-09-20 Thread Gregory Igelmund via rails-dev
@grekko pushed 1 commit. 0c1fe2325478051164a9165a382a6d8a02be75b0 Ditch Note#comments_with_extra_open_comment and ignore `opened`-event -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/297f640e6c0503a23ba8ec72957479d24df05931..0c1fe2325478051164a9165

Re: [openstreetmap/openstreetmap-website] `/messages/{id}/mark?mark={unread/read}` returns HTML code (Issue #5222)

2024-09-20 Thread Anton Khorev via rails-dev
I'm not convinced that POST actually sends the response body even though Firefox shows it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5222#issuecomment-2363857242 You are receiving this because you are subscribed to this th

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Nenad Vujicic via rails-dev
> > Regarding "Entity: line 1: parser error : Start tag expected, '<' not > > found" message, it's introduced by adding test_parse_error_notification > > which tries to load JPG file with XML reader. > > Do you think that if you upload a binary file without this PR, the error > won't be printed

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

2024-09-20 Thread Anton Khorev via rails-dev
*Duplicate tab* is also broken. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175#issuecomment-2363928828 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Removed unused translations in changesets namespace (PR #5223)

2024-09-20 Thread Tom Hughes via rails-dev
Merged #5223 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5223#event-14343967478 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

2024-09-20 Thread Tom Hughes via rails-dev
Merged #5226 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5226#event-14343967500 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

[openstreetmap/openstreetmap-website] Drop ignore of removed creation_ip column (PR #5228)

2024-09-20 Thread Tom Hughes via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5228 -- Commit Summary -- * Drop ignore of removed creation_ip column -- File Changes -- M app/models/user.rb (2) -- Patch Links -- https://github.com/openstre

Re: [openstreetmap/openstreetmap-website] GPX Upload does not check for filetype (#2630)

2024-09-20 Thread Tom Hughes via rails-dev
Closed #2630 as completed via #5226. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2630#event-14343967807 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Bump puma from 5.6.8 to 5.6.9 (PR #5229)

2024-09-20 Thread Tom Hughes via rails-dev
Merged #5229 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5229#event-14346247418 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Drop ignore of removed creation_ip column (PR #5228)

2024-09-20 Thread Anton Khorev via rails-dev
Merged #5228 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5228#event-14346647427 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Drop ignore of removed creation_ip column (PR #5228)

2024-09-20 Thread Anton Khorev via rails-dev
Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5228#issuecomment-2364735403 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev

[openstreetmap/openstreetmap-website] Bump eslint from 9.10.0 to 9.11.0 (PR #5230)

2024-09-20 Thread dependabot[bot] via rails-dev
Bumps [eslint](https://github.com/eslint/eslint) from 9.10.0 to 9.11.0.
Release notes

Sourced from eslint's releases.

v9.11.0

Features