> Regarding "Entity: line 1: parser error : Start tag expected, '<' not found" 
> message, it's introduced by adding test_parse_error_notification which tries 
> to load JPG file with XML reader.

Do you think that if you upload a binary file without this PR, the error won't 
be printed?

> Perhaps the best would be to redirect stderr to temporary file which could be 
> printed if this test fails?

We don't need this error printed because we're additionally logging it with 
Rails logger.

I disabled xml library error writing for this case but there's also another 
path for multi-file archives with different errors. And there's also a 
changeset diff reader elsewhere.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2363806999
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5226/c2363806...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to