@nenad-vujicic approved this pull request.
This works great on my side, thanks!
Regarding detecting file types, it's very hard to do it quickly and efficiently
(e.g. xmllint can check if it is valid XML file, but we will pay with higher
execution time). /usr/bin/file returns XML file type only if it starts with
"<?xml", which may narrow down the space of supported trace files (devices
generating them).
Regarding "Entity: line 1: parser error : Start tag expected, '<' not found"
message, it's introduced by adding test_parse_error_notification which tries to
load JPG file with XML reader. Perhaps the best would be to redirect stderr to
temporary file which could be printed if this test fails?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#pullrequestreview-2318200364
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5226/review/2318200...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
