> It will make Reporter Users cells too high which will cause additional
> whitespaces in other cells.
Is that additional whitespace going to be a problem?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#issuecomment-2504795
Updated with dark option
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5339#issuecomment-2504759860
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
@AntonKhorev pushed 5 commits.
7b30d1756f787d5e116c62b2d825fd5654119bac Add auto/light color scheme
stylesheets depending on user preferences
35c131fb700567d367599a39199df4cf978b0d37 Show color scheme on user preferences
page
98b0b886966d035b00b97cd52c09654b1f5636aa Add color scheme select to
@AntonKhorev pushed 3 commits.
0147a60b497eb4fe3043a1504bbb754216642e68 Add color scheme select to
preferences form
9db0e9407a05b5abbc69c2f70f1dc30457654b86 Store selected color scheme
0f595ba520ad3fe6340165b71e5f26b64225e321 Don't change color scheme preference
if the value wasn't provided
I find adjusting the current filter from `brightness(0.8)` to `brightness(0.9)
contrast(1.1)` is a big improvement. It slightly reduces the overall light
output without making the map look dull and low contrast. I'd recommend a
tweak along these lines if the maintainers don't want to remove th
Merged #5358 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5358#event-15456656987
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
If a hillshaded map is featured in light mode, and the cartographers' decision
for the dark mode variant is to have a light version of the style without
hillshading be inverted by the browser.
This would mean a different URL/style and a filter. Should this be permitted?
--
Reply to this email d
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5358#issuecomment-2504596459
You are receiving this because you are subscribed to this thread.
Message ID:
___
> Should cartographers have the choice to use a specific style _and_ a filter
> or is it an exclusive or? Because this would change how I would implement
> this choice.
I'm sorry, I don't understand your question.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstr
This PR was discussed at the 10/31 OWG meeting according to the [public
minutes](https://osmfoundation.org/wiki/Operations/Minutes/2024-10-31#Vector_tile_serving).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-
This allows us to enable output safety checks for all code within erb files.
`rubocop --auto-gen-config` ignores code within the erb files, so it is easier
to maintain an exclusion on the helper than inside the layout.
You can view, comment on, or merge this pull request online at:
https://gi
Merged #5357 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5357#event-15456088947
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5357#issuecomment-2504486104
You are receiving this because you are subscribed to this thread.
Message ID:
___
I'm told by some people here that there should have been announcements "on the
official OSM social media" etc and wasn't even a maintainer when I was working
on dark mode.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#is
They have standardized on underscores. See
https://github.com/Shopify/erb_lint/pull/360
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5357
-- Commit Summary --
* Resolve erb_lint deprecations
-- File Changes --
> It wasn't created by another maintainer. Compare the dates of #4712 and #4911.
I don't think that matters, you're a maintainer now! :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2504379378
You are
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4316#issuecomment-2504376554
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #4316 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4316#event-1541989
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Should cartographers have the choice to use a specific style *and* a filter or
is it an exclusive or? Because this would change how I would implement this
choice.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecommen
> However, the PR that implemented the filter
> (https://github.com/openstreetmap/openstreetmap-website/pull/4712) was
> created by another maintainer
It wasn't created by another maintainer. Compare the dates of #4712 and #4911.
--
Reply to this email directly or view it on GitHub:
https://gi
Closed #840 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/840#event-15455162268
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails
Implemented in
https://github.com/openstreetmap/openstreetmap-website/pull/5284,
https://github.com/openstreetmap/openstreetmap-website/pull/5304,
https://github.com/openstreetmap/openstreetmap-website/pull/5310,
https://github.com/openstreetmap/openstreetmap-website/pull/5314,
https://github.
I think if we both agree to add a new preference with 3 options, there's no
need to split that into different pull requests for each option! :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5339#issuecomment-2504289732
You
> "let's make everyone have no filter until _the cartographers_ let them have
> some filter"?
Technically that depends on the discussion in #5328. It doesn't strictly matter
how dark mode maps are implemented, in order to have this preference available
and useful.
But yes, since my preference
I also think that it should have three options. The question is do you want a
larger pull request that adds three options or do you want a smaller one (you
usually say you want small pull requests) that lets you disable the auto dark
mode?
--
Reply to this email directly or view it on GitHub:
> Since the third maintainer doesn't want to discuss dark mode any longer,
While unfortunate behavior at a personal level, in general this response means
they (singular) basically agree to the wider community decision. Which seems to
be reasonably clear and inevitable.
--
Reply to this email d
@gravitystorm Is 5 "let's make everyone use this particular filter in dark
mode" (which filter?) or is it "let's make everyone have no filter until *the
cartographers* let them have some filter"?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
I would prefer #5339
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2504202626
You are receiving this because you are subscribed to this thread.
Message ID:
___
rail
About starting (not) expanded and vertical space:
The first obvious thing that I came up this is to use roughly the same logic
other `` elements are open/closed by default. Way nodes has this line
`>` which expands way nodes
if there are fewer than 10 of them. So I thought I'd expand node ways
I think the preference should have three options - auto (default), light and
dark. In auto mode, either the browser color-mode should be used, or if that's
not available, we should use light mode.
See
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2504102012
fo
I've been asked why we can't merge either #5327 or #5340 to remove the darken
filter.
Normally, maintainers can merge any pull request that they are happy with, and
personally I'd be happy to merge these, since they both fit with my proposals
at
https://github.com/openstreetmap/openstreetmap-
I don't approve of this PR, because I believe the cartographers, not the
developers, should choose what their "dark mode maps" look like. See
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2488361637
--
Reply to this email directly or view it on GitHub:
https://
> Your original description of _Option 4b_ didn't include implementing
> preferences, it had "we shouldn't control those colours in dark mode", that's
> completely different now. It even looks like you agree to change this too:
> "We don't control what colours are used on the maps in light mode"
> can you move specific comments to a new issue about improving communication
> or would we have to start that from scratch again there? Does github have a
> feature like Discourse or just "mark as off-topic"?
No, we can't move comments to a new thread. So please everyone, stay on topic.
We're
Thanks for your comments. Here is my proposal.
(You can think of this as a hierarchy, where each line is an override for the
previous step)
1. We should continue to serve light mode by default.
2. If a browser requests dark mode (through the
[prefers-color-scheme](https://developer.mozilla.org/
@AntonKhorev pushed 6 commits.
1b743448d4a82973f49e34e8d3680cbb6e8afbbf Show "node also part of ways" as
nested lists on way pages
cfe13c548df22e00bba357b37910c399797b75a7 Put nested "also..." lists into
collapsible details
4935fdcf6e1c68c03d4c83be6ca49b156c27281e Group tagless way nodes with
36 matches
Mail list logo
