### URL
_No response_
### How to reproduce the issue?
Use phone to connect to openstreetmap.org
### Screenshot(s) or anything else?
On phone the edit button is now displayed, while it works for iD (if it is
useful is a matter of debate), JOSM RC will not work as is. See
https://github.com/op
@DaveF63
Random OSM user passing by, but my guess is that, per
https://github.com/gravitystorm/openstreetmap-carto/issues/5044, there are
actually no "official" dark tiles from osm-carto yet, so the dimming is a
stop-gap measure to get dark mode published. I would expect the tile-dimming
prob
For the time being this should be discussed in depth and not treated as a
"quick fix". Theres serious implications to changing the color of a map that
has been meticulously colored and iterated on for the past decade.
Realistically, I don't expect a "default" dark map theme until the vector map
> As an alternative to reverting, I have created PR #5325 as a quick fix that
> basically uses one of the filters from this issue.
Please be aware of the performance issues with adding multiple css filters, old
hardware will struggle.
--
Reply to this email directly or view it on GitHub:
https
It darkens the map background, which also dims the map. and no option to
disable dark mode on the page.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-242931
You are receiving this because you are subscri
I quite like the new dark mode. I've used that inversion filter OP mentioned on
my own website, but wasn't a fan due to the terrible performance on old devices.
I think adding `contrast(1.1)` to the filter would help readability.
--
Reply to this email directly or view it on GitHub:
https://git
Agreed, the current darkened map does not look great, especially as iD does not
yet support dark mode at all, and so there's a bit of a jump on editing.
Maybe some layers can be changed for dark mode? Whilst I usually agree that I
don't like dark mode maps, I make an exception for Tracestrack's
There were dozens of pull requests over many months so it was hardly done in a
hurry beyond maybe the final merge to turn it on which I admit took me somewhat
by surprise.
I'll leave an decision about reverting that decision to the person that made it
and and will bow out of all future discussi
> We're not going to be merging anything in a hurry anyway so talk of a
> "hotfix" or of not having time to do things properly is not helpful.
In that case, please revert the dark mode, and I'll close this PR.
I'm proposing this change as a service to the community, with multiple people
having
> I like dark modes in general, but can someone (other than TH) explain the
> reason for the lack of choice & the dimmed tile window?
Is my opinion not welcome then? What exactly have I done to upset you?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/ope
> This "feauture" should at minimum be opt-in.
That is something to disuss at #5324 not here.
> I agree, but that is out of scope for this issue. It would need JavaScript
> changes (basically the [code from the Bootstrap
> docs](https://getbootstrap.com/docs/5.3/customize/color-modes/#javascrip
> how does it look with the other map styles?
 explain the
reason for the lack of choice & the dimmed tile window?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4761#issuecomment-2477526339
You are receiving this
We're not going to be merging anything in a hurry anyway so talk of a "hotfix"
or of not having time to do things properly is not helpful.
If changes are need we should get them right rather than keep cycling through
multiple changes.
Obviously as the person that merged the original change here
how does it look with the other map styles?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2477518825
You are receiving this because you are subscribed to this thread.
Message ID:
__
Why dim the entire map? This makes things very difficult to read... Maybe a
toggle to dim the map would be more appropriate. (As well as a toggle for dark
mode in general)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4712#issu
> There are two options: dim them or invert them
You left out the third option of not changing anything! Just leaving my two
cents here to say this should be reverted. Thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4712#
For what it is worth, as someone that loves dark mode and even has an AMOLED
display that makes a pure black background very easy on the eyes,
for someone that is a fan of dark mode, I don't want my normal map usage to
have tiles that have a dark background.
Only while driving I like having dark
I really hope the dim filter over the map is removed. Either have a proper dark
tile map or just don’t touch it at all. It just looks terribly washed out.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2332#issuecomment-2477483
@nenad-vujicic pushed 2 commits.
54e517b2494b94508dbfb155f5d7f517e175fca9 Added NoteTag model and note_tags
table
ea120b04271d7be36b07cf973246cc1b7e4a9cf8 Added note_tag factory and NoteTag
model test-case
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5323
> This "feauture" should at minimum be opt-in.
I agree, but that is out of scope for this issue. It would need JavaScript
changes (basically the [code from the Bootstrap
docs](https://getbootstrap.com/docs/5.3/customize/color-modes/#javascript)) and
an additional UI element. That's no longer a
There should be absolutely no image or map dimming. It just reduces readability.
Just leaving this comment here so an option is **NOT** created for it. The
dimming shouldn’t be a thing.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/
For what it is worth, as someone that loves dark mode and even has an AMOLED
display that makes a pure black background very easy on the eyes,
for someone that is a fan of dark mode, I don't want my normal map usage to
have tiles that have a dark background.
Only while driving I like having dark
As an alternative to reverting, I have created PR #5325 as a quick fix that
basically uses one of the filters from this issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2332#issuecomment-2477469696
You are receiving this b
### Description
This is basically a hotfix to address the dark mode rollout from today. I'm
new to contributing here and kind of in a hurry, sorry in advance if anything
in this PR isn't perfect.
The current implementation of dark mode is already pretty good, but the tile
display (i.e. the actu
This seems to have been rolled out on the main website.
At least, the main website has some css trick to make the tiles darker on my
firefox on desktop.
The unfortunate downside of this solution is that I can't use the website
anymore. The contrast is too low, the text has become unreadable.
T
Closed #5322 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5322#event-15304091302
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
OK, I read the URI RFC and it seems that indeed every URI type may contain a
query part. And as the z is not standardized in the geo URI RFC, it is fair
enough to put it into the query part.
So I retract my objection here and will create issues elsewhere...
--
Reply to this email directly or v
Can the light/dark/follow system style be made as a user preference? I like
what Dark Reader is doing way more, but it only works with light as a base
style.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2332#issuecomment-247
I agree, there needs to be a config option.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2477298494
You are receiving this because you are subscribed to this thread.
Message ID:
___
@kcne
>Would you know which class should be targeted to apply this effect to the map?
I'm not using the latest version of Leaflet, so I don't know if anything has
changed, but back then I did this:
JS code:
```js
const mapElementId = "map";
map = L.map(mapElementId,
{
attributionControl
The tile screen didn't need dimming; it makes it difficult to read.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2477244820
You are receiving this because you are subscribed to this thread.
Message ID:
### Problem
Browsers do not let you set a per-site dark mode preference. Some users do not
want to use the new dark mode.
### Description
A toggle similar to the Wikipedia appearance (see below). It should probably be
accessible for users who are not logged in, as well.
### Screenshots
![ima
> we get feedback on this
Yes, get it :) I won't ask you to return everything back, because the Edit
button is now more visible for beginners. But the current implementation has a
problem: when you narrow the screen width, there is too much empty space that
the History and Export buttons used t
Merged #5320 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5320#event-15302541431
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -0,0 +1,22 @@
+module Api
+ class NoteSubscriptionsController < ApiController
+before_action :check_api_writable
+before_action :authorize
+
+authorize_resource
+
+def create
+ note_id = params[:note_id].to_i
+ note = Not
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5320#issuecomment-2477071696
You are receiving this because you are subscribed to this thread.
Message ID:
___