> We're not going to be merging anything in a hurry anyway so talk of a
> "hotfix" or of not having time to do things properly is not helpful.
In that case, please revert the dark mode, and I'll close this PR.
I'm proposing this change as a service to the community, with multiple people
having called the page "unusable" now (and I have to say that I agree). And I'm
not interested in spending an hour or more to set up a dev environment. Feel
free to take the change, or modify it, or revert, or don't do anything at all.
I'm fine with all of that. I'm not fine with spending hours now to defend this
proposal.
> If changes are need we should get them right rather than keep cycling through
> multiple changes.
I'm sorry if I misjudged the amount of testing and feedback that goes into a
change like this. That assumption was based on the "dark mode" that was
deployed without regarding, or notifying, the people working on it in #2332,
and it was released in a state that's irritating and confusing users and
seriously breaking accessibility.
Again: If you don't agree with these changes, don't take them, and revert
instead, or simply remove the dimming and have the "bright" tiles displayed and
just the rest of the UI be dark. Or don't do anything, it's not my place to
tell you what to do. I'm just proposing a change here.
> Obviously as the person that merged the original change here this is partly
> down to me but dark mode is not something I use or have any experience with
> so I had little to go on other than my own experience where I find having
> bright things in the middle of a dark screen really odd and hard to look at
> which is why I went with what appeared to be the best available option to get
> something that, while not ideal, was the least worst option for people that
> insisted on using dark mod.
With all due respect, but if you're not even using dark mode, you might not be
the best person to decide what's "the least worst option".
Because right now, dark mode users have to deal with the map looking like
there's an invisible popup somewhere that's dimming everything, and they can't
even revert to looking at OSM in "light mode" without changing their whole
browser to light mode, for all websites.
> my concern is exactly what I think was discussed originally, that I think
> this is completely distorting the colours chosen by the style designer? Which
> we were concerned was not a reasonable thing to and something that might be
> received badly by style designers.
Obliterating the contrast on the existing design is also "completely distorting
the colours".
If you want to keep the colors as they are, remove the dimming and leave the
map bright as it was before. As I said, I'm fine with that, and I think that
most, if not all, dark mode users would still prefer that to the dimmed tiles.
(However, as a dark mode user, I was blown away by the designs in #2332 and
would prefer any of them to a bright map, since, as you said, being blinded in
the dark by tiles not designed for dark mode sucks.)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2477561462
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5325/c2477561...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
