<!-- Please read the contributing guidelines before making a PR: https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md
Pay particular attention to the section on how to present PRs: https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#pull-requests --> ### Description <!--Describe your changes in detail. If you have made changes to the UI, include screenshots. If your PR addresses a Github issue, please link to it.--> Added migration for creating `note_tags` DB table, created model file `NoteTag.rb`, updated associations with `Note` class and added `note_tag` factory and unit tests `NoteTagTests` for testing basic functionalities (key/value lengths validity, key/value lengths invalidity, orphaned tags invalidity and note-tags uniqueness). This PR is first step of adding support for map note tags described in #5294 and which fully implementation can be found [here](https://github.com/nenad-vujicic/openstreetmap-website/tree/issue_5294_poc) (decomposed to smaller because of simpler review). ### How has this been tested? <!--Explain the steps you took to test your code.--> Tested by running linters from `lint.yml` workflow, unit tests and by manually inserting note-tags manipulations and as part of [complete implementation](https://github.com/nenad-vujicic/openstreetmap-website/tree/issue_5294_poc) locally. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5323 -- Commit Summary -- * Added NoteTag model and note_tags table * Added note_tag factory and NoteTag model test-case -- File Changes -- M app/models/note.rb (2) A app/models/note_tag.rb (20) A db/migrate/20241030122707_create_note_tags.rb (13) M db/structure.sql (35) A test/factories/note_tags.rb (8) A test/fixtures/note_tags.yml (11) A test/models/note_tag_test.rb (49) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5323.patch https://github.com/openstreetmap/openstreetmap-website/pull/5323.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5323 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
