[openstreetmap/openstreetmap-website] Bump eslint from 9.11.0 to 9.11.1 (PR #5234)
Bumps [eslint](https://github.com/eslint/eslint) from 9.11.0 to 9.11.1.Now you can check *Map Data*, wait for the rendering to start then quickly click *Map Data* 2*n times and watch how data is added then removed then added then removed... n times. While this is happening and *Map Data* is checked, pan to a different place to get a stream of javascript errors. --
Re: [openstreetmap/openstreetmap-website] Process trace files once (PR #5233)
@nenad-vujicic approved this pull request. Great improvement! It works great on my side. Thank you very much! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5233#pullrequestreview-2323373821 You are receiving this because you a
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm commented on this pull request. > @@ -945,6 +945,76 @@ img.trace_image { .node, .way, .relation { margin-left: 25px; } + + .svg_icon { +overflow: hidden; +display: inline-block; +margin-left: -25px; +width: 25px; +height: 18px; +/*rtl:ignore*/ transfo
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm pushed 1 commit. 2ff0b3617bde2fe206875ef8bc004fdf41aec894 Replaced two png by svg symbols -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/783a05b16398ba8626f8fd3b6be2430e5a336ccc..2ff0b3617bde2fe206875ef8bc004fdf41aec894 You are receiving th
Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)
@AntonKhorev commented on this pull request. > @@ -76,6 +85,15 @@ <%= link_to t("layouts.copyright"), copyright_path, :class => "dropdown-item" %> <%= link_to t("layouts.help"), help_path, :class => "dropdown-item" %> <%= link_to t("layouts.about"), about_path,
[openstreetmap/openstreetmap-website] Process trace files once (PR #5233)
Currently uploaded gpx files are unpacked and parsed each time the `points` method is called. This happens a dozen of times: once for storing the trackpoints in the db, once for generating a thumbnail and once for each frame of an animated trace image. Even if we don't mind reparsing the files o
Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)
@gravitystorm I've reworked the PR a bit based on your feedback. Regarding the readability of the history perspective on the PR changes. Rebasing the branch destroys the git history which breaks the conversation messages attached to specific commits, but I recall that you prefer a rebase becaus
Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)
@grekko commented on this pull request. > + +def call + return false if skip? + + attributes = opened_comment_note.attributes.slice(*%w[body author_id author_ip]).compact_blank + @note.update_columns(attributes) # rubocop:disable Rails/SkipsModelValidations +end + +d
Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)
@grekko pushed 1 commit. a40cd374235fc5d5792700c7de4a27f832e00d39 Fix Note#api_comments, add test for before-migration state -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/2f7d921c7aa3420d56781b75f4523a98e22c08bd..a40cd374235fc5d5792700c7de4a27f832
Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)
@grekko pushed 1 commit. 2f7d921c7aa3420d56781b75f4523a98e22c08bd NotesController#show must only drop first comments if they have been migrated -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/9e6109d8a3143bad6da30a7c0d2b7247bb1851be..2f7d921c7aa3420
Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)
PR was updated to include changes made in the https://github.com/openstreetmap/leaflet-osm/pull/38. As leaflet-osm PR is now merged, this PR can be reviewed and merged. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5009#issueco
Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)
@nertc pushed 1 commit. ca019cd28c25eed1bd211f070b0bd8f10293878d Map Data checkbox: perhaps use toggle slider instead -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/41e606921c8d7a08800b07f43a22d7d64c0ed024..ca019cd28c25eed1bd211f070b0bd8f10293878d
Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)
@grekko pushed 1 commit. 9e6109d8a3143bad6da30a7c0d2b7247bb1851be Add Note#api_comments -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/12cd2335f3c115f2bd56baa4ed0f32eb7a7dd66b..9e6109d8a3143bad6da30a7c0d2b7247bb1851be You are receiving this because
Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)
@grekko pushed 1 commit. 12dfc7cbe77be45aca3640ca374626d0fd9ef282 Add Note#api_comments -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/668d8d2151f938525544c62f418164484fe2a526..12dfc7cbe77be45aca3640ca374626d0fd9ef282 You are receiving this because
Re: [openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)
@grekko pushed 1 commit. 668d8d2151f938525544c62f418164484fe2a526 Add Note#api_comments -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/0c1fe2325478051164a9165a382a6d8a02be75b0..668d8d2151f938525544c62f418164484fe2a526 You are receiving this because
