@gravitystorm I've reworked the PR a bit based on your feedback.
Regarding the readability of the history perspective on the PR changes.
Rebasing the branch destroys the git history which breaks the conversation
messages attached to specific commits, but I recall that you prefer a rebase
because you'd like to avoid merge commits since PRs are not squash-merged into
the `master`-branch.
At this point I'm happy to use this PR as a draft/proposal and rather have
merge conflicts in this Proposal PR than breaking the Github Conversation UI.
If this PR reaches a state in which maintainers are happy to introduce the
changes into the `master`-branch I will create one or more clean slate PRs.
Would that work for you?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-2368032533
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/4481/c2368032...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
