[Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-14 Thread pisa
From: Pavel Pisa Basic emulation of CAN bus controller and interconnection for QEMU. Patches version 4: Resolve comments longer than 80 characters to suppress all warnings reported by scripts/checkpatch.pl. Follow all suggestions from Frederic Konrad review. Replace all printf and perror calls

[Qemu-devel] [PATCH V4 1/7] CAN bus simple messages transport implementation for QEMU

2018-01-14 Thread pisa
From: Pavel Pisa The CanBusState state structure is created for each emulated CAN channel. Individual clients/emulated CAN interfaces or host interface connection registers to the bus by CanBusClientState structure. The CAN core is prepared to support connection to the real host CAN bus network

[Qemu-devel] [PATCH V4 3/7] CAN bus SJA1000 chip register level emulation for QEMU

2018-01-14 Thread pisa
From: Pavel Pisa The core SJA1000 support is independent of following patches which map SJA1000 chip to PCI boards. The work is based on Jin Yang GSoC 2013 work funded by Google and mentored in frame of RTEMS project GSoC slot donated to QEMU. Rewritten for QEMU-2.0+ versions and architecture

[Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-14 Thread pisa
From: Pavel Pisa Connection to the real host CAN bus network through SocketCAN network interface is available only for Linux host system. Mechanism is generic, support for another CAN API and operating systems can be implemented in future. Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs

[Qemu-devel] [PATCH V4 6/7] CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.

2018-01-14 Thread pisa
From: Deniz Eren Signed-off-by: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_pcm3680_pci.c | 336 +++ 2 files changed, 337 insertions(+) create mode 100644 hw/can/can_pcm3680_pci.c diff --git a/hw/can

[Qemu-devel] [PATCH V4 4/7] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2018-01-14 Thread pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- default-configs/pci.mak | 1 + hw/can/Makefile.objs| 1 + hw/can/can_kvaser_pci.c | 375 3 files changed, 377 insertions(+) create mode 100644 hw/can/can_kvaser_pci.c diff --git a/default

[Qemu-devel] [PATCH V4 5/7] QEMU CAN bus emulation documentation

2018-01-14 Thread pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- docs/can.txt | 78 1 file changed, 78 insertions(+) create mode 100644 docs/can.txt diff --git a/docs/can.txt b/docs/can.txt new file mode 100644 index 00..ac3170e947 --- /dev

[Qemu-devel] [PATCH V4 7/7] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.

2018-01-14 Thread pisa
From: Deniz Eren Signed-off-by: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_mioe3680_pci.c | 336 ++ 2 files changed, 337 insertions(+) create mode 100644 hw/can/can_mioe3680_pci.c diff --git a/hw/can

[Qemu-devel] [PATCH 0/6] CAN bus support for QEMU (SJA1000 PCI so far)

2017-10-24 Thread pisa
From: Pavel Pisa Basic emulation of CAN bus controller and interconnection for QEMU. The work has been started by Jin Yang in the frame of GSoC 2013 slot contributed by RTEMS project which has been looking for environment to allow develope and test CAN drivers for multiple CPU rachitectures. I

[Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU

2017-10-24 Thread pisa
From: Pavel Pisa The work is based on Jin Yang GSoC 2013 work funded by Google and mentored in frame of RTEMS project GSoC slot donated to QEMU. Rewritten for QEMU-2.0+ versions and architecture cleanup by Pavel Pisa (Czech Technical University in Prague). The core SJA1000 support is

[Qemu-devel] [PATCH 4/6] Fixed IRQ problem for CAN device can_pcm3680_pci.

2017-10-24 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/can_pcm3680_pci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/can/can_pcm3680_pci.c b/hw/can/can_pcm3680_pci.c index 77523f2ddb..bc6b164ea7 100644 --- a/hw/can/can_pcm3680_pci.c +++ b/hw/can/can_pcm3680_pci.c

[Qemu-devel] [PATCH 2/6] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2017-10-24 Thread pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs| 1 + hw/can/can_kvaser_pci.c | 376 2 files changed, 377 insertions(+) create mode 100644 hw/can/can_kvaser_pci.c diff --git a/hw/can/Makefile.objs b/hw/can

[Qemu-devel] [PATCH 3/6] CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.

2017-10-24 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_pcm3680_pci.c | 325 +++ 2 files changed, 326 insertions(+) create mode 100644 hw/can/can_pcm3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can

[Qemu-devel] [PATCH 5/6] Minor clean-up of can_pcm3680_pci.

2017-10-24 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/can_pcm3680_pci.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/can/can_pcm3680_pci.c b/hw/can/can_pcm3680_pci.c index bc6b164ea7..692aab6ab8 100644 --- a/hw/can/can_pcm3680_pci.c +++ b/hw/can

[Qemu-devel] [PATCH 6/6] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.

2017-10-24 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_mioe3680_pci.c | 335 ++ 2 files changed, 336 insertions(+) create mode 100644 hw/can/can_mioe3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can

[Qemu-devel] [PATCH 0/6] CAN bus support for QEMU (SJA1000 PCI so far)

2017-01-05 Thread pisa
From: Pavel Pisa Hello Stefan and others, I have found some time over holidays. I have rebased patches and checked that the CAN bus emulation works with QEMU-2.8 release. The work has been started by Jin Yang in the frame of GSoC 2013 slot contributed by RTEMS project which has been looking

[Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU

2017-01-05 Thread pisa
From: Pavel Pisa The work is based on Jin Yang GSoC 2013 work funded by Google and mentored in frame of RTEMS project GSoC slot donated to QEMU. Rewritten for QEMU-2.0+ versions and architecture cleanup by Pavel Pisa (Czech Technical University in Prague). The core SJA1000 support is

[Qemu-devel] [PATCH 2/6] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2017-01-05 Thread pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs| 1 + hw/can/can_kvaser_pci.c | 364 2 files changed, 365 insertions(+) create mode 100644 hw/can/can_kvaser_pci.c diff --git a/hw/can/Makefile.objs b/hw/can

[Qemu-devel] [PATCH 5/6] Minor clean-up of can_pcm3680_pci.

2017-01-05 Thread pisa
From: Deniz Eren --- hw/can/can_pcm3680_pci.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/can/can_pcm3680_pci.c b/hw/can/can_pcm3680_pci.c index 9d8d3f7..1134960 100644 --- a/hw/can/can_pcm3680_pci.c +++ b/hw/can/can_pcm3680_pci.c @@ -249,8 +249,7 @@ static void

[Qemu-devel] [PATCH 6/6] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.

2017-01-05 Thread pisa
(deniz.e...@icloud.com) + * + * Based on Kvaser PCI CAN device (SJA1000 based) emulation implemented by + * Jin Yang and Pavel Pisa + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software")

[Qemu-devel] [PATCH 3/6] CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.

2017-01-05 Thread pisa
...@icloud.com) + * + * Based on Kvaser PCI CAN device (SJA1000 based) emulation implemented by + * Jin Yang and Pavel Pisa + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal

[Qemu-devel] [PATCH 4/6] Fixed IRQ problem for CAN device can_pcm3680_pci.

2017-01-05 Thread pisa
From: Deniz Eren --- hw/can/can_pcm3680_pci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/can/can_pcm3680_pci.c b/hw/can/can_pcm3680_pci.c index 6e5c9f2..9d8d3f7 100644 --- a/hw/can/can_pcm3680_pci.c +++ b/hw/can/can_pcm3680_pci.c @@ -61,6 +61,7 @@ typedef struct Pcm3680i

[Qemu-devel] [PATCH 0/5 v2] CAN bus support for QEMU (SJA1000 PCI so far)

2017-11-01 Thread pisa
From: Pavel Pisa Basic emulation of CAN bus controller and interconnection for QEMU. Patches version 2: The bus emulation and the SJA1000 chip emulation introduced by individual patches as suggested by Frederic Konrad. Simple example board to test SJA1000 as single memory-mapped BAR has been

[Qemu-devel] [PATCH 1/5] CAN bus simple messages transport implementation for QEMU

2017-11-01 Thread pisa
From: Pavel Pisa The CanBusState state structure is created for each emulated CAN channel. Individual clients/emulated CAN interfaces or host interface connection registers to the bus by CanBusClientState structure. Connection to the real host CAN bus network through SocketCAN network interface

[Qemu-devel] [PATCH 4/5] CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.

2017-11-01 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_pcm3680_pci.c | 335 +++ 2 files changed, 336 insertions(+) create mode 100644 hw/can/can_pcm3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can

[Qemu-devel] [PATCH 3/5] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2017-11-01 Thread pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- default-configs/pci.mak | 1 + hw/can/Makefile.objs| 1 + hw/can/can_kvaser_pci.c | 376 3 files changed, 378 insertions(+) create mode 100644 hw/can/can_kvaser_pci.c diff --git a/default

[Qemu-devel] [PATCH 2/5] CAN bus SJA1000 chip register level emulation for QEMU

2017-11-01 Thread pisa
From: Pavel Pisa The core SJA1000 support is independent of following patches which map SJA1000 chip to PCI boards. The work is based on Jin Yang GSoC 2013 work funded by Google and mentored in frame of RTEMS project GSoC slot donated to QEMU. Rewritten for QEMU-2.0+ versions and architecture

[Qemu-devel] [PATCH 5/5] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.

2017-11-01 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_mioe3680_pci.c | 335 ++ 2 files changed, 336 insertions(+) create mode 100644 hw/can/can_mioe3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can

[Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-06 Thread pisa
From: Pavel Pisa Basic emulation of CAN bus controller and interconnection for QEMU. Patches version 3: Support to connect to host SocketCAN interface has been separated from the core bus implementation. Only simple statically initialize pointer to the connection function is used, no QOM

[Qemu-devel] [PATCH 1/7] CAN bus simple messages transport implementation for QEMU

2018-01-06 Thread pisa
From: Pavel Pisa The CanBusState state structure is created for each emulated CAN channel. Individual clients/emulated CAN interfaces or host interface connection registers to the bus by CanBusClientState structure. The CAN core is prepared to support connection to the real host CAN bus network

[Qemu-devel] [PATCH 4/7] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2018-01-06 Thread pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- default-configs/pci.mak | 1 + hw/can/Makefile.objs| 1 + hw/can/can_kvaser_pci.c | 375 3 files changed, 377 insertions(+) create mode 100644 hw/can/can_kvaser_pci.c diff --git a/default

[Qemu-devel] [PATCH 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-06 Thread pisa
From: Pavel Pisa Connection to the real host CAN bus network through SocketCAN network interface is available only for Linux host system. Mechanism is generic, support for another CAN API and operating systems can be implemented in future. Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs

[Qemu-devel] [PATCH 5/7] CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.

2018-01-06 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_pcm3680_pci.c | 335 +++ 2 files changed, 336 insertions(+) create mode 100644 hw/can/can_pcm3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can

[Qemu-devel] [PATCH 3/7] CAN bus SJA1000 chip register level emulation for QEMU

2018-01-06 Thread pisa
From: Pavel Pisa The core SJA1000 support is independent of following patches which map SJA1000 chip to PCI boards. The work is based on Jin Yang GSoC 2013 work funded by Google and mentored in frame of RTEMS project GSoC slot donated to QEMU. Rewritten for QEMU-2.0+ versions and architecture

[Qemu-devel] [PATCH 6/7] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.

2018-01-06 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_mioe3680_pci.c | 335 ++ 2 files changed, 336 insertions(+) create mode 100644 hw/can/can_mioe3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can

[Qemu-devel] [PATCH 7/7] QEMU CAN bus emulation documentation

2018-01-06 Thread pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- docs/can.txt | 78 1 file changed, 78 insertions(+) create mode 100644 docs/can.txt diff --git a/docs/can.txt b/docs/can.txt new file mode 100644 index 00..ac3170e947 --- /dev

[PATCH v1 0/6] CTU CAN FD core support

2020-07-14 Thread pisa
From: Pavel Pisa CTU CAN FD is an open source soft core written in VHDL. It originated in 2015 as Ondrej Ille's project at the Department of Measurement of FEE at CTU. Integration for Xilinx Zynq and Intel based SoCs is available as well as support for PCIe integration of the core. The

[PATCH v1 1/6] net/can: Initial host SocketCan support for CAN FD.

2020-07-14 Thread pisa
From: Jan Charvat Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa --- hw/net/can/can_sja1000.c | 2 ++ include/net/can_emu.h| 8 ++- net/can/can_socketcan.c | 47 +--- 3 files changed, 53 insertions(+), 4 deletions(-) diff --git a/hw/net

[PATCH v1 2/6] hw/net/can: sja1000 ignore CAN FD frames

2020-07-14 Thread pisa
From: Jan Charvat Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa --- hw/net/can/can_sja1000.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c index d83c550edc..382911560c 100644 --- a

[PATCH v1 3/6] net/can: Add can_dlc2len and can_len2dlc for CAN FD.

2020-07-14 Thread pisa
From: Jan Charvat Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa --- include/net/can_emu.h | 4 net/can/can_core.c| 36 2 files changed, 40 insertions(+) diff --git a/include/net/can_emu.h b/include/net/can_emu.h index c6164dcfb4

[PATCH v1 4/6] hw/net/can/ctucafd: Add CTU CAN FD core register definitions.

2020-07-14 Thread pisa
implementation. Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa --- hw/net/can/ctu_can_fd_frame.h | 190 +++ hw/net/can/ctu_can_fd_regs.h | 972 ++ 2 files changed, 1162 insertions(+) create mode 100644 hw/net/can/ctu_can_fd_frame.h create mode 100644 hw/net/can

[PATCH v1 5/6] hw/net/can: CTU CAN FD IP open hardware core emulation.

2020-07-14 Thread pisa
-bus by QEMU parameters -device ctucan_pci,canbus0=canbus0-bus,canbus1=canbus0-bus Signed-off-by: Jan Charvat Signed-off-by: Pavel Pisa --- hw/net/can/Makefile.objs | 3 + hw/net/can/ctucan_core.c | 691 +++ hw/net/can/ctucan_core.h | 127 +++ hw

[PATCH v1 6/6] hw/net/can: Documentation for CTU CAN FD IP open hardware core emulation.

2020-07-14 Thread pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- MAINTAINERS | 8 docs/can.txt | 113 ++- 2 files changed, 110 insertions(+), 11 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fe8139f367..d554a1cb41 100644 --- a/MAINTAINERS

[PATCH v2 0/7] CTU CAN FD core support

2020-09-03 Thread pisa
From: Pavel Pisa CTU CAN FD is an open source soft core written in VHDL. It originated in 2015 as Ondrej Ille's project at the Department of Measurement of FEE at CTU. Integration for Xilinx Zynq and Intel based SoCs is available as well as support for PCIe integration of the core. The

[Qemu-devel] [PATCH 0/2] CAN SJA100 controller emulation and SocketCAN based host CAN bus access

2014-05-09 Thread Pavel Pisa
or now. Some filters union and application to the SocketCAN can be usesfull for future. But separation of CAN bus model out of chardev and or vlan allows to implement CAN specific things more easily. Best wishes, Pavel -- Pavel Pisa e-mail: p...@cmp.fel

[Qemu-devel] [PATCH 2/2] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2014-05-09 Thread Pavel Pisa
Signed-off-by: Pavel Pisa --- hw/net/Makefile.objs| 1 + hw/net/can_kvaser_pci.c | 355 2 files changed, 356 insertions(+) create mode 100644 hw/net/can_kvaser_pci.c diff --git a/hw/net/Makefile.objs b/hw/net/Makefile.objs index 28679fc

Re: [Qemu-devel] [PATCH 0/2] CAN SJA100 controller emulation and SocketCAN based host CAN bus access

2014-05-15 Thread Pavel Pisa
in the next post. Even that it is one of potential users, original "investor", internals of the emulation are out of this project scope. On Monday 12 of May 2014 11:18:09 Andreas Färber wrote: > Am 12.05.2014 11:01, schrieb Peter Crosthwaite: > > On Sat, May 10, 2014 at 4:14 AM

Re: [Qemu-devel] [PATCH 0/2] CAN SJA100 controller emulation and SocketCAN based host CAN bus access

2014-05-23 Thread Pavel Pisa
Hello Stefan, On Friday 23 of May 2014 11:42:25 Stefan Hajnoczi wrote: > On Thu, May 15, 2014 at 03:53:07PM +0200, Pavel Pisa wrote: > > The decisions for further development > > > > Should be minimal working solution included in the QEMU > > mainline in short term? &g

Re: [Qemu-devel] Writing a CAN driver for QEMU

2013-05-18 Thread Pavel Pisa
that one big carmaker in cooperation with one big chip maker has full CAN controller and network model including bit-timing implemented. But I do not know more and it is possible that their implementation is to complex for reuse in QEMU (and probly even not publicable). But we should disc

Re: [Qemu-devel] Writing a CAN driver for QEMU

2013-05-19 Thread Pavel Pisa
Hello Andreas and others, On Sunday 19 May 2013 20:23:55 Andreas Färber wrote: > Am 18.05.2013 20:24, schrieb Rempel, Cynthia: > >>> The RTEMS development community is considering having a Google Summer > >>> of Code student test LinCAN on a simulated RTEMS target board using > >>> QEMU, and have

[Qemu-devel] PCI CAN interface emulation updated for QEMU 2.4

2015-09-07 Thread Pavel Pisa
ps://devel.rtems.org/wiki/Developer/Simulators/QEMU/CANEmulation Relevant commits commit 2d873a9ed3bcb8301a247f36b77227b1cd9211c0 Author: Pavel Pisa Date: Mon Sep 7 15:24:56 2015 +0200 CAN bus simple SJA1000 PCI card emulation for QEMU The work is based on Jin Yang GSoC 2013 work fund

Re: [PATCH] hw/net/can: Add mcp25625 model

2023-01-17 Thread Pavel Pisa
bedded World where we plan to show CAN latency tester demo with CTU CAN FD and some MCUs... Best wishes, Pavel -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13,

Re: [PATCH v2] hw/net/can: Add mcp25625 model

2023-03-27 Thread Pavel Pisa
There is tracing support with --trace "*mcp25*" > > Signed-off-by: Ben Dooks > Co-developed-by: Nazar Kazakov > Signed-off-by: Nazar Kazakov > Co-developed-by: Lawrence Hunter > Signed-off-by: Lawrence Hunter > Reviewed-by: Frank Chang Tested-by: Pavel P

Re: [PATCH v2] hw/net/can: Add mcp25625 model

2023-03-17 Thread Pavel Pisa
does not provide right SPI emulation as you have noticed, what about BeagleBoneBlack? Does it support SPI? It could be good target to test that mcp25625 chip emulation is portable.. Best wishes, Pavel -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.fe

Re: QEMU CAN-FD emulation

2022-01-19 Thread Pavel Pisa
itial ramdisk to test QEMU and kernel from it. On Monday 17 of January 2022 17:31:32 Pavel Pisa wrote: > If you can reach shell prompt in the target system > you should check that Kvaser CAN controller is seen > on PCI bus. > > Try > > lspci -nn > > You should see t

Re: [QEMU][PATCH 2/5] hw/net/can: Introduce Xilinx Versal CANFD controller

2022-09-22 Thread Pavel Pisa
including some short netion of QEMU integration https://can-newsletter.org/uploads/media/raw/a9abe317ae034be55d99fee4410ad70e.pdf I hope I wind some time for CAN in QEMU, RTEMS and Linux ongoing projects, but I need to finish some promissed project for ESA the first. Best wishes,

Re: [PATCH] treewide: Remove the unnecessary space before semicolon

2022-10-24 Thread Pavel Pisa
| 2 +- > hw/net/can/can_sja1000.c | 2 +- Acked-by: Pave Pisa > hw/timer/renesas_cmt.c | 2 +- > hw/timer/renesas_tmr.c | 8 > hw/virtio/virtio-pci.c | 2 +- > target/riscv/vector_helper.c | 2 +- > target/rx/op_helper.c| 4 ++-- > ui

Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-20 Thread Pavel Pisa
{ > is_canfd_frame = true; > > /* Store dlc value in Xilinx specific format. */ Reviewed-by: Pavel Pisa That is a great catch, I have overlooked this in previous review of the Xilinx code. When I look into hw/net/can/xlnx-versal-canfd.c functions regs2f

Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-21 Thread Pavel Pisa
ree time which should have at least some maintainership backup by somebody who intend to use the project in frame of company or some automotive consortium. I know that there are big money flowing on base of these activities. Best wishes, Pavel Pisa phone: +420 603531

Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-25 Thread Pavel Pisa
ishes, Pavel -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121 35, Prague 2 university: http://control.fel.cvut.cz/ personal: http://cmp.felk.cvut.c

Re: [PATCH v2 1/7] hw/net/can/xlnx-versal-canfd: Fix interrupt level

2024-08-29 Thread Pavel Pisa
applying it, resulting in the IRQ never being delivered. > > Signed-off-by: Doug Brown > Reviewed-by: Francisco Iglesias Reviewed-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering

Re: [PATCH v2 2/7] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-29 Thread Pavel Pisa
Brown > Reviewed-by: Pavel Pisa > Reviewed-by: Francisco Iglesias Reviewed-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121 35, Pra

Re: [PATCH v2 3/7] hw/net/can/xlnx-versal-canfd: Translate CAN ID registers

2024-08-29 Thread Pavel Pisa
me for all of its ID registers. Correct this problem for > both RX and TX, including RX filtering. > > Signed-off-by: Doug Brown > Reviewed-by: Francisco Iglesias Acked-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut

Re: [PATCH v2 4/7] hw/net/can/xlnx-versal-canfd: Handle flags correctly

2024-08-29 Thread Pavel Pisa
o it's only implemented for the receive case. > > Signed-off-by: Doug Brown Reviewed-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121

Re: [PATCH v2 5/7] hw/net/can/xlnx-versal-canfd: Fix byte ordering

2024-08-29 Thread Pavel Pisa
TX and RX code to put the data in the correct order. > > Signed-off-by: Doug Brown > Reviewed-by: Francisco Iglesias Acked-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT

Re: [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions

2024-08-29 Thread Pavel Pisa
DLC of 0-8, which was broken previously. > > Signed-off-by: Doug Brown Reviewed-by: Pavel Pisa -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121 35, Prague

Re: [PATCH v2 7/7] hw/net/can/xlnx-versal-canfd: Fix FIFO issues

2024-08-29 Thread Pavel Pisa
per analysis if no other looks into the whole code. Best wishes, Pavel -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121 35, Prague 2 university: http://con

CTU CAN FD IP core SocketCAN driver - success with mainine Linux kernel and mainline QEMU builds

2022-05-27 Thread Pavel Pisa
QtRvSim – RISC-V Simulator for Computer Architectures Classes, June 21, 2022 Session 10.3 – System-on-Chip (SoC) Design RISC-V Development (16:00 - 16:30) at Embedded World Conference. Our toy there https://github.com/cvut/qtrvsim Best wishes, Pavel Pisa phone: +420 603531357

[PATCH] docs/system/devices/can.rst: correct links to CTU CAN FD IP core documentation.

2022-04-02 Thread Pavel Pisa
Signed-off-by: Pavel Pisa --- docs/system/devices/can.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/system/devices/can.rst b/docs/system/devices/can.rst index 16d72c3ac3..fe37af8223 100644 --- a/docs/system/devices/can.rst +++ b/docs/system/devices/can.rst

Re: [PATCH] docs: use "buses" rather than "busses"

2024-01-03 Thread Pavel Pisa
ed-off-by: Samuel Tardieu Reviewed-by: Pavel Pisa PS: there is waiting my previous CAN FIX from December 14 and I have received any feedback if it will be taken by somebody with commit rights https://gitlab.com/qemu-project/qemu/-/issues/2028 https://patchew.org/QEMU/20231214104623.31147-1-p...@fel.cvut.cz/ Should I resend it?

[PATCH v2] hw/net/can/sja1000: fix bug for single acceptance filter and standard frame

2024-01-03 Thread Pavel Pisa
From: Pavel Pisa A CAN sja1000 standard frame filter mask has been computed and applied incorrectly for standard frames when single Acceptance Filter Mode (MOD_AFM = 1) has been selected. The problem has not been found by Linux kernel testing because it uses dual filter mode (MOD_AFM = 0) and

[PATCH] hw/net/can/sja1000: fix bug for single acceptance filer and standard frame

2023-12-14 Thread Pavel Pisa
From: Pavel Pisa A CAN sja1000 standard frame filter mask has been computed and applied incorrectly for standard frames when single Acceptance Filter Mode (MOD_AFM = 1) has been selected. The problem has not been found by Linux kernel testing because it uses dual filter mode (MOD_AFM = 0) and

Re: [PATCH] MAINTAINERS: Add the can documenation file to the CAN section

2023-10-29 Thread Pavel Pisa
changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index cce6feff35..48d45b958f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2606,6 +2606,7 @@ W: https://canbus.pages.fel.cvut.cz/ > F: net/can/* > F: hw/net/can/* > F: include/net/can_*.h > +F

Re: [Qemu-devel] [PATCH] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.

2016-09-08 Thread Pavel Pisa
Hello Deniz, thanks much for contribution and testing. I have applied your patches to our QEMU repo https://github.com/CTU-IIG/qemu You find QEMU-2.6.1 based version of our merged patches on "merged-2.6" branch. I have updated and shortly tested all our topic branches with actual QEMU-2.7.0

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-23 Thread Pavel Pisa
Hello Philippe, On Monday 22 of January 2018 12:35:33 Philippe Mathieu-Daudé wrote: > Hi Pavel, > > On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > > I think your series is quite ready to get accepted, although I'm not > sure through with tree it will goes. > > Most of my review comments ar

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-24 Thread Pavel Pisa
Hello everybody, On Tuesday 23 of January 2018 22:42:31 Pavel Pisa wrote: > When Linux specific object file is linked in then some local > function needs to be called before QOM instances population. > I know how to do that GCC specific/non-portable way > > static void __attribute

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-25 Thread Pavel Pisa
Hello Philippe, On Wednesday 24 of January 2018 22:41:16 Philippe Mathieu-Daudé wrote: > Hi Pavel, > > I have seen that a few other type_init-s do more > > than simple sequence of type_register_static(). > > Is it acceptable to use type_init for registration > > to CAN core by function call for no

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-25 Thread Pavel Pisa
. Contributions/suggestions from other are welcomed. I can look for students for GSoC at our university or under other funding. On Thursday 25 of January 2018 14:58:41 Paolo Bonzini wrote: > On 23/01/2018 22:42, Pavel Pisa wrote: > > Do you think QOM based? I would like it to be implemented > >

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-28 Thread Pavel Pisa
Hello Paolo, On Friday 26 of January 2018 12:12:32 Paolo Bonzini wrote: > Coincidentially, I have some time on a flight next Monday. :) I > obviously cannot really _test_ anything, but I can at least do the > changes below and set up all the QOM boilerplate. thanks much for offer to help. Deniz

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-30 Thread Pavel Pisa
Hello Paolo, thanks much for conversion to acceptable QOM model. On Tuesday 30 of January 2018 15:15:22 Paolo Bonzini wrote: > On 25/01/2018 22:33, Pavel Pisa wrote: > > Hello Paolo, > > > > thanks for suggestions. I understand and fully agree with your > > reque

Re: [Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-13 Thread Pavel Pisa
Hello Konrad, thanks for review. On Friday 12 of January 2018 11:43:18 KONRAD Frederic wrote: > You should add that to the title as well: > > git format-patch ... --subject-prefix="PATCH V3" ... > > to avoid any confusion. OK, I add V4. > You need to run the ./scripts/checkpatch.pl on your patc

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-15 Thread Pavel Pisa
wrote: > Hi Pavel, > > I'm CC'ing the QEMU Sockets maintainer to ask them a quick review of the > socket part. > > On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > > From: Pavel Pisa > Please move those checks out of the function, to call them on

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

2018-01-19 Thread Pavel Pisa
Hello Philippe, On Tuesday 16 of January 2018 01:12:09 Philippe Mathieu-Daudé wrote: > On 01/15/2018 06:29 PM, Pavel Pisa wrote: > > Hello Philippe, > > > > thanks for review. > > > > I have updated patch series in can-pci branch in > > > >

Re: [Qemu-devel] [PATCH V4 1/7] CAN bus simple messages transport implementation for QEMU

2018-01-19 Thread Pavel Pisa
Hello Philippe, On Friday 19 of January 2018 13:38:11 Philippe Mathieu-Daudé wrote: > On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > > From: Pavel Pisa > > > > +extern int (*can_bus_connect_to_host_variant)(CanBusState *bus, > > +

Re: [Qemu-devel] [PATCH V4 1/7] CAN bus simple messages transport implementation for QEMU

2018-01-19 Thread Pavel Pisa
Hello Philippe, On Friday 19 of January 2018 13:38:11 Philippe Mathieu-Daudé wrote: > > diff --git a/hw/can/Makefile.objs b/hw/can/Makefile.objs > > new file mode 100644 > > index 00..1028d7c455 > > --- /dev/null > > +++ b/hw/can/Makefile.objs > > @@ -0,0 +1,6 @@ > > +# CAN bus interfaces

Re: [Qemu-devel] [PATCH 4/6] Fixed IRQ problem for CAN device can_pcm3680_pci.

2017-10-25 Thread Pavel Pisa
d series. If review leads to need update whole series, I merge this to previous one before posting. Thanks much for your time, Pavel > On 10/25/2017 01:29 AM, p...@cmp.felk.cvut.cz wrote: > > From: Deniz Eren > > > > Signed-off-by: Pavel Pisa > > --- > > hw/can/c

Re: [Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU

2017-10-29 Thread Pavel Pisa
Hello Fred, thanks much for review and remarks. On Friday 27 of October 2017 16:18:31 KONRAD Frederic wrote: > Hi Pavel, > > On 10/25/2017 01:12 AM, p...@cmp.felk.cvut.cz wrote: > > From: Pavel Pisa > > > > The work is based on Jin Yang GSoC 2013 work funded > >

Re: [Qemu-devel] [PATCH 0/6] CAN bus support for QEMU (SJA1000 PCI so far)

2017-01-06 Thread Pavel Pisa
Hello all, On Friday 06 of January 2017 00:22:28 no-re...@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Message-id: cover.1483655893.git.p...@cmp.felk.cvut.cz > Subject: [Qemu-devel] [PATCH 0/6] CAN bus support for Q

Re: [Qemu-devel] [PATCH 1/6] CAN bus simple SJA1000 PCI card emulation for QEMU

2017-10-30 Thread Pavel Pisa
Hello Marek and Konrad, On Monday 30 of October 2017 12:38:12 KONRAD Frederic wrote: > On 10/30/2017 11:51 AM, Marek Vasut wrote: > > On 10/30/2017 10:19 AM, KONRAD Frederic wrote: > > > > [...] > > > >>> CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added. > >>> hw/can/can_mioe3680_p

Re: [Qemu-devel] [PATCH 0/5 v2] CAN bus support for QEMU (SJA1000 PCI so far)

2017-11-01 Thread Pavel Pisa
Hello Philippe, On Thursday 02 of November 2017 02:27:18 Philippe Mathieu-Daudé wrote: > On 11/01/2017 10:00 PM, p...@cmp.felk.cvut.cz wrote: > > Some page about the project > > > > https://gitlab.fel.cvut.cz/canbus/qemu-canbus/wikis/home > > > > FEE CTU GitLab repository with can-pci branch for

Re: [Qemu-devel] QEMU CAN bus work

2017-12-28 Thread Pavel Pisa
Hello Oleksij and Philippe, I have found some time to update QEMU CAN patch series and test it with actual QEMU master. As QEMU 2.11 is realeased now, I hope that it is time to disscuss integration of initial/simple CAN bus emulation now. The actual version can be found on branch can-pci in our

Re: [Qemu-devel] [PATCH V4 4/7] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2018-03-06 Thread Pavel Pisa
Hello Thomas, thanks for report but I at this time I am and can be some time in condition which does not allow me to access e-mail and normal work On Tuesday 06 of March 2018 16:29:19 Thomas Huth wrote: > On 14.01.2018 21:14, p...@cmp.felk.cvut.cz wrote: > > From: Pavel Pisa > >

Re: [PATCH] hw/net/can: Add missing fallthrough statements

2020-07-13 Thread Pavel Pisa
hrough */ > > case 11 ... 19: > > if ((s->control & 0x01) == 0) { /* Operation mode */ > > s->tx_buff[addr - 10] = val; /* Store to TX buffer > > directly. */ > > cc: Pavel Pisa > > Reviewed-by: Laurent Vivi

Re: [PATCH v1 0/6] CTU CAN FD core support - patchew report

2020-07-14 Thread Pavel Pisa
me MIPS based system, if the check result is important. But it would worth to have even real HW to compare real programmed PCIe card behavior and I do not pose Linux capable big endian systems. I have some safety based Cortex-R big endian ARMS there, but they do not have PCIe and QEMU support. Thanks

Re: [PATCH v1 5/6] hw/net/can: CTU CAN FD IP open hardware core emulation.

2020-07-24 Thread Pavel Pisa
; The core is mapped to PCIe card same as on one of its real hardware > adaptations. The device implementing two CTU CAN FD ip cores > is instantiated after CAN bus definition > > -object can-bus,id=canbus0-bus > > by QEMU parameters > > -device ctucan_pci,canbus0=c

Re: [PATCH 06/12] can_host: Use class properties

2020-10-12 Thread Pavel Pisa
Hello Eduardo, On Friday 09 of October 2020 18:01:16 Eduardo Habkost wrote: > Instance properties make introspection hard and are not shown by > "-object ...,help". Convert them to class properties. > > Signed-off-by: Eduardo Habkost > --- > Cc: Pavel Pisa >

[PATCH] hw/net/can: sja1000 fix buff2frame_bas for dlc out of std CAN 8 bytes

2021-07-26 Thread Pavel Pisa
Problem reported by openEuler fuzz-sig group. The buff2frame_bas function (hw\net\can\can_sja1000.c) infoleak(qemu5.x~qemu6.x) or stack-overflow(qemu 4.x). Reported-by: Qiang Ning Signed-off-by: Pavel Pisa --- hw/net/can/can_sja1000.c | 4 1 file changed, 4 insertions(+) diff --git a/hw

Re: [PATCH] hw/net/can: sja1000 fix buff2frame_bas for dlc out of std CAN 8 bytes

2021-07-29 Thread Pavel Pisa
Hello everybody, please, can somebody accept the fix for master? It should be ideally applied even to stable branches. Or should I send request through some other form then on the list? Thanks, Pavel On Monday 26 of July 2021 18:24:58 Pavel Pisa wrote: > Problem reported by openEuler fuzz-

Re: [PATCH-for-6.1] hw/net/can: sja1000 fix buff2frame_bas for dlc out of std CAN 8 bytes

2021-07-29 Thread Pavel Pisa
ee. I can try to find how to build required fuzz test or fuzz team has some code availabe, may it be in the required form. But the fix is from SJA1000 CAN frame/chip definition. > > On Monday 26 of July 2021 18:24:58 Pavel Pisa wrote: > >> Problem reported by openEuler fuzz-sig gro

[PATCH v2] hw/net/can: sja1000 fix buff2frame_bas and buff2frame_pel when dlc is out of std CAN 8 bytes

2021-07-29 Thread Pavel Pisa
Problem reported by openEuler fuzz-sig group. The buff2frame_bas function (hw\net\can\can_sja1000.c) infoleak(qemu5.x~qemu6.x) or stack-overflow(qemu 4.x). Reported-by: Qiang Ning Signed-off-by: Pavel Pisa --- hw/net/can/can_sja1000.c | 8 1 file changed, 8 insertions(+) diff --git

  1   2   >