Hello Peter, thanks for the review and Vikram for his work, I do not know much about Xilinx emulation nor Xilixn CAN controllers so I cannot comment much on this part.
On Thursday 22 of September 2022 16:46:48 Peter Maydell wrote: > On Sat, 10 Sept 2022 at 07:13, Vikram Garhwal <vikram.garh...@amd.com> > > To > create virtual CAN on the host machine, please check the QEMU CAN > > docs: https://github.com/qemu/qemu/blob/master/docs/can.txt > > That link is a 404. You could just give the relative path to the > docs in the repo, which is docs/system/devices/can.rst The actual generated documentation is located at https://www.qemu.org/docs/master/system/devices/can.html I think that that URL is stable for some time... Could it be used directly in source to provide path to formated version? > For the machine specifics, you should include (either in the patch 4 > where you add this to the xlnx-versal-virt board, or in a separate patch > if it seems too big) updates to docs/system/arm/xlnx-versal-virt.rst > which document the new functionality, including, if it's useful to users, > some documentation of how to use it. Some short example how to use emulation even with Xilinx Zynq and Ultra Scale would be nice if added into the document. If the document length expands too much, then probably division into individual documents per controllers would be nice. By the way, CAN in Automation publishes our overview article about our CAN activities including some short netion of QEMU integration https://can-newsletter.org/uploads/media/raw/a9abe317ae034be55d99fee4410ad70e.pdf I hope I wind some time for CAN in QEMU, RTEMS and Linux ongoing projects, but I need to finish some promissed project for ESA the first. Best wishes, Pavel -- Pavel Pisa phone: +420 603531357 e-mail: p...@cmp.felk.cvut.cz Department of Control Engineering FEE CVUT Karlovo namesti 13, 121 35, Prague 2 university: http://control.fel.cvut.cz/ personal: http://cmp.felk.cvut.cz/~pisa projects: https://www.openhub.net/accounts/ppisa CAN related:http://canbus.pages.fel.cvut.cz/ RISC-V education: https://comparch.edu.cvut.cz/ Open Technologies Research Education and Exchange Services https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home
