;error_fatal);
for (i = 0; i < IOAPIC_NUM_PINS; i++) {
qdev_connect_gpio_out_named(lpc_dev, ICH9_GPIO_GSI, i, x86ms->gsi[i]);
}
-pci_realize_and_unref(lpc, host_bus, &error_fatal);
rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(lpc), "rtc"));
Reviewed-by: Damien Hedde
env->tick = cpu_timer_create("tick", cpu, tick_irq,
Reviewed-by: Damien Hedde
On 1/24/24 08:47, Hannes Reinecke wrote:
On 1/24/24 07:52, Philippe Mathieu-Daudé wrote:
Hi Hannes,
[+Markus as QOM/QDev rubber duck]
On 23/1/24 13:40, Hannes Reinecke wrote:
On 1/23/24 11:59, Damien Hedde wrote:
Hi all,
We are currently looking into hotplugging nvme devices and it is
On 1/29/24 16:35, Hannes Reinecke wrote:
On 1/29/24 14:13, Damien Hedde wrote:
On 1/24/24 08:47, Hannes Reinecke wrote:
On 1/24/24 07:52, Philippe Mathieu-Daudé wrote:
Hi Hannes,
[+Markus as QOM/QDev rubber duck]
On 23/1/24 13:40, Hannes Reinecke wrote:
On 1/23/24 11:59, Damien Hedde
This commit make use of the resettable API to reset the device being
hotplugged during when it is realized. Also it make sure it is put in
a reset state coherent with the parent it is plugged into.
Signed-off-by: Damien Hedde
---
I'm not sure I've done everything that's required
Adds trace events to reset procedure and when updating the parent
bus of a device.
Signed-off-by: Damien Hedde
---
hw/core/qdev.c | 27 ---
hw/core/trace-events | 9 +
2 files changed, 33 insertions(+), 3 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core
parent under reset, the object goes in
reset.
+ when an object is removed from a parent under reset, the object
leaves reset.
The added function avoid any glitch if both old and new parent are
already in reset.
Signed-off-by: Damien Hedde
---
hw/core/resettable.c| 54
t from hotplug).
Thanks for your feedback,
Damien
Damien Hedde (13):
add device_legacy_reset function to prepare for reset api change
hw/core/qdev: add trace events to help with resettable transition
hw/core: create Resettable QOM interface
hw/core: add Resettable support to BusClass and Devi
local state and query
information from the block backend.
Signed-off-by: Damien Hedde
---
The raspi reset change can be observed by using the following command
(reset will occurs, then do Ctrl-C to end qemu; no firmware is
given here).
qemu-system-aarch64 -M raspi3 \
-trace
sdbus_reparent_card(). This function is only used in the raspi machines,
including during the sysbus reset procedure. This case will be fixed by
a following commit before globally enabling resettable API for sysbus
reset.
Signed-off-by: Damien Hedde
---
Exhaustive list of the 28 virtio caller to
buses as well as the specified device). Subsequent
commits will make the changeover for each call site individually; once
that is complete device_legacy_reset() will be removed.
Signed-off-by: Damien Hedde
Reviewed-by: Peter Maydell
Acked-by: David Gibson
---
Cc: Gerd Hoffmann
Cc: Paolo
Signed-off-by: Damien Hedde
---
Should I add an entry into index.rst ?
---
docs/devel/reset.rst | 282 +++
1 file changed, 282 insertions(+)
create mode 100644 docs/devel/reset.rst
diff --git a/docs/devel/reset.rst b/docs/devel/reset.rst
new file mode
().
Following patches will be needed to look at legacy reset call sites
and switch to resettable api. The legacy functions will be removed
when unused.
Signed-off-by: Damien Hedde
---
I've removed the general helpers
+ device_reset(DeviceState *dev, ResetType type)
+ bus_reset(BusState *dev, Rese
any transition
because they do not override the legacy reset method.
Signed-off-by: Damien Hedde
---
hw/core/bus.c | 97 ++
hw/core/qdev.c | 97 ++
include/hw/qdev-core.h | 27
te
the 2nd
phase which is executed in children-then-parent order inside a tree.
This will allow to transition devices and buses smoothly while
keeping the exact current qdev/qbus reset behavior for now.
Documentation will be added in a following commit.
Signed-off-by: Damien Hedde
---
In this patch
.
Signed-off-by: Damien Hedde
---
Cc: Cornelia Huck
Cc: qemu-s3...@nongnu.org
Cc: Christian Borntraeger
Cc: Thomas Huth
---
hw/s390x/ipl.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index ca544d64c5..2689f7a017 100644
--- a/hw/s390x
Split gpfsel_set() in 2 so that the sdbus reparenting is done
in a dedicated function.
Signed-off-by: Damien Hedde
---
Cc: Peter Maydell
Cc: Andrew Baumann
Cc: Philippe Mathieu-Daudé
Cc: qemu-...@nongnu.org
---
hw/gpio/bcm2835_gpio.c | 16
1 file changed, 12 insertions(+), 4
Transition the bcm2835_gpio device class to Resettable.
The sdbus reparenting is delayed in hold phase to respect
resettable side-effect rules.
Signed-off-by: Damien Hedde
---
Cc: Peter Maydell
Cc: Andrew Baumann
Cc: Philippe Mathieu-Daudé
Cc: qemu-...@nongnu.org
---
hw/gpio/bcm2835_gpio.c
On 12/4/19 9:34 PM, Philippe Mathieu-Daudé wrote:
> On 12/4/19 5:40 PM, Damien Hedde wrote:
>> On 12/2/19 5:15 PM, Peter Maydell wrote:
>>>
>>> The one topic I think we could do with discussing is whether
>>> a simple uint64_t giving the frequency
Remove the packet size upper limit by using a GByteArray
instead of a statically allocated array for last_packet.
Thus we can now send big packets.
Also remove the last_packet_len field and use last_packet->len
instead.
Signed-off-by: Damien Hedde
---
This patch is a follow-up of Alex'
On 11/29/19 8:00 PM, Peter Maydell wrote:
> On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote:
>>
>> Signed-off-by: Damien Hedde
>
> Subject line still says ".txt".
>
>> ---
>>
>> Should I add an entry into index.rst ?
>
> Yes, ple
On 11/29/19 8:00 PM, Peter Maydell wrote:
> On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote:
>>
>> Signed-off-by: Damien Hedde
>
> Subject line still says ".txt".
>
>> ---
>>
>> +Polling the reset state
>> +
On 12/4/19 7:51 PM, Eduardo Habkost wrote:
> On Wed, Dec 04, 2019 at 05:21:25PM +0100, Jens Freimann wrote:
>> On Wed, Dec 04, 2019 at 11:35:37AM -0300, Eduardo Habkost wrote:
>>> On Wed, Dec 04, 2019 at 10:18:24AM +0100, Jens Freimann wrote:
On Tue, Dec 03, 2019 at 06:40:04PM -0300, Eduard
On 12/9/19 11:15 AM, Luc Michel wrote:
>
>
> On 12/6/19 2:42 PM, Damien Hedde wrote:
>> Remove the packet size upper limit by using a GByteArray
>> instead of a statically allocated array for last_packet.
>> Thus we can now send big packets.
>>
>> Also r
t; - * The type of the QOM property is derived from prop->info.
> - */
> void qdev_property_add_static(DeviceState *dev, Property *prop,
>Error **errp)
> {
>
Reviewed-by: Damien Hedde
Regards,
--
Damien
Remove the packet size upper limit by using a GByteArray
instead of a statically allocated array for last_packet.
Thus we can now send big packets.
Also remove the last_packet_len field and use last_packet->len
instead.
Signed-off-by: Damien Hedde
Reviewed-by: Philippe Mathieu-Da
Since we can now send packets of arbitrary length:
simplify gdb_monitor_write() and send the whole payload
in one packet.
Suggested-by: Luc Michel
Signed-off-by: Damien Hedde
---
gdbstub.c | 23 +++
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/gdbstub.c b
naro.org>
v2:
+ patch 1: fix gdb_monitor_write() max_sz error (Luc)
+ patch 2: new patch (Luc)
--
Damien
Damien Hedde (2):
gdbstub: change GDBState.last_packet to GByteArray
gdbstub: do not split gdb_monitor_write payload
gdbstub.c | 60 +--
-
> target/arm/cpu.c | 33 +++--
> 3 files changed, 16 insertions(+), 35 deletions(-)
>
Reviewed-by: Damien Hedde
Regards,
--
Damien
Hi Alex,
On 12/11/19 6:05 PM, Alex Bennée wrote:
> Instead of passing a pointer to memory now just extend the GByteArray
> to all the read register helpers. They can then safely append their
> data through the normal way. We don't bother with this abstraction for
> write registers as we have alr
On 12/11/19 7:58 PM, Philippe Mathieu-Daudé wrote:
> On 12/11/19 5:05 PM, Damien Hedde wrote:
>> Since we can now send packets of arbitrary length:
>> simplify gdb_monitor_write() and send the whole payload
>> in one packet.
>
> While we can send arbitrary lengt
On 12/11/19 7:59 PM, Alex Bennée wrote:
>
> Damien Hedde writes:
>
>> Since we can now send packets of arbitrary length:
>> simplify gdb_monitor_write() and send the whole payload
>> in one packet.
>
> Do we know gdb won't barf on us. Does the negotiate
On 12/12/19 11:52 AM, Alex Bennée wrote:
>
> Damien Hedde writes:
>
>> On 12/11/19 7:59 PM, Alex Bennée wrote:
>>>
>>> Damien Hedde writes:
>>>
>>>> Since we can now send packets of arbitrary length:
>>>> simplify gdb_monitor
e size range.
>
> Signed-off-by: Alex Bennée
> Reviewed-by: Richard Henderson
> Reviewed-by: Damien Hedde
> Tested-by: Damien Hedde
>
> ---
> v3
> - fixed up email on Damien's tags
> ---
> gdbstub.c | 56 ++---
On 11/29/19 1:45 PM, Peter Maydell wrote:
> On Fri, 29 Nov 2019 at 12:26, Igor Mammedov wrote:
>> But from the my very limited understanding, on real hardware,
>> once device is uplugged it's gone (finalized) from machine
>> perspective, so it's unclear to my why someone would use
>> realize->un
On 11/29/19 7:32 PM, Peter Maydell wrote:
> On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote:
>>
>> This commit defines an interface allowing multi-phase reset. This aims
>> to solve a problem of the actual single-phase reset (built in
>> DeviceClass and BusClass):
On 11/29/19 7:36 PM, Peter Maydell wrote:
> On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote:
>>
>> This commit adds support of Resettable interface to buses and devices:
>> + ResettableState structure is added in the Bus/Device state
>> + Resettable methods a
On 11/29/19 7:38 PM, Peter Maydell wrote:
> On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote:
>>
>> Add a function resettable_change_parent() to do the required
>> plumbing when changing the parent a of Resettable object.
>>
>> We need to make sure that the
On 11/29/19 8:05 PM, Peter Maydell wrote:
> On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote:
>>
>> Split gpfsel_set() in 2 so that the sdbus reparenting is done
>> in a dedicated function.
>>
>> Signed-off-by: Damien Hedde
>> ---
>> Cc: Peter Ma
On 12/2/19 1:33 PM, Peter Maydell wrote:
> On Mon, 2 Dec 2019 at 12:27, Damien Hedde wrote:
>>
>>
>>
>> On 11/29/19 8:05 PM, Peter Maydell wrote:
>>> On Fri, 18 Oct 2019 at 16:07, Damien Hedde
>>> wrote:
>>>> @@ -97,6 +101,7 @@ stat
>
> Signed-off-by: Alex Bennée
> Cc: Damien Hedde
> Cc: Richard Henderson
>
> ---
> v2
> - made entirely static, dropped dh/rth r-b tags due to changes
Modulo Richard's remark about unnecessary memset,
Reviewed-by: Damien Hedde
On 11/30/19 9:45 AM, Alex Bennée wrote:
> We only have one GDBState which should be allocated at the time we
> process any commands. This will make further clean-up a bit easier.
>
> Signed-off-by: Alex Bennée
> ---
> gdbstub.c | 539 +++---
> 1
Richard Henderson
>
> ---
> v2
> - fix conflict from status gdbserver_state
> - add put_strbuf helper
> ---
> gdbstub.c | 195 +-
> 1 file changed, 90 insertions(+), 105 deletions(-)
>
Reviewed-by: Damien Hedde
--
Damien
y_cpu);
> }
>
> @@ -2058,7 +2070,7 @@ static void handle_query_thread_extra(GdbCmdContext
> *gdb_ctx, void *user_ctx)
> }
> trace_gdbstub_op_extra_info(rs->str);
> memtohex(gdbserver_state.str_buf, (uint8_t *)rs->str, rs->len);
> -put_strbuf();;
> +put_strbuf();
> }
>
With the ";;" fix
Reviewed/Tested-by: Damien Hedde
--
Damien
27;t happen with in-tree targets, it works
fine. So,
Tested-by: Damien Hedde
I'll work on the missing bits for bigger packet support I soon as I have
some spare time.
Regards,
--
Damien
On 12/2/19 4:34 PM, Peter Maydell wrote:
> On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote:
>>
>> Add the connection between the slcr's output clocks and the uarts inputs.
>>
>> Also add the main board clock 'ps_clk', which is hard-coded to 33.33MHz
On 11/25/19 2:37 PM, Philippe Mathieu-Daudé wrote:
> On 9/4/19 2:55 PM, Damien Hedde wrote:
>> Introduce clock objects: ClockIn and ClockOut.
>>
>> These objects may be used to distribute clocks from an object to several
>> other objects. Each ClockIn object contai
On 12/2/19 2:42 PM, Peter Maydell wrote:
> On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote:
>>
>> Introduce clock objects: ClockIn and ClockOut.
>>
>> These objects may be used to distribute clocks from an object to several
>> other objects. Each ClockIn obj
On 11/25/19 2:30 PM, Philippe Mathieu-Daudé wrote:
> Nitpick: remove trailing dot in patch subject
>
> On 9/4/19 2:55 PM, Damien Hedde wrote:
>> Add functions to easily add input or output clocks to a device.
>> A clock objects is added as a child of the device.
>
&
On 12/2/19 3:34 PM, Peter Maydell wrote:
> On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote:
>>
>> Add functions to easily add input or output clocks to a device.
>> A clock objects is added as a child of the device.
>
> "object"
>
>> The api i
On 12/2/19 4:13 PM, Peter Maydell wrote:
> On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote:
>>
>> Introduce a function and macro helpers to setup several clocks
>> in a device from a static array description.
>>
>> An element of the array describes the clock (
On 12/4/19 10:53 AM, Philippe Mathieu-Daudé wrote:
> On 12/4/19 10:05 AM, Damien Hedde wrote:
>> On 12/2/19 3:34 PM, Peter Maydell wrote:
>>> On Wed, 4 Sep 2019 at 13:56, Damien Hedde
>>> wrote:
>>>>
> [...]
>>>> +/**
>>>> + *
On 12/2/19 4:17 PM, Peter Maydell wrote:
> On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote:
>>
>> Add the documentation about the clock inputs and outputs in devices.
>>
>> This is based on the original work of Frederic Konrad.
>>
>> Signed-off-by: Damien
On 12/2/19 4:20 PM, Peter Maydell wrote:
> On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote:
>>
>> Switch the slcr to multi-phase reset and add some clocks:
>> + the main input clock (ps_clk)
>> + the reference clock outputs for each uart (uart0 & 1)
>>
On 12/2/19 4:24 PM, Peter Maydell wrote:
> On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote:
>>
>> Switch the cadence uart to multi-phase reset and add the
>> reference clock input.
>>
>> The input clock frequency is added to the migration structure.
>&
On 12/2/19 5:15 PM, Peter Maydell wrote:
>
> The one topic I think we could do with discussing is whether
> a simple uint64_t giving the frequency of the clock in Hz is
> the right representation. In particular in your patch 9 the
> board has a clock frequency that's not a nice integer number
>
On 8/8/19 12:50 PM, Cornelia Huck wrote:
> On Mon, 29 Jul 2019 16:56:35 +0200
> Damien Hedde wrote:
>
>> Replace deprecated qdev_reset_all by device_reset_warm.
>>
>> This does not impact the behavior.
>
> Not so sure about that; see below.
In this case,
On 8/9/19 7:51 AM, David Gibson wrote:
> On Wed, Aug 07, 2019 at 11:37:51AM +0100, Peter Maydell wrote:
>> On Wed, 31 Jul 2019 at 07:33, David Gibson
>> wrote:
>>>
>>> On Mon, Jul 29, 2019 at 04:56:29PM +0200, Damien Hedde wrote:
>>>> It adds the p
On 8/7/19 4:27 PM, Peter Maydell wrote:
> On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote:
>>
>> Provide a temporary function doing what device_reset does to do the
>> transition with Resettable API which will trigger a prototype change
>> of device_reset.
>
On 8/7/19 5:31 PM, Peter Maydell wrote:
> On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote:
>>
>> Replace deprecated qdev/bus_reset_all by device/bus_reset_warm.
>>
>> This does not impact the behavior.
>>
>> Signed-off-by: Damien Hedde
>
> I
On 8/9/19 12:07 PM, Peter Maydell wrote:
> On Thu, 8 Aug 2019 at 16:42, Dr. David Alan Gilbert
> wrote:
>>
>> * Peter Maydell (peter.mayd...@linaro.org) wrote:
>>> On Mon, 29 Jul 2019 at 15:59, Damien Hedde
>>> wrote:
>>>>
>>>> T
On 8/9/19 12:32 PM, Peter Maydell wrote:
> On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote:
>>
>> One way to keep the feature without copy-pasting vmsd would be to add
>> a new vmstate_register with an additional argument to pass the base
>> class vmsd section and h
On 8/7/19 4:41 PM, Peter Maydell wrote:
> On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote:
>>
>>
>> +/**
>> + * device_reset:
>> + * Resets the device @dev, @cold tell whether to do a cold or warm reset.
>> + * Base behavior is to reset the device and
Provide a temporary function doing what device_reset does to do the
transition with Resettable API which will trigger a prototype change
of device_reset.
Signed-off-by: Damien Hedde
---
hw/core/qdev.c | 6 +++---
include/hw/qdev-core.h | 9 +++--
2 files changed, 10 insertions(+), 5
Signed-off-by: Damien Hedde
---
hw/audio/intel-hda.c | 2 +-
hw/hyperv/hyperv.c | 2 +-
hw/i386/pc.c | 2 +-
hw/ide/microdrive.c | 8
hw/intc/spapr_xive.c | 2 +-
hw/ppc/pnv_psi.c | 2 +-
hw/ppc/spapr_pci.c | 2 +-
hw/ppc/spapr_vio.c
t calls
- Patches 18 to 27 replace device_reset calls
- Patch 28 cleans remaining legacy reset API
- Patches 29 to 33 modify the xilinx_zynq to add 3-phases reset support in the
uart and the slcr (the reset controller of the soc).
Thanks,
Damien
Damien Hedde (33):
Create Reset
Deprecate old reset apis and make them use the new one while they
are still used somewhere.
Signed-off-by: Damien Hedde
---
hw/core/qdev.c | 22 +++---
include/hw/qdev-core.h | 28 ++--
2 files changed, 25 insertions(+), 25 deletions(-)
diff
Signed-off-by: Damien Hedde
---
docs/devel/reset.txt | 165 +++
1 file changed, 165 insertions(+)
create mode 100644 docs/devel/reset.txt
diff --git a/docs/devel/reset.txt b/docs/devel/reset.txt
new file mode 100644
index 00..c7a1eb068f
--- /dev
-to-parent order.
This will allow to replace current qdev_reset mechanism by this interface
without side-effects on reset order.
Note: I used an uint32 for the count. This match the type already used
in the existing resetting counter in hw/scsi/vmw_pvscsi.c for the
PVSCSIState.
Signed-off-by: Da
Replace deprecated qbus_reset_all by resettable_reset_cold_fn for
the sysbus reset registration.
This does not impact the behavior.
Signed-off-by: Damien Hedde
---
vl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index b426b32134..5a465c8236 100644
--- a
.
Signed-off-by: Damien Hedde
---
hw/core/Makefile.objs | 1 +
hw/core/qdev-vmstate.c | 45 ++
2 files changed, 46 insertions(+)
create mode 100644 hw/core/qdev-vmstate.c
diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
index d9234aa98a
ntly under reset and
if the current reset is cold or not.
Signed-off-by: Damien Hedde
---
hw/core/bus.c | 85 ++
hw/core/qdev.c | 82
include/hw/qdev-c
Replace legacy's reset call by device_reset_warm.
The new function propagates also the reset to the sub-buses tree but this has
no impact since since HDACodecDevice has no child bus.
Signed-off-by: Damien Hedde
---
hw/audio/intel-hda.c | 2 +-
1 file changed, 1 insertion(+), 1 del
Replace deprecated qdev/bus_reset_all by device/bus_reset_warm.
This does not impact the behavior.
Signed-off-by: Damien Hedde
---
hw/pci/pci.c| 6 +++---
hw/pci/pci_bridge.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index
It adds the possibility to add 2 gpios to control the warm and cold reset.
With theses ios, the reset can be maintained during some time.
Each io is associated with a state to detect level changes.
Vmstate subsections are also added to the existsing device_reset
subsection.
Signed-off-by: Damien
Replace deprecated qdev_reset_all by device_reset_warm.
This does not impact the behavior.
Signed-off-by: Damien Hedde
---
hw/ide/piix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/piix.c b/hw/ide/piix.c
index b97e555072..64cb4a52ef 100644
--- a/hw/ide/piix.c
This add the reset related sections for every QOM
device.
Signed-off-by: Damien Hedde
---
hw/core/qdev-vmstate.c | 41 +
hw/core/qdev.c | 12 +++-
include/hw/qdev-core.h | 3 +++
stubs/Makefile.objs| 1 +
stubs/device.c | 7
Replace legacy's reset call by device_reset_warm.
The new function propagates also the reset to the sub-buses tree but this has
no impact since SpaprXive has no child bus.
Signed-off-by: Damien Hedde
---
hw/intc/spapr_xive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Replace deprecated qdev/bus_reset_all by device/bus_reset_warm.
This does not impact the behavior.
Signed-off-by: Damien Hedde
---
hw/scsi/lsi53c895a.c | 4 ++--
hw/scsi/megasas.c | 2 +-
hw/scsi/mptsas.c | 8
hw/scsi/spapr_vscsi.c | 2 +-
hw/scsi/virtio-scsi.c | 6
Replace deprecated qbus_reset_all by resettable_reset_cold_fn for
the ipl registration in the main reset handlers.
This does not impact the behavior.
Signed-off-by: Damien Hedde
---
hw/s390x/ipl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/ipl.c b/hw
Replace legacy's reset call by device_reset_warm.
The new function propagates also the reset to the sub-buses tree but this has
no impact since SDState has no child bus.
Signed-off-by: Damien Hedde
---
hw/sd/omap_mmc.c | 2 +-
hw/sd/pl181.c| 2 +-
2 files changed, 2 insertions(
Replace deprecated qdev_reset_all by device_reset_warm.
This does not impact the behavior.
Signed-off-by: Damien Hedde
---
hw/input/adb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/input/adb.c b/hw/input/adb.c
index 1446f32521..6b35682aba 100644
--- a/hw/input/adb.c
Replace deprecated qdev_reset_all by device_reset_warm.
This does not impact the behavior.
Signed-off-by: Damien Hedde
---
hw/usb/dev-uas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
index abd8070d0c..b3a6e470e4 100644
--- a/hw/usb
Replace additional APIC legacy reset by device_reset_cold.
The new function propagates also the reset to the sub-buses tree.
APIC does not have any so it should have no impact on behavior.
Signed-off-by: Damien Hedde
---
hw/i386/pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Replace deprecated qdev_reset_all by device_reset_warm.
This does not impact the behavior.
Signed-off-by: Damien Hedde
---
hw/s390x/s390-virtio-ccw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 5b6a9a4e55
Replace legacy's reset call by device_reset_warm.
The new function propagates also the reset to the sub-buses tree but this has
no impact since XiveSource has no child bus.
Signed-off-by: Damien Hedde
---
hw/ppc/pnv_psi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
es of a SpaprPhbState.
If there is a device with a child bus, then this bus will now be reset
(and all its qdev tree).
Signed-off-by: Damien Hedde
---
hw/ppc/spapr_pci.c | 2 +-
hw/ppc/spapr_vio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/spapr_pci.c b/h
Remove the functions now they are unused:
+ device_legacy_reset
+ qdev_reset_all[_fn]
+ qbus_reset_all[_fn]
Signed-off-by: Damien Hedde
---
hw/core/qdev.c | 30 --
include/hw/qdev-core.h | 29 -
2 files changed, 59 deletions
Replace legacy's reset call by device_reset_warm.
The new function propagates also the reset to the sub-buses tree but this has
no impact since SCSIDevices have no child bus (neither generic device nor
disks).
Signed-off-by: Damien Hedde
---
hw/scsi/vmw_pvscsi.c | 2 +-
1 file chang
Change the legacy reset function into the init phase and test the
resetting flag in register accesses.
Signed-off-by: Damien Hedde
---
hw/misc/zynq_slcr.c | 39 +++
1 file changed, 35 insertions(+), 4 deletions(-)
diff --git a/hw/misc/zynq_slcr.c b/hw/misc
implemented so resetting the
qdev/qbus ide tree will have no effect.
Keep the explicit call to ide_bus_reset (in md_reset function) since
it is not called when using the standard reset method of the IDE_BUS
object.
Signed-off-by: Damien Hedde
---
hw/ide/microdrive.c | 8
1 file changed, 4
Replace S390PCIBusDevice legacy reset by device_reset_warm.
The new function propagates also the reset to the sub-buses tree.
I'm not sure whether S390PCIBusDevice has bus children or not.
Signed-off-by: Damien Hedde
---
hw/s390x/s390-pci-inst.c | 2 +-
1 file changed, 1 insertion(
Connect the two uart reset inputs to the slcr corresponding outputs.
Signed-off-by: Damien Hedde
---
hw/arm/xilinx_zynq.c | 14 --
include/hw/char/cadence_uart.h | 10 +-
2 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm
Replace legacy's reset call by device_reset_warm in
*hyperv_synic_reset*.
The new function propagates also the reset to the sub-buses tree but this has
no impact since SynICState has no child bus.
Signed-off-by: Damien Hedde
---
hw/hyperv/hyperv.c | 2 +-
1 file changed, 1 insertion(
Replace the zynq_slcr registers enum and macros using the
hw/registerfields.h macros.
Signed-off-by: Damien Hedde
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/misc/zynq_slcr.c | 472 ++--
1 file changed, 236 insertions
Add two gpio outputs to control the uart resets.
Signed-off-by: Damien Hedde
---
hw/misc/zynq_slcr.c | 36 +++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c
index 6fcdbce4f0..b6c9a281c2 100644
--- a/hw
Split the existing reset procedure into 3 phases.
Test the resetting flag to discard register accesses
and character reception.
Also adds a active high reset io.
Signed-off-by: Damien Hedde
---
hw/char/cadence_uart.c | 77 +++---
1 file changed, 73 insertions
On 7/30/19 3:59 PM, Peter Maydell wrote:
> On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote:
>>
>> On Tue, 30 Jul 2019 14:44:21 +0100
>> Peter Maydell wrote:
>>
>>> On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote:
I'm having a hard time figuring out what a 'cold' or a 'warm' reset is
>
On 7/31/19 7:56 AM, David Gibson wrote:
> On Mon, Jul 29, 2019 at 04:56:25PM +0200, Damien Hedde wrote:
>> This add Resettable interface implementation for both Bus and Device.
>>
>> *resetting* counter and *reset_is_cold* flag are added in DeviceState
>> and BusStat
On 7/31/19 8:05 AM, David Gibson wrote:
> On Mon, Jul 29, 2019 at 04:56:26PM +0200, Damien Hedde wrote:
>> Deprecate old reset apis and make them use the new one while they
>> are still used somewhere.
>>
>> Signed-off-by: Damien Hedde
>> --
1 - 100 of 581 matches
Mail list logo
