On 8/7/19 4:27 PM, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:58, Damien Hedde <damien.he...@greensocs.com> wrote: >> >> Provide a temporary function doing what device_reset does to do the >> transition with Resettable API which will trigger a prototype change >> of device_reset. > > The other point here is that device_legacy_reset() resets > only that device, not any of its qbus children, right? > So the new function which we eventually replace the callsites > with also has different semantics, which is why we do the > changes one by one in patches 10-28.
Yes, for device_reset there is a change of scope. > > So you could add: > > The new resettable API function also has different semantics > (resetting child buses as well as the specified device). > Subsequent commits will make the changeover for each callsite > individually; once that is complete device_legacy_reset() will be > removed. sure > >> Signed-off-by: Damien Hedde <damien.he...@greensocs.com> > > I agree with David that patch 3 could be squashed into this one. ok > > If you do that and tweak the commit message you can have > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > > thanks > -- PMM >
