On 11/29/19 8:00 PM, Peter Maydell wrote:
> On Fri, 18 Oct 2019 at 16:07, Damien Hedde <damien.he...@greensocs.com> wrote:
>>
>> Signed-off-by: Damien Hedde <damien.he...@greensocs.com>
>
> Subject line still says ".txt".
>
>> ---
>>
>> Should I add an entry into index.rst ?
>
> Yes, please.
>
> I have one substantive comment on this patch: in the
> MyDev example of implementing reset, you make the enter/hold/exit
> functions do the reset of the subclass and then call the
> myclass->parent_phases method. This feels to me like it's the
> wrong way round and the parent class should reset first. Does
> it make any difference to do it this way round?
>
Not really, I'll update them to what you say.
--
Damien
