Re: [Qemu-devel] [PATCH] nseries: attach monitor powerdown request to menelaus

2012-02-16 Thread andrzej zaborowski
On 20 January 2012 12:10, Paolo Bonzini wrote: > I noticed some unused code in the twl92230, probably from before > qdev-ification.  This patch makes the machine use the chip's pwrbtn > signal. Thanks, applied this patch. Cheers

Re: [Qemu-devel] [PATCH 2/4] arm: switch real-time clocks to rtc_clock

2012-02-16 Thread andrzej zaborowski
On 20 January 2012 13:06, Paolo Bonzini wrote: > This lets the user specify the desired semantics.  By default, the RTC > will follow adjustments from the host's NTP client.  "-rtc clock=vm" will > improve determinism with both icount and qtest.  Finally, the previous > behavior is available with

Re: [Qemu-devel] [PATCH] target-arm/helper.c: Correct FPSID value for Cortex-A9

2012-02-16 Thread andrzej zaborowski
On 7 February 2012 18:56, Peter Maydell wrote: > The correct FPSID for the Cortex-A9 (according to the TRM) is > 0x41033090 for the r0p0 that we claim to model. Thanks, applied this patch. Cheers

Re: [Qemu-devel] [PATCH v2] pxa2xx_lcd: SRAM is valid location for the framebuffer

2012-02-16 Thread andrzej zaborowski
On 24 January 2012 20:32, Vasily Khoruzhick wrote: > Signed-off-by: Vasily Khoruzhick Thanks, applied this patch. Cheers

Re: [Qemu-devel] [PATCH] hw/arm: Remove redundant arguments from set_kernel_args*

2012-02-16 Thread andrzej zaborowski
On 29 January 2012 08:52, Stefan Weil wrote: > The parameters initrd_size and base are already included > in the info parameter, so there is no need to pass them > separately. Thanks, applied. Cheers

Re: [Qemu-devel] [PATCH] target-arm/helper.c: tb_flush() on CPU reset

2012-02-16 Thread andrzej zaborowski
On 1 February 2012 18:23, Peter Maydell wrote: > Since target-arm has some CPUState fields for which we take the approach > of baking assumptions about them into translated code and then calling > tb_flush() when the fields change, we must also tb_flush on CPU reset, > because reset is a change of

Re: [Qemu-devel] [PATCH 2/4] Make -machine/-enable-kvm options merge into a single list

2012-02-17 Thread andrzej zaborowski
On 8 February 2012 06:41, Peter Maydell wrote: > Make the "machine" option list use list merging, so that multiple > -machine arguments (and the -enable-kvm argument) all merge together > into a single list. Drop the calls to qemu_opts_reset() which meant > that only the last -machine or -enable-k

Re: [Qemu-devel] [PATCH 2/4] arm: switch real-time clocks to rtc_clock

2012-02-17 Thread andrzej zaborowski
On 17 February 2012 09:05, Paolo Bonzini wrote: > On 02/17/2012 08:09 AM, andrzej zaborowski wrote: >>> > This lets the user specify the desired semantics.  By default, the RTC >>> > will follow adjustments from the host's NTP client.  "-rtc clock=vm"

Re: [Qemu-devel] [PATCH RFC v3 14/21] target-arm: Move the PXA270's iwMMXt reset to pxa270_reset()

2012-02-17 Thread andrzej zaborowski
On 3 February 2012 03:59, Andreas Färber wrote: > No other emulated CPU uses this at this time. But why does this code better fit in hw/ than target-arm? The iwMMXt registers are core registers after all. Also the defines let the board code request a cpu revision by name instead of using a magi

Re: [Qemu-devel] [PATCH RFC v3 14/21] target-arm: Move the PXA270's iwMMXt reset to pxa270_reset()

2012-02-17 Thread andrzej zaborowski
On 17 February 2012 13:03, Andreas Färber wrote: > Am 17.02.2012 10:59, schrieb andrzej zaborowski: >> On 3 February 2012 03:59, Andreas Färber wrote: >>> No other emulated CPU uses this at this time. >> >> But why does this code better fit in hw/ than target-arm

Re: [Qemu-devel] Fw: Max7310: confused about the method of reading output port register

2013-09-01 Thread andrzej zaborowski
Hi Yang, On 26 August 2013 03:47, Yang Ning wrote: > > Dear All: > > Firstly,I'm writing to express my thanks to Zaborowski for the source code > of Max7310 which have helped me so much. > But I'm still confused about the method of reading output port register. > code: >> >>case 0x01: /*

Re: [Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm from omap_mpu_state

2011-12-20 Thread andrzej zaborowski
On 20 December 2011 19:11, Peter Maydell wrote: > From: Juha Riihimäki > > Signed-off-by: Juha Riihimäki > [Riku Voipio: Fixes and restructuring patchset] > Signed-off-by: Riku Voipio > [Peter Maydell: More fixes and cleanups for upstream submission] > Signed-off-by:  Peter Maydell > --- >  hw

Re: [Qemu-devel] [RFC][PATCH 8/8 v3] introduce a new monitor command 'dump' to dump guest's memory

2011-12-20 Thread andrzej zaborowski
On 20 December 2011 17:25, Eric Blake wrote: > On 12/20/2011 02:15 AM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> --- >>  Makefile.target |    8 +- >>  dump.c          |  452 >> +++ >>  dump.h          |    4 + >>  hmp-commands.hx |

Re: [Qemu-devel] [PATCH 00/10] hw/sd.c: Fix various status related bugs

2011-12-20 Thread andrzej zaborowski
Hi Peter, On 18 December 2011 21:37, Peter Maydell wrote: > This patchset fixes a number of bugs in our SD card emulation, mostly > in the status bit handling. In particular, it fixes the issues raised > in https://bugs.launchpad.net/qemu/+bug/597641 . The others are things > I noticed while I wa

Re: [Qemu-devel] Incorrect hw/omap_dss.c:chip[] index for RFBI_READ and RFBI_STATUS?

2012-01-06 Thread andrzej zaborowski
Hi, On 6 January 2012 17:55, Stefan Hajnoczi wrote: > Is the following code correct in hw/omap_dss.c: > > case 0x58:  /* RFBI_READ */ >    if ((s->rfbi.control & (1 << 2)) && s->rfbi.chip[0]) >        s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 1); >    else if ((s->rfbi.contro

[Qemu-devel] [PATCH] Add a comment to autogenerated .texi files noting that fact.

2012-01-08 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski --- scripts/hxtool |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/scripts/hxtool b/scripts/hxtool index 995bb7f..a985f5c 100644 --- a/scripts/hxtool +++ b/scripts/hxtool @@ -20,6 +20,8 @@ hxtotexi() { flag=0 line=1 +echo

[Qemu-devel] [PATCH] Add tab-completion for device_add.

2012-01-08 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski --- There are other ways to do this, but adding an API for querying available qdev drivers was the one that made most sense to me. --- hw/qdev.c | 38 ++ hw/qdev.h |7 +++ monitor.c | 41

Re: [Qemu-devel] [PATCH] Add tab-completion for device_add.

2012-01-08 Thread andrzej zaborowski
On 8 January 2012 16:14, Andrzej Zaborowski wrote: > Signed-off-by: Andrzej Zaborowski > --- > There are other ways to do this, but adding an API for querying > available qdev drivers was the one that made most sense to me. > --- >  hw/qdev.c |   38 ++

[Qemu-devel] [PATCH] Add tab-completion for device_add.

2012-01-08 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski --- There are other ways to do this, but adding an API for querying available qdev drivers was the one that made most sense to me. --- hw/qdev.c | 38 ++ hw/qdev.h |7 +++ monitor.c | 41

[Qemu-devel] [PATCH 0/6] OpenGL passthrough support once again

2012-01-09 Thread Andrzej Zaborowski
5340 (Actual authors of each file are listed in the file headers, not in the Signed-off-by) Andrzej Zaborowski (6): gl: Add an OpenGL offscreen rendering API and backends. gl: Add mesa OpenGL headers. gl: OpenGL passthrough implementation. virtio-serial: Call .guest_ready when new space is a

[Qemu-devel] [PATCH 4/6] virtio-serial: Call .guest_ready when new space is available in the queue.

2012-01-09 Thread Andrzej Zaborowski
Without that it's impossible to write a virtio-serial port driver that sends any buffers bigger than a couple kilobytes, other than by polling to check when space in the queue becomes available. Signed-off-by: Andrzej Zaborowski --- hw/virtio-serial-bus.c |8 1 files chang

[Qemu-devel] [PATCH 5/6] gl: virtio-serial port driver for OpenGL passthrough.

2012-01-09 Thread Andrzej Zaborowski
r the port access and open/close the device at every command buffer. * host cannot know for sure when a guest process has died unexpectedly. Signed-off-by: Andrzej Zaborowski --- Makefile.target |3 +- hw/virtio-gl-port.c | 241 +++ 2 files ch

[Qemu-devel] [PATCH 6/6] gl: -enable-gl switch to enable the GL virtio port.

2012-01-09 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski --- qemu-options.hx | 24 vl.c| 36 2 files changed, 60 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 7903e5c..f00bb6d 100644 --- a/qemu

Re: [Qemu-devel] [PATCH] elf: Improve symbol lookup (optimize, fix for bsd-user)

2012-01-11 Thread andrzej zaborowski
On 5 January 2012 15:39, Stefan Weil wrote: > Coverity complained about local variable key which was only partially > initiated. Only key.st_value was set. As this was also the only part > of key which was used in function symfind, the code could be optimized > by directly passing a pointer to ori

Re: [Qemu-devel] [PATCH] omap_dss: correct chip[1] index in RFBI_READ/RFBI_STATUS

2012-01-11 Thread andrzej zaborowski
On 7 January 2012 12:59, Stefan Hajnoczi wrote: > The RFBI_READ/RFBI_STATUS code incorrectly uses chip[0] when it should > be using chip[1].  Andrzej Zaborowski confirmed this > bug since I don't know this code well. > > Reported-by: Dr David Alan Gilbert > Signed-

Re: [Qemu-devel] [PATCH v4 1/2] hw/integratorcp: Fix sense of REMAP bit

2012-01-11 Thread andrzej zaborowski
On 6 January 2012 19:58, Peter Maydell wrote: > Fix the sense of the REMAP bit: 0 should mean "map flash", > 1 should mean "map RAM". Thanks, applied both patches. Cheers

Re: [Qemu-devel] [PATCH] tcg/arm: Use r6 as TCG_AREG0 to avoid clash with Thumb framepointer

2012-01-11 Thread andrzej zaborowski
On 9 January 2012 12:24, Peter Maydell wrote: > Ping? > > (either I forgot to cc you, Andrzej, or the mailing list manager helpfully > dropped you off the cc list again. Sorry.) Thank you, now applied. I've been in CC but my patch queue was moving slow, sorry. Cheers

Re: [Qemu-devel] [PATCH] wm8750: Fix calculation of number of array elements

2012-01-11 Thread andrzej zaborowski
On 9 January 2012 19:32, Stefan Weil wrote: > Coverity says that the division by sizeof(*s->rate) might be wrong. > I think that coverity is right. Thanks, applied. Cheers

Re: [Qemu-devel] [PATCH 0/6] OpenGL passthrough support once again

2012-01-11 Thread andrzej zaborowski
Hi, On 10 January 2012 09:29, Alon Levy wrote: > On Mon, Jan 09, 2012 at 08:57:50AM +0100, Andrzej Zaborowski wrote: >> This is the host part of an OpenGL passthrough framework to make apps >> run faster.  It has initially lived on nongnu.org as a separate project >> by Ev

Re: [Qemu-devel] [PATCH] (dont commit) virtio-gl-fixes for build on F17

2012-01-11 Thread andrzej zaborowski
On 10 January 2012 09:44, Alon Levy wrote: > All but the last are assigned but unused variables, > and an always true comparison, but the last looks like a logic > error - decode not returning the actual return value for the last call > in the buffer (vmgl-exec.c). > --- >  gl/gloffscreen-xcomposi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Add 'fall through' comments to case statements without break

2012-01-12 Thread andrzej zaborowski
On 10 January 2012 09:35, Stefan Hajnoczi wrote: > On Mon, Jan 09, 2012 at 06:29:51PM +0100, Stefan Weil wrote: >> These comments are used by static code analysis tools and in code reviews >> to avoid false warnings because of missing break statements. >> >> The case statements handled here were r

Re: [Qemu-devel] [PATCH] (dont commit) virtio-gl-fixes for build on F17

2012-01-12 Thread andrzej zaborowski
On 12 January 2012 11:42, Alon Levy wrote: > Don't mind at all! But for some reason this email and the other one I > send before it to you and to the qemu-devel list didn't reach the list. > If you saw this email is it too much to assume you saw the other one as > well? Thanks. http://lists.nongn

Re: [Qemu-devel] [Android-virt] [PATCH 03/12] hw/arm_boot.c: Make SMP boards specify address to poll in bootup loop

2012-01-16 Thread andrzej zaborowski
On 16 January 2012 09:31, Peter Maydell wrote: > On 16 January 2012 01:56, Alexander Graf wrote: >> >> On 13.01.2012, at 21:52, Peter Maydell wrote: >> >>> From: Evgeny Voevodin >>> >>> The secondary CPU bootloader in arm_boot.c holds secondary CPUs in a >>> pen until the primary CPU releases th

Re: [Qemu-devel] [PATCH 3/3] configure: add '--disable-cocoa' switch

2012-01-16 Thread Andrzej Zaborowski
On 14 January 2012 01:42, Andreas Färber wrote: > Am 08.12.2011 01:41, schrieb Andreas Färber: >> Am 10.11.2011 19:40, schrieb Pavel Borzenkov: >>> When SDL support is disabled, there is no way to build QEMU without >>> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and >>> all

Re: [Qemu-devel] [PATCH 2/2] pxa2xx_lcd: fix palette parser

2012-01-16 Thread andrzej zaborowski
On 12 January 2012 20:30, Vasily Khoruzhick wrote: > Pallete entry size for 16bpp format is 2 bytes, not 4 > > Signed-off-by: Vasily Khoruzhick Thanks, applied, (with a style consistency change). Cheers

Re: [Qemu-devel] [PATCH 1/2] pxa2xx_keypad: make single automatic scans work

2012-01-16 Thread andrzej zaborowski
On 12 January 2012 20:30, Vasily Khoruzhick wrote: > u-boot uses single automatic scans and polling in > pxa2xx_keypad driver, so clear KPC_AS bit immediately > and update keys state even if KPC_AS and KPC_ASACT are > cleared. Thanks, applied. Cheers

Re: [Qemu-devel] [PATCH v7 01/10] hw/sysbus.h: Increase maximum number of device IRQs.

2012-01-16 Thread andrzej zaborowski
On 16 January 2012 07:48, Evgeny Voevodin wrote: > Samsung exynos4210 Interrupt Combiner needs 512 IRQ sources. Thanks, I applied this patch and the second one reviewed by Peter Maydell. I haven't look at the other patches but on quick glance the code formatting is still a little off in places.

Re: [Qemu-devel] [PATCH 03/12] hw/arm_boot.c: Make SMP boards specify address to poll in bootup loop

2012-01-16 Thread andrzej zaborowski
On 13 January 2012 21:52, Peter Maydell wrote: > From: Evgeny Voevodin > > The secondary CPU bootloader in arm_boot.c holds secondary CPUs in a > pen until the primary CPU releases them. Make boards specify the > address to be polled to determine whether to leave the pen (it was > previously hard

[Qemu-devel] [PATCH v2] Add tab-completion for device_add.

2012-01-16 Thread Andrzej Zaborowski
From: Andrzej Zaborowski Signed-off-by: Andrzej Zaborowski --- v2: pass only char *prop_name as qdev_driver_prop_foreach_func parameter, Anthony noted Property was soon going away. --- hw/qdev.c | 38 ++ hw/qdev.h |7 +++ monitor.c | 41

Re: [Qemu-devel] [PATCH 3/3] configure: add '--disable-cocoa' switch

2012-01-17 Thread Andrzej Zaborowski
On 17 January 2012 12:06, Andreas Färber wrote: > Am 17.01.2012 00:46, schrieb Andrzej Zaborowski: >> On 14 January 2012 01:42, Andreas Färber wrote: >>> Am 08.12.2011 01:41, schrieb Andreas Färber: >>>> Am 10.11.2011 19:40, schrieb Pavel Borzenkov: >>>&g

Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-16 Thread andrzej zaborowski
On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote: > Hello, > > On 5/16/11, andrzej zaborowski wrote: >> On 25 April 2011 11:06, Dmitry Eremin-Solenikov >> wrote: >>> Switch dscm1 microdrive driver to use qdev infrastructure. >>&

Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-16 Thread andrzej zaborowski
On 16 May 2011 15:08, Dmitry Eremin-Solenikov wrote: > On 5/16/11, andrzej zaborowski wrote: >> On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote: >>> Socket is required, as we have to know the QBus before creating the >>> device on it. >> >> Let's

Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-17 Thread andrzej zaborowski
On 17 May 2011 07:44, Jan Kiszka wrote: > On 2011-05-17 03:38, andrzej zaborowski wrote: >> On 16 May 2011 15:08, Dmitry Eremin-Solenikov wrote: >>> On 5/16/11, andrzej zaborowski wrote: >>>> On 16 May 2011 06:54, Dmitry Eremin-Solenikov wrote: >>>>&g

Re: [Qemu-devel] [Qemu-trivial] [PATCH] bitbang_i2c: Fix spurious slave read after NACK

2011-05-28 Thread andrzej zaborowski
Hi, On 28 May 2011 21:52, Stefan Hajnoczi wrote: > On Sat, May 28, 2011 at 3:55 PM, Marcus Comstedt wrote: >> After NACKing a read operation, a raising SCL should not trigger a new >> read from the slave.  Introduce a new state which just waits for a stop >> or start condition after NACK. Makes

Re: [Qemu-devel] [PATCH 06/13] vmware-vga: Eliminate vga_dirty_log_restart

2011-06-15 Thread andrzej zaborowski
On 14 June 2011 18:53, Jan Kiszka wrote: > Convert the last user of vga_dirty_log_restart to > cpu_register_physical_memory_log and drop the service. > > CC: Andrzej Zaborowski > Signed-off-by: Jan Kiszka Reviewed-by: Andrzej Zaborowski > --- >  hw/vga.c        |    6 -

Re: [Qemu-devel] [PATCH 08/13] vmware-vga: Register reset service

2011-06-15 Thread andrzej zaborowski
On 14 June 2011 18:53, Jan Kiszka wrote: > Fixes cold reset in vmware graphic modes. > > CC: Andrzej Zaborowski > Signed-off-by: Jan Kiszka Reviewed-by: Andrzej Zaborowski > --- >  hw/vmware_vga.c |    9 ++--- >  1 files changed, 6 insertions(+), 3 deletions(-

Re: [Qemu-devel] [PATCH 07/13] vmware_vga: Do not enable dirty logging when in SVGA mode

2011-06-15 Thread andrzej zaborowski
On 14 June 2011 18:53, Jan Kiszka wrote: > Just like on SVGA_REG_ENABLE changes, keep dirty logging off on PCI BAR > remappings when SVGA mode is on. > > CC: Andrzej Zaborowski > Signed-off-by: Jan Kiszka Reviewed-by: Andrzej Zaborowski > --- >  hw/vmware_vga.c |    3 ++-

Re: [Qemu-devel] [PATCH 09/13] vmware-vga: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-15 Thread andrzej zaborowski
On 14 June 2011 18:53, Jan Kiszka wrote: > This eliminates the last user of vga_dirty_log_start/start. > > CC: Andrzej Zaborowski > Signed-off-by: Jan Kiszka Reviewed-by: Andrzej Zaborowski > --- >  hw/vmware_vga.c |   12 +++- >  1 files changed, 7 inser

Re: [Qemu-devel] [PATCH] hw/9118.c: Implement active-low interrupt support

2011-06-15 Thread andrzej zaborowski
Hi, On 26 May 2011 18:34, Peter Maydell wrote: > The 9118 ethernet controller interrupt line is active low unless > the IRQ config register is programmed to set both the IRQ_POL > (polarity: active-high) and IRQ_TYPE (type: push-pull) bits: > implement support for inverting the irq output in othe

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is suitable for microdrive" test

2011-07-29 Thread andrzej zaborowski
On 20 July 2011 18:24, Markus Armbruster wrote: > We try the drive defined with -drive if=ide,index=0 (or equivalent > sugar).  We use it only if (dinfo && bdrv_is_inserted(dinfo->bdrv) && > !bdrv_is_removable(dinfo->bdrv)).  This is a convoluted way to test > for "drive media can't be removed". >

Re: [Qemu-devel] [PATCH 02/15] hw/omap_gpio.c: Don't complain about some writes to r/o registers

2011-07-29 Thread andrzej zaborowski
Hi, I went ahead and pushed the series with the exception of this patch and 14/15 because I think these are the types of patches that should remain in downstream as a reminder, is there an argument for not fixing these things in Linux? In patch 04 I renamed omap2_gpio_module_set to omap2_gpio_set

Re: [Qemu-devel] [PATCH v5] Add support for Zipit Z2 machine

2011-07-29 Thread andrzej zaborowski
On 6 July 2011 15:52, Vasily Khoruzhick wrote: > Zipit Z2 is small PXA270 based handheld. Thanks, I pushed this version. Cheers

Re: [Qemu-devel] [PATCH 15/15] hw/onenand: program actions can only clear bits

2011-07-29 Thread andrzej zaborowski
On 29 July 2011 17:35, Peter Maydell wrote: > From: Juha Riihimäki > > The program actions onenand_prog_main() and onenand_prog_spare() > can only set bits. > > This implies a rewrite of onenand_erase() to not use the program > functions, since erase does need to set bits. > > Signed-off-by: Juha

Re: [Qemu-devel] [PATCH 2/7] sd: fix card size checking on R/W accesses

2011-07-29 Thread andrzej zaborowski
Hi Vincent, On 26 July 2011 01:19, Vincent Palatin wrote: > We need to check that we are not crossing the boundaries of the card for > the current access not for the next one which might not happen. > > Signed-off-by: Vincent Palatin > --- >  hw/sd.c |   22 -- >  1 files chan

Re: [Qemu-devel] [PATCH v2] usb-hid: Fix 0/0 position for Windows in tablet mode

2011-07-29 Thread andrzej zaborowski
On 13 July 2011 23:05, Andreas Färber wrote: > Am 12.07.2011 um 09:47 schrieb Jan Kiszka: > >> On 2011-07-04 20:15, andrzej zaborowski wrote: >>> >>> On 26 June 2011 11:11, Jan Kiszka wrote: >>>> >>>> On 2011-06-25 15:10, Andreas Färber

Re: [Qemu-devel] [PATCH] user: Restore debug usage message for '-d ?' in user mode emulation

2011-07-29 Thread andrzej zaborowski
On 18 July 2011 12:44, Peter Maydell wrote: > The code which prints the debug usage message on '-d ?' for *-user > has to come before the check for "not enough arguments", so that > "qemu-foo -d ?" prints the list of possible debug log items rather than > the generic usage message. (This was inadv

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is suitable for microdrive" test

2011-08-03 Thread andrzej zaborowski
On 3 August 2011 10:12, Markus Armbruster wrote: > Peter Maydell writes: > >> On 1 August 2011 13:33, Markus Armbruster wrote: >>> andrzej zaborowski writes: >>>> On 20 July 2011 18:24, Markus Armbruster wrote: >>>>> We try the drive d

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is suitable for microdrive" test

2011-08-03 Thread andrzej zaborowski
On 3 August 2011 15:28, Markus Armbruster wrote: > andrzej zaborowski writes: > >> On 3 August 2011 10:12, Markus Armbruster wrote: >>> Peter Maydell writes: >>> >>>> On 1 August 2011 13:33, Markus Armbruster wrote: >>>>> andrzej

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is suitable for microdrive" test

2011-08-03 Thread andrzej zaborowski
On 3 August 2011 18:38, Markus Armbruster wrote: > andrzej zaborowski writes: >>                                                      2. if the >> underlaying storage can disappear for any other reason if that's >> possible to check. > > bdrv_is_removable() *i

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is suitable for microdrive" test

2011-08-03 Thread andrzej zaborowski
On 3 August 2011 20:24, Markus Armbruster wrote: > andrzej zaborowski writes: >> On 3 August 2011 18:38, Markus Armbruster wrote: >>> andrzej zaborowski writes: >>>>                                                      2. if the >>>> underlaying sto

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is suitable for microdrive" test

2011-08-08 Thread andrzej zaborowski
On 4 August 2011 10:02, Kevin Wolf wrote: > Am 03.08.2011 22:20, schrieb andrzej zaborowski: >> On 3 August 2011 20:24, Markus Armbruster wrote: >>> andrzej zaborowski writes: >>>> On 3 August 2011 18:38, Markus Armbruster wrote: &g

Re: [Qemu-devel] [PATCH 6/6] tcg-arm: Make tcg_out_addi inline

2011-08-19 Thread andrzej zaborowski
On 20 August 2011 01:51, Peter Maydell wrote: > On 17 August 2011 22:11, Richard Henderson wrote: >> As it's not used, fixes a compilation error. Stefan Weil submitted an identical patch a couple of weeks ago, but I can't see the rationale for inlining. It seems like working around the warning

[Qemu-devel] [PATCH] bt: Fix the bitmask in event masked check.

2012-06-07 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski --- hw/bt-hci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/bt-hci.c b/hw/bt-hci.c index 8c717f9..48cbbb5 100644 --- a/hw/bt-hci.c +++ b/hw/bt-hci.c @@ -442,7 +442,7 @@ static inline uint8_t *bt_hci_event_start(struct bt_hci_s

[Qemu-devel] [PATCH] bt: HCI Reset returns a Cmd Complete event.

2012-06-07 Thread Andrzej Zaborowski
HCI Reset command returns a Command Complete event, not a Command Status event. We need to avoid resetting the stored last command code for the response to be fully correct. Signed-off-by: Andrzej Zaborowski --- hw/bt-hci.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

Re: [Qemu-devel] SD card subsystem synchronous I/O

2012-04-19 Thread andrzej zaborowski
On 18 April 2012 14:35, Stefan Hajnoczi wrote: > Recently there have been new SD card emulation patches so I want to > raise the issue of synchronous I/O while there is focus on the SD > subsystem.  Maybe some of the people who are improving the SD > subsystem will be able to help. > > sd_blk_read

Re: [Qemu-devel] SD card subsystem synchronous I/O

2012-04-20 Thread andrzej zaborowski
On 20 April 2012 11:50, Stefan Hajnoczi wrote: > On Fri, Apr 20, 2012 at 12:21 AM, andrzej zaborowski > wrote: >> Yes, controllers would be affected, but there are various ways to go >> about it.  Some could be simple to implement (looking at >> pxa2xx_mmci.

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread andrzej zaborowski
Hi, On 17 February 2012 19:21, Peter Maydell wrote: > I'm looking at cleaning up some more omap3 patches, and have > been working on the omap_i2c related ones. At the moment in > omap_i2c.c there are the following #defines for the I2C module > revision (as exposed via the revision register): > >

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread andrzej zaborowski
On 20 February 2012 13:12, andrzej zaborowski wrote: > I have neither of the TRMs at hand but I downloaded the TRM for > omap35x which features i2c module 3.1 and it looks like the current Sorry, the revision is not given in the TRM, 3.1 is an example. Cheers

[Qemu-devel] [PATCH v3] Add tab-completion for device_add.

2012-02-20 Thread Andrzej Zaborowski
From: Andrzej Zaborowski Signed-off-by: Andrzej Zaborowski --- v2: pass only char *prop_name as qdev_driver_prop_foreach_func parameter, Anthony noted Property was soon going away. v3: use QOM. --- monitor.c | 58 ++ 1 files changed

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread andrzej zaborowski
On 22 February 2012 11:15, Igor Mitsyanko wrote: > Convert three variables in DMAChannel state from type target_phys_addr_t to > uint32_t, > use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. > We can do it safely because: > 1) pxa2xx has 32-bit physical address; > 2) rest of the c

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread andrzej zaborowski
On 22 February 2012 13:00, Peter Maydell wrote: > On 22 February 2012 11:36, andrzej zaborowski wrote: >> On 22 February 2012 11:15, Igor Mitsyanko wrote: >>> Convert three variables in DMAChannel state from type target_phys_addr_t to >>> uint32_t, >&g

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread andrzej zaborowski
On 22 February 2012 13:26, Mitsyanko Igor wrote: > On 02/22/2012 03:36 PM, andrzej zaborowski wrote: >> Why's uint32_t more correct though?  The purpose of using a named type >> across qemu is to mark fields as memory addresses (similar to size_t >> being used for size

Re: [Qemu-devel] [PATCH 3/5] hw/pxa2xx_lcd.c: drop VMSTATE_UINTTL usage

2012-02-22 Thread andrzej zaborowski
On 22 February 2012 13:48, Peter Maydell wrote: > On 22 February 2012 12:13, andrzej zaborowski wrote: >> On 22 February 2012 13:00, Peter Maydell wrote: >>> On 22 February 2012 11:36, andrzej zaborowski wrote: >>>> On 22 February 2012 11:15, Igor Mitsyan

Re: [Qemu-devel] "qemu -device ?" segfaults

2012-02-23 Thread andrzej zaborowski
On 23 February 2012 09:20, Gerd Hoffmann wrote: > $subject says all, which pretty much breaks libvirt-managed qemu ... Also "device_add nonexistent-device" in the monitor gives a rather unhelpful message: Parameter 'driver' expects device type Cheers

Re: [Qemu-devel] "qemu -device ?" segfaults

2012-02-23 Thread andrzej zaborowski
On 23 February 2012 09:48, Markus Armbruster wrote: > andrzej zaborowski writes: > >> On 23 February 2012 09:20, Gerd Hoffmann wrote: >>> $subject says all, which pretty much breaks libvirt-managed qemu ... >> >> Also "device_add nonexistent-device"

[Qemu-devel] [PATCH 4/6 v2] virtio-serial: Call .guest_ready when new space is available in the queue.

2012-02-23 Thread Andrzej Zaborowski
Without that it's impossible to write a virtio-serial port driver that sends any buffers bigger than a couple kilobytes, other than by polling to check when space in the queue becomes available. Signed-off-by: Andrzej Zaborowski --- v2: rebase after QOM. --- hw/virtio-serial-bus.c |

[Qemu-devel] [PATCH 5/6 v2] gl: virtio-serial port driver for OpenGL passthrough.

2012-02-23 Thread Andrzej Zaborowski
r the port access and open/close the device at every command buffer. * host cannot know for sure when a guest process has died unexpectedly. Signed-off-by: Andrzej Zaborowski --- v2: rebase after QOM. --- Makefile.target |3 +- hw/virtio-gl-por

[Qemu-devel] [PATCH 6/6 v2] gl: -enable-gl switch to enable the OpenGL virtio port.

2012-02-23 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski --- qemu-options.hx | 24 vl.c| 36 2 files changed, 60 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index b129996..8a5784c 100644 --- a/qemu

Re: [Qemu-devel] [PATCH] usb-hid: Fix 0/0 position for Windows in tablet mode

2011-07-04 Thread andrzej zaborowski
On 26 June 2011 11:11, Jan Kiszka wrote: > On 2011-06-25 15:10, Andreas Färber wrote: >> Am 25.06.2011 um 14:55 schrieb Jan Kiszka: >> >>> On 2011-06-25 14:37, Andreas Färber wrote: Am 24.06.2011 um 16:27 schrieb Jan Kiszka: > For unknown reasons, Windows drivers (tested with XP and

Re: [Qemu-devel] [PATCH v4 1/2] pxa2xx_lcd: add proper rotation support

2011-07-04 Thread andrzej zaborowski
On 17 June 2011 12:04, Vasily Khoruzhick wrote: > Until now, pxa2xx_lcd only supported 90deg rotation, but > some machines (for example Zipit Z2) needs 270deg rotation. > > Signed-off-by: Vasily Khoruzhick > --- > v2: codestyle fixes > v3: fix dpy_update calls for 180 and 360 deg. rotation. > v4:

Re: [Qemu-devel] [PATCH] arm: Add const attribute to some arm_boot_info pointers

2011-07-04 Thread andrzej zaborowski
On 23 June 2011 17:53, Stefan Weil wrote: > Parameter 'info' is const, so add the missing attribute. > > v2: > Add 'const' to the local variable info in do_cpu_reset() and to > the boot_info field in CPUARMState (suggested by Peter Maydell). I pushed this version, thanks. Cheers

Re: [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev

2011-07-04 Thread andrzej zaborowski
Hi, On 29 June 2011 20:53, Peter Maydell wrote: > From: Juha Riihimäki > > Convert the OMAP GPIO module to qdev. > > Signed-off-by: Juha Riihimäki > [Riku Voipio: Fixes and restructuring patchset] > Signed-off-by: Riku Voipio > [Peter Maydell: More fixes and cleanups for upstream submission] >

[Qemu-devel] [Bug 568614] Re: x86_64 host curses interface: spacing/garbling

2011-07-04 Thread Andrzej Zaborowski
If I remember correctly, the type is unsigned long because it needs to match "chtype" as declared in curses.h. On some implementations of curses it may be declared differently, we really should use the "chtype" type directly but console.h is also used when the use of curses was disabled in qemu co

[Qemu-devel] [Bug 568614] Re: x86_64 host curses interface: spacing/garbling

2011-07-07 Thread Andrzej Zaborowski
This is probably the source of the problem. As you say it'd be best to use chtype directly if it can be done cleanly, unfortunately it looks like it'll add a curses specific snippet in console.h, but so be it. The only other option is to add a conversion step in curses.c and give up zero-copy pass

Re: [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev

2011-07-07 Thread andrzej zaborowski
Hi, On 5 July 2011 15:19, Peter Maydell wrote: > On 4 July 2011 23:39, andrzej zaborowski wrote: >> I'd also prefer that omap2_gpio_init remains a function that >> does all the qdev magic in omap_gpio.c and with the current signature > > I'm not convinced ab

Re: [Qemu-devel] [PATCH] [v3] hw/arm_gic.c: Fix save/load of irq_target array

2011-10-21 Thread andrzej zaborowski
On 20 October 2011 12:48, Dmitry Koshelev wrote: > irq_target array saving/loading is in the wrong loop. > Version bump. > > Signed-off-by: Dmitry Koshelev Thanks, pushed this patch. Cheers

Re: [Qemu-devel] [PATCH] hw/omap2: Wire up the IRQ for the 2430's fifth GPIO module

2011-10-21 Thread andrzej zaborowski
On 18 October 2011 17:12, Peter Maydell wrote: > The OMAP2430 version of the omap-gpio device has five GPIO modules, > not four like the other OMAP2 versions; wire up the fifth module's > IRQ line correctly. Thanks, pushed this patch. Cheers

Re: [Qemu-devel] [PATCH] linux-user: Fix broken "-version" option

2011-10-21 Thread andrzej zaborowski
On 29 September 2011 16:48, Peter Maydell wrote: > Fix the "-version" option, which was accidentally broken in commit > fc9c541: >  * exit after printing version information rather than proceeding >   blithely onward (and likely printing the full usage message) >  * correct the cut-n-paste error i

Re: [Qemu-devel] [PATCH] compatfd.c: Don't pass NULL pointer to SYS_signalfd

2011-10-21 Thread andrzej zaborowski
On 13 October 2011 19:45, Peter Maydell wrote: > Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available(): > this isn't valid and Valgrind complains about it. Also pushed this patch. Cheers

Re: [Qemu-devel] [PATCH V5] Add AACI audio playback support to the ARM Versatile/PB platform

2011-10-21 Thread andrzej zaborowski
Hi Mathieu, On 18 October 2011 23:45, Mathieu Sonet wrote: > This driver emulates the ARM AACI interface (PL041) connected to a LM4549 > codec. > It enables audio playback for the Versatile/PB platform. > > Limitations: > - Supports only a playback on one channel (Versatile/Vexpress) > - Supports

Re: [Qemu-devel] [PULL v2 0/8] target-arm queue

2011-10-26 Thread andrzej zaborowski
On 20 October 2011 16:36, Peter Maydell wrote: > Hi; these are the pending target-arm patches I'd like to get in for 1.0; > a couple of minor ones plus the A15 insn work. Please pull. > > V2 of this pullreq just adds Andreas' trivial patch as 8/8, > so I haven't bothered re-emailing the identical

Re: [Qemu-devel] [PATCH v6 1/2] Add AACI audio playback support to the ARM Versatile/PB platform

2011-10-30 Thread andrzej zaborowski
On 28 October 2011 11:55, Peter Maydell wrote: > From: Mathieu Sonet > > This driver emulates the ARM AACI interface (PL041) connected to a LM4549 > codec. > It enables audio playback for the Versatile/PB platform. Thanks, pushed both changes. Cheers

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

2011-11-08 Thread Andrzej Zaborowski
from vl.c? > > To make things more complicated, it looks like Thiemo Seufer did the > original mips support, and he passed away.  So he can't obviously > comment. > > Anthony asked me to send a patch to the list, asking form comments. Acked-by: Andrzej Zaborowski Cheers

Re: [Qemu-devel] [PATCH] hw/pxa2xx.c: Fix handling of R/WC bits in PMCR

2011-11-11 Thread andrzej zaborowski
Hi, On 11 November 2011 20:45, Anthony Liguori wrote: > On 11/09/2011 02:46 PM, Peter Maydell wrote: >> >> Fix a bug in handling the write-one-to-clear bits in the PMCR >> which meant that we would always clear the bit even if the >> value written was a zero. Spotted by Coverity (see bug 887883).

Re: [Qemu-devel] [PATCH] hw/pxa2xx.c: Fix handling of RW bits in PMCR

2011-11-13 Thread andrzej zaborowski
On 13 November 2011 15:18, Peter Maydell wrote: > Fix an error in commit afd4a6522 which meant that writing a zero > to the RW bits in the PMCR wouldn't actually clear them. (Error > spotted by Andrzej Zaborowski.) > > Signed-off-by: Peter Maydell Thanks, pushed. Cheers

Re: [Qemu-devel] [PATCH] hw/usb-net.c: Fix precedence bug when checking rndis_state

2011-11-13 Thread andrzej zaborowski
On 9 November 2011 22:09, Peter Maydell wrote: > "!X == 2" is always false (spotted by Coverity), so the checks > for whether rndis is in the correct state would never fire. I pushed this patch because it's a bugfix and the check is guarded by is_rndis() so there should be no risk of affecting no

Re: [Qemu-devel] [PATCH v3] hw/arm_sysctl: Fix RESETCTL for realview-pb-a8 and -pbx-a9

2011-11-13 Thread andrzej zaborowski
On 6 November 2011 20:14, Jean-Christophe DUBOIS wrote: > Depending on the considered baseboard the bit used to > reset the platform is different. > > Here is the list of considered Realview/Versatile platforms: > > Realview/Versatile AB for ARM926EJ-S: BOARD_ID = 0x100 = BOARD_ID_PB926 > http://i

Re: [Qemu-devel] [PATCH v2 0/2] nand/onenand: reject read-only drives

2011-11-13 Thread andrzej zaborowski
On 20 October 2011 14:53, wrote: > From: Juha Riihimäki > > Make NAND and OneNAND device models reject read-only drives. > Test for example by running > > $ qemu-system-arm -drive if=none,file=/dev/zero,readonly,id=foo -device > nand,drive=foo,chip_id=0x59 -kernel /dev/null > > or > > $ qemu-sy

Re: [Qemu-devel] [PATCH] hw/usb-net.c: Fix precedence bug when checking rndis_state

2011-11-14 Thread andrzej zaborowski
On 14 November 2011 09:08, Peter Maydell wrote: > I'm happy that non-rndis works, I tested that. What I don't know > is whether the patch breaks rndis Sorry, I misread what you said assuming that you tested a branch affected by this patch. I'm unable to find a guest to test the rndis mode so I r

Re: [Qemu-devel] [PATCH 0/2] omap_intc: convert to MemoryRegion, qdev

2011-09-16 Thread andrzej zaborowski
On 16 September 2011 16:32, Peter Maydell wrote: > On 16 September 2011 14:05, Anthony Liguori wrote: >> On 09/09/2011 11:48 AM, Peter Maydell wrote: >>> Ping? >> >> Is anyone actively maintaining the omap device model? > > Whoops, Andrzej's email got dropped from the cc (some odd interaction > b

  1   2   3   4   5   6   7   >