Re: [PULL 45/51] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2023-05-13 Thread Yicong Yang via
Hi Philippe, On 2023/5/10 18:13, Philippe Mathieu-Daudé wrote: > Hi Yang, > > On 5/1/23 10:16, Michael S. Tsirkin wrote: >> From: Yicong Yang >> >> Currently we'll always generate a cluster node no matter user has >> specified '-smp clusters=X' or not. Cluster is an optional level >> and will pa

Re: [PATCH v2 2/4] tests: virt: update expected ACPI tables for virt test

2022-10-31 Thread Yicong Yang via
On 2022/10/29 15:53, Michael S. Tsirkin wrote: > On Thu, Oct 27, 2022 at 11:26:11AM +0800, Yicong Yang wrote: >> From: Yicong Yang >> >> Update the ACPI tables according to the acpi aml_build change. >> >> Signed-off-by: Yicong Yang > > OK nice but if patch 1 is applied alone that will break mak

Re: [PATCH v2 1/4] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-10-31 Thread Yicong Yang via
Hi Yanan, On 2022/10/31 14:56, wangyanan (Y) wrote: > Hi Yicong, > > On 2022/10/27 11:26, Yicong Yang wrote: >> From: Yicong Yang >> >> Currently we'll always generate a cluster node no matter user has >> specified '-smp clusters=X' or not. Cluster is an optional level >> and will participant th

[PATCH v3 3/5] tests: acpi: add and whitelist *.topology blobs

2022-10-31 Thread Yicong Yang via
From: Yicong Yang Add and whitelist *.topology blobs, prepares for the aarch64's ACPI topology building test. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.topology | 0 tests/data/acpi/virt/DSDT.topology | 0 tests/data/acpi/virt/PPTT.topology | 0 tests/

[PATCH v3 0/5] Only generate cluster node in PPTT when specified

2022-10-31 Thread Yicong Yang via
From: Yicong Yang This series mainly change the policy for building a cluster topology node in PPTT. Previously we'll always build a cluster node in PPTT without asking the user, after this set the cluster node will be built only the the user specify through "-smp clusters=X". One problem is rel

[PATCH v3 1/5] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-10-31 Thread Yicong Yang via
From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and will participant the building of Linux scheduling domains and only appears on a few platforms. It's unncessary to always build it which cannot r

[PATCH v3 4/5] tests: acpi: aarch64: add topology test for aarch64

2022-10-31 Thread Yicong Yang via
From: Yicong Yang Add test for aarch64's ACPI topology building for all the supported levels. Acked-by: Michael S. Tsirkin Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b

[PATCH v3 2/5] tests: virt: update expected ACPI tables for virt test

2022-10-31 Thread Yicong Yang via
From: Yicong Yang Update the ACPI tables according to the acpi aml_build change. Acked-by: Michael S. Tsirkin Signed-off-by: Yicong Yang --- tests/data/acpi/virt/PPTT | Bin 96 -> 76 bytes tests/qtest/bios-tables-test-allowed-diff.h | 1 - 2 files changed, 1 deletion(-) d

[PATCH v3 5/5] tests: acpi: aarch64: add *.topology tables

2022-10-31 Thread Yicong Yang via
From: Yicong Yang Add *.topology tables for the aarch64's topology test. Acked-by: Michael S. Tsirkin Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.topology | Bin 0 -> 700 bytes tests/data/acpi/virt/DSDT.topology | Bin 0 -> 5398 bytes tests/data/acpi/virt/PPTT.t

Re: [PATCH v3 4/5] tests: acpi: aarch64: add topology test for aarch64

2022-10-31 Thread Yicong Yang via
On 2022/10/31 19:48, wangyanan (Y) wrote: > Hi Yicong, > > On 2022/10/31 17:05, Yicong Yang wrote: >> From: Yicong Yang >> >> Add test for aarch64's ACPI topology building for all the supported >> levels. >> >> Acked-by: Michael S. Tsirkin >> Signed-off-by: Yicong Yang >> --- >>   tests/qtest/b

Re: [PATCH v3 2/5] tests: virt: update expected ACPI tables for virt test

2022-10-31 Thread Yicong Yang via
Hi Michael and Yanan, On 2022/10/31 20:30, Michael S. Tsirkin wrote: > On Mon, Oct 31, 2022 at 07:21:31PM +0800, wangyanan (Y) wrote: >> Hi Yicong, >> >> On 2022/10/31 17:05, Yicong Yang wrote: >>> From: Yicong Yang >>> >>> Update the ACPI tables according to the acpi aml_build change. >> We may

Re: [PATCH v3 1/5] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-10-31 Thread Yicong Yang via
On 2022/10/31 19:17, wangyanan (Y) wrote: > > On 2022/10/31 17:05, Yicong Yang wrote: >> From: Yicong Yang >> >> Currently we'll always generate a cluster node no matter user has >> specified '-smp clusters=X' or not. Cluster is an optional level >> and will participant the building of Linux sche

[PATCH v4 5/6] tests: acpi: aarch64: Add topology test for aarch64

2022-11-01 Thread Yicong Yang via
From: Yicong Yang Add test for aarch64's ACPI topology building for all the supported levels. Acked-by: Michael S. Tsirkin Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/te

[PATCH v4 6/6] tests: acpi: aarch64: Add *.topology tables

2022-11-01 Thread Yicong Yang via
From: Yicong Yang Add *.topology tables for the aarch64's topology test and empty bios-tables-test-allowed-diff.h The disassembled differences between actual and expected PPTT (the table which we actually care about): +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler versio

[PATCH v4 1/6] tests: virt: Allow changes to PPTT test table

2022-11-01 Thread Yicong Yang via
From: Yicong Yang Allow changes to test/data/acpi/virt/PPTT, prepare to change the building policy of the cluster topology. Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h

[PATCH v4 3/6] tests: virt: Update expected ACPI tables for virt test

2022-11-01 Thread Yicong Yang via
From: Yicong Yang Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h. The disassembled differences between actual and expected PPTT: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180105 (64-bit version)

[PATCH v4 4/6] tests: acpi: Add and whitelist *.topology blobs

2022-11-01 Thread Yicong Yang via
From: Yicong Yang Add and whitelist *.topology blobs, prepares for the aarch64's ACPI topology building test. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.topology | 0 tests/data/acpi/virt/DSDT.topology | 0 tests/data/acpi/virt/PPTT.topology | 0 tests/

[PATCH v4 0/6] Only generate cluster node in PPTT when specified

2022-11-01 Thread Yicong Yang via
From: Yicong Yang This series mainly change the policy for building a cluster topology node in PPTT. Previously we'll always build a cluster node in PPTT without asking the user, after this set the cluster node will be built only the the user specify through "-smp clusters=X". One problem is rel

[PATCH v4 2/6] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-11-01 Thread Yicong Yang via
From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and will participant the building of Linux scheduling domains and only appears on a few platforms. It's unnecessary to always build it when it canno

Re: [PATCH v4 0/6] Only generate cluster node in PPTT when specified

2022-11-03 Thread Yicong Yang via
On 2022/11/2 16:17, Michael S. Tsirkin wrote: > On Tue, Nov 01, 2022 at 03:10:42PM +0800, Yicong Yang wrote: >> From: Yicong Yang >> >> This series mainly change the policy for building a cluster topology node >> in PPTT. Previously we'll always build a cluster node in PPTT without >> asking the u

Re: [PATCH 0/4] Only generate cluster node in PPTT when specified

2022-09-23 Thread Yicong Yang via
On 2022/9/22 22:31, Jonathan Cameron wrote: > On Thu, 22 Sep 2022 21:11:39 +0800 > Yicong Yang wrote: > >> From: Yicong Yang >> >> This series mainly change the policy for building a cluster topology node >> in PPTT. Previously we'll always build a cluster node in PPTT without >> asking the user

Re: [PATCH 0/4] Only generate cluster node in PPTT when specified

2022-10-26 Thread Yicong Yang via
Hi Michael, On 2022/10/26 22:52, Michael S. Tsirkin wrote: > On Thu, Sep 22, 2022 at 09:11:39PM +0800, Yicong Yang wrote: >> From: Yicong Yang >> >> This series mainly change the policy for building a cluster topology node >> in PPTT. Previously we'll always build a cluster node in PPTT without >

[PATCH v2 1/4] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-10-26 Thread Yicong Yang via
From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and will participant the building of Linux scheduling domains and only appears on a few platforms. It's unncessary to always build it which cannot r

[PATCH v2 3/4] tests: acpi: aarch64: add topology test for aarch64

2022-10-26 Thread Yicong Yang via
From: Yicong Yang Add test for aarch64's ACPI topology building for all the supported levels. Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.

[PATCH v2 2/4] tests: virt: update expected ACPI tables for virt test

2022-10-26 Thread Yicong Yang via
From: Yicong Yang Update the ACPI tables according to the acpi aml_build change. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/PPTT | Bin 96 -> 76 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/data/acpi/virt/PPTT b/tests/data/acpi/virt/PPTT index f56ea63b369

[PATCH v2 4/4] tests: acpi: aarch64: add *.topology tables

2022-10-26 Thread Yicong Yang via
From: Yicong Yang Add *.topology tables for the aarch64's topology test. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.topology | Bin 0 -> 700 bytes tests/data/acpi/virt/DSDT.topology | Bin 0 -> 5398 bytes tests/data/acpi/virt/PPTT.topology | Bin 0 -> 336 bytes 3 files changed, 0

[PATCH v2 0/4] Only generate cluster node in PPTT when specified

2022-10-26 Thread Yicong Yang via
From: Yicong Yang This series mainly change the policy for building a cluster topology node in PPTT. Previously we'll always build a cluster node in PPTT without asking the user, after this set the cluster node will be built only the the user specify through "-smp clusters=X". One problem is rel

Re: [PATCH v3 0/8] AArch64/HMAT support and tests

2022-10-28 Thread Yicong Yang via
Hi Hesham, On 2022/10/27 18:00, Hesham Almatary wrote: > This patchset adds support for AArch64/HMAT including a test. > It relies on other two patch sets from: > > Brice Goglin: to support -numa without initiators on q35/x86. > https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf...@i

Re: [PATCH v4 0/6] Only generate cluster node in PPTT when specified

2022-12-21 Thread Yicong Yang via
On 2022/12/21 14:27, Michael S. Tsirkin wrote: > On Tue, Nov 01, 2022 at 03:10:42PM +0800, Yicong Yang wrote: >> From: Yicong Yang >> >> This series mainly change the policy for building a cluster topology node >> in PPTT. Previously we'll always build a cluster node in PPTT without >> asking the

[PATCH v5 5/6] tests: acpi: aarch64: Add topology test for aarch64

2022-12-28 Thread Yicong Yang via
From: Yicong Yang Add test for aarch64's ACPI topology building for all the supported levels. Acked-by: Michael S. Tsirkin Reviewed-by: Yanan Wang Tested-by: Yanan Wang Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test.c | 19 +++ 1 file changed, 19 insertions(+)

[PATCH v5 0/6] Only generate cluster node in PPTT when specified

2022-12-28 Thread Yicong Yang via
From: Yicong Yang This series mainly change the policy for building a cluster topology node in PPTT. Previously we'll always build a cluster node in PPTT without asking the user, after this set the cluster node will be built only the the user specify through "-smp clusters=X". One problem is rel

[PATCH v5 4/6] tests: acpi: Add and whitelist *.topology blobs

2022-12-28 Thread Yicong Yang via
From: Yicong Yang Add and whitelist *.topology blobs, prepares for the aarch64's ACPI topology building test. Reviewed-by: Yanan Wang Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.topology | 0 tests/data/acpi/virt/DSDT.topology | 0 tests/data/acpi/virt/PPTT.topo

[PATCH v5 1/6] tests: virt: Allow changes to PPTT test table

2022-12-28 Thread Yicong Yang via
From: Yicong Yang Allow changes to test/data/acpi/virt/PPTT*, prepare to change the building policy of the cluster topology. Reviewed-by: Yanan Wang Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/bio

[PATCH v5 6/6] tests: acpi: aarch64: Add *.topology tables

2022-12-28 Thread Yicong Yang via
From: Yicong Yang Add *.topology tables for the aarch64's topology test and empty bios-tables-test-allowed-diff.h The disassembled differences between actual and expected PPTT (the table which we actually care about): +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler versio

[PATCH v5 2/6] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-12-28 Thread Yicong Yang via
From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and will participant the building of Linux scheduling domains and only appears on a few platforms. It's unncessary to always build it when it cannot

[PATCH v5 3/6] tests: virt: Update expected ACPI tables for virt test

2022-12-28 Thread Yicong Yang via
From: Yicong Yang Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h. The disassembled differences between actual and expected PPTT: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180105 (64-bit version)

Re: [PATCH v2 0/8] AArch64/HMAT support and tests

2022-09-15 Thread Yicong Yang via
On 2022/7/19 17:49, Hesham Almatary wrote: > This patchset adds support for AArch64/HMAT including a test. > It relies on other two patch sets from: > > Brice Goglin: to support -numa without initiators on q35/x86. > https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf...@inria.fr/ > Xi

[PATCH 3/4] tests: acpi: aarch64: add topology test for aarch64

2022-09-22 Thread Yicong Yang via
From: Yicong Yang Add test for aarch64's ACPI topology building for all the supported levels. Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.

[PATCH 4/4] tests: acpi: aarch64: add *.topology tables

2022-09-22 Thread Yicong Yang via
From: Yicong Yang Add *.topology tables for the aarch64's topology test. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.topology | Bin 0 -> 700 bytes tests/data/acpi/virt/DBG2.topology | Bin 0 -> 87 bytes tests/data/acpi/virt/DSDT.topology | Bin 0 -> 5398 bytes tests/data/acpi/vir

[PATCH 2/4] tests: virt: update expected ACPI tables for virt test

2022-09-22 Thread Yicong Yang via
From: Yicong Yang Update the ACPI tables according to the acpi aml_build change. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.pxb | Bin 0 -> 168 bytes tests/data/acpi/virt/DBG2.memhp | Bin 0 -> 87 bytes tests/data/acpi/virt/DBG2.numamem | Bin 0 -> 87 bytes tests/data/acpi/

[PATCH 0/4] Only generate cluster node in PPTT when specified

2022-09-22 Thread Yicong Yang via
From: Yicong Yang This series mainly change the policy for building a cluster topology node in PPTT. Previously we'll always build a cluster node in PPTT without asking the user, after this set the cluster node will be built only the the user specify through "-smp clusters=X". Update the tests a

[PATCH 1/4] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-09-22 Thread Yicong Yang via
From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and it's unncessary to build it if user don't need. So only generate it when user specify explicitly. Also update the test ACPI tables. Signed-off

Re: [PATCH 1/4] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-10-11 Thread Yicong Yang via
On 2022/10/9 14:46, wangyanan (Y) wrote: > Hi Yicong, > > On 2022/9/22 21:11, Yicong Yang wrote: >> From: Yicong Yang >> >> Currently we'll always generate a cluster node no matter user has >> specified '-smp clusters=X' or not. Cluster is an optional level >> and it's unncessary to build it if us

Re: [PATCH 1/4] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-10-11 Thread Yicong Yang via
On 2022/10/7 21:48, Michael S. Tsirkin wrote: > On Thu, Sep 22, 2022 at 09:11:40PM +0800, Yicong Yang wrote: >> From: Yicong Yang >> >> Currently we'll always generate a cluster node no matter user has >> specified '-smp clusters=X' or not. Cluster is an optional level >> and it's unncessary to bu

Re: [PATCH 6/8] contrib/gitdm: map HiSilicon to Huawei

2023-10-15 Thread Yicong Yang via
On 2023/10/13 23:44, Alex Bennée wrote: > HiSilicon is a wholly owned subsidiary of Huawei so map the domain to > the same company to avoid splitting the contributions. > > Signed-off-by: Alex Bennée > Cc: Yicong Yang Reviewed-by: Yicong Yang > Cc: Jonathan Cameron > --- > contrib/gitdm/dom

[PATCH 0/5] Building PPTT with root node and identical implementation flag

2024-09-26 Thread Yicong Yang via
From: Yicong Yang OS like Linux is using PPTT processor node's identical implementation flag [1] to infer whether the whole system or a certain CPU cluster is homogeneous or not [2]. QEMU currently only support building homogeneous system, set the flag to indicate the fact. Build a root node in P

[PATCH 1/5] tests: virt: Allow changes to PPTT test table

2024-09-26 Thread Yicong Yang via
From: Yicong Yang Allow changes to PPTT test table, preparing for adding identical implementation flags support and for adding a root node for all the system. Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests

[PATCH 5/5] tests: virt: Update expected ACPI tables for virt test

2024-09-26 Thread Yicong Yang via
From: Yicong Yang Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h. The disassembled differences between actual and expected PPTT shows below. Only about the root node adding and identification flag set as expected. /* * Intel ACPI C

[PATCH 3/5] hw/acpi/aml-build: Build a root node in the PPTT table

2024-09-26 Thread Yicong Yang via
From: Yicong Yang Currently we build the PPTT starting from the socket node and each socket will be a separate tree. For a multi-socket system it'll be hard for the OS to know the whole system is homogeneous or not (actually we're in the current implementation) since no parent node to telling the

[PATCH 2/5] hw/acpi/aml-build: Set identical implementation flag for PPTT processor nodes

2024-09-26 Thread Yicong Yang via
From: Yicong Yang Per ACPI 6.5 Table 5.158: Processor Structure Flags, the identical implementation flag indicates whether all the children processors of this node share the same identical implementation revision. Currently Linux support parsing this field [1] and maybe used to identify the heter

[PATCH 4/5] hw/acpi/aml-build: Update the revision of PPTT table

2024-09-26 Thread Yicong Yang via
From: Yicong Yang The lastest ACPI spec 6.5 support PPTT revision 3. Update it by handy. This is compatible with previous revision. Signed-off-by: Yicong Yang --- hw/acpi/aml-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c i