Hi Michael, On 2022/10/26 22:52, Michael S. Tsirkin wrote: > On Thu, Sep 22, 2022 at 09:11:39PM +0800, Yicong Yang wrote: >> From: Yicong Yang <yangyic...@hisilicon.com> >> >> This series mainly change the policy for building a cluster topology node >> in PPTT. Previously we'll always build a cluster node in PPTT without >> asking the user, after this set the cluster node will be built only the >> the user specify through "-smp clusters=X". >> >> Update the tests and test tables accordingly. > > > This will need an ack from virt maintainers.
Sure. > > And I think what people are asking is about the impact > of this patch on guests. On the current kernel (tested on 6.1-rc1), there's no impact for the kernel side, only the cluster node in PPTT is not generated. Booted with `-smp 8` without this patch: with this patch: estuary:/sys/devices/system/cpu/cpu0/topology$ cat cluster_* ff # cluster_cpus 0-7 # cluster_cpus_list 56 # cluster_id with this patch: estuary:/sys/devices/system/cpu/cpu0/topology$ cat cluster_* ff # cluster_cpus 0-7 # cluster_cpus_list 36 # cluster_id, with no cluster node kernel will make it to physical package id Will send a v2 version and update this information. Thanks. > >> Yicong Yang (4): >> hw/acpi/aml-build: Only generate cluster node in PPTT when specified >> tests: virt: update expected ACPI tables for virt test >> tests: acpi: aarch64: add topology test for aarch64 >> tests: acpi: aarch64: add *.topology tables >> >> hw/acpi/aml-build.c | 2 +- >> hw/core/machine-smp.c | 3 +++ >> include/hw/boards.h | 2 ++ >> tests/data/acpi/virt/APIC.pxb | Bin 0 -> 168 bytes >> tests/data/acpi/virt/APIC.topology | Bin 0 -> 700 bytes >> tests/data/acpi/virt/DBG2.memhp | Bin 0 -> 87 bytes >> tests/data/acpi/virt/DBG2.numamem | Bin 0 -> 87 bytes >> tests/data/acpi/virt/DBG2.pxb | Bin 0 -> 87 bytes >> tests/data/acpi/virt/DBG2.topology | Bin 0 -> 87 bytes >> tests/data/acpi/virt/DSDT.topology | Bin 0 -> 5398 bytes >> tests/data/acpi/virt/FACP.pxb | Bin 0 -> 268 bytes >> tests/data/acpi/virt/FACP.topology | Bin 0 -> 268 bytes >> tests/data/acpi/virt/GTDT.pxb | Bin 0 -> 96 bytes >> tests/data/acpi/virt/GTDT.topology | Bin 0 -> 96 bytes >> tests/data/acpi/virt/IORT.topology | Bin 0 -> 128 bytes >> tests/data/acpi/virt/MCFG.pxb | Bin 0 -> 60 bytes >> tests/data/acpi/virt/MCFG.topology | Bin 0 -> 60 bytes >> tests/data/acpi/virt/PPTT | Bin 96 -> 76 bytes >> tests/data/acpi/virt/PPTT.memhp | Bin 0 -> 76 bytes >> tests/data/acpi/virt/PPTT.numamem | Bin 0 -> 76 bytes >> tests/data/acpi/virt/PPTT.pxb | Bin 0 -> 76 bytes >> tests/data/acpi/virt/PPTT.topology | Bin 0 -> 336 bytes >> tests/data/acpi/virt/SPCR.pxb | Bin 0 -> 80 bytes >> tests/data/acpi/virt/SPCR.topology | Bin 0 -> 80 bytes >> tests/qtest/bios-tables-test.c | 22 ++++++++++++++++++++++ >> 25 files changed, 28 insertions(+), 1 deletion(-) >> create mode 100644 tests/data/acpi/virt/APIC.pxb >> create mode 100644 tests/data/acpi/virt/APIC.topology >> create mode 100644 tests/data/acpi/virt/DBG2.memhp >> create mode 100644 tests/data/acpi/virt/DBG2.numamem >> create mode 100644 tests/data/acpi/virt/DBG2.pxb >> create mode 100644 tests/data/acpi/virt/DBG2.topology >> create mode 100644 tests/data/acpi/virt/DSDT.topology >> create mode 100644 tests/data/acpi/virt/FACP.pxb >> create mode 100644 tests/data/acpi/virt/FACP.topology >> create mode 100644 tests/data/acpi/virt/GTDT.pxb >> create mode 100644 tests/data/acpi/virt/GTDT.topology >> create mode 100644 tests/data/acpi/virt/IORT.topology >> create mode 100644 tests/data/acpi/virt/MCFG.pxb >> create mode 100644 tests/data/acpi/virt/MCFG.topology >> create mode 100644 tests/data/acpi/virt/PPTT.memhp >> create mode 100644 tests/data/acpi/virt/PPTT.numamem >> create mode 100644 tests/data/acpi/virt/PPTT.pxb >> create mode 100644 tests/data/acpi/virt/PPTT.topology >> create mode 100644 tests/data/acpi/virt/SPCR.pxb >> create mode 100644 tests/data/acpi/virt/SPCR.topology >> >> -- >> 2.24.0 > > . >
