On 2022/10/29 15:53, Michael S. Tsirkin wrote:
> On Thu, Oct 27, 2022 at 11:26:11AM +0800, Yicong Yang wrote:
>> From: Yicong Yang <yangyic...@hisilicon.com>
>>
>> Update the ACPI tables according to the acpi aml_build change.
>>
>> Signed-off-by: Yicong Yang <yangyic...@hisilicon.com>
> 
> OK nice but if patch 1 is applied alone that will break make check
> won't it? And this means the patchset breaks git bisect.
> Pls look at top of tests/qtest/bios-tables-test.c to see
> how to organize a patchset changing expected tables.
> 

Will follow the guidance and correctly mentioned the changes in
tests/qtest/bios-tables-test-allowed-diff.h. So is the rest patches
in the series.

Thanks.

> 
>> ---
>>  tests/data/acpi/virt/PPTT | Bin 96 -> 76 bytes
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>
>> diff --git a/tests/data/acpi/virt/PPTT b/tests/data/acpi/virt/PPTT
>> index 
>> f56ea63b369a604877374ad696c396e796ab1c83..7a1258ecf123555b24462c98ccbb76b4ac1d0c2b
>>  100644
>> GIT binary patch
>> delta 32
>> fcmYfB;R*-{3GrcIU|?D?k;`ae01J-_kOKn%ZFdCM
>>
>> delta 53
>> pcmeZC;0g!`2}xjJU|{l?$YrDgWH5jU5Ca567#O&Klm(arApowi1QY-O
>>
>> -- 
>> 2.24.0
> 
> .
> 

Reply via email to