+kernel_command_line = 'printk.time=0 console=ttyS0'
> +self.vm.add_args('-kernel', kbuild.vmlinux,
> + '-append', kernel_command_line)
> +self.vm.launch()
> +wait_for_console_pattern(self, 'Kernel command line: %s' %
> + kernel_command_line)
> --
> 2.21.0
>
Tested-by: Willian Rampazzo
On Mon, Nov 25, 2019 at 3:10 PM Cleber Rosa wrote:
>
> On Mon, Nov 25, 2019 at 10:58:02AM -0300, Eduardo Habkost wrote:
> > Thank you, Philippe, those are great ideas. I have copied them
> > to the Avocado+QEMU Trello board so we don't forget about them:
> > https://trello.com/b/6Qi1pxVn/avocado-
1T083923Z/pool-m68k/main'
> '/l/linux/kernel-image-5.3.0-1-m68k-di_5.3.7-1_m68k.udeb')
> deb_hash = '044954bb9be4160a3ce81f8bc1b5e856b75cccd1'
> try:
Tested-by: Willian Rampazzo
The code was tested and works as expected.
---
Willian
elf.extract_from_deb(deb_path,
> '/boot/vmlinux-5.3.0-1-m68k')
>
Tested-by: Willian Rampazzo
Although I prefer to be on the safe side and keep the verification,
the code works as expected.
---
Willian
Public bug reported:
While running the acceptance tests on s390x, the arm tests under
qemu/tests/acceptance/boot_linux_console.py will timeout, except the
test using u-boot. All the arm tests run without problems on x86 and
ppc.
This test boots the kernel and wait for a kernel panic to make sure
e
> create mode 100755 scripts/ci/org.centos/stream/8/x86_64/test-avocado
> create mode 100644 scripts/ci/org.centos/stream/README
>
Maybe it is too late, but just for the records:
Reviewed-by: Willian Rampazzo
Tested-by: Willian Rampazzo
CI job on a custom VM runner:
https://gitlab.com/willianrampazzo/qemu/-/jobs/1778451942
erges to the stable branches.
>
> User forks meanwhile should be allowed to run Cirrus CI jobs freely.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> .gitlab-ci.d/cirrus.yml | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Willian Rampazzo
deletions(-)
>
Reviewed-by: Willian Rampazzo
ned-off-by: Alex Bennée
> ---
> tests/vm/Makefile.include | 17 +
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
Reviewed-by: Willian Rampazzo
ners/centos-stream-8-x86_64.yml
> create mode 100644 .gitlab-ci.d/custom-runners/ubuntu-18.04-s390x.yml
> create mode 100644 .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml
>
Reviewed-by: Willian Rampazzo
's increase the timeout on the gitlab side a little bit, so
> that these jobs are not marked as failing just because of the delay.
>
> Signed-off-by: Thomas Huth
> ---
> .gitlab-ci.d/cirrus.yml | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Willian Rampazzo
t; ---
> .gitlab-ci.yml | 24
> 1 file changed, 24 deletions(-)
>
Reviewed-by: Willian Rampazzo
ore unique directory to put sockfiles in by default.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine/machine.py | 17 +
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
Reviewed-by: Willian Rampazzo
igned-off-by: John Snow
> ---
> python/qemu/machine/machine.py | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
Reviewed-by: Willian Rampazzo
ult nickname to foolproof this in all cases.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine/machine.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
On Thu, Nov 18, 2021 at 5:51 PM John Snow wrote:
>
> No need to clear them only to set them later.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine/machine.py | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Reviewed-by: Willian Rampazzo
> +
> +from avocado import skip
You are not using this import in the file. No need to import it here.
Removing the unused import, the code looks good to me, so:
Reviewed-by: Willian Rampazzo
One more comment, sorry.
On Fri, Nov 19, 2021 at 10:54 AM Fabiano Rosas wrote:
>
> These tests ensure that our emulation for these cpus is not completely
> broken and we can at least run OpenBIOS on them.
>
> $ make check-avocado AVOCADO_TESTS=../tests/avocado/ppc_74xx.py
>
> Signed-off-by: Fabia
d and only go
> fishing for forbidden details when we absolutely have to.
>
> Reported-by: Thomas Huth
> Signed-off-by: John Snow
> ---
> python/qemu/aqmp/qmp_client.py | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
Reviewed-by: Willian Rampazzo
f-by: John Snow
Nitpick: double signed-off-by
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine/machine.py | 19 ---
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
Reviewed-by: Willian Rampazzo
Remove me as a reviewer for the Build and test automation and the
Integration Testing with the Avocado Framework and add Beraldo
Leal.
Signed-off-by: Willian Rampazzo
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
gt; +
> +# Press cursor control 'Down' to select the "Run a program" menu
> +exec_command(self, '\x1b[B')
> +
> +program = 'scsi(0)cdrom(2)fdisk(0)boot scsi(0)cdrom(2)fdisk(0)netbsd'
> +exec_command(self, program)
> +wait_for_console_pattern(self, 'NetBSD/arc Bootstrap, Revision 1.1')
> +
> +# Terminal type? [vt100]
> +console_pattern = 'erase ^H, werase ^W, kill ^U, intr ^C, status ^T'
> +wait_for_console_pattern(self, console_pattern)
> +
> +# (I)nstall, (S)hell or (H)alt
> +exec_command_and_wait_for_pattern(self, '', 'Erase is backspace.')
> +exec_command(self, 'S')
> +interrupt_interactive_console_until_pattern(self, '#')
> +
> +exec_command_and_wait_for_pattern(self, 'ifconfig', 'address: ' +
> mac)
> +interrupt_interactive_console_until_pattern(self, '#')
> +
> +exec_command(self, 'ifconfig sn0 10.0.2.3/24')
> +interrupt_interactive_console_until_pattern(self, '#')
> +
> +exec_command_and_wait_for_pattern(self, 'ping -c 3 10.0.2.2',
> +'3 packets transmitted, 3 packets received, 0.0% packet
> loss')
> +
> +exec_command_and_wait_for_pattern(self, 'shutdown -r now',
> + 'rebooting...')
Nice!
Except for the nvram.bin.xz,
Reviewed-by: Willian Rampazzo
On Tue, Nov 23, 2021 at 7:37 AM Philippe Mathieu-Daudé
wrote:
>
> On 11/22/21 20:11, Willian Rampazzo wrote:
> > Remove me as a reviewer for the Build and test automation and the
> > Integration Testing with the Avocado Framework and add Beraldo
> > Leal.
>
> T
implementation patch to the series.
Changes from V1:
- Rename TESTFILES to AVOCADO_TEST_FILES on patch 2
- Add Suggested-by tag on patch 2
Willian Rampazzo (3):
tests/Makefile: allow control over tags during check-acceptance
docs/devel/testing: add instruction to run a single acceptance test
Add instructions to the Acceptance tests section about running a
single test file or a test within the test file.
Signed-off-by: Willian Rampazzo
---
docs/devel/testing.rst | 28
1 file changed, 28 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel
Add the possibility of running all the tests from a single file, or
multiple files, running a single test within a file or multiple tests
within multiple files using `make check-acceptance` and the
AVOCADO_TESTS environment variable.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Willian
tests should run based on the tags defined.
This also makes the check-acceptance command flexible to restrict tests
based on tags while running on CI.
e.g.:
AVOCADO_TAGS="foo bar baz" make check-acceptance
Signed-off-by: Willian Rampazzo
Tested-by: Wainer dos Santos Moschetta
R
Hi, Cleber,
On Fri, Sep 24, 2021 at 3:57 PM Cleber Rosa wrote:
>
> The avocado.Test class, used as the basis of the avocado_qemu.Test
> class, performs a clean of temporary directories up as part of its own
> tearDown() implementation.
>
> But the avocado_qemu.Test class is currently missing the
On Mon, Sep 27, 2021 at 11:12 AM Philippe Mathieu-Daudé
wrote:
>
> On 9/20/21 22:49, Willian Rampazzo wrote:
> > The current implementation will crash if the connection fails as the
> > `time` module is not imported. This fixes the import problem and tweaks
> >
On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy
wrote:
>
> 9/30/21 11:47, Richard W.M. Jones wrote:
> > Under SELinux, Unix domain sockets have two labels. One is on the
> > disk and can be set with commands such as chcon(1). There is a
> > different label stored in memory (called t
qemu-project/qemu.git.
> +The project does not process merge requests filed on GitHub.
> +
> +QEMU welcomes contributions of code (either fixing bugs or
> adding new
> +functionality). However, we get a lot of patches, and so we have
> some
> +guidelines about contributing on the project website:
> +https://www.qemu.org/contribute/
> + lock-pull: true
> + close-pull: true
> --
> 2.30.2
>
>
Besides the "issues" comment, it looks good to me.
Reviewed-by: Willian Rampazzo
s/requirements.txt b/tests/requirements.txt
> index a21b59b443..40af24c664 100644
> --- a/tests/requirements.txt
> +++ b/tests/requirements.txt
> @@ -1,5 +1,5 @@
> # Add Python module requirements, one per line, to be installed
> # in the tests/venv Python virtual environment. For more info,
> # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
> -avocado-framework==88.1
> +avocado-framework==91.0
> pycdlib==1.11.0
> --
> 2.31.1
>
Apart from a tiny documentation change, the code is welcome as it
allows using the new Avocado runner.
Reviewed-by: Willian Rampazzo
On Fri, Sep 24, 2021 at 3:57 PM Cleber Rosa wrote:
>
> It is helpful to know the tests that would be executed with a "make
> check-acceptance" without executing them. Let's introduce a "make
> list-acceptance" rule for that purpose.
>
> Signed-off-by: Cleber Rosa
> ---
> tests/Makefile.include
; Signed-off-by: Cleber Rosa
> ---
> tests/acceptance/boot_xen.py | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
Reviewed-by: Willian Rampazzo
changed, 5 insertions(+), 21 deletions(-)
>
Reviewed-by: Willian Rampazzo
the opportunity to add some future improvements in a clearer
> fashion.
>
> Signed-off-by: Cleber Rosa
> ---
> tests/acceptance/boot_xen.py | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
Reviewed-by: Willian Rampazzo
On Fri, Sep 24, 2021 at 3:59 PM Cleber Rosa wrote:
>
> Rather than defining a single use variable, let's just use the class
> attribute directly.
>
> Signed-off-by: Cleber Rosa
> ---
> tests/acceptance/boot_xen.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletio
8 deletions(-)
>
Reviewed-by: Willian Rampazzo
On Wed, Oct 6, 2021 at 4:17 PM Willian Rampazzo wrote:
>
> On Fri, Sep 24, 2021 at 4:01 PM Cleber Rosa wrote:
> >
> > The arch and machine tags apply to all tests, so let's define them
> > only once.
> >
> > Signed-off-by: Cleber Rosa
> >
B TIME : 0.54 s
>
> Reviewed-by: Willian Rampazzo
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/acceptance/load_bflt.py | 54 +++
> 1 file changed, 54 insertions(+)
> create mode 100644 tests/acceptance/load_bflt.py
>
> d
; -def fetch_asset(self, name,
> -asset_hash=None, algorithm=None,
> -locations=None, expire=None,
> -find_only=False, cancel_on_missing=True):
> -return super(Test, self).fetch_asset(name,
> -asset_hash=asset_hash,
> -algorithm=algorithm,
> -locations=locations,
> -expire=expire,
> -find_only=find_only,
> -cancel_on_missing=cancel_on_missing)
> -
>
> class LinuxSSHMixIn:
> """Contains utility methods for interacting with a guest via SSH."""
> --
> 2.31.1
>
Except for one (or two, if you consider the first) small comment,
looks good to me, so
Reviewed-by: Willian Rampazzo
ldpath in self._ldpath])
> +bin_args = " ".join(args)
> +return process.run("%s %s %s %s" % (self.qemu_bin, qemu_args,
> + bin_path, bin_args))
> +
> +
> class LinuxSSHMixIn:
> """Contains utility methods for interacting with a guest via SSH."""
Besides some Python related suggestions, the code looks good.
Reviewed-by: Willian Rampazzo
>
> --
> 2.31.1
>
tches, you don't
need this change here.
>
> self.machine = self.params.get('machine',
>
> default=self._get_unique_tag_val('machine'))
> @@ -515,11 +512,11 @@ def default_kernel_params(self):
> return self._info.get('kernel_params', None)
>
>
> -class LinuxTest(Test, LinuxSSHMixIn):
> +class LinuxTest(QemuSystemTest, LinuxSSHMixIn):
> """Facilitates having a cloud-image Linux based available.
>
> For tests that indend to interact with guests, this is a better choice
If you touch this patch again, please, s/indend/intend/
So far, looks good to me
Reviewed-by: Willian Rampazzo
/acceptance/avocado_qemu/__init__.py | 57 ++
> tests/acceptance/virtiofs_submounts.py| 59 +--
> 2 files changed, 59 insertions(+), 57 deletions(-)
>
Reviewed-by: Willian Rampazzo
@ class Test(QemuBaseTest):
> def setUp(self):
> self._vms = {}
>
> -super(Test, self).setUp()
> +super(Test, self).setUp('qemu-system-')
If you need to change something else in this patch, consider using PEP3135:
super().setUp('qemu-system-')
Anyway,
Reviewed-by: Willian Rampazzo
>
> self.machine = self.params.get('machine',
>
> default=self._get_unique_tag_val('machine'))
> --
> 2.31.1
>
le changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
a-cris-cross.docker | 2 +-
> tests/docker/dockerfiles/fedora-win32-cross.docker | 2 +-
> tests/docker/dockerfiles/fedora-win64-cross.docker | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Willian Rampazzo
deletion(-)
>
Reviewed-by: Willian Rampazzo
-
> .gitlab-ci.yml | 24
> 1 file changed, 24 deletions(-)
>
Reviewed-by: Willian Rampazzo
files and the documentation.
[1] https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg06553.html
GitLab pipeline with new naming:
https://gitlab.com/willianrampazzo/qemu/-/pipelines/401431592
Signed-off-by: Willian Rampazzo
Willian Rampazzo (1):
tests/acceptance: rename tests acceptance to
files and the documentation.
[1] https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg06553.html
Signed-off-by: Willian Rampazzo
---
.gitlab-ci.d/buildtest-template.yml | 2 +-
.gitlab-ci.d/buildtest.yml| 56 +--
MAINTAINERS
On Thu, Nov 4, 2021 at 9:50 AM Philippe Mathieu-Daudé wrote:
>
> On 11/3/21 22:14, Willian Rampazzo wrote:
> > In the discussion about renaming the `tests/acceptance` [1], the
> > conclusion was that the folders inside `tests` are related to the
> > framework running th
release and leave the warning to force
people to move to the new `check-avocado` target.
Later, the `check-acceptance` target can be removed. The intent
is to avoid a direct impact during the current soft freeze.
Suggested-by: Philippe Mathieu-Daudé
Signed-off-by: Willian Rampazzo
---
docs
files and the documentation.
[1] https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg06553.html
For the Orange Pi PC documentation:
Reviewed-by: Niek Linnenbank
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Willian Rampazzo
---
.gitlab-ci.d/buildtest
too.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> docs/about/deprecated.rst | 3 ---
> 1 file changed, 3 deletions(-)
>
Reviewed-by: Willian Rampazzo
deprecate warning message when it is used.
(Suggested-by: Philippe Mathieu-Daudé)
- Remove unrelated changes.
Signed-off-by: Willian Rampazzo
Willian Rampazzo (2):
tests/acceptance: introduce new check-avocado tartget
tests/acceptance: rename tests acceptance to tests avocado
.gitlab-ci.d
On Mon, Nov 8, 2021 at 6:49 AM Philippe Mathieu-Daudé wrote:
>
> On 11/8/21 10:24, Daniel P. Berrangé wrote:
> > On Mon, Nov 08, 2021 at 08:59:51AM +0100, Thomas Huth wrote:
> >> On 05/11/2021 16.53, Willian Rampazzo wrote:
> >>> This introduces a new `make` ta
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Based-on: <20211105155354.154864-1-willi...@redhat.com>
> ---
> tests/avocado/boot_linux_console.py | 7 ---
> 1 file changed, 7 deletions(-)
>
Reviewed-by: Willian Rampazzo
Id: <20211014224435.2539547-5-richard.hender...@linaro.org>
> ---
> .gitlab-ci.d/buildtest.yml | 4
> .gitlab-ci.d/container-cross.yml | 27 +++
> 2 files changed, 3 insertions(+), 28 deletions(-)
>
Reviewed-by: Willian Rampazzo
ed, 95 insertions(+)
> create mode 100755
> tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh
>
Reviewed-by: Willian Rampazzo
sh | 87 +++
> .../dockerfiles/debian-toolchain.docker | 36
> 4 files changed, 149 insertions(+)
> create mode 100755
> tests/docker/dockerfiles/debian-nios2-cross.d/build-toolchain.sh
> create mode 100644 tests/docker/dockerfiles/debian-toolchain.docker
>
Reviewed-by: Willian Rampazzo
ile.include | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Reviewed-by: Willian Rampazzo
er-template.yml | 11 ++-
> .gitlab-ci.d/edk2.yml | 11 ++-
> .gitlab-ci.d/opensbi.yml| 11 ++-
> 3 files changed, 30 insertions(+), 3 deletions(-)
>
Reviewed-by: Willian Rampazzo
ed-by: Wainer dos Santos Moschetta
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.yml | 30 +++---
> 1 file changed, 11 insertions(+), 19 deletions(-)
>
Reviewed-by: Willian Rampazzo
-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.d/container-template.yml | 22 ++
> .gitlab-ci.d/containers.yml | 24 ++--
> 2 files changed, 24 insertions(+), 22 deletions(-)
> create mode 100644 .gitlab-ci.d/container-template.yml
>
Reviewed-by: Willian Rampazzo
-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.d/crossbuild-template.yml | 41 ++
> .gitlab-ci.d/crossbuilds.yml | 43 ++--
> 2 files changed, 43 insertions(+), 41 deletions(-)
> create mode 100644 .gitlab-ci.d/crossbuild-
files changed, 25 insertions(+), 25 deletions(-)
> create mode 100644 .gitlab-ci.d/static_checks.yml
>
Reviewed-by: Willian Rampazzo
hich are mainly useful for mainstream CI.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.d/stages.yml | 8
> .gitlab-ci.yml | 10 +-
> 2 files changed, 9 insertions(+), 9 deletions(-)
> create mode 100644 .gitlab-ci.d/stages.yml
>
Reviewed-by: Willian Rampazzo
est-template.yml | 69
> .gitlab-ci.yml | 71 +
> 2 files changed, 70 insertions(+), 70 deletions(-)
> create mode 100644 .gitlab-ci.d/buildtest-template.yml
>
Reviewed-by: Willian Rampazzo
d/buildtest.yml | 726 +
> .gitlab-ci.yml | 726 +
> 2 files changed, 727 insertions(+), 725 deletions(-)
> create mode 100644 .gitlab-ci.d/buildtest.yml
>
Reviewed-by: Willian Rampazzo
eate mode 100644 .gitlab-ci.d/container-core.yml
>
Reviewed-by: Willian Rampazzo
ab-ci.d/qemu-project.yml
>
Reviewed-by: Willian Rampazzo
tlab-ci.d/containers.yml | 5 ---
> tests/docker/dockerfiles/centos7.docker | 43 -
> 2 files changed, 48 deletions(-)
> delete mode 100644 tests/docker/dockerfiles/centos7.docker
>
Reviewed-by: Willian Rampazzo
ngé
> ---
> .gitlab-ci.yml | 10 --
> configure | 4 +---
> crypto/cipher-nettle.c.inc | 31 ---
> crypto/hash-nettle.c | 4
> crypto/hmac-nettle.c | 4 ----
> 5 files changed, 1 insertion(+), 52 deletions(-)
>
Reviewed-by: Willian Rampazzo
gt; ---
> .gitlab-ci.yml | 10 --
> configure | 18 +-
> crypto/meson.build | 6 +-----
> 3 files changed, 2 insertions(+), 32 deletions(-)
>
Reviewed-by: Willian Rampazzo
t; configure | 2 +-
> 2 files changed, 1 insertion(+), 16 deletions(-)
>
Reviewed-by: Willian Rampazzo
> ---
> configure | 2 +-
> include/glib-compat.h | 9 --
> util/oslib-win32.c| 204 ------
> 3 files changed, 1 insertion(+), 214 deletions(-)
>
Reviewed-by: Willian Rampazzo
On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé wrote:
>
> The condition being tested has never been set since the day the code was
> first introduced.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> crypto/tlscredsx509.c | 2 --
> 1 file changed, 2 deletions(-)
;
> With this list Debian Stretch is the constraint at 6.3.0
>
> Signed-off-by: Daniel P. Berrangé
> ---
> configure | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Willian Rampazzo
1
>
> An LLVM version of 7.0.1 corresponds to macOS XCode version of 10.2
> which dates from March 2019.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> configure | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Willian Rampazzo
Hi Thomas,
On Wed, May 12, 2021 at 8:54 AM Thomas Huth wrote:
>
> On 12/05/2021 13.44, Philippe Mathieu-Daudé wrote:
> > On 5/11/21 3:26 PM, Daniel P. Berrangé wrote:
> >> Several distros have been dropped since the last time we bumped the
> >> minimum required CLang version.
> >>
> >> Per repolo
On Wed, May 12, 2021 at 10:56 AM Thomas Huth wrote:
>
> On 12/05/2021 15.47, Willian Rampazzo wrote:
> > Hi Thomas,
> >
> > On Wed, May 12, 2021 at 8:54 AM Thomas Huth wrote:
> >>
> >> On 12/05/2021 13.44, Philippe Mathieu-Daudé wrote:
> >
; -port = network.find_free_port()
> +def _get_free_port(self, address='localhost'):
> +port = network.find_free_port(address=address)
> if port is None:
> self.cancel('Failed to find a free port')
> return port
> --
> 2.21.1
>
Just confirming,
Reviewed-by: Willian Rampazzo
On Tue, Mar 31, 2020 at 5:07 PM Philippe Mathieu-Daudé
wrote:
>
> First job failed by timeout, 2nd succeeded:
> https://travis-ci.org/github/philmd/qemu/jobs/669265466
>
> However "Ran for 46 min 48 sec"
>
> From the log:
>
> Fetching asset from
> tests/acceptance/boot_linux_console.py:BootLinux
On Wed, Apr 1, 2020 at 5:21 PM Philippe Mathieu-Daudé wrote:
> Odd, with avocado-framework==76.0 I get:
>
> https://travis-ci.org/github/philmd/qemu/jobs/669851870#L4908
>
> Traceback (most recent call last):
>File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
> "__mai
On Thu, Apr 2, 2020 at 8:08 AM Philippe Mathieu-Daudé wrote:
>
> This issue persists, OTOH the good news is caching is working:
>
> https://travis-ci.org/github/philmd/qemu/builds/670078763#L1626
>
Philippe, do you have a way to clean up the Travis cache and try it
again? Last week, when I was in
> That certainly sounds like an improvement. I still don't love the
> idea that the test results will vary based on something outside of the
> tested code, even if a cancel is definitely better than a fail.
During the development of Avocado release 76.0, we have discussed how
to implement a new r
On Fri, Jul 24, 2020 at 3:26 PM Wainer dos Santos Moschetta
wrote:
>
> Hi Philippe,
>
> On 7/24/20 4:35 AM, Philippe Mathieu-Daudé wrote:
> > The boot_linux.py file triggers an exception:
> >
> >$ make fetch-acceptance
> >AVOCADO tests/acceptance
> >Fetching assets from tests/acceptanc
uot;tests: Move unit tests into a separate directory")
> Signed-off-by: Wainer dos Santos Moschetta
> Reviewed-by: Thomas Huth
> ---
> v1->v2:
> * Fixed typo on subject [jsnow]
> * Replaced Related-to with Fixes [jsnow]
>
> docs/devel/testing.rst | 6 +++---
> 1 f
12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Reviewed-by: Willian Rampazzo
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 9ffbaa7ffb..7714c7cac8 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -23,9 +23,9 @@ include:
> - cd buil
> ---
> .gitlab-ci.yml | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Willian Rampazzo
ml | 30 +++---
> 1 file changed, 3 insertions(+), 27 deletions(-)
>
Reviewed-by: Willian Rampazzo
Hi Philippe,
On Mon, Mar 22, 2021 at 1:59 PM Philippe Mathieu-Daudé wrote:
>
> On Mon, Mar 22, 2021 at 5:54 PM Philippe Mathieu-Daudé
> wrote:
> >
> > Hi Willian,
> >
> > On 3/8/21 9:44 PM, Willian Rampazzo wrote:
> > > On Mon, Mar 8, 2021
Hi Philippe,
On Mon, Mar 22, 2021 at 1:54 PM Philippe Mathieu-Daudé wrote:
>
> Hi Willian,
>
> On 3/8/21 9:44 PM, Willian Rampazzo wrote:
> > On Mon, Mar 8, 2021 at 5:41 PM Willian Rampazzo wrote:
> >>
> >> On Mon, Mar 8, 2021 at 5:32 PM Niek Linnenbank
On Mon, Mar 22, 2021 at 2:24 PM Philippe Mathieu-Daudé wrote:
>
> On 3/22/21 6:12 PM, Willian Rampazzo wrote:
> > Hi Philippe,
> >
> > On Mon, Mar 22, 2021 at 1:59 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> On Mon, Mar 22, 2021 at 5:54 PM Phi
On Mon, Mar 22, 2021 at 3:47 PM Philippe Mathieu-Daudé wrote:
>
> On 3/22/21 6:18 PM, Willian Rampazzo wrote:
> > Hi Philippe,
> >
> > On Mon, Mar 22, 2021 at 1:54 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> Hi Willian,
> >>
> >&
Hi Peter,
On Tue, Mar 23, 2021 at 12:28 PM Peter Maydell wrote:
>
> I just got this running 'make check-acceptance': does it
> ring a bell with anybody?
>
> [etc]
> Fetching asset from
> tests/acceptance/replay_kernel.py:ReplayKernelSlow.test_mips64el_malta_5KEc_cpio
> Fetching asset from
> tests
e set.
>
> This keeps the same logic, but improves readability a bit.
>
> Signed-off-by: Cleber Rosa
> Reviewed-by: Beraldo Leal
> ---
> tests/acceptance/virtiofs_submounts.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
, '..',
> 'python'))
> from qemu.accel import kvm_available
> from qemu.machine import QEMUMachine
> +from qemu.utils import get_info_usernet_hostfwd_port
> import subprocess
> import hashlib
> import argparse
> @@ -306,11 +307,7 @@ def boot(self, img, extra_args=[]):
> self.console_init()
> usernet_info = guest.qmp("human-monitor-command",
> command_line="info usernet")
> -self.ssh_port = None
> -for l in usernet_info["return"].splitlines():
> -fields = l.split()
> -if "TCP[HOST_FORWARD]" in fields and "22" in fields:
> -self.ssh_port = l.split()[3]
> +self.ssh_port = get_info_usernet_hostfwd_port(usernet_info)
> if not self.ssh_port:
> raise Exception("Cannot find ssh port from 'info usernet':\n%s"
> % \
> usernet_info)
> --
> 2.25.4
>
Other than maybe a small adjustment to the
get_info_usernet_hostfwd_port function:
Reviewed-by: Willian Rampazzo
/avocado_qemu/__init__.py | 4 +++-
> tests/acceptance/virtiofs_submounts.py| 4
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
Reviewed-by: Willian Rampazzo
1 - 100 of 476 matches
Mail list logo
