On Fri, Nov 19, 2021 at 10:54 AM Fabiano Rosas <faro...@linux.ibm.com> wrote: > > These tests ensure that our emulation for these cpus is not completely > broken and we can at least run OpenBIOS on them. > > $ make check-avocado AVOCADO_TESTS=../tests/avocado/ppc_74xx.py > > Signed-off-by: Fabiano Rosas <faro...@linux.ibm.com> > > --- > Note that the 7450s are currently broken, depending on the fix for > https://gitlab.com/qemu-project/qemu/-/issues/86 that is being > discussed in the thread: > > https://lists.nongnu.org/archive/html/qemu-ppc/2021-11/msg00289.html > --- > tests/avocado/ppc_74xx.py | 134 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 134 insertions(+) > create mode 100644 tests/avocado/ppc_74xx.py > > diff --git a/tests/avocado/ppc_74xx.py b/tests/avocado/ppc_74xx.py > new file mode 100644 > index 0000000000..72b99d39c0 > --- /dev/null > +++ b/tests/avocado/ppc_74xx.py > @@ -0,0 +1,134 @@ > +# Smoke tests for 74xx cpus (aka G4). > +# > +# Copyright (c) 2021, IBM Corp. > +# > +# This work is licensed under the terms of the GNU GPL, version 2 or > +# later. See the COPYING file in the top-level directory. > + > +from avocado import skip
You are not using this import in the file. No need to import it here. Removing the unused import, the code looks good to me, so: Reviewed-by: Willian Rampazzo <willi...@redhat.com>
