[PATCH] MAINTAINERS: Update Sriram Yagnaraman mail address

2024-02-28 Thread Sriram Yagnaraman
Due to company policies, I have changed my mail address. Updating MAINTAINERS and .mailmap to show my latest mail address. Signed-off-by: Sriram Yagnaraman --- .mailmap| 1 + MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index

RE: [PATCH] MAINTAINERS: Update Sriram Yagnaraman mail address

2024-02-28 Thread Sriram Yagnaraman
Hi Philippe, > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Wednesday, 28 February 2024 16:25 > To: Sriram Yagnaraman ; qemu- > de...@nongnu.org > Subject: Re: [PATCH] MAINTAINERS: Update Sriram Yagnaraman mail address > > Hi Sriram, > > On 28

RE: [PATCH v8 02/15] pcie_sriov: Validate NumVFs

2024-02-28 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Wednesday, 28 February 2024 12:33 > To: Philippe Mathieu-Daudé ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Williamson ; Cédric Le Goater > ; Paolo Bonzini ; Daniel P. > Berrangé ; Eduardo Habkost > ;

RE: [PATCH v8 05/15] hw/pci: Always call pcie_sriov_pf_reset()

2024-02-28 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Wednesday, 28 February 2024 12:33 > To: Philippe Mathieu-Daudé ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Williamson ; Cédric Le Goater > ; Paolo Bonzini ; Daniel P. > Berrangé ; Eduardo Habkost > ;

RE: [PATCH v8 03/15] pcie_sriov: Reset SR-IOV extended capability

2024-02-28 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Wednesday, 28 February 2024 12:33 > To: Philippe Mathieu-Daudé ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Williamson ; Cédric Le Goater > ; Paolo Bonzini ; Daniel P. > Berrangé ; Eduardo Habkost > ;

RE: [PATCH v2 00/13] Introduce igb

2023-01-17 Thread Sriram Yagnaraman
tation. > > > > Note that there is another effort to bring 82576 emulation. This > > series was developed independently by Sriram Yagnaraman. > > https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg04670.html > > > > It is possible to merge the work from Sriram Yagna

[PATCH v10 0/8] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-03-24 Thread Sriram Yagnaraman
d the patches to make changes easier to understand Changes since v1: - Fix review comments from Akihiko Sriram Yagnaraman (8): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly igb: add ICR_RXDW igb: implement VFRE and VFTE registers igb: check overs

[PATCH v10 4/8] igb: implement VFRE and VFTE registers

2023-03-24 Thread Sriram Yagnaraman
Also introduce: - Checks for RXDCTL/TXDCTL queue enable bits - IGB_NUM_VM_POOLS enum (Sec 1.5: Table 1-7) Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 38 +++--- hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 35 insertions

[PATCH v10 8/8] igb: respect VMVIR and VMOLR for VLAN

2023-03-24 Thread Sriram Yagnaraman
. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 62 +-- 1 file changed, 49 insertions(+), 13 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 162ba8becf..d733fed6cf 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v10 7/8] igb: implement VF Tx and Rx stats

2023-03-24 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

[PATCH v10 2/8] igb: handle PF/VF reset properly

2023-03-24 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 38 ++ hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 31 insertions(+), 12 deletions

[PATCH v10 6/8] igb: respect E1000_VMOLR_RSSE

2023-03-24 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 38aa4596b1..fd61c6c550 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v10 3/8] igb: add ICR_RXDW

2023-03-24 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/net

[PATCH v10 5/8] igb: check oversized packets for VMDq

2023-03-24 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 753f17b40c..38aa4596b1 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v10 1/8] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-03-24 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b56ccdd92..a9ed6143f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2252,6 +2252,7 @@ F: tests

RE: [PATCH v2 00/13] Introduce igb

2023-01-24 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Tuesday, 24 January 2023 05:54 > To: Jason Wang ; Sriram Yagnaraman > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos S

RE: [PATCH v2 00/13] Introduce igb

2023-01-26 Thread Sriram Yagnaraman
> -Original Message- > From: Sriram Yagnaraman > Sent: Tuesday, 24 January 2023 09:54 > To: Akihiko Odaki ; Jason Wang > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos Santos

[PATCH 8/9] igb: respect VT_CTL ignore MAC field

2023-01-28 Thread Sriram Yagnaraman
Also trace out a warning if replication mode is disabled, since we only support replication mode enabled. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 + hw/net/trace-events | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c

[PATCH 2/9] igb: handle PF/VF reset properly

2023-01-28 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 1 + hw/net/igb_core.c| 33 + hw/net/trace-events | 2 ++ 3 files changed, 24 insertions(+), 12 deletions(-) diff

[PATCH 9/9] igb: respect VMVIR and VMOLR for VLAN

2023-01-28 Thread Sriram Yagnaraman
Add support for stripping/inserting VLAN for VFs. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 100 ++ 1 file changed, 65 insertions(+), 35 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 8e33e15505..96a5c5eca3

[PATCH 5/9] igb: respect E1000_VMOLR_RSSE

2023-01-28 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 1eb7ba168f..e4fd4a1a5f 100644 --- a/hw/net/igb_core.c

[PATCH 6/9] igb: add ICR_RXDW

2023-01-28 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/net

[PATCH 7/9] igb: implement VF Tx and Rx stats

2023-01-28 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/hw/net

[PATCH 4/9] igb: check oversized packets for VMDq

2023-01-28 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 74 ++- 1 file changed, 54 insertions(+), 20 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 6bca5459b9..1eb7ba168f 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH 1/9] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-01-28 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests

[PATCH 3/9] igb: implement VFRE and VFTE registers

2023-01-28 Thread Sriram Yagnaraman
Also add checks for RXDCTL/TXDCTL queue enable bits Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 42 +++--- hw/net/igb_regs.h | 3 ++- 2 files changed, 33 insertions(+), 12 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index

[PATCH 0/9] igb: add missing feature set from

2023-01-28 Thread Sriram Yagnaraman
Based-on: <20230126111943.38695-1-akihiko.od...@daynix.com> ([PATCH v4 00/13] Introduce igb) Rebased on latest changes from Akihiko, and merged changes from my original patchset: https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg04670.html Sriram Yagnaraman (9): MAINTAINERS: Add

RE: [PATCH v2 00/13] Introduce igb

2023-01-28 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 26 January 2023 12:32 > To: Sriram Yagnaraman ; Jason Wang > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos S

RE: [PATCH 3/9] igb: implement VFRE and VFTE registers

2023-01-30 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 29 January 2023 10:16 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; Michael S . Tsirkin > ; Marcel Apfelbaum > Subject: Re: [PATCH 3/9] igb: implement VFRE an

RE: [PATCH 5/9] igb: respect E1000_VMOLR_RSSE

2023-01-30 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 29 January 2023 08:25 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; Michael S . Tsirkin > ; Marcel Apfelbaum > Subject: Re: [PATCH 5/9] igb: respect E1000_VMOLR_RS

[PATCH v2 0/9] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-01-30 Thread Sriram Yagnaraman
s from Akihiko Sriram Yagnaraman (9): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly igb: implement VFRE and VFTE registers igb: add ICR_RXDW igb: check oversized packets for VMDq igb: respect E1000_VMOLR_RSSE igb: implement VF Tx and Rx stats

[PATCH v2 6/9] igb: respect E1000_VMOLR_RSSE

2023-01-30 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 89650fcfd4..b41b1a5d21 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v2 2/9] igb: handle PF/VF reset properly

2023-01-30 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 1 + hw/net/igb_core.c| 33 + hw/net/trace-events | 2 ++ 3 files changed, 24 insertions(+), 12 deletions(-) diff

[PATCH v2 5/9] igb: check oversized packets for VMDq

2023-01-30 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 48 +++ 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index cea7c036f0..89650fcfd4 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v2 9/9] igb: respect VMVIR and VMOLR for VLAN

2023-01-30 Thread Sriram Yagnaraman
Add support for stripping/inserting VLAN for VFs. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 84 ++- 1 file changed, 54 insertions(+), 30 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 5ca666229e..a511c64773

[PATCH v2 3/9] igb: implement VFRE and VFTE registers

2023-01-30 Thread Sriram Yagnaraman
Also add checks for RXDCTL/TXDCTL queue enable bits Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 ++--- hw/net/igb_regs.h | 4 +++- 2 files changed, 33 insertions(+), 12 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index

[PATCH v2 7/9] igb: implement VF Tx and Rx stats

2023-01-30 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

[PATCH v2 1/9] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-01-30 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests

[PATCH v2 4/9] igb: add ICR_RXDW

2023-01-30 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 28 ++-- 2 files changed, 18 insertions(+), 14 deletions

[PATCH v2 8/9] igb: respect VT_CTL ignore MAC field

2023-01-30 Thread Sriram Yagnaraman
Also trace out a warning if replication mode is disabled, since we only support replication mode enabled. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 + hw/net/trace-events | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c

[PATCH v3 5/9] igb: check oversized packets for VMDq

2023-01-31 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 48 +++ 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 4a1b98bf0e..2f6f30341f 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v3 4/9] igb: implement VFRE and VFTE registers

2023-01-31 Thread Sriram Yagnaraman
Also add checks for RXDCTL/TXDCTL queue enable bits Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 30 +- hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net

[PATCH v3 0/9] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-01-31 Thread Sriram Yagnaraman
Akhiko - Reordered the patches to make changes easier to understand Changes since v1: - Fix review comments from Akihiko Sriram Yagnaraman (9): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly igb: add ICR_RXDW igb: implement VFRE and VFTE registers

[PATCH v3 8/9] igb: respect VT_CTL ignore MAC field

2023-01-31 Thread Sriram Yagnaraman
Also trace out a warning if replication mode is disabled, since we only support replication mode enabled. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 + hw/net/trace-events | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c

[PATCH v3 6/9] igb: respect E1000_VMOLR_RSSE

2023-01-31 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 2f6f30341f..31a325d374 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v3 1/9] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-01-31 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests

[PATCH v3 7/9] igb: implement VF Tx and Rx stats

2023-01-31 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

[PATCH v3 3/9] igb: add ICR_RXDW

2023-01-31 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 46 +--- 2 files changed, 22 insertions

[PATCH v3 2/9] igb: handle PF/VF reset properly

2023-01-31 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 33 + hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 26 insertions(+), 12 deletions(-) diff

[PATCH v3 9/9] igb: respect VMVIR and VMOLR for VLAN

2023-01-31 Thread Sriram Yagnaraman
Add support for stripping/inserting VLAN for VFs. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 51 ++- 1 file changed, 42 insertions(+), 9 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 8115be2d76..a697fcf56a 100644

RE: [PATCH v2 00/13] Introduce igb

2023-01-31 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Monday, 30 January 2023 15:39 > To: Sriram Yagnaraman ; Jason Wang > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos S

RE: [PATCH v3 3/9] igb: add ICR_RXDW

2023-02-01 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Wednesday, 1 February 2023 05:36 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; Michael S . Tsirkin > ; Marcel Apfelbaum > Subject: Re: [PATCH v3 3/9] igb: add ICR_RXDW

RE: [PATCH v3 8/9] igb: respect VT_CTL ignore MAC field

2023-02-01 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Wednesday, 1 February 2023 05:58 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; Michael S . Tsirkin > ; Marcel Apfelbaum > Subject: Re: [PATCH v3 8/9] igb: respect VT_CTL

[PATCH v4 9/9] igb: respect VMVIR and VMOLR for VLAN

2023-02-01 Thread Sriram Yagnaraman
. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 54 ++- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index d1448dfcd3..d46aee47ac 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v4 4/9] igb: implement VFRE and VFTE registers

2023-02-01 Thread Sriram Yagnaraman
Also introduce: - Checks for RXDCTL/TXDCTL queue enable bits - IGB_NUM_VM_POOLS enum (Sec 1.5: Table 1-7) Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 36 hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 32 insertions(+), 8

[PATCH v4 5/9] igb: check oversized packets for VMDq

2023-02-01 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index c44b30b6d1..cda81a54bf 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v4 8/9] igb: respect VT_CTL ignore MAC field

2023-02-01 Thread Sriram Yagnaraman
Also trace out a warning if replication mode is disabled, since we only support replication mode enabled. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 + hw/net/trace-events | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c

[PATCH v4 1/9] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-02-01 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests

[PATCH v4 0/9] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-02-01 Thread Sriram Yagnaraman
sed on latest patchset from Akihiko - Remove Rx loop improvements that Akihiko has pulled into his patchset Changes since v2: - Fixed more comments from Akhiko - Reordered the patches to make changes easier to understand Changes since v1: - Fix review comments from Akihiko Sriram Yagnara

[PATCH v4 7/9] igb: implement VF Tx and Rx stats

2023-02-01 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

[PATCH v4 6/9] igb: respect E1000_VMOLR_RSSE

2023-02-01 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index cda81a54bf..c0b20287f2 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v4 3/9] igb: add ICR_RXDW

2023-02-01 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/net

[PATCH v4 2/9] igb: handle PF/VF reset properly

2023-02-01 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 33 + hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 26 insertions(+), 12 deletions(-) diff

RE: [PATCH v3 8/9] igb: respect VT_CTL ignore MAC field

2023-02-01 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Wednesday, 1 February 2023 14:03 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; Michael S . Tsirkin > ; Marcel Apfelbaum > Subject: Re: [PATCH v3 8/9] igb: respect VT_CTL

[PATCH v5 5/8] igb: check oversized packets for VMDq

2023-02-01 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 8437cd6829..eab140070b 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v5 8/8] igb: respect VMVIR and VMOLR for VLAN

2023-02-01 Thread Sriram Yagnaraman
. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 54 ++- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 42e3517695..d85f39a25f 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v5 7/8] igb: implement VF Tx and Rx stats

2023-02-01 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

RE: [PATCH v6 2/7] igb: rename E1000E_RingInfo_st

2023-05-15 Thread Sriram Yagnaraman
> -Original Message- > From: Tomasz Dzieciol > Sent: Friday, 12 May 2023 17:44 > To: qemu-devel@nongnu.org; akihiko.od...@daynix.com > Cc: Sriram Yagnaraman ; > jasow...@redhat.com; k.kwiec...@samsung.com; > m.socha...@samsung.com > Subject: [PATCH v6 2/7] igb: r

RE: [PATCH v6 1/7] igb: remove TCP ACK detection

2023-05-15 Thread Sriram Yagnaraman
> -Original Message- > From: Tomasz Dzieciol > Sent: Friday, 12 May 2023 17:43 > To: qemu-devel@nongnu.org; akihiko.od...@daynix.com > Cc: Sriram Yagnaraman ; > jasow...@redhat.com; k.kwiec...@samsung.com; > m.socha...@samsung.com > Subject: [PATCH v6 1/7] igb:

RE: [PATCH v6 5/7] igb: add IPv6 extended headers traffic detection

2023-05-15 Thread Sriram Yagnaraman
> -Original Message- > From: Tomasz Dzieciol > Sent: Friday, 12 May 2023 17:44 > To: qemu-devel@nongnu.org; akihiko.od...@daynix.com > Cc: Sriram Yagnaraman ; > jasow...@redhat.com; k.kwiec...@samsung.com; > m.socha...@samsung.com > Subject: [PATCH v6 5/7] igb: a

RE: [PATCH v6 4/7] igb: RX payload guest writting refactoring

2023-05-15 Thread Sriram Yagnaraman
> -Original Message- > From: Tomasz Dzieciol > Sent: Friday, 12 May 2023 17:44 > To: qemu-devel@nongnu.org; akihiko.od...@daynix.com > Cc: Sriram Yagnaraman ; > jasow...@redhat.com; k.kwiec...@samsung.com; > m.socha...@samsung.com > Subject: [PATCH v6 4/7] igb: R

RE: [PATCH 22/40] igb: Add more definitions for Tx descriptor

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ;

RE: [PATCH 23/40] igb: Share common VF constants

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Friday, 14 April 2023 17:09 > To: Akihiko Odaki > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH 19/40] igb: Read DCMD.VLE of the first Tx descriptor

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ; Beraldo Lea

RE: [PATCH 03/40] igb: Fix Rx packet type encoding

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ; Beraldo Lea

RE: [PATCH 06/40] net/net_rx_pkt: Use iovec for net_rx_pkt_set_protocols()

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ; Beraldo Lea

RE: [PATCH 18/40] igb: Remove goto

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ;

RE: [PATCH 14/40] e1000x: Share more Rx filtering logic

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ; Beraldo Lea

RE: [PATCH 29/40] igb: Implement MSI-X single vector mode

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ; Beraldo Lea

RE: [PATCH 05/40] igb: Do not require CTRL.VME for tx VLAN tagging

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ; Beraldo Lea

RE: [PATCH 31/40] igb: Use UDP for RSS hash

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ;

RE: [PATCH 37/40] igb: Implement Tx timestamp

2023-04-15 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:38 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ;

RE: [PATCH 30/40] igb: Implement igb-specific oversize check

2023-04-16 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 14 April 2023 13:37 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S. Tsirkin ; Alex Bennée ; > Philippe Mathieu-Daudé ; Thomas Huth > ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 29/41] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:47 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 31/41] igb: Use UDP for RSS hash

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:47 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 16/41] e1000x: Rename TcpIpv6 into TcpIpv6Ex

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:47 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 23/41] igb: Add more definitions for Tx descriptor

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:47 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 38/41] igb: Implement Tx timestamp

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:47 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 04/41] igb: Fix Rx packet type encoding

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:46 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 32/41] igb: Implement Rx SCTP CSO

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:47 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 27/41] net/eth: Always add VLAN tag

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:47 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 28/41] hw/net/net_rx_pkt: Enforce alignment for eth_header

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:47 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v2 03/41] e1000x: Fix BPRC and MPRC

2023-04-20 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 20 April 2023 07:46 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v3 29/47] igb: Rename a variable in igb_receive_internal()

2023-04-24 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 23 April 2023 06:18 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v3 36/47] igb: Implement Rx SCTP CSO

2023-04-24 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 23 April 2023 06:18 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v3 37/47] igb: Implement Tx SCTP CSO

2023-04-24 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 23 April 2023 06:18 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access

2023-04-24 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 23 April 2023 06:18 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ; Beraldo Lea

RE: [PATCH v3 40/47] igb: Implement igb-specific oversize check

2023-04-24 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 23 April 2023 06:18 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

RE: [PATCH v3 06/47] igb: Clear IMS bits when committing ICR access

2023-04-24 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Monday, 24 April 2023 12:52 > To: Sriram Yagnaraman > Cc: Jason Wang ; Dmitry Fleytman > ; Michael S . Tsirkin ; Alex > Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos Santos > Moschetta ; B

RE: [PATCH v3 09/47] igb: Always copy ethernet header

2023-04-24 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 23 April 2023 06:18 > Cc: Sriram Yagnaraman ; Jason Wang > ; Dmitry Fleytman ; > Michael S . Tsirkin ; Alex Bennée > ; Philippe Mathieu-Daudé ; > Thomas Huth ; Wainer dos Santos Moschetta > ;

  1   2   >