Re: [Qemu-devel] [PATCH for-next] spapr: Avoid "HOST@0" CPU node name in SLOF device tree for -cpu host

2013-08-07 Thread Prerna Saxena
". > > Reported-by: Prerna Saxena > Signed-off-by: Andreas Färber > --- ACK. Reviewed and tested --Works as expected. I'll send out an updated follow-up patch later in the day which ensures PAPR compliance for nomenclature. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [PATCH 0/2] [v3] target-ppc: Enhance CPU nodes of SPAPR-generated device tree

2013-08-08 Thread Prerna Saxena
/2 : Make the device-tree CPU nodes PAPR-compliant. Changelog from v2: PATCH 1/2 : Reworked and augmented by Andres Farber against original posted by Prerna. PATCH 2/2 : New. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [PATCH 1/2] [v3] target-ppc: Get CPU name to correct reflect its model in the SLOF device tree.

2013-08-08 Thread Prerna Saxena
t;POWER7_V2.3@0". Tested-by: Prerna Saxena Signed-off-by: Andreas Färber --- hw/ppc/spapr.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 16bfab9..59e2fea 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1072,7 +1

[Qemu-devel] [PATCH 2/2] [v3] target-ppc: Enhance CPU nodes of device tree to be PAPR compliant.

2013-08-08 Thread Prerna Saxena
From: Prerna Saxena Date: Thu, 8 Aug 2013 06:38:03 +0530 Subject: [PATCH 2/2] Enhance CPU nodes of device tree to be PAPR compliant. This is based on patch from Andreas which enables the default CPU with KVM to show up as "-cpu ", such as "POWER7_V2.3@0" While this

Re: [Qemu-devel] [PATCH 2/2] [v3] target-ppc: Enhance CPU nodes of device tree to be PAPR compliant.

2013-08-11 Thread Prerna Saxena
On 08/08/2013 04:04 PM, Andreas Färber wrote: > Am 08.08.2013 09:26, schrieb Prerna Saxena: >> >> From: Prerna Saxena >> Date: Thu, 8 Aug 2013 06:38:03 +0530 >> Subject: [PATCH 2/2] Enhance CPU nodes of device tree to be PAPR compliant. >> >> This is based

Re: [Qemu-devel] [PATCH 16/17] ppc64: Enable QEMU to run on POWER 8 DD1 chip.

2013-07-04 Thread Prerna Saxena
-off-by: Prerna Saxena Signed-off-by: Alexey Kardashevskiy Reviewed-by: Paul Mackerras Reviewed-by: Andreas Farber --- target-ppc/cpu-models.c | 3 +++ target-ppc/cpu-models.h | 1 + target-ppc/translate_init.c | 34 ++ 3 files changed, 38 insertions

[Qemu-devel] [PATCH] Target-ppc : Enhance the CPU node labels for guest device tree for pseries.

2013-07-05 Thread Prerna Saxena
evice-tree/cpus/PowerPC,POWER7@0/... /proc/device-tree/cpus/PowerPC,POWER7@4/... This also helps userspace tools like ppc64_cpu, which expect the device tree to be in this format in the guest. Signed-off-by: Prerna Saxena --- hw/ppc/spapr.c | 17 ++--- target-ppc

[Qemu-devel] [PATCH v2 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-08 Thread Prerna Saxena
ce tree to be in this format. Signed-off-by: Prerna Saxena Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson --- hw/ppc/spapr.c | 18 +++--- target-ppc/cpu-qom.h| 1 + target-ppc/translate_init.c | 28 3 files c

Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-08 Thread Prerna Saxena
optimization level is turned down, so that it doesn't >> recognize that the kvm_enabled() is always false, then this could >> attempt to compile the ppc asm instructions on an x86 (or >> whatever) host. > > This hunk can be completely replaced by QOM mechanisms - jus

Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-09 Thread Prerna Saxena
Hi Andreas, Thanks for the response. On 07/08/2013 10:15 PM, Andreas Färber wrote: > Hi, > > Am 08.07.2013 17:49, schrieb Prerna Saxena: >> On 07/08/2013 02:32 PM, Andreas Färber wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >

[Qemu-devel] [PATCH 1/2] Block: Cleanup vvfat.c to remove dead code.

2016-04-15 Thread Prerna Saxena
Commit 43dc2a64 replaced assert() with abort(), but didnt remove statements that followed these calls. So current code still has return values set after a call to abort(). Such statements will never execute and need to be cleaned up. Signed-off-by: Prerna Saxena --- block/vvfat.c | 17

[Qemu-devel] [PATCH 0/2] Cleanup and instrumenting qemu exits due to abort().

2016-04-15 Thread Prerna Saxena
precede calls to abort(). Prerna Saxena (2): Block: Cleanup vvfat.c to remove dead code. Debug : Add error messages before a call to debug(). block.c| 1 + block/block-backend.c | 4 block/curl.c | 1 + block/io.c | 1 + block/linux-aio.c | 1

[Qemu-devel] [PATCH 2/2] Debug : Add error messages before a call to debug().

2016-04-15 Thread Prerna Saxena
Qemu code has abort() calls in various places which raises a SIGABRT; This patch adds error messages before (most)calls to abort(), so that it is easier to determine why QEMU died. Signed-off-by: Prerna Saxena --- block.c| 1 + block/block-backend.c | 4 block/curl.c

[Qemu-devel] [PATCH 0/1] vhost-user: Add a protocol extension for client responses to vhost commands.

2016-06-24 Thread Prerna Saxena
From: Prerna Saxena The current vhost-user protocol requires the client to send responses to only few commands. For the remaining commands, it is impossible for QEMU to know the status of the requested operation -- ie, did it succeed at all, and if so, at what time. This is inconvenient, and

[Qemu-devel] [PATCH 1/1] vhost-user : Introduce a new feature VHOST_USER_PROTOCOL_F_REPLY_ACK. This feature, if negotiated, forces the remote vhost-user process to send a u64 reply containing a status

2016-06-24 Thread Prerna Saxena
From: Prerna Saxena Signed-off-by: Prerna Saxena --- docs/specs/vhost-user.txt | 36 +++ hw/virtio/vhost-user.c| 153 +- 2 files changed, 186 insertions(+), 3 deletions(-) diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost

[Qemu-devel] Re: [RFC][PATCH 4/5] trace-event

2010-10-24 Thread Prerna Saxena
On 10/22/2010 08:57 PM, Stefan Hajnoczi wrote: On Thu, Oct 21, 2010 at 03:10:18PM +0530, Prerna Saxena wrote: trace-event : QMP interface to change state of a trace-event. (Analogous to hmp command : trace-event ) Signed-off-by: Prerna Saxena --- qmp-commands.hx | 32

Re: [Qemu-devel] [PATCH v2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-10-27 Thread Prerna Saxena
the full build path for defining the probe point. Eg, probe qemu.qemu_malloc = process("/Path/to/build/dir/bin/qemu").mark("qemu_malloc") { .. } -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [Tracing] [RFC PATCH 0/2] : QMP query Interfaces for tracing

2010-10-13 Thread Prerna Saxena
This patch set introduces two QMP interfaces for tracing : * query-trace: to list current contents of trace-buffer * query-trace-events : to list all available trace-events with their state. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [Tracing] [RFC PATCH 1/2] : Introduce 'query-trace' & 'query-trace-events' interfaces

2010-10-13 Thread Prerna Saxena
[PATCH 1/2] Introduce QMP interfaces : query-trace & query-trace-events Signed-off-by: Prerna Saxena --- monitor.c | 46 ++ simpletrace.c | 54 ++ simpletrace.h |2 ++ 3 files cha

[Qemu-devel] [Tracing] [RFC PATCH 2/2] : Documentation for QMP interfaces

2010-10-13 Thread Prerna Saxena
[PATCH 2/2] Add documentation for QMP commands: query-trace & query-trace-events. Signed-off-by: Prerna Saxena --- qmp-commands.hx | 53 + 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-command

[Qemu-devel] [Tracing][RFC v2 PATCH 0/2] QMP Query interfaces for tracing

2010-10-14 Thread Prerna Saxena
ut. - Misc cleanups. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [Tracing][RFC v2 PATCH 1/2] Introduce 'query-trace' & 'query-trace-events' interfaces

2010-10-14 Thread Prerna Saxena
[PATCH 1/2] Introduce QMP interfaces : query-trace & query-trace-events Signed-off-by: Prerna Saxena --- monitor.c | 46 +--- simpletrace.c | 58 + simpletrace.h |4 +++ 3 files cha

[Qemu-devel] [Tracing][RFC v2 PATCH 2/2] Documentation for QMP interfaces

2010-10-14 Thread Prerna Saxena
[PATCH 2/2] Add documentation for QMP commands: query-trace & query-trace-events. Signed-off-by: Prerna Saxena --- qmp-commands.hx | 71 +++ 1 files changed, 71 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-command

[Qemu-devel] [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tracing

2010-10-17 Thread Prerna Saxena
and st_print_trace_events_to_qlist() to return QList* Changes v1 -> v2 : - Add 'timestamp' field for query-trace output. - Misc cleanups. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [Tracing][RFC v3 PATCH 1/2] Introduce QMP interfaces : query-trace & query-trace-events

2010-10-17 Thread Prerna Saxena
[PATCH 1/2] Introduce QMP interfaces : query-trace & query-trace-events. Signed-off-by: Prerna Saxena --- monitor.c | 40 +++--- simpletrace.c | 58 + simpletrace.h |4 +++ 3 files changed

[Qemu-devel] [Tracing][RFC v3 PATCH 2/2] Add documentation for QMP commands: query-trace & query-trace-events.

2010-10-17 Thread Prerna Saxena
[PATCH 2/2] Add documentation for QMP commands: query-trace & query-trace-events. Signed-off-by: Prerna Saxena --- qmp-commands.hx | 71 +++ 1 files changed, 71 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-command

[Qemu-devel] Re: [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces for tracing

2010-10-18 Thread Prerna Saxena
On 10/18/2010 07:51 PM, Luiz Capitulino wrote: On Mon, 18 Oct 2010 11:36:55 +0530 Prerna Saxena wrote: This patch set introduces two QMP interfaces for tracing : * query-trace: to list current contents of trace-buffer * query-trace-events : to list all available trace-events with

[Qemu-devel] [Tracing][v4 PATCH 0/2] QMP Query interfaces for tracing

2010-10-18 Thread Prerna Saxena
: - Add 'timestamp' field for query-trace output. - Misc cleanups. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [Tracing][v4 PATCH 1/2] Introduce QMP interfaces

2010-10-18 Thread Prerna Saxena
[PATCH 1/2] Introduce QMP interfaces : - query-trace - query-trace-events - query-trace-file Signed-off-by: Prerna Saxena --- monitor.c | 53 --- simpletrace.c | 69 + simpletrace.h

[Qemu-devel] [Tracing][v4 PATCH 2/2] Add documentation for QMP interfaces

2010-10-18 Thread Prerna Saxena
[PATCH 2/2] Add documentation for QMP commands: - query-trace - query-trace-events - query-trace-file. Signed-off-by: Prerna Saxena --- qmp-commands.hx | 94 +++ 1 files changed, 94 insertions(+), 0 deletions(-) diff --git a/qmp

Re: [Qemu-devel] [Tracing][v4 PATCH 2/2] Add documentation for QMP interfaces

2010-10-19 Thread Prerna Saxena
On 10/19/2010 11:57 AM, Prerna Saxena wrote: [PATCH 2/2] Add documentation for QMP commands: - query-trace - query-trace-events - query-trace-file. I've been trying ways to avoid building this documentation for other trace backends ( since these commands are only available wit

[Qemu-devel] [Tracing][RFC] QMP interface to toggle state of a trace-event

2010-10-20 Thread Prerna Saxena
7;ll post the final version as a part of the cumulative QMP patchset for tracing ( including patches for query-* commands posted earlier : http://lists.gnu.org/archive/html/qemu-devel/2010-10/msg01232.html ) Signed-off-by: Prerna Saxena --- hmp-commands.hx |2 +- monitor.c

[Qemu-devel] Re: [Tracing][v4 PATCH 2/2] Add documentation for QMP interfaces

2010-10-20 Thread Prerna Saxena
Hi Luiz, Thanks for your feedback. On 10/21/2010 12:47 AM, Luiz Capitulino wrote: On Tue, 19 Oct 2010 11:57:50 +0530 Prerna Saxena wrote: [PATCH 2/2] Add documentation for QMP commands: - query-trace - query-trace-events - query-trace-file. Please, split this. Each command should be

[Qemu-devel] Re: [Tracing][RFC] QMP interface to toggle state of a trace-event

2010-10-20 Thread Prerna Saxena
Thanks for the review! On 10/21/2010 12:53 AM, Luiz Capitulino wrote: On Wed, 20 Oct 2010 15:28:49 +0530 Prerna Saxena wrote: QMP command trace-event to toggle state of a trace-event. Illustration : -> { "execute": "trace-event", "arguments": { "

[Qemu-devel] [RFC][PATCH 1/5] query-trace command

2010-10-21 Thread Prerna Saxena
QMP interface "query-trace" to list current contents of trace-buffer. ( Analogous to hmp command : info trace ) Signed-off-by: Prerna Saxena --- qmp-commands.hx | 51 +++ 1 files changed, 51 insertions(+), 0 deletions(-) diff -

[Qemu-devel] [RFC][PATCH 2/5] query-trace-events

2010-10-21 Thread Prerna Saxena
'query-trace-events' : QMP interface to display currently available trace-events with their state. ( Analogous to hmp command : info trace-events ) Signed-off-by: Prerna Saxena --- qmp-commands.hx | 32 1 files changed, 32 insertions(+), 0 deletion

[Qemu-devel] [RFC][PATCH 5/5] set-trace-file

2010-10-21 Thread Prerna Saxena
set-trace-file : QMP command to: - Enable/disable logging traces to file - Set a new output file - Flush a semi-filled trace-buffer to output file. Signed-off-by: Prerna Saxena --- qmp-commands.hx | 41 + 1 files changed, 41 insertions

[Qemu-devel] [RFC] [PATCH 3/5] query-trace-file

2010-10-21 Thread Prerna Saxena
'query-trace-file' : QMP interface to find currently set trace file and its status. (Analogous to hmp command : trace-file) Signed-off-by: Prerna Saxena --- qmp-commands.hx | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/qmp-command

[Qemu-devel] [RFC][PATCH 4/5] trace-event

2010-10-21 Thread Prerna Saxena
trace-event : QMP interface to change state of a trace-event. (Analogous to hmp command : trace-event ) Signed-off-by: Prerna Saxena --- qmp-commands.hx | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx

[Qemu-devel] [RFC 0/5] QMP interfaces for tracing

2010-10-21 Thread Prerna Saxena
: to display currently set trace file and its status. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

Re: [Qemu-devel] [RFC 0/2] Tracing

2010-05-21 Thread Prerna Saxena
e improved in my current implementation :-) 3. Allow events in any execution context (cpu, io, aio emulation threads). Agree. 4. Make it easy to add new events. Agree ! I'm trying to provide a unified macro interface like trace events which makes it easy enough to add new events. Re

[Qemu-devel] [RFC 0/3] Tracing framework for QEMU

2010-05-24 Thread Prerna Saxena
cing. I'll take care of merging pieces together. Looking forward to suggestions.. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [PATCH 1/3]make tdb_hash available

2010-05-24 Thread Prerna Saxena
This function is used for hash table lookups by tracepoint framework. The patch adds trivial changes to reuse it. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India Signed-off by : Prerna (pre...@linux.vnet.ibm.com) Index: qemu/qdict.c

[Qemu-devel] [PATCH 2/3] Tracepoint, buffer & monitor framework

2010-05-24 Thread Prerna Saxena
: to see available tracepoints and their status. 3. trace [on|off] : to enable / disable trace data collection. 4. tracepoint ABC [on|off] : to enable / disable traces from a specific tracepoint, eg ABC -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [PATCH 3/3] Samples to add a tracepoint.

2010-05-24 Thread Prerna Saxena
should have a 'trace_name(args..)' (Remember to include "trace-entries.h" in the file where the tracepoint is logged) This patch adds tracepoints to virtio_blk_rw_complete() and paio_submit() -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore,

Re: [Qemu-devel] [PATCH 2/3] Tracepoint, buffer & monitor framework

2010-05-25 Thread Prerna Saxena
ces can be retained as is. Also, I'd implemented the monitor interface for enabling/disabling data logging for a given tracepoint (for a running guest) Not sure if this is supported in the set of patches you've posted ? It might be a good to have feature. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] Tracing concerns for concurrent execution

2010-05-25 Thread Prerna Saxena
t would be good to have some pointers on what assumptions can / not be made for concurrent thread execution in qemu, and what could be done to safeguard tracing in such hot-paths ? Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [PATCH] Re: Tracing backends : Fix for building with --prefix

2010-06-07 Thread Prerna Saxena
This patch is a minor fix over Stefan's tracing framework, to enable compilation when the build directory is different from source. Signed-off-by: Prerna Saxena --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a9f79a9..ef

[Qemu-devel] [PATCH 0/3] Monitor commands for 'simple' trace backend

2010-06-07 Thread Prerna Saxena
: to view all available tracepoints and their state. - tracepoint NAME on|off: to enable/disable the logging of data from tracepoint 'NAME'. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [PATCH 1/3] export tdb_hash()

2010-06-08 Thread Prerna Saxena
This exports tdb_hash() for use by tracing framework. Signed-off-by: Prerna Saxena --- qdict.c |2 +- qdict.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qdict.c b/qdict.c index 175bc17..5261872 100644 --- a/qdict.c +++ b/qdict.c @@ -56,7 +56,7 @@ QDict

[Qemu-devel] [PATCH 2/3] Monitor command 'trace'

2010-06-08 Thread Prerna Saxena
This introduces the monitor command 'trace' to read current contents of trace buffer. Signed-off-by: Prerna Saxena --- configure |3 +++ monitor.c |3 +++ qemu-monitor.hx | 16 simpletrace.c | 15 +++ tracetool |4 +++

[Qemu-devel] [PATCH 3/3] Toggle tracepoint state

2010-06-08 Thread Prerna Saxena
-- there is scope for optimizations that can be employed here to speed this up. Signed-off-by: Prerna Saxena --- monitor.c | 21 + qemu-monitor.hx | 16 simpletrace.c | 55 ++- tracetool | 30

Re: [Qemu-devel] [RFC 0/3] Tracing framework for QEMU

2010-06-08 Thread Prerna Saxena
enough to dump entire arrays if need be -- which is not as easily accomplished in the proposed approach as with kernel tracepoints. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [RFC v2] [PATCH 2/3] Monitor command 'info trace'

2010-06-10 Thread Prerna Saxena
This introduces the monitor command 'info trace' to display current contents of trace buffer. Signed-off-by: Prerna Saxena --- configure |3 +++ monitor.c | 12 qemu-monitor.hx |4 simpletrace.c | 12 tracetool |2 +

[Qemu-devel] [RFC v2] [PATCH 1/3] Export tdb_hash()

2010-06-10 Thread Prerna Saxena
For now, I simply export tdb_hash() from qdict.h for use by tracing framework. Luiz suggested renaming and exporting it from a location other than qdict.h . Would "qemu-common.h" be a better place? Signed-off-by: Prerna Saxena --- qdict.c |2 +- qdict.h |2 ++ 2 files

[Qemu-devel] [RFC v2] [PATCH 3/3] Toggle tracepoint state

2010-06-10 Thread Prerna Saxena
oring optimizations that can be employed to make this faster. Signed-off-by: Prerna Saxena --- monitor.c | 16 +++- qemu-monitor.hx | 18 ++ simpletrace.c | 53 + tracetool |

[Qemu-devel] [RFC v2] [PATCH 0/3] Monitor Support for 'simple' trace backend

2010-06-10 Thread Prerna Saxena
ents of buffer, in place of 'trace'. - Cleanups -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

Re: [Qemu-devel] [PATCH 1/3] export tdb_hash()

2010-06-11 Thread Prerna Saxena
On 06/10/2010 02:05 AM, Luiz Capitulino wrote: On Tue, 8 Jun 2010 12:31:38 +0530 Prerna Saxena wrote: This exports tdb_hash() for use by tracing framework. Suggest to rename it (eg. qemu_hash()) and move it to a better location, qdict is not the best module to export such service

Re: [Qemu-devel] [PATCH 2/3] Monitor command 'trace'

2010-06-11 Thread Prerna Saxena
Hi Luiz, Thanks for your feedback. On 06/10/2010 02:07 AM, Luiz Capitulino wrote: On Tue, 8 Jun 2010 12:34:37 +0530 Prerna Saxena wrote: This introduces the monitor command 'trace' to read current contents of trace buffer. ... diff --git a/simpletrace.c b/simpletrace.c ind

Re: [Qemu-devel] [PATCH 3/3] Toggle tracepoint state

2010-06-11 Thread Prerna Saxena
Hi Luiz, Thanks for taking time to review it. On 06/10/2010 02:13 AM, Luiz Capitulino wrote: On Tue, 8 Jun 2010 12:38:58 +0530 Prerna Saxena wrote: This patch adds support for dynamically enabling/disabling of tracepoints. Monitor commands added : Monitor has a bool type, please

[Qemu-devel] [PATCH 0/3] Monitor support QEMU trace framework

2010-06-16 Thread Prerna Saxena
rent contents of the trace buffer - info tracepoints : to view all available tracepoints and their state. - tracepoint NAME on|off : to enable/disable the logging of data from tracepoint 'NAME' to on/off. Changelog : - Clean-ups from v2, particularly relating to export of tdb_hash() -- Prerna

[Qemu-devel] [PATCH 3/3] Toggle tracepoint state

2010-06-16 Thread Prerna Saxena
paio_submit off disables logging of data when paio_submit is hit. Signed-off-by: Prerna Saxena --- monitor.c | 16 ++ qemu-monitor.hx | 18 simplet

[Qemu-devel] [PATCH 2/3] Monitor command 'info trace'

2010-06-16 Thread Prerna Saxena
Monitor command 'info trace' to display contents of trace buffer Signed-off-by: Prerna Saxena --- configure |3 +++ monitor.c | 12 qemu-monitor.hx |4 simpletrace.c | 13 + tracetool |2 ++ 5 files changed, 34 insert

[Qemu-devel] [PATCH 1/3] Export hash function

2010-06-16 Thread Prerna Saxena
Rename tdb_hash() to qemu_hash(). Move definition from qdict.c to a new file qemu-misc.c for use by tracing infrastructure. Signed-off-by: Prerna Saxena --- Makefile.objs |2 +- qdict.c | 24 qemu-common.h |3 +++ qemu-misc.c | 24

[Qemu-devel] Re: [PATCH 2/3] Monitor command 'info trace'

2010-06-18 Thread Prerna Saxena
Hi Stefan, Jan, Thanks for taking a look. On 06/17/2010 08:38 PM, Stefan Hajnoczi wrote: On Wed, Jun 16, 2010 at 06:12:06PM +0530, Prerna Saxena wrote: diff --git a/simpletrace.c b/simpletrace.c index 2fec4d3..239ae3f 100644 --- a/simpletrace.c +++ b/simpletrace.c @@ -62,3 +62,16 @@ void

Re: [Qemu-devel] Re: [PATCH 3/3] Toggle tracepoint state

2010-06-18 Thread Prerna Saxena
On 06/17/2010 09:33 PM, Stefan Hajnoczi wrote: On Wed, Jun 16, 2010 at 06:14:35PM +0530, Prerna Saxena wrote: This patch adds support for dynamically enabling/disabling of tracepoints. This is done by internally maintaining each tracepoint's state, and permitting logging of data f

[Qemu-devel] [Request for inputs]Qemu parameters that need runtime change.

2011-03-02 Thread Prerna Saxena
user to -net tap ? ) I'm presently aware of these; it would be good to get more inputs on what more can be done here. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [RFC][PATCH 0/2] Allow cache settings for block devices to be changed at runtime.

2011-02-28 Thread Prerna Saxena
)set_cache ide0-hd0 presently errors out. Ideally, it should display current cache setting for the given device ide0-hd0 -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [RFC][PATCH 1/2] Add monitor command 'set-cache' to change cache settings for a block device.

2011-02-28 Thread Prerna Saxena
user_print = monitor_user_noop, +.mhandler.cmd_new = do_set_cache, +}, +STEXI +@item set_cache +@findex set_cache +Set cache options for a block device. +ETEXI { .name = "acl_show", .args_type = "aclname:s", -- 1.7.2.3 -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [RFC][PATCH 2/2] Extend monitor command 'info block' to display cache settings for block devices.

2011-02-28 Thread Prerna Saxena
;'open_flags': %d }", bs->device_name, type, bs->removable, -bs->locked); +bs->locked, bs->open_flags); if (bs->drv) { QObject *obj; -- 1.7.2.3 -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [RFC v4][PATCH 0/3] Monitor support for Qemu tracing

2010-06-24 Thread Prerna Saxena
lace of 'trace'. 2. Cleanups Todos : 1. Integration with QMP 2. More tracepoints need to be added for instrumenting other qemu components such as virtio drivers, etc. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [RFC v4][PATCH 1/3] Change type declarations

2010-06-24 Thread Prerna Saxena
Change type 'TraceEvent' to 'TraceEventID' Signed-off-by: Prerna Saxena --- simpletrace.c | 12 ++-- tracetool | 12 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/simpletrace.c b/simpletrace.c index 2fec4d3..b488380 100644

[Qemu-devel] [RFC v4][PATCH 2/3] Monitor command 'info trace'

2010-06-24 Thread Prerna Saxena
Monitor command 'info trace' to display contents of trace buffer Signed-off-by: Prerna Saxena --- configure |3 +++ monitor.c | 12 qemu-monitor.hx |4 simpletrace.c | 12 tracetool |1 + 5 files changed, 32 insert

[Qemu-devel] [RFC v4][PATCH 3/3] Support for dynamically enabling/disabling trace events.

2010-06-24 Thread Prerna Saxena
paio_submit off disables logging of data when paio_submit is hit. By default, all trace-events are disabled. One can enable desired trace-events via the monitor. Signed-off-by: Prerna Saxena --- monitor.c | 16 qemu-mo

[Qemu-devel] [PATCH][Tracing] Fix for make parallelization.

2010-06-28 Thread Prerna Saxena
[PATCH] Restore parallel building This is based on : http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing Signed-off-by: Prerna Saxena --- Makefile |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index e64e397..de9b175 100644 --- a

Re: [Qemu-devel] Tracing: outstanding tasks

2010-06-30 Thread Prerna Saxena
stigating scope for further optimization. Owner : Prerna Thanks, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [PATCH][Tracing] Fix build errors for target i386-linux-user

2010-06-30 Thread Prerna Saxena
these are needed by do_info_trace which dumps buffer contents. Signed-off-by: Prerna Saxena --- monitor.c | 21 + simpletrace.c | 39 ++- tracetool | 16 3 files changed, 39 insertions(+), 37 deletions(-) diff

[Qemu-devel] [PATCH] Fix broken --kerneldir

2010-07-01 Thread Prerna Saxena
-by: Prerna Saxena --- Makefile.target |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile.target b/Makefile.target index d58b201..b433112 100644 --- a/Makefile.target +++ b/Makefile.target @@ -29,12 +29,15 @@ QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF) endif

[Qemu-devel] [PATCH] Makefile: Fix compilation for non-standard host kernel path

2010-07-02 Thread Prerna Saxena
-by: Prerna Saxena --- Makefile.target |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile.target b/Makefile.target index d58b201..b433112 100644 --- a/Makefile.target +++ b/Makefile.target @@ -29,12 +29,15 @@ QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF

[Qemu-devel] [RFC v2][PATCH][Tracing] Fix build errors for target i386-linux-user

2010-07-06 Thread Prerna Saxena
On Thu, 1 Jul 2010 10:18:41 +0100 Stefan Hajnoczi wrote: > On Wed, Jun 30, 2010 at 09:11:45PM +0530, Prerna Saxena wrote: > > [PATCH 1/1] Move definitions of monitor command handlers (do_info_trace, > > do_info_all_trace_events) to monitor.c. This removes build errors for > &

Re: [Qemu-devel] [PATCH] Makefile: Fix compilation for non-standard host kernel path

2010-07-07 Thread Prerna Saxena
On 07/07/2010 01:10 AM, Anthony Liguori wrote: On 07/02/2010 06:15 AM, Prerna Saxena wrote: Set up host kernel include paths specified by --kerneldir When host kernel headers are placed in non-standard paths, the KVM_CFLAGS are presently invoked only for a few .c files (kvm*.c,vhost*.c) and

[Qemu-devel] [RFC v3][PATCH][Tracing] Fix build errors for target i386-linux-user

2010-07-07 Thread Prerna Saxena
[PATCH] Separate monitor command handler interfaces and tracing internals. Signed-off-by: Prerna Saxena --- monitor.c | 23 +++ simpletrace.c | 51 +-- tracetool |7 +++ 3 files changed, 59 insertions

Re: [Qemu-devel] [PATCH 3/3] trace: Flush trace buffer on exit

2010-07-07 Thread Prerna Saxena
n case qemu is started with -smp 2 or more. We might need to enforce some kind of synchronisation so that threads on other cpus do not log traces while the buffer is being sync'ed. ( For now, I have not been able to get upstream qemu run with -smp. Going forward, this is something that mig

[Qemu-devel] Re: [RFC v3][PATCH][Tracing] Fix build errors for target i386-linux-user

2010-07-08 Thread Prerna Saxena
On 07/08/2010 02:50 PM, Stefan Hajnoczi wrote: On Thu, Jul 08, 2010 at 10:58:58AM +0530, Prerna Saxena wrote: [PATCH] Separate monitor command handler interfaces and tracing internals. Signed-off-by: Prerna Saxena --- monitor.c | 23 +++ simpletrace.c | 51

[Qemu-devel] [PATCH][Tracing] Specify trace file name

2010-07-09 Thread Prerna Saxena
ff-by: Prerna Saxena --- configure | 20 simpletrace.c | 13 - tracetool |1 + vl.c |8 4 files changed, 41 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 02bf602..18cb6ab 100755 --- a/configure

[Qemu-devel] [RFC v4][PATCH][Tracing] Fix build errors for target i386-linux-user

2010-07-09 Thread Prerna Saxena
[PATCH] Separate monitor command handler interfaces and tracing internals. Changelog from v3 : 1. Cleanups. Signed-off-by: Prerna Saxena --- monitor.c | 23 +++ simpletrace.c | 52 ++-- tracetool |7 +++ 3

[Qemu-devel] Re: [RFC v3][PATCH][Tracing] Fix build errors for target i386-linux-user

2010-07-09 Thread Prerna Saxena
On 07/08/2010 07:04 PM, Stefan Hajnoczi wrote: On Thu, Jul 08, 2010 at 04:50:52PM +0530, Prerna Saxena wrote: On 07/08/2010 02:50 PM, Stefan Hajnoczi wrote: On Thu, Jul 08, 2010 at 10:58:58AM +0530, Prerna Saxena wrote: [PATCH] Separate monitor command handler interfaces and tracing internals

[Qemu-devel] [RFC v5[PATCH][Tracing] Fix build errors for target i386-linux-user

2010-07-11 Thread Prerna Saxena
[PATCH] Separate monitor command handler interfaces and tracing internals. Changelog from v3: - cleanup ( removed unnecessary references to 'rec' ) Signed-off-by: Prerna Saxena --- monitor.c | 23 +++ simpletrac

[Qemu-devel] [Tracing][PATCH] Allow bulk enabling of trace events at compile time.

2010-07-13 Thread Prerna Saxena
vents are enabled by default. TODO : This could be enhanced when the trace-event namespace is partitioned into a group and an ID within that group. In such a case, marking a group as enabled would automatically enable all trace-events listed under it. Signed-off-by: Prerna Saxena --- trace-events |

[Qemu-devel] [Tracing][PATCH] Add options to specify trace file name at startup and runtime.

2010-08-02 Thread Prerna Saxena
ption set at config-time. Also, this adds monitor sub-command 'set' to trace-file commands to dynamically change trace log file at runtime. Eg, (qemu)trace-file set FILENAME This allows one to set trace outputs to FILENAME from the default specified at startup. Signed-off-by:

[Qemu-devel] [Tracing][PATCH v2] Add options to specify trace file name at startup and runtime.

2010-08-04 Thread Prerna Saxena
1 : - Cleanups. Signed-off-by: Prerna Saxena --- monitor.c |6 ++ qemu-monitor.hx |6 +++--- qemu-options.hx | 11 +++ simpletrace.c | 41 +++-- tracetool |1 + vl.c| 20 6 files changed,

Re: [Qemu-devel] [Tracing][PATCH] Add options to specify trace file name at startup and runtime.

2010-08-04 Thread Prerna Saxena
On 08/03/2010 07:45 PM, Stefan Hajnoczi wrote: On Tue, Aug 3, 2010 at 6:37 AM, Prerna Saxena wrote: This patch adds an optional command line switch '-trace' to specify the filename to write traces to, when qemu starts. Eg, If compiled with the 'simple' trace backend, [t...@

[Qemu-devel] [Tracing][PATCH v3] Add options to specify trace file name at startup and runtime.

2010-08-04 Thread Prerna Saxena
e outputs to FILENAME from the default specified at startup. Changelog from v2 : - Cleanups. Signed-off-by: Prerna Saxena --- monitor.c |6 ++ qemu-monitor.hx |6 +++--- qemu-options.hx | 11 +++ simpletrace.c | 41 +++--

[Qemu-devel] [Tracing][PATCH] Compilation fixes

2010-08-05 Thread Prerna Saxena
Fix to ensure rebuild is properly triggered when switching trace backends using ./configure. Also, when using the 'ust' backend, check if the relevant headers are available at host. Signed-off-by: Prerna Saxena --- Makefile |4 ++-- configure | 20 +--- 2 fil

[Qemu-devel] [Tracing][PATCH] Fix a build warning

2010-08-05 Thread Prerna Saxena
A build warning arising out of 'incompatible pointer assignment' shows up at times. This will take care of it. Signed-off-by: Prerna Saxena --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 46314d4..989c35b 100644 --- a/vl.c

[Qemu-devel] [Tracing] Compilation failure

2010-08-09 Thread Prerna Saxena
*/ .timestamp_ns = 0xf2b177cb0aa429b4, /* magic number */ error. Also, it would be better to #define the magic number to some macro, and use that instead of using the constant directly. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab

Re: [Qemu-devel] [PATCH] trace: Make trace record fields 64-bit

2010-08-10 Thread Prerna Saxena
trace_args="$trace_args, $(cast_args_to_ulong "$1")" +trace_args="$trace_args, $(cast_args_to_uint64_t "$1")" fi cat< -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [Tracing] More Trace events

2010-08-11 Thread Prerna Saxena
This patch adds few more trace events for tracking IO and also to trace balloon event flagged via the monitor. Signed-off-by: Prerna Saxena --- balloon.c|2 ++ ioport.c |7 +++ trace-events |8 3 files changed, 17 insertions(+), 0 deletions(-) diff --git a

[Qemu-devel] [PATCH v2] trace: Make trace record fields 64-bit

2010-08-11 Thread Prerna Saxena
uintptr_t, and then to uint64_t to bypass warnings. Signed-off-by: Prerna Saxena --- simpletrace.c | 41 ++--- simpletrace.h | 13 +++-- simpletrace.py |2 +- tracetool |6 +++--- 4 files changed, 37 insertions(+), 25 deletions(-) diff

[Qemu-devel] [Tracing][PATCH 0/2] More Trace events

2010-08-11 Thread Prerna Saxena
Set of patches to add trace-events for tracking IO and balloon events flagged via the monitor. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

  1   2   >