On 10/22/2010 08:57 PM, Stefan Hajnoczi wrote:
On Thu, Oct 21, 2010 at 03:10:18PM +0530, Prerna Saxena wrote:
trace-event : QMP interface to change state of a trace-event.
(Analogous to hmp command : trace-event )

Signed-off-by: Prerna Saxena<pre...@linux.vnet.ibm.com>
---
  qmp-commands.hx |   32 ++++++++++++++++++++++++++++++++
  1 files changed, 32 insertions(+), 0 deletions(-)

diff --git a/qmp-commands.hx b/qmp-commands.hx
index 7e95f4e..f2008e8 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -761,6 +761,38 @@ Example:

  Note: This command must be issued before issuing any other command.

+EQMP
+
+    {
+        .name       = "trace-event",
+        .args_type  = "name:s,option:b",
+        .params     = "name on|off",
+        .help       = "changes state of a specific trace event",
+        .user_print = monitor_user_noop,
+        .mhandler.cmd_new = do_change_trace_event_state_qmp,
+    },
+
+SQMP
+trace-event
+-----------
+
+Change state of a trace-event.

The name is a little odd because it has no verb.  How about
set-trace-event or enable-trace-event?


Sure, makes sense.
I'll incorporate this when I send out the next set of patches.

Thanks,
--
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India

Reply via email to