On 11/21/2017 10:12 PM, David Gibson wrote:
...
> I've applied several patches from this series to ppc-for-2.12, others
> I've commented on. If you could address the comments and rebase
> what's left on ppc-for-2.12, that would be great.
Will do.
signature.asc
Description: OpenPGP digital sign
On 11/21/2017 10:08 PM, David Gibson wrote:
> On Sun, Nov 19, 2017 at 09:24:16PM -0600, Michael Davidsaver wrote:
>> Signed-off-by: Michael Davidsaver
>
> You're adding what seems to be a fairly specific device to the general
> e500 init - this again suggests that it s
On 11/21/2017 09:28 PM, David Gibson wrote:
> On Sun, Nov 19, 2017 at 09:24:09PM -0600, Michael Davidsaver wrote:
>> allow board code to skip common NIC and guest image setup
>> and configure decrementor frequency.
>> Existing boards unchanged.
>>
>> Signed-of
Signed-off-by: Michael Davidsaver
---
Makefile.objs | 1 +
hw/i2c/trace-events | 1 +
2 files changed, 2 insertions(+)
create mode 100644 hw/i2c/trace-events
diff --git a/Makefile.objs b/Makefile.objs
index 285c6f3c15..984ae8ecba 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -155,6
anged
Michael Davidsaver (17):
openpic: debug w/ info_report()
i2c: start trace-events
i2c: add mpc8540 i2c controller
qtest: add e500_i2c_create()
timer: generalize Dallas/Maxim RTC i2c devices
tests: rewrite testing for DS RTC devices
e500: fix pci host bridge class/type
e500: addit
Add interface for testing i2c devices
with PPC e500.
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include | 1 +
tests/libqos/i2c-e500.c | 66 +
tests/libqos/i2c.h | 3 +++
3 files changed, 70 insertions(+)
create mode 100644
Signed-off-by: Michael Davidsaver
---
hw/ppc/e500.c | 13 -
hw/ppc/e500_ccsr.c | 18 ++
2 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 1872bb8eaa..2d87d91582 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
Replace *printf() with *_report().
Remove trailing new lines.
Signed-off-by: Michael Davidsaver
---
hw/intc/openpic.c | 102 +++---
1 file changed, 51 insertions(+), 51 deletions(-)
diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c
index
Signed-off-by: Michael Davidsaver
---
hw/i2c/Makefile.objs | 1 +
hw/i2c/mpc8540_i2c.c | 307 +++
hw/i2c/trace-events | 6 +
3 files changed, 314 insertions(+)
create mode 100644 hw/i2c/mpc8540_i2c.c
diff --git a/hw/i2c/Makefile.objs b/hw
Replace existing ds1338-test with more thorough
test of time read and set.
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include | 4 +-
tests/ds-rtc-i2c-test.c | 162
tests/ds1338-test.c | 77 ---
3 files
y (valid) CCB frequency of 333MHz
in the device tree and for the UART.
Signed-off-by: Michael Davidsaver
---
hw/ppc/e500.c | 9 -
hw/ppc/e500_ccsr.c | 16
2 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 2d87d9158
ters don't have valid values.
Signed-off-by: Michael Davidsaver
---
hw/pci-host/ppce500.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c
index f2d108bc8a..8073d396ff 100644
--- a/hw/pci-host/ppce500.c
+++ b/hw/pci-host/ppce500.c
@@ -423,11 +
Add CCSRBAR to allow CCSR region to be relocated.
Guest memory size introspection via RAM config
registers.
Dummy RAM error controls.
Clock introspection via Power on Reset PLL
Status Register.
Signed-off-by: Michael Davidsaver
ccsrbase also update iack
---
hw/ppc/e500.c | 5 ++-
hw
Signed-off-by: Michael Davidsaver
---
hw/ppc/e500.c | 13 -
hw/ppc/e500_ccsr.c | 27 +++
2 files changed, 31 insertions(+), 9 deletions(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index cfd5ed0152..b0c8495aef 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc
ff-by: Michael Davidsaver
---
hw/ppc/e500.c | 102 +++--
hw/ppc/e500_ccsr.c | 85 +---
2 files changed, 84 insertions(+), 103 deletions(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index e22919f4f1..1872b
Support for: ds1307, ds1337, ds1338, ds1339,
ds1340, ds1375, ds1388, and ds3231.
Tested with ds1338 and ds1375.
Signed-off-by: Michael Davidsaver
---
default-configs/arm-softmmu.mak | 2 +-
hw/timer/Makefile.objs | 2 +-
hw/timer/ds-rtc-i2c.c | 461
Exercise some features of the mvme3100 CPLD logic
and read from the eeprom w/ VPD.
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include | 3 ++
tests/mvme3100-test.c | 79 ++
2 files changed, 82 insertions(+)
create mode 100644 tests
split off the remaining board specific parts
of e500_init() as mpc85xx_init() which
will be used by the existing
mpc8544ds and generic e500 boards.
Signed-off-by: Michael Davidsaver
---
hw/ppc/e500.c | 49 -
hw/ppc/e500.h | 3 ++-
hw
Signed-off-by: Michael Davidsaver
---
default-configs/ppc-softmmu.mak | 1 +
hw/ppc/Makefile.objs| 1 +
hw/ppc/mvme3100.c | 740
hw/ppc/mvme3100_cpld.c | 192 +++
4 files changed, 934 insertions(+)
create
Add i2c controller found on mpc8540,
mpc8544, and P2010 (newer ppc, unmodeled).
Signed-off-by: Michael Davidsaver
---
hw/ppc/e500_ccsr.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/hw/ppc/e500_ccsr.c b/hw/ppc/e500_ccsr.c
index c479ed91ee..cd8216daaf 100644
--- a/hw/ppc
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include | 3 ++-
tests/ds-rtc-i2c-test.c | 8
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 56045cdf09..062d4e5b7b 100644
--- a/tests/Makefile.include
+++ b/tests
On 11/27/2017 01:12 AM, David Gibson wrote:
> On Sun, Nov 26, 2017 at 03:59:01PM -0600, Michael Davidsaver wrote:
>> Signed-off-by: Michael Davidsaver
>> ---
>> hw/i2c/Makefile.objs | 1 +
>> hw/i2c/mpc8540_i2c.c | 307
>> +++
update IRQ pins on reset.
Signed-off-by: Michael Davidsaver
---
hw/net/fsl_etsec/etsec.c | 68 +++-
hw/net/fsl_etsec/etsec.h | 2 ++
hw/net/fsl_etsec/registers.h | 10 +++
hw/net/fsl_etsec/rings.c | 12 +---
4 files changed, 49 inserti
On 05/22/2018 10:30 PM, Thomas Huth wrote:
> On 22.05.2018 21:17, Paolo Bonzini wrote:
>> AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is
>> being included in all emulators that use I2C, even if they do not
>> really need it. Separate it and, since it was added for the e500
>> mac
Use names for registers and bits except
for R_CTRL which will be dealt with later,
and isn't modeled anyway.
Signed-off-by: Michael Davidsaver
Reviewed-by: Peter Maydell
---
hw/timer/ds1338.c | 80 +--
1 file changed, 54 insertions(+
Signed-off-by: Michael Davidsaver
---
tests/ds-rtc-common.h | 10 +++---
tests/ds-rtc-current-test.c | 9 -
tests/ds-rtc-set-test.c | 6 --
3 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/tests/ds-rtc-common.h b/tests/ds-rtc-common.h
index c8e6c2bc5b
Need to save HOUR[HOUR12] bit to keep
track of guest selection of 12-hour mode.
Write through current time registers to
achieve this. Will be overwritten
by the next read/latch.
This was only being done in two of three
arms of this conditional block.
Signed-off-by: Michael Davidsaver
---
hw
Simplify and comment the translation between
registers and struct tm.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds1338.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c
index b56db5852e..637a0f4246 100644
--- a/hw
o CTRL register handling is split out
as a seperate patch "timer: ds1338 remove vestige of un-modeled OSF"
= timer: ds-rtc handle CENTURY bit
Changed as suggested.
Michael Davidsaver (14):
tests: more thorough tests of ds1338
timer: ds1338 use registerfields.h
timer: ds1338
and host timezones.
Allow guest to use any day as start of week
(day 1). eg. Monday instead of Sunday.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds1338.c | 95 ---
1 file changed, 48 insertions(+), 47 deletions(-)
diff --git a/hw/timer
Prepare to generalize with a more generic
name.
Keep device name and vmstate name "ds1338"
for compatibility.
Signed-off-by: Michael Davidsaver
Reviewed-by: Peter Maydell
---
hw/timer/ds1338.c | 72 +++
1 file changed, 36 inserti
Test current time and set+get round trip.
Separate current time test from set/get tests
to avoid test needing to impose order, or to
have a magic handshaketo reset RTC to current time.
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include | 4 ++
tests/ds-rtc-common.h | 67
Oscillator stop has never been modeled, so the
Oscillator Stop Flag can never be set.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds-rtc.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/hw/timer/ds-rtc.c b/hw/timer/ds-rtc.c
index 3c5781d53c..126566ce1f
Signed-off-by: Michael Davidsaver
Reviewed-by: Peter Maydell
---
hw/timer/ds-rtc.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/timer/ds-rtc.c b/hw/timer/ds-rtc.c
index 6d3a8b5586..9abac38628 100644
--- a/hw/timer/ds-rtc.c
+++ b/hw/timer/ds-rtc.c
@@ -70,6 +70,7
Signed-off-by: Michael Davidsaver
---
tests/ds-rtc-set-test.c | 52 +
1 file changed, 52 insertions(+)
diff --git a/tests/ds-rtc-set-test.c b/tests/ds-rtc-set-test.c
index 35e1a36281..c48406ee2c 100644
--- a/tests/ds-rtc-set-test.c
+++ b/tests/ds
Signed-off-by: Michael Davidsaver
Reviewed-by: Peter Maydell
---
default-configs/arm-softmmu.mak | 2 +-
hw/timer/Makefile.objs | 2 +-
hw/timer/{ds1338.c => ds-rtc.c} | 0
3 files changed, 2 insertions(+), 2 deletions(-)
rename hw/timer/{ds1338.c => ds-rtc.c} (100%)
diff -
differences from ds1338
* Has alarms (not modeled)
* different control register (not modeled)
* smaller address space (0x20 vs. 0x40)
Signed-off-by: Michael Davidsaver
Reviewed-by: Peter Maydell
---
hw/timer/ds-rtc.c | 30 --
1 file changed, 28 insertions(+), 2
redundant to ds-rtc-*-test.c
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include | 2 --
tests/ds1338-test.c| 75 --
2 files changed, 77 deletions(-)
delete mode 100644 tests/ds1338-test.c
diff --git a/tests/Makefile.include b
On 07/05/2018 08:39 PM, David Gibson wrote:
> On Thu, Jul 05, 2018 at 11:19:50AM -0700, Michael Davidsaver wrote:
> 11;rgb://> Need to save HOUR[HOUR12] bit to keep
>> track of guest selection of 12-hour mode.
>> Write through current time registers to
>
Signed-off-by: Michael Davidsaver
---
tests/ds-rtc-common.h | 9 ---
tests/ds-rtc-current-test.c | 2 +-
tests/ds-rtc-set-test.c | 58 +++--
3 files changed, 63 insertions(+), 6 deletions(-)
diff --git a/tests/ds-rtc-common.h b/tests/ds
Signed-off-by: Michael Davidsaver
---
tests/ds-rtc-common.h | 10 +++---
tests/ds-rtc-current-test.c | 9 -
tests/ds-rtc-set-test.c | 6 --
3 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/tests/ds-rtc-common.h b/tests/ds-rtc-common.h
index 5bc7ab32a6
On 07/05/2018 09:35 PM, Michael Davidsaver wrote:
> Also, I though I had test coverage of this bug. That's actually how I
> noticed it to begin with. But it seems my later change to allow for a
> slow test runner also stopped testing readback of the 12/24 hour mode bit.
> It j
On 11/28/2017 05:35 PM, David Gibson wrote:
> On Mon, Nov 27, 2017 at 08:42:13PM -0600, Michael Davidsaver wrote:
>> Interrupt conditions occurring while masked are not being
>> signaled when later unmasked.
>> The fix is to raise/lower IRQs when IMASK is changed.
>>
>
update IRQ pins on reset.
Signed-off-by: Michael Davidsaver
Reviewed-by: Cédric Le Goater
---
hw/net/fsl_etsec/etsec.c | 68 +++-
hw/net/fsl_etsec/etsec.h | 2 ++
hw/net/fsl_etsec/registers.h | 10 +++
hw/net/fsl_etsec/rings.c | 12 +--
Actual number of interrupt pins isn't known
in ppce500_init_mpic() so a hardcoded number
was used, which causes a crash with older openpic.
Instead, return the DeviceState* and change ppce500_init()
to call qdev_get_gpio_in() to get only the irq pins
which are needed.
Signed-off-by: Mi
On 01/12/2017 09:14 AM, Peter Maydell wrote:
> ...
> Michael has confirmed to me that this was just an oversight.
This was me not knowing the process. (just to confirm this publicly)
signature.asc
Description: OpenPGP digital signature
Test time set+get in 12 hour mode.
Also test handling of day of week
offset.
Signed-off-by: Michael Davidsaver
---
tests/ds-rtc-i2c-test.c | 54 -
1 file changed, 53 insertions(+), 1 deletion(-)
diff --git a/tests/ds-rtc-i2c-test.c b/tests/ds-rtc
Test current time and set+get round trip.
The set+get test is repeated 4 times. These cases are
spread across a single day in an attempt to trigger some potential
issues regardless of the timezone of the machine running the tests.
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include
hese are described in the
commit message for #3. So this series first adds those tests which pass with
both old and new model. Then later adds some additional tests which only
pass with the new model.
Michael Davidsaver (5):
timer: ds1338 add magic reset for test code
tests: more thorou
When running w/ QTest, allow the tester
to reliably zero time offsets.
Allows tests to read the current time,
and set time, independent of test order.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds1338.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/timer/ds1338.c b/hw
Now redundant to ds-rtc-i2c-test.
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include | 2 --
tests/ds1338-test.c| 75 --
2 files changed, 77 deletions(-)
delete mode 100644 tests/ds1338-test.c
diff --git a/tests/Makefile.include b
in 24 hour mode.
2. wday_offset is always stored for the
local time zone. When the RTC is set
and rtc_utc=1 and the local timezone
has a different day than UTC, then
wday_offset will be off by one.
Signed-off-by: Michael Davidsaver
---
default-configs/arm-softmmu.mak | 2 +-
hw/timer/Makefile
On 02/18/2018 11:39 PM, Thomas Huth wrote:
> On 19.02.2018 05:03, Michael Davidsaver wrote:
>> Test current time and set+get round trip.
>>
>> The set+get test is repeated 4 times. These cases are
>> spread across a single day in an attempt to trigger some potential
On 12/06/2017 05:11 AM, David Gibson wrote:
> On Tue, Dec 05, 2017 at 10:42:25PM -0500, Michael Davidsaver wrote:
>> On 12/05/2017 01:53 AM, David Gibson wrote:
>>> On Sun, Nov 26, 2017 at 03:59:11PM -0600, Michael Davidsaver wrote:
>>>> Signed-off-by: Michael Davi
On 12/06/2017 05:14 AM, David Gibson wrote:
> On Sun, Dec 03, 2017 at 03:15:10PM -0600, Michael Davidsaver wrote:
>> On 11/29/2017 11:13 PM, David Gibson wrote:
>>> On Sun, Nov 26, 2017 at 03:59:03PM -0600, Michael Davidsaver wrote:
>>>> Support for: ds1307, ds133
', and 1 second otherwise.
Comparision of day of the week is still exact, so there is a chance of
a false positive if the test is running across midnight UTC.
Michael Davidsaver (14):
tests: more thorough tests of ds1338
timer: ds1338 use registerfields.h
timer: ds1338 persist 12-hour mode sel
redundant to ds-rtc-*-test.c
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include | 2 --
tests/ds1338-test.c| 75 --
2 files changed, 77 deletions(-)
delete mode 100644 tests/ds1338-test.c
diff --git a/tests/Makefile.include b
instead of a read-modify-write, do direct translation
of device registers to struct tm members.
This new ds1338_update() is the reverse of
the existing capture_current_time().
Simplifies later handling of CENTURY bit in
similar Dallas RTC chips.
Signed-off-by: Michael Davidsaver
---
hw/timer
Signed-off-by: Michael Davidsaver
---
hw/timer/ds-rtc.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/hw/timer/ds-rtc.c b/hw/timer/ds-rtc.c
index 2df1bce3f8..5a4df1b115 100644
--- a/hw/timer/ds-rtc.c
+++ b/hw/timer/ds-rtc.c
@@ -70,6 +70,7 @@ typedef
Signed-off-by: Michael Davidsaver
---
tests/ds-rtc-common.h | 10 +++---
tests/ds-rtc-current-test.c | 9 -
tests/ds-rtc-set-test.c | 6 --
3 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/tests/ds-rtc-common.h b/tests/ds-rtc-common.h
index c8e6c2bc5b
Signed-off-by: Michael Davidsaver
---
tests/ds-rtc-set-test.c | 52 +
1 file changed, 52 insertions(+)
diff --git a/tests/ds-rtc-set-test.c b/tests/ds-rtc-set-test.c
index 35e1a36281..c48406ee2c 100644
--- a/tests/ds-rtc-set-test.c
+++ b/tests/ds
Use names for registers and bits except
for R_CTRL which will be dealt with later,
and isn't modeled anyway.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds1338.c | 84 ++-
1 file changed, 58 insertions(+), 26 deletions(-)
diff --git
Simplify and comment the translation between
registers and struct tm.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds1338.c | 35 +--
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c
index 72a4692d60
Prepare to generalize with a more generic
name.
Keep device name and vmstate name "ds1338"
for compatibility.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds1338.c | 74 +++
1 file changed, 37 insertions(+), 37 deletions(-)
diff
Signed-off-by: Michael Davidsaver
---
default-configs/arm-softmmu.mak | 2 +-
hw/timer/Makefile.objs | 2 +-
hw/timer/{ds1338.c => ds-rtc.c} | 0
3 files changed, 2 insertions(+), 2 deletions(-)
rename hw/timer/{ds1338.c => ds-rtc.c} (100%)
diff --git a/default-configs/arm-softm
> On 02/20/2018 09:44 AM, Michael Davidsaver wrote:
>> On 02/18/2018 11:39 PM, Thomas Huth wrote:
...
>> That magic (together with patch 1/5) is IMHO a little bit ugly. I've hit
>> the same problem with the m48t59 test recently, and I solved it by
>> moving the qte
Test current time and set+get round trip.
Separate current time test from set/get
tests to avoid test order issues.
Signed-off-by: Michael Davidsaver
---
tests/Makefile.include | 4 ++
tests/ds-rtc-common.h | 67 +
tests/ds-rtc-current-test.c | 59
Correctly handle different real weekday in
guest and host timezones.
Allow guest to use any day as start of week
(day 1). eg. Monday instead of Sunday.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds1338.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff
differences from ds1338
* Has alarms (not modeled)
* different control register (not modeled)
* smaller address space (0x20 vs. 0x40)
Signed-off-by: Michael Davidsaver
---
hw/timer/ds-rtc.c | 30 --
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/hw
Need to save HOUR[HOUR12] bit to keep
track of guest selection of 12-hour mode.
Write through current time registers to
achieve this. Will be overwritten
by the next read/latch.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds1338.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions
Add class level handling for address space size
and control register.
Signed-off-by: Michael Davidsaver
---
hw/timer/ds-rtc.c | 63 ---
1 file changed, 46 insertions(+), 17 deletions(-)
diff --git a/hw/timer/ds-rtc.c b/hw/timer/ds-rtc.c
index
On 03/26/2018 02:18 AM, Paolo Bonzini wrote:
> On 24/03/2018 20:24, Michael Davidsaver wrote:
>> Test current time and set+get round trip.
>> Separate current time test from set/get
>> tests to avoid test order issues.
>
> What are these issues? You can start a d
101 - 172 of 172 matches
Mail list logo
