Public bug reported:
qemu-ppc64le version 2.12.0
host machine: x86_64 Arch Linux
I'm currently working on VSX support in libVPX, I'm using qemu to test,
on line 723 of vpx_dsp/ppc/loopfilter_vsx.c, when I change the vec_sub
to vec_subs I get:
qemu: uncaught target signal 4 (Illegal instruction)
Thanks for the reply.
I tried with the -cpu power9 and it works!
However, I tried with -cpu power8 and it does not work. I tried the code
on a real power8 and it works. So -cpu power8 should work
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscrib
t easy :)
thanks in advance !
Luc
___
Qemu-devel mailing list
Qemu-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/qemu-devel
back counts into the same variable.
I wonder... For this test don't you want to keep a plain uint64_t for
callback counts? I have the feeling that this test was made so one can
make sure inline and callback counts match.
Luc
> static bool do_inline, do_callback;
> static bool do_h
On 13:14 Mon 26 Feb , Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier
Reviewed-by: Luc Michel
> ---
> tests/plugin/insn.c | 106 +---
> 1 file changed, 50 insertions(+), 56 deletions(-)
>
> diff --git a/tests/plugin/ins
On 13:14 Mon 26 Feb , Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier
Reviewed-by: Luc Michel
> ---
> tests/plugin/bb.c | 63 +++
> 1 file changed, 26 insertions(+), 37 deletions(-)
>
> diff --git a/tests/plugin/b
Hi Pierrick,
On 13:14 Mon 26 Feb , Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier
> ---
> contrib/plugins/hotblocks.c | 50 ++---
> 1 file changed, 30 insertions(+), 20 deletions(-)
>
> diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hot
On 15:09 Tue 27 Feb , Pierrick Bouvier wrote:
> On 2/27/24 2:54 PM, Luc Michel wrote:
> > Hi Pierrick,
> >
> > On 13:14 Mon 26 Feb , Pierrick Bouvier wrote:
> > > Signed-off-by: Pierrick Bouvier
> > > ---
&
On 14:56 Tue 27 Feb , Pierrick Bouvier wrote:
> Hi Luc,
>
> On 2/27/24 1:35 PM, Luc Michel wrote:
> > Hi Pierrick,
> >
> > On 13:14 Mon 26 Feb , Pierrick Bouvier wrote:
> > > Signed-off-by: Pierrick Bouvier
>
On 14:33 Thu 29 Feb , Alex Bennée wrote:
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Luc Michel writes:
>
> > On 15:09 Tue 27 Feb , Pierrick Bouvier wrote:
>
rt92.c| 1 +
> hw/isa/lpc_ich9.c | 1 -
> hw/timer/hpet.c | 1 -
> target/i386/monitor.c | 1 -
> 9 files changed, 8 insertions(+), 12 deletions(-)
>
> --
> 2.41.0
>
>
For the series:
Reviewed-by: Luc Michel
An access fault is raised when the Access Flag is not set in the
looked-up PTE and the AFFD field is not set in the corresponding context
descriptor. This was already implemented for stage 2. Implement it for
stage 1 as well.
Signed-off-by: Luc Michel
---
hw/arm/smmuv3-internal.h | 1
An access fault is raised when the Access Flag is not set in the
looked-up PTE and the AFFD field is not set in the corresponding context
descriptor. This was already implemented for stage 2. Implement it for
stage 1 as well.
Signed-off-by: Luc Michel
---
v2: drop erroneous submodule
On 16:58 Fri 22 Mar , Philippe Mathieu-Daudé wrote:
> Let clock_set_mul_div() return a boolean value whether the
> clock has been updated or not, similarly to clock_set().
>
> Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Luc Michel
> ---
> include/hw/clock.h |
ck_set() does not call clock_propagate(). clock_update() is a
clock_set() followed by a clock_propagate() if the period changed.
I think this is where the problem comes from here. clock_update() call
won't call clock_propagate() if the clock period does not change.
I think you'll want som
On 09:40 Mon 25 Mar , Luc Michel wrote:
> On 16:58 Fri 22 Mar , Philippe Mathieu-Daudé wrote:
> > Let clock_set_mul_div() return a boolean value whether the
> > clock has been updated or not, similarly to clock_set().
> >
> > Signed-off-by: Philippe Mathie
On 18:15 Sun 31 Mar , Stefan Weil wrote:
> Signed-off-by: Stefan Weil
Reviewed-by: Luc Michel
> ---
> docs/devel/atomics.rst | 2 +-
> docs/devel/ci-jobs.rst.inc | 2 +-
> docs/devel/clocks.rst | 2 +-
> docs/system/i386/sgx.rst | 2 +-
> qapi/qom.json
ture for the hold and exit reset methods.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Luc Michel
> ---
> hw/i2c/allwinner-i2c.c | 3 +--
> hw/sensor/adm1272.c| 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/i2c/allwinner-i2c.c b/hw/i2c
#x27;s reset method directly
>calls the implementation of a different device's method
>
> Signed-off-by: Peter Maydell
Reviewed-by: Luc Michel
(I'm not a coccinelle expert but LGTM)
> ---
> The structure here is a bit of an experiment: usually I would make
> the
--sp-file scripts/coccinelle/reset-type.cocci \
> --keep-comments --smpl-spacing --in-place \
> --include-headers --dir $dir; done
>
> and no manual edits.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Luc Michel
> ---
> incl
On 17:08 Fri 12 Apr , Peter Maydell wrote:
> Update the reset documentation's example code to match the new API
> for the hold and exit phase method APIs where they take a ResetType
> argument.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Luc Michel
> ---
>
't know
> about should be handled like RESET_TYPE_COLD"; switch these
> devices to do that. Then adding a new reset type will only
> need to touch those devices where its behaviour really needs
> to be different from the standard cold reset.
>
> Signed-off-by: Peter Mayde
ht reset type for the ShutdownCause it is passed. This
> allows us to get rid of the device_reset_reason global we
> were using to implement qemu_register_reset_nosnapshotload().
>
> Signed-off-by: Peter Maydell
Reviewed-by: Luc Michel
> ---
> docs/devel/reset.rst| 17 ++
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote:
> Python dictionary are not that expensive. Use a key makes the
> code easier to review.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> tests/acceptance/boot_linux_console.py | 8
&g
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote:
> We want to tests different Raspberry Pi machines. Refactor to
> take the board version as argument.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> tests/acceptance/boot_lin
|
> CANCEL 0
> JOB TIME : 13.18 s
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> tests/acceptance/boot_linux_console.py | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/acceptance/boot_linux_console.
000)
> console: gcc (Debian 8.3.0-7) 8.3.0
> console: GNU ld (GNU Binutils for Debian) 2.31.1
> console: U-Boot> reset
> console: resetting ...
> PASS (0.46 s)
>
> U-Boot is built by the Debian project, see:
> https://wiki.debian.org/InstallingDebianOn/Al
|
> CANCEL 0
> JOB TIME : 12.88 s
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> tests/acceptance/boot_linux_console.py | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/acceptance/boot_linux_console.
line: printk.time=0
> earlycon=uart8250,mmio32,0x3f215040 console=ttyS1,115200
> PASS (12.46 s)
> RESULTS: PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 |
> CANCEL 0
> JOB TIME : 39.60 s
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Mi
bian project, see:
> https://wiki.debian.org/InstallingDebianOn/Allwinner#Creating_a_bootable_SD_Card_with_u-boot
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> tests/acceptance/boot_linux_console.py | 25 +
> 1 file chan
pberry at position (x, y) = (71, 0)
> framebuffer: found raspberry at position (x, y) = (142, 0)
> framebuffer: found raspberry at position (x, y) = (213, 0)
> PASS (11.06 s)
> RESULTS: PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 |
> CANCEL 0
> JOB TI
0 | WARN 0 | INTERRUPT 0 |
> CANCEL 0
> JOB TIME : 1.88 s
>
> [1] https://github.com/pbatard/RPi3#summary
> [2]
> https://github.com/ARM-software/arm-trusted-firmware/blob/v2.1/docs/plat/rpi3.rst
> [3] http://www.skylyrac.net/2018-02-01-port-arm-tf-to-rpi3.html
>
&
RaspiProcessorId board_processor_id(uint32_t board_rev)
> {
> +int proc_id = FIELD_EX32(board_rev, REV_CODE, PROCESSOR);;
You have a superfluous semicolon here.
Apart from that:
Reviewed-by: Luc Michel
> +
> assert(FIELD_EX32(board_rev, REV_CODE, STYLE)); /* Only new styl
{
> +firmware_addr = FIRMWARE_ADDR_2;
Maybe rename those constants too, because now that the version is gone,
we can wonder what those 2 and 3 mean. By the way since this firmware
address seems processor ID specific, maybe you can put them in your
soc_property structure?
A
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> $ qemu-system-arm -M raspi1b -serial stdio \
> -kernel raspberrypi/firmware/boot/kernel.img \
> -dtb raspberrypi/firmware/boot/bcm2708-rpi-b.dtb \
> -append 'printk.time=0 earlycon=pl011,0x20201000 console=ttyAMA0'
> [0.
6, preallocated irqs: 16
> sched_clock: 32 bits at 1000kHz, resolution 1000ns, wraps every
> 2147483647500ns
> clocksource: timer: mask: 0x max_cycles: 0x, max_idle_ns:
> 1911260446275 ns
> bcm2835: system timer (irq = 27)
> Console: colour dummy device 80
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> No code out of bcm2836.c uses (or requires) this declarations.
> Move it locally to the C source file.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> include/hw/arm/bcm2836.h | 12
&
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> The BCM2835 has only one core. Introduce the core_count field to
> be able to use values different than BCM283X_NCPUS (4).
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> hw/arm/bcm2836.c | 7
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> It makes no sense to set enabled-cpus=0 on single core SoCs.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> hw/arm/bcm2836.c | 15 +++
> 1 file changed, 7 insertions(+), 8 deletions(
ller (and mailboxes, etc.) */
> ...
>}
>
> Split the two part, so we can reuse the common part with other
> SoCs from this family.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> hw/arm/bcm2836.c | 23 +++
> 1 file changed,
On 2/17/20 12:45 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> include/hw/arm/bcm2836.h | 1 +
> hw/arm/bcm2836.c | 40
> hw/arm/raspi.c | 2 ++
> 3
o. For backward compatibility, add
> an alias to the previous generic name.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> hw/arm/raspi.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/raspi.c b/hw/arm
ed-by: Richard Henderson
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> hw/arm/raspi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c
> index 90ad9b8115..221356933e 100644
> --- a/hw/arm
ENOSPC;;
> total: 1 errors, 1 warnings, 485 lines checked
>
> Reported-by: Luc Michel
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> Cc: Paolo Bonzini
> ---
> scripts/checkpatch.pl | 5 +
> 1 file changed, 5 insertions(+)
>
needs some modifications. This fix
is not specific to ARM or TCG, but to the gdbstub itself. You also
mention this bug you have with PC, which is not related to the bug you
are fixing here. Could you rewrite it in a more generic way? You simply
need to emphasis the effect of advertising the 'vContSupported+' feature
on GDB.
Thanks.
--
Luc
On 12/9/19 10:03 AM, Philippe Mathieu-Daudé wrote:
> Make the gic a field in the machine state, and instead of filling
> an array of qemu_irq and passing it around, directly call
> qdev_get_gpio_in() on the gic field.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed
H + 4) - 2) / 2
-> (MAX_PACKET_LENGTH / 2) + 1
Now we have MAX_PACKET_LENGTH / 2
But looking at the gdb_monitor_output() function, it performs the
following check:
if (len > (MAX_PACKET_LENGTH/2) - 1)
len = (MAX_PACKET_LENGTH/2) - 1;
So both versions seem actually wrong and can lead to characters being
dropped.
However gdb_monitor_output() is still using a MAX_PACKET_LENGTH sized
local buffer. With this patch it can probably be removed entirely so
that last_packet is written directly (with a g_byte_array aware version
of memtohex?).
--
Luc
> for (;;) {
> if (len <= max_sz) {
> gdb_monitor_output(&gdbserver_state, p, len);
>
d.
>
> Signed-off-by: Damien Hedde
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Luc Michel
> ---
> gdbstub.c | 39 +--
> 1 file changed, 21 insertions(+), 18 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 7b695bd
oad.
>
> Cc: Luc Michel
> Signed-off-by: Jamie Iles
Reviewed-by: Luc Michel
> ---
> hw/arm/armv7m.c | 2 +-
> hw/arm/boot.c| 8 ++--
> hw/core/generic-loader.c | 2 +-
> hw/core/loader.c | 81 +---
>
Use the new semihosting_exit_request instead of a call to exit when
handling a semihosted exit syscall.
Signed-off-by: Luc Michel
---
semihosting/arm-compat-semi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
Use the new semihosting_exit_request instead of a call to exit when
handling a semihosted exit syscall.
Signed-off-by: Luc Michel
---
target/m68k/m68k-semi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
index
Use the new semihosting_exit_request instead of a call to exit when
handling a semihosted exit syscall.
Signed-off-by: Luc Michel
---
target/mips/tcg/sysemu/mips-semi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/mips/tcg/sysemu/mips-semi.c
b/target/mips/tcg
because
it does not allow other CPU threads to exit properly, leading to e.g.
at_exit callbacks being called while other CPUs still run. This can lead
to strange bugs, especially in plugins with a registered at_exit function.
Signed-off-by: Luc Michel
---
qapi/run-state.json|
Add the two function qemu_set_exit_status() and qemu_get_exit_status().
Use qemu_get_exit_status() in main instead of 0 as the return value.
This is in preparation for the semihosting exit request implementation.
Signed-off-by: Luc Michel
---
include/sysemu/sysemu.h | 2 ++
softmmu/main.c
T) used in this case. The CPU is stopped
and returns to the main CPU loop so that no more instruction get
executed (the semihosting_exit_request is declared G_NORETURN).
All targets are converted to use this new function.
Thanks,
Luc
Luc Michel (7):
softmmu: add qemu_[set|get]_exit_status
Use the new semihosting_exit_request instead of a call to exit when
handling a semihosted exit syscall.
Signed-off-by: Luc Michel
---
target/xtensa/xtensa-semi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/xtensa/xtensa-semi.c b/target/xtensa/xtensa-semi.c
index
On 07:37 Tue 21 Jun , Richard Henderson wrote:
> On 6/21/22 05:59, Luc Michel wrote:
> > v2:
> >- fix linux-user compilation. Declare semihosting_exit_request "static
> > inline G_NORETURN" on CONFIG_USER_ONLY side. Use
> > g_assert_not_reac
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> accel/stubs/tcg-stub.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
> index ea4a0dd2
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Provide the callback with consistent state -- always use
> host error numbers. The individual callback can then
> decide if the errno requires conversion for the guest.
>
> Signed-off-by: Richard Henderson
Reviewed
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> We've already loaded cs->env_ptr into a local variable; use it.
> Since env is unconditionally used, we don't need a dummy use.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> se
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Split out the non-ARM specific portions of SYS_OPEN to a
> reusable function. This handles gdb and host file i/o.
>
> Add helpers to validate the length of the filename string.
> Prepare for usage by other semihosting by allowing the
> filename
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Split out the non-ARM specific portions of SYS_CLOSE to a
> reusable function. This handles all GuestFD.
>
> Note that gdb_do_syscall %x reads target_ulong, not int.
>
> Signed-off-by: Richard Henderson
Revie
rw_cb(CPUState *cs, target_ulong ret, target_ulong
> err)
> +{
> +/* Recover the original length from the third argument. */
> +CPUArchState *env G_GNUC_UNUSED = cs->env_ptr;
> +target_ulong args = common_semi_arg(cs, 1);
> +target_ulong arg2;
> +GET_ARG(2);
> +
;
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/syscalls.h | 6
> semihosting/arm-compat-semi.c | 52 +---
> semihosting/syscalls.c | 54 ++
> 3 files cha
rson
Reviewed-by: Luc Michel
> ---
> semihosting/syscalls.c | 16
> 1 file changed, 16 insertions(+)
>
> diff --git a/semihosting/syscalls.c b/semihosting/syscalls.c
> index 5cb12d6adc..eefbae74f1 100644
> --- a/semihosting/syscalls.c
> +++ b/semihosting
ternal type of the offset to int64_t, and
> provide the whence argument, which will be required by
> m68k and nios2 semihosting.
>
> Note that gdb_do_syscall %x reads target_ulong, not int.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/
gt; success result.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/syscalls.h | 3 +++
> semihosting/arm-compat-semi.c | 40 --
> semihosting/syscalls.c | 36 ++
>
On 20:09 Wed 22 Jun , Peter Maydell wrote:
> On Tue, 21 Jun 2022 at 13:59, Luc Michel wrote:
> >
> > Add the semihosting_exit_request function to be used by targets when
> > handling an `exit' semihosted syscall. This function calls gdb_exit to
> > clo
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> The ARM-specific SYS_FLEN isn't really something that can be
> reused by other semihosting apis, but there are parts that can
> reused for the implementation of semihost_sys_fstat.
>
> Signed-off-by: Richard Henderson
Rev
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Split out the non-ARM specific portions of SYS_RENAME to a
> reusable function.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/syscalls.h | 4 +++
> semihosting/ar
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Split out the non-ARM specific portions of SYS_REMOVE to a
> reusable function.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/syscalls.h | 3 +++
> semihosting/ar
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Split out the non-ARM specific portions of SYS_SYSTEM to a
> reusable function.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/syscalls.h | 3 +++
> semihosting/ar
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> These syscalls will be used by m68k and nios2 semihosting.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/syscalls.h | 7 ++
> semihosting/syscal
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> This syscall will be used by m68k and nios2 semihosting.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/syscalls.h | 3 +++
> semihosting/sysca
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> These syscalls will be used by m68k and nios2 semihosting.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/syscalls.h | 7 ++
> semihosting/syscal
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> The implementation of qemu_semihosting_console_inc does not
> defer to gdbstub, but only reads from the fifo in console.c.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihos
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> We don't need CPUArchState, and we do want the CPUState of the
> thread performing the operation -- use this instead of current_cpu.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Miche
ed ("TARGET_FMT_ld")",
> - __func__, err);
> +if (err) {
> +qemu_log("%s: gdb console output failed (%d)", __func__, err);
While you're at it, this qemu_log() call probably lacks a '\n'.
Reviewed-by: Luc Michel
> }
> }
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Allow more than one character to be read at one time.
> Will be used by m68k and nios2 semihosting for stdio.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/console.h | 12 +++
which lets us drop
> semihosting_get_chardev.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/semihost.h | 13 ++---
> semihosting/config.c | 17 +++--
> semihosting/console.c | 31
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Will replace qemu_semihosting_console_{outs,outc},
> but we need more plumbing first.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/console.h | 12
>
iptor
> exposed to the guest.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/guestfd.h | 7 ++--
> semihosting/syscalls.c| 68 +++
> 2 files changed, 72 insertions(+), 3 deletions(-)
&
by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/guestfd.h | 7 +
> include/semihosting/semihost.h | 1 +
> linux-user/main.c | 9 ++
> semihosting/console.c | 2 ++
> semihosting/guestfd.c | 52 ++
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> semihosting/arm-compat-semi.c | 27 ++-
> 1 file changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/semihosting/a
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> semihosting/arm-compat-semi.c | 20
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/semihosting/arm-compat-semi.c
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> This function has been replaced by *_write.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/console.h | 13 -
> linux-user/semihost.c | 16 -
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> This function has been replaced by *_write.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> include/semihosting/console.h | 13 --
> linux-user/semihost.c | 17
>
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> semihosting/arm-compat-semi.c | 11 +--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/semihosting/arm-compat-semi.c b/semi
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> This will be used for implementing the xtensa select_one
> system call. Choose "poll" over "select" so that we can
> reuse Glib's g_poll constants and to avoid struct timeval.
>
> Signed-off-by: Ric
On 13:45 Tue 07 Jun , Richard Henderson wrote:
> Move the ARM and RISCV specific helpers into
> their own header file.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Luc Michel
> ---
> target/arm/common-semi-target.h | 62
> target/riscv
On 08:05 Wed 22 Jun , Richard Henderson wrote:
> On 6/22/22 02:35, Luc Michel wrote:
> > On 13:45 Tue 07 Jun , Richard Henderson wrote:
> > > Split out the non-ARM specific portions of SYS_OPEN to a
> > > reusable function. This handles gdb and host file i/o.
On 14:26 Mon 14 Feb , Luc Michel wrote:
> In some cases, cpu->exit_request can be false after handling the
> interrupt, leading to another TB being executed instead of returning
> to the main loop.
>
> Fix this by returning true unconditionally when in single-ste
emove this limitation.
Signed-off-by: Luc Michel
---
include/hw/elf_ops.h | 25 +-
include/hw/loader.h | 60 ++--
hw/core/loader.c | 60 +++-
3 files changed, 74 insertions(+), 71 deletions(-)
di
On 00:12 Mon 31 Jan , Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Connect the ZynqMP CRF - Clock Reset FPD device.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> include/hw/arm/xlnx-zynqmp.h | 2 ++
>
On 15:01 Thu 03 Feb , Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Add a model of the Xilinx ZynqMP APU Control.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> include/hw/misc/xlnx-zynqmp-apu-ctrl.h | 95 +
&g
> is lost and will not reach guest SW).
>
> Signed-off-by: Francisco Iglesias
Reviewed-by: Luc Michel
> ---
>
> Hi,
>
> I noted this after receiving a review comment (from Peter Maydell) on a
> similar
> issue on the Versal machine while working on the OSP
OBJ_PROP_FLAG_READWRITE);
I think you may have a problem here. cpu->rvbar is used to define the
reset value of the rvbar_elx registers in register_cp_regs_for_features.
This is done at realize time. Changing the rvbar property after realize
would fail to update the rvbar_elx register values.
I guess you should also switch to a .readfn instead of a .resetvalue for
those registers.
--
Luc
> }
>
> #ifndef CONFIG_USER_ONLY
> --
> 2.25.1
>
--
EADWRITE);
I think you may have a problem here. cpu->rvbar is used to define the
reset value of the rvbar_elx registers in register_cp_regs_for_features.
This is done at realize time. Changing the rvbar property after realize
would fail to update the rvbar_elx register values.
I guess you should also switch to a .readfn instead of a .resetvalue for
those registers.
--
Luc
> }
>
> #ifndef CONFIG_USER_ONLY
> --
> 2.25.1
>
--
On 00:12 Mon 31 Jan , Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Connect the ZynqMP APU Control device.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> include/hw/arm/xlnx-zynqmp.h | 4 +++-
>
Hi Edgar,
On 15:01 Thu 03 Feb , Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Connect the ZynqMP APU Control device.
Somehow you don't seem to connect the "wfi_in" pins. I guess it's
because currently QEMU ARM CPUs do not expose a "
1 - 100 of 680 matches
Mail list logo
