On 13:45 Tue 07 Jun , Richard Henderson wrote: > The implementation of qemu_semihosting_console_inc does not > defer to gdbstub, but only reads from the fifo in console.c. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
Reviewed-by: Luc Michel <lmic...@kalray.eu> > --- > include/semihosting/console.h | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/include/semihosting/console.h b/include/semihosting/console.h > index 0238f540f4..4f6217bf10 100644 > --- a/include/semihosting/console.h > +++ b/include/semihosting/console.h > @@ -41,11 +41,10 @@ void qemu_semihosting_console_outc(CPUArchState *env, > target_ulong c); > * qemu_semihosting_console_inc: > * @env: CPUArchState > * > - * Receive single character from debug console. This may be the remote > - * gdb session if a softmmu guest is currently being debugged. As this > - * call may block if no data is available we suspend the CPU and will > - * re-execute the instruction when data is there. Therefore two > - * conditions must be met: > + * Receive single character from debug console. As this call may block > + * if no data is available we suspend the CPU and will re-execute the > + * instruction when data is there. Therefore two conditions must be met: > + * > * - CPUState is synchronized before calling this function > * - pc is only updated once the character is successfully returned > * > -- > 2.34.1 > > > > > To declare a filtering error, please use the following link : > https://www.security-mail.net/reporter.php?mid=5699.629fd40f.c3695.0&r=lmichel%40kalrayinc.com&s=qemu-devel-bounces%2Blmichel%3Dkalrayinc.com%40nongnu.org&o=%5BPATCH+v4+41%2F53%5D+semihosting%3A+Fix+docs+comment+for+qemu_semihosting_console_inc&verdict=C&c=4edb0e3b3a44b5db8e011cdb60e9e8174e2cc844 > --
