Reviewed-by: Konstantin Kostiuk
On Fri, Feb 4, 2022 at 7:20 AM Philippe Mathieu-Daudé via <
qemu-devel@nongnu.org> wrote:
> On 3/2/22 18:33, Paolo Bonzini wrote:
> > From: Marc-André Lureau
> >
> > There are no good reason anymore to keep a pre-built file in the
&
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 8, 2022 at 1:15 PM Konstantin Kostiuk
wrote:
> Signed-off-by: Konstantin Kostiuk
>
> On Thu, Feb 3, 2022 at 8:03 PM Paolo Bonzini wrote:
>
>> From: Marc-André Lureau
>>
>> Signed-off-by: Marc-André Lureau
&
Reviewed-by: Konstantin Kostiuk
On Fri, Feb 4, 2022 at 7:18 AM Philippe Mathieu-Daudé via <
qemu-devel@nongnu.org> wrote:
> On 3/2/22 18:33, Paolo Bonzini wrote:
> > From: Marc-André Lureau
> >
> > Stop using special paths with outdated headers from an old SDK.
&g
Signed-off-by: Konstantin Kostiuk
On Thu, Feb 3, 2022 at 8:16 PM Paolo Bonzini wrote:
> From: Marc-André Lureau
>
> Microsoft midl compiler doesn't take "-options" form, nor does it take
> OUTPUT filename. The -I option seems needless as well (at least with
>
Signed-off-by: Konstantin Kostiuk
On Thu, Feb 3, 2022 at 8:03 PM Paolo Bonzini wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> Signed-off-by: Paolo Bonzini
> ---
> configure| 23 ---
> meso
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 8, 2022 at 1:13 PM Konstantin Kostiuk
wrote:
> Signed-off-by: Konstantin Kostiuk
>
>
>
> On Thu, Feb 3, 2022 at 8:16 PM Paolo Bonzini wrote:
>
>> From: Marc-André Lureau
>>
>> Microsoft midl compiler doesn'
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 8, 2022 at 1:14 PM Konstantin Kostiuk
wrote:
> Signed-off-by: Konstantin Kostiuk
>
> On Thu, Feb 3, 2022 at 8:08 PM Paolo Bonzini wrote:
>
>> From: Marc-André Lureau
>>
>> widl from mingw64-tools and wine can compil
On Sat, Jan 15, 2022 at 2:40 PM Peter Maydell
wrote:
> On Mon, 10 Jan 2022 at 13:46, Konstantin Kostiuk
> wrote:
> >
> > The following changes since commit
> df722e33d5da26ea8604500ca8f509245a0ea524:
> >
> > Merge tag 'bsd-user-arm-pull-request' of
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
index 26c5dd6e0e..9483ccd3b8 100644
--- a/qga/vss-win32/meson.build
+++ b/qga/vss-win32/meson.build
@@ -7,7
volume_name_wchar is allocated by 'void* operator new [](long long unsigned int)
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/requester.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp
index 45133
Hi
On Thu, May 12, 2022 at 8:00 PM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Hi
>
> On Thu, May 12, 2022 at 5:49 PM Konstantin Kostiuk
> wrote:
> >
> > Signed-off-by: Konstantin Kostiuk
> > ---
> > qga/vss-win32/meson.build | 2
On Fri, May 13, 2022 at 1:40 PM luzhipeng wrote:
> Add a new 'guest-get-diskstats' command for report disk io statistics
> for Linux guests. This can be usefull for getting io flow or handling
> IO fault, no need to enter guests.
>
> Signed-off-by: luzhipeng
>
> ---
> Changes v1->v2:
> v1:https
On Fri, May 13, 2022 at 1:50 PM Konstantin Kostiuk
wrote:
>
>
> On Fri, May 13, 2022 at 1:40 PM luzhipeng wrote:
>
>> Add a new 'guest-get-diskstats' command for report disk io statistics
>> for Linux guests. This can be usefull for getting io flow or hand
Reviewed-by: Konstantin Kostiuk
On Fri, May 20, 2022 at 5:20 AM luzhipeng wrote:
> Add a new 'guest-get-diskstats' command for report disk io statistics
> for Linux guests. This can be useful for getting io flow or handling
> IO fault, no need to enter guests.
>
>
Reviewed-by: Konstantin Kostiuk
On Fri, May 13, 2022 at 9:08 PM wrote:
> From: Marc-André Lureau
>
> qemu_open_old() uses qemu_open_internal() which handles special
> "/dev/fdset/" path for monitor fd sets, set CLOEXEC, and uses Error
> reporting (and some O_DI
Reviewed-by: Konstantin Kostiuk
On Fri, May 13, 2022 at 9:08 PM wrote:
> From: Marc-André Lureau
>
> This a more accurate way to lookup the test data, and will allow to move
> the test in a subproject.
>
> Signed-off-by: Marc-André Lureau
> ---
> tests/unit/test-qga
Bus type spaces (Indicates a storage spaces bus) is not
supported, so return it as unknown.
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index d56b5fd2a7..5ca2af9173 100644
--- a
Signed-off-by: Kostiantyn Kostiuk
Reviewed-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael Roth
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c98a61caee..391904bc60 100644
--- a/MAINTAINERS
+++ b/MAINT
From: Kostiantyn Kostiuk
Signed-off-by: Kostiantyn Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Kostiantyn Kostiuk
---
qga/commands-win32.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 4e84afd83b..3dd74fe2
From: Kostiantyn Kostiuk
Signed-off-by: Kostiantyn Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Kostiantyn Kostiuk
---
qga/commands-win32.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 8588fa8633..30925663
From: Kostiantyn Kostiuk
To prevent memory leaks, always try to free initialized variables.
Signed-off-by: Kostiantyn Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Kostiantyn Kostiuk
---
qga/commands-win32.c | 25 -
1 file changed, 12 insertions(+), 13 deletio
The following changes since commit df722e33d5da26ea8604500ca8f509245a0ea524:
Merge tag 'bsd-user-arm-pull-request' of gitlab.com:bsdimp/qemu into staging
(2022-01-08 09:37:59 -0800)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/qga-win32-pull-2022-01-10
From: Kostiantyn Kostiuk
Microsoft suggests this solution in the documentation:
https://docs.microsoft.com/en-us/windows/win32/api/setupapi/nf-setupapi-setupdigetdeviceinterfacedetaila
Signed-off-by: Kostiantyn Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Kostiantyn Kostiuk
---
qga/
From: Kostiantyn Kostiuk
Windows Server 2016, 2019, 2022 are based on Windows 10 and
have the same major and minor versions. So, the only way to
detect the proper version is to use the build number.
Before this commit, the guest agent use the last build number
for each OS, but it causes problems
From: Kostiantyn Kostiuk
In case when the function fails to get parent device data,
the parent_dev_info variable will be initialized, but not freed.
Signed-off-by: Kostiantyn Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Kostiantyn Kostiuk
---
qga/commands-win32.c | 7 +--
1 file
From: Kostiantyn Kostiuk
Windows 10 and 11 have the same major and minor versions.
So, the only way to determine the correct version is to
use the build number.
After this commit, the guest agent will return the proper
"version" and "version-id" for Windows 11. The "pretty-name"
is read from the
From: Kostiantyn Kostiuk
Signed-off-by: Kostiantyn Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Kostiantyn Kostiuk
---
qga/commands-win32.c | 161 +++
1 file changed, 87 insertions(+), 74 deletions(-)
diff --git a/qga/commands-win32.c b/qga/co
Thanks for the information. I will read about the 'b4' tool.
Best Regards,
Konstantin Kostiuk.
On Mon, Jan 10, 2022 at 4:16 PM Peter Maydell
wrote:
> On Mon, 10 Jan 2022 at 14:14, Philippe Mathieu-Daudé
> wrote:
> >
> > On 1/10/22 14:46, Konstantin Kostiuk wrote:
The mingw-w64-tool package in Fedora provides widl tool with a
cross prefix, so adds it automatically for cross builds.
WIDL env can be used to redefine the path to tool.
The same behavior as with windres.
Signed-off-by: Konstantin Kostiuk
---
configure | 3 +++
1 file changed, 3 insertions
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
index 71c50d0866..26c5dd6e0e 100644
--- a/qga/vss-win32/meson.build
+++ b/qga/vss-win32/meson.build
Konstantin Kostiuk (2):
configure: Add cross prefix for widl tool
qga-vss: always build qga-vss.tlb when qga-vss.dll is built
configure | 3 +++
qga/vss-win32/meson.build | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
--
2.25.1
Resend because the series didn't reach the mailing list.
Konstantin Kostiuk (2):
configure: Add cross prefix for widl tool
qga-vss: always build qga-vss.tlb when qga-vss.dll is built
configure | 3 +++
qga/vss-win32/meson.build | 4 ++--
2 files changed, 5 insertions(
The mingw-w64-tool package in Fedora provides widl tool with a
cross prefix, so adds it automatically for cross builds.
WIDL env can be used to redefine the path to tool.
The same behavior as with windres.
Signed-off-by: Konstantin Kostiuk
---
configure | 3 +++
1 file changed, 3 insertions
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
index 71c50d0866..26c5dd6e0e 100644
--- a/qga/vss-win32/meson.build
+++ b/qga/vss-win32/meson.build
Hi Daniel,
This was my mistake when I sent patches.
Thanks for your comment.
Best Regards,
Konstantin Kostiuk.
On Tue, May 3, 2022 at 11:59 AM Daniel P. Berrangé
wrote:
> On Fri, Apr 29, 2022 at 12:10:34AM +0200, Paolo Bonzini wrote:
> > On 4/28/22 20:21, Konstantin Kost
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> No need to setup an environment or to check if the variable is undefined
> manually.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/in
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> No clear reason to make guesses here.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/installer/qemu-ga.wxs | 9 -
> 1 file changed, 9 deletions(-)
>
&
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> Sadly, wixl doesn't have 'elif'.
>
> Signed-off-by: Marc-André Lureau
> ---
> qga/installer/qemu-ga.wxs | 20 +++-
> 1 file changed, 7
Reviewed-by: Konstantin Kostiuk
On Thu, May 5, 2022 at 11:16 AM wrote:
> From: Marc-André Lureau
>
> Use more conventional variables to set the location of pre-built
> DLL/bin.
>
> Signed-off-by: Marc-André Lureau
> ---
> configure | 9
Reviewed-by: Konstantin Kostiuk
On Wed, Aug 24, 2022 at 12:42 PM Bin Meng wrote:
> From: Bin Meng
>
> g_mkdir() is a deprecated API and newer codes should use
> g_mkdir_with_parents().
>
> Signed-off-by: Bin Meng
> ---
>
> qga/commands-posix-ssh.c | 2 +-
> 1 f
On Tue, Feb 14, 2023 at 3:20 AM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Hi
>
> On Mon, Feb 13, 2023 at 8:20 PM Konstantin Kostiuk
> wrote:
>
>> Hi Marc-André,
>>
>> Can you please review this patch set?
>>
>> Best Regards,
>
Reviewed-by: Konstantin Kostiuk
On Thu, Feb 9, 2023 at 2:50 AM Kfir Manor wrote:
> Query VSS backup type number (DWORD) from QEMU Guest Agent VSS Provider
> registry key registry value VssOption
>
> Translate the VSS backup type number (DWORD) into its VSS backup type
> (
Reviewed-by: Konstantin Kostiuk
On Thu, Feb 9, 2023 at 2:50 AM Kfir Manor wrote:
> Adds registry value VssOption with value 1 to QEMU Guest Agent VSS
> Provider service registry key
>
> Signed-off-by: Kfir Manor
> ---
> qga/installer/qemu-ga.wxs | 4
> 1 file
Reviewed-by: Konstantin Kostiuk
On Thu, Feb 9, 2023 at 2:50 AM Kfir Manor wrote:
> Change requester_freeze so that the VSS backup type queried from the
> registry
>
> Signed-off-by: Kfir Manor
> ---
> qga/vss-win32/requester.cpp | 3 ++-
> 1 file changed, 2 inse
resolves: rhbz#2167436
fixes: CVE-2023-0664
Signed-off-by: Konstantin Kostiuk
---
qga/installer/qemu-ga.wxs | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 51340f7ecc..feb629ec47 100644
--- a/qga/installer/qemu-ga.wxs
+++ b/qga
Konstantin Kostiuk (2):
qga/win32: Remove change action from MSI installer
qga/win32: Use rundll for VSS installation
qga/installer/qemu-ga.wxs | 11 ++-
qga/vss-win32/install.cpp | 9 +
qga/vss-win32/qga-vss.def | 2 ++
3 files changed, 17 insertions(+), 5 deletions
Add specific an entry points for rundll which is
just a wrapper for COMRegister/COMUnregister functions.
resolves: rhbz#2167436
fixes: CVE-2023-0664
Signed-off-by: Konstantin Kostiuk
---
qga/installer/qemu-ga.wxs | 10 +-
qga/vss-win32/install.cpp | 9 +
qga/vss-win32/qga
On Tue, Feb 21, 2023 at 10:15 AM Philippe Mathieu-Daudé
wrote:
> On 20/2/23 18:41, Konstantin Kostiuk wrote:
> > resolves: rhbz#2167436
>
> "You are not authorized to access bug #2167436."
>
> > fixes: CVE-2023-0664
>
> This commit description is rather s
e custom action also leverages cmd.exe
to run qemu-ga.exe in line 134 and 142 which causes an interactive command
shell to spawn even though the MSI is set to be non-interactive on line 53.
v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-02/msg05661.html
v1 -> v2:
Add explanation into comm
curity issue.
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167423
fixes: CVE-2023-0664
Signed-off-by: Konstantin Kostiuk
Reviewed-by: Yan Vugenfirer
---
qga/installer/qemu-ga.wxs | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index
COMRegister/COMUnregister functions with proper arguments.
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167423
fixes: CVE-2023-0664
Signed-off-by: Konstantin Kostiuk
Reviewed-by: Yan Vugenfirer
---
qga/installer/qemu-ga.wxs | 10 +-
qga/vss-win32/install.cpp | 9 +
qga
Reviewed-by: Konstantin Kostiuk
On Mon, Oct 31, 2022 at 10:12 AM Philippe Mathieu-Daudé
wrote:
> On 31/10/22 05:40, Brad Smith wrote:
> > qga: Add initial OpenBSD support
> >
> > Signed-off-by: Brad Smith
> > ---
> > meson.build | 2 +-
> > q
ips stuff has
> > been converted, since we now do not have to mix C and C++ linkage
> anymore?
>
> Oh I guess I got it, we only need to link qga.exe as a standalone binary
> unrelated to the qemu-system/user binaries, so we can simplify most of
> the linkage?
>
>
Hi All,
Currently, we need C++ only for the VSS part of Windows Guest Agent.
Anyway, the VSS source is fully based on Windows API, so in general,
we can rewrite it to C.
Best Regards,
Konstantin Kostiuk.
Reviewed-by: Konstantin Kostiuk
On Wed, Nov 9, 2022 at 7:37 PM Thomas Huth wrote:
> If configuring with "--disable-system --disable-user --enable-guest-agent"
> the linking currently fails with:
>
> qga/qemu-ga.p/commands.c.o: In function `qmp_command_info':
> bui
On Thu, Nov 10, 2022 at 8:25 AM Akihiko Odaki
wrote:
> GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
> defined by MinGW-w64. They are not only unnecessary, but can lead to
> duplicate definition errors at link time with some unknown condition.
>
What version of MinGW-w64 d
Reviewed-by: Konstantin Kostiuk
On Mon, Oct 3, 2022 at 12:58 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
>
>
> On Mon, Oct 3, 2022 at 1:39 PM Alexander Ivanov <
> alexander.iva...@virtuozzo.com> wrote:
>
>> - Fix device path.
>> - F
Reviewed-by: Konstantin Kostiuk
On Mon, Oct 3, 2022 at 12:39 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> In the next patches we are going to add FreeBSD support for QEMU Guest
> Agent. In the result, code in commands-posix.c will be too cumbersome.
>
> Move
Reviewed-by: Konstantin Kostiuk
On Mon, Oct 3, 2022 at 12:39 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> UFS supports FS freezing through ioctl UFSSUSPEND on /dev/ufssuspend.
> Frozen FS can be thawed by closing /dev/ufssuspend file descriptior.
>
> Use g
Reviewed-by: Konstantin Kostiuk
On Mon, Oct 3, 2022 at 12:39 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> Add appropriate shutdown command arguments to qmp_guest_shutdown()
> for FreeBSD.
>
> Reviewed-by: Marc-André Lureau
> Signed-off-by: Alexander
Reviewed-by: Konstantin Kostiuk
On Mon, Oct 3, 2022 at 12:39 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> Replace a dumb function in commands-bsd.c by the code of HW address
> getting.
>
> Reviewed-by: Marc-André Lureau
> Signed-off-by: Alexander Ivanov
Reviewed-by: Konstantin Kostiuk
On Mon, Oct 3, 2022 at 12:54 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
>
>
> On Mon, Oct 3, 2022 at 1:39 PM Alexander Ivanov <
> alexander.iva...@virtuozzo.com> wrote:
>
>> Move qmp_guest_set_user_passw
*/
>> -if (errno == EADDRNOTAVAIL) {
>> -/* The interface doesn't have a hw addr (e.g.
>> loopback). */
>> -g_debug("failed to get MAC address of %s: %s",
>> -ifa->ifa_name, strerror(errno));
>> -} else{
>> -g_warning("failed to get MAC address of %s: %s",
>> - ifa->ifa_name, strerror(errno));
>> -}
>> -
>> -} else {
>> -#ifdef CONFIG_SOLARIS
>> -mac_addr = (unsigned char *) &ifr.ifr_addr.sa_data;
>> -#else
>> -mac_addr = (unsigned char *) &ifr.ifr_hwaddr.sa_data;
>> -#endif
>> +if (obtained) {
>> info->hardware_address =
>> g_strdup_printf("%02x:%02x:%02x:%02x:%02x:%02x",
>> (int) mac_addr[0], (int) mac_addr[1],
>> (int) mac_addr[2], (int) mac_addr[3],
>> (int) mac_addr[4], (int)
>> mac_addr[5]);
>> -
>> info->has_hardware_address = true;
>> }
>> -close(sock);
>> }
>>
>> if (ifa->ifa_addr &&
>> --
>> 2.34.1
>>
>>
> otherwise, lgtm
> Reviewed-by: Marc-André Lureau
>
>
in win32 parts, we have similar behavior, so lgtm
Reviewed-by: Konstantin Kostiuk
>
>
> --
> Marc-André Lureau
>
Reviewed-by: Konstantin Kostiuk
On Fri, Oct 21, 2022 at 1:04 AM Bjørn Forsman
wrote:
> It's useful to know which device was used if/when it fails.
>
> channel-win32.c had this since 2015, with
> c69403fcd4a0cb89f838a212ab71e4a1a3464c95 ("qemu-ga: debug printouts
From: Alexander Ivanov
In the next patch FreeBSD support for guest-network-get-interfaces will be
added. Previously move Linux-specific code of HW address getting to a
separate functions and add a dumb function to commands-bsd.c.
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
.
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Alexander Ivanov
Signed-off-by: Konstantin Kostiuk
---
qga/commands-common.h | 34 +
qga/commands-linux.c | 286 +
qga/commands-posix.c | 287
From: Alexander Ivanov
Move qmp_guest_set_user_password() from __linux__ condition to
(__linux__ || __FreeBSD__) condition. Add command and arguments
for password setting in FreeBSD.
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Alexander Ivanov
Signed-off-by
From: Alexander Ivanov
- Fix device path.
- Fix virtio-serial channel initialization.
- Make the code buildable in FreeBSD.
Reviewed-by: Konstantin Kostiuk
Acked-by: Marc-André Lureau
Signed-off-by: Alexander Ivanov
Signed-off-by: Konstantin Kostiuk
---
meson.build | 2 +-
qga
d-off-by: Bjørn Forsman
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/channel-posix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index 568350ded4..0c5175d957 100644
--- a/qga/channel-posix.c
+++ b/qga/
From: Alexander Ivanov
Replace a dumb function in commands-bsd.c by the code of HW address
getting.
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Alexander Ivanov
Signed-off-by: Konstantin Kostiuk
---
qga/commands-bsd.c | 15 +++
1 file changed
Thanks for the reminder. PR was sent
https://patchew.org/QEMU/20221026175518.2636846-1-kkost...@redhat.com/
Best Regards,
Konstantin Kostiuk.
On Wed, Oct 26, 2022 at 4:25 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> Could you please clarify the status of the
PR was sent
https://patchew.org/QEMU/20221026175518.2636846-1-kkost...@redhat.com/
On Wed, Oct 26, 2022 at 8:31 PM Konstantin Kostiuk
wrote:
> Reviewed-by: Konstantin Kostiuk
>
> On Fri, Oct 21, 2022 at 1:04 AM Bjørn Forsman
> wrote:
>
>> It's useful to know which
From: Alexander Ivanov
UFS supports FS freezing through ioctl UFSSUSPEND on /dev/ufssuspend.
Frozen FS can be thawed by closing /dev/ufssuspend file descriptior.
Use getmntinfo to get a list of mounted FS.
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by
From: Alexander Ivanov
Add appropriate shutdown command arguments to qmp_guest_shutdown()
for FreeBSD.
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Alexander Ivanov
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 7 +++
1 file changed, 7
The following changes since commit 79fc2fb685f35a5e71e23629760ef4025d6aba31:
Merge tag 'trivial-branch-for-7.2-pull-request' of
https://gitlab.com/laurent_vivier/qemu into staging (2022-10-25 11:37:17 -0400)
are available in the Git repository at:
g...@github.com:kostyanf14/qemu.git tags/qg
ning such kinds of apps.
>
>
>
> Cheers,
> Vadim.
>
> On Wed, Aug 31, 2022 at 5:46 PM Konstantin Kostiuk
> wrote:
>
>> CC: Vadim
>>
>> On Wed, Aug 31, 2022 at 10:42 AM Konstantin Kostiuk
>> wrote:
>>
>>> ping
>>>
>>> O
Reviewed-by: Konstantin Kostiuk
On Wed, Jun 15, 2022 at 8:43 PM Akihiko Odaki
wrote:
> Signed-off-by: Akihiko Odaki
> ---
> qga/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index c373fec3ee6..06e507b9979 1006
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 7, 2023 at 10:45 AM Juan Quintela wrote:
> Markus Armbruster wrote:
> > Signed-off-by: Markus Armbruster
> > ---
> > authz/listfile.c | 1 -
> > backends/cryptodev-vhost.c | 1 -
> > b
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 7, 2023 at 10:53 AM Juan Quintela wrote:
> Markus Armbruster wrote:
> > slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED.
> > This macro never existed. The reference got added in commit
> > e3d4d2520
Hi Marc-André,
Can you please review this patch set?
Best Regards,
Konstantin Kostiuk.
On Thu, Feb 9, 2023 at 10:50 AM Kfir Manor wrote:
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/775
>
> The problem, VSS backup type VSS-FULL (the only available VSS backup type
&g
Reviewed-by: Konstantin Kostiuk
On Mon, Feb 13, 2023 at 6:14 PM Pierrick Bouvier <
pierrick.bouv...@linaro.org> wrote:
> Reported when compiling with clang-windows-arm64.
>
> ../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used
> uninitialized when
ping
On Tue, Feb 21, 2023 at 1:41 PM Philippe Mathieu-Daudé
wrote:
> On 21/2/23 12:21, Konstantin Kostiuk wrote:
> > resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167423
> > fixes: CVE-2023-0664
> >
> > CVE Technical details: The cached installer for QEMU
Currently, there is a code freeze in QEMU for release 7.2.
I will merge this after it https://wiki.qemu.org/Planning/7.2
Best Regards,
Konstantin Kostiuk.
On Mon, Dec 12, 2022 at 2:17 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> On 11/29/22 19:38, Andrey Drobys
(
https://github.com/qemu/qemu/blob/ea3a008d2d9ced9c4f93871c823baee237047f93/configure#L1466
)
So, the build process should check the GLib2 version and select libpcre2 or
libpcre.
Best Regards,
Konstantin Kostiuk.
On Mon, Dec 12, 2022 at 2:23 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> w
Reviewed-by: Konstantin Kostiuk
Tested-by: Konstantin Kostiuk
On Tue, Dec 13, 2022 at 5:13 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> According to GLib changelog [1], since version 2.73.2 GLib is using
> libpcre2 instead of libpcre. As a result, qemu-ga MSI
Reviewed-by: Konstantin Kostiuk
Tested-by: Konstantin Kostiuk
Hi Andrey,
Do you expect Event Viewer to be empty by default in the current
implementation?
Currently, all logs that we write in the guest agent do not have "syslog"
domain
so we will have logs only in file.
On Mon, Dec 1
From: Alexander Ivanov
In the next patch ZFS TRIM support for FreeBSD will be added. Move
Linux-specific TRIM code to commands-linux.c file.
Signed-off-by: Alexander Ivanov
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-linux.c | 73
Kostiuk
Tested-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/installer/qemu-ga.wxs | 12 +---
qga/meson.build | 6 ++
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 813d1c6ca6
The following changes since commit edc93f455fa823a9a5fcb3a8da430104c7375a0a:
Revert "hw/loongarch/virt: Add cfi01 pflash device" (2022-12-05 11:24:35
-0500)
are available in the Git repository at:
g...@github.com:kostyanf14/qemu.git tags/qga-pull-2022-12-16
for you to fetch changes up to 1
From: Alexander Ivanov
Use zpool tool for ZFS pools trimming in FreeBSD.
Signed-off-by: Alexander Ivanov
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-bsd.c| 109 ++
qga/commands-common.h | 1 +
2 files
uot; domain is slog()
function. However, this patch allows the interface to be extended.
Note that since slog() is using G_LOG_LEVEL_INFO level, its behaviour
doesn't change.
Originally-by: Yuri Pudgorodskiy
Signed-off-by: Andrey Drobyshev
Reviewed-by: Marc-André Lureau
Reviewed-by: Konsta
From: Kfir Manor
Refactoring code to avoid duplication of creating an empty PCI address code.
Signed-off-by: Kfir Manor
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 20 +---
1 file changed, 13
From: Kfir Manor
Skip getting PCI info from disks type USB and give them an empty PCI address
instead.
Signed-off-by: Kfir Manor
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 12
1 file changed, 8
com/en-us/windows/win32/eventlog/message-text-files
Originally-by: Yuri Pudgorodskiy
Signed-off-by: Andrey Drobyshev
Reviewed-by: Marc-André Lureau
Reviewed-by: Konstantin Kostiuk
Tested-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
configure | 3 +++
qga/inst
From: Brad Smith
qga: Add initial OpenBSD and NetBSD support
Signed-off-by: Brad Smith
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Konstantin Kostiuk
---
meson.build | 2 +-
qga/commands-bsd.c | 5 +
qga/commands-posix.c | 9
Thanks.
You are right. I tested another command and don't see logs in the event
viewer.
PR was sent.
On Fri, Dec 16, 2022 at 5:27 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> On 12/16/22 12:01, Konstantin Kostiuk wrote:
> > Reviewed-by: Konstantin Kost
Kostiuk
Tested-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/installer/qemu-ga.wxs | 12 +---
qga/meson.build | 6 ++
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index e344c38e74
From: Brad Smith
qga: Add initial OpenBSD and NetBSD support
Signed-off-by: Brad Smith
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Konstantin Kostiuk
---
meson.build | 2 +-
qga/commands-bsd.c | 5 +
qga/commands-posix.c | 9
uot; domain is slog()
function. However, this patch allows the interface to be extended.
Note that since slog() is using G_LOG_LEVEL_INFO level, its behaviour
doesn't change.
Originally-by: Yuri Pudgorodskiy
Signed-off-by: Andrey Drobyshev
Reviewed-by: Marc-André Lureau
Reviewed-by: Konsta
The following changes since commit d038d2645acabf6f52fd61baeaa021c3ebe97714:
Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging
(2022-12-16 13:26:09 +)
are available in the Git repository at:
g...@github.com:kostyanf14/qemu.git tags/qga-pull-2022-12-17
for you to fe
From: Kfir Manor
Refactoring code to avoid duplication of creating an empty PCI address code.
Signed-off-by: Kfir Manor
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 20 +---
1 file changed, 13
101 - 200 of 542 matches
Mail list logo
