Signed-off-by: Konstantin Kostiuk <kkost...@redhat.com>


On Thu, Feb 3, 2022 at 8:16 PM Paolo Bonzini <pbonz...@redhat.com> wrote:

> From: Marc-André Lureau <marcandre.lur...@redhat.com>
>
> Microsoft midl compiler doesn't take "-options" form, nor does it take
> OUTPUT filename. The -I option seems needless as well (at least with
> VS15).
>
> It's not clear what was actually used when it was introduced in commit
> b39297aedfabe9.
>
> strings says "Created by MIDL version 7.00.0555 at Fri Dec 21 13:36:39
> 2012".
>
> I doubt the makefile rule actually ever worked.
>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
>  qga/vss-win32/meson.build | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
> index 90825edef3..78bdf5e74a 100644
> --- a/qga/vss-win32/meson.build
> +++ b/qga/vss-win32/meson.build
> @@ -26,8 +26,7 @@ if midl.found()
>    gen_tlb = custom_target('gen-tlb',
>                            input: 'qga-vss.idl',
>                            output: 'qga-vss.tlb',
> -                          command: [midl, '-tlb', '-I' +
> config_host['WIN_SDK'],
> -                                     '@INPUT@', '@OUTPUT@'])
> +                          command: [midl, '@INPUT@', '/tlb', '@OUTPUT@'])
>  else
>    gen_tlb = custom_target('gen-tlb',
>                            input: 'qga-vss.tlb',
> --
> 2.34.1
>
>
>
>

Reply via email to