PR was sent
https://patchew.org/QEMU/20221026175518.2636846-1-kkost...@redhat.com/
On Wed, Oct 26, 2022 at 8:31 PM Konstantin Kostiuk <kkost...@redhat.com>
wrote:
> Reviewed-by: Konstantin Kostiuk <kkost...@redhat.com>
>
> On Fri, Oct 21, 2022 at 1:04 AM Bjørn Forsman <bjorn.fors...@gmail.com>
> wrote:
>
>> It's useful to know which device was used if/when it fails.
>>
>> channel-win32.c had this since 2015, with
>> c69403fcd4a0cb89f838a212ab71e4a1a3464c95 ("qemu-ga: debug printouts to
>> help troubleshoot installation"), this brings channel-posix.c up to
>> speed.
>>
>> Signed-off-by: Bjørn Forsman <bjorn.fors...@gmail.com>
>> ---
>> qga/channel-posix.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
>> index 6796a02cff..e6dce985ae 100644
>> --- a/qga/channel-posix.c
>> +++ b/qga/channel-posix.c
>> @@ -138,7 +138,7 @@ static gboolean ga_channel_open(GAChannel *c, const
>> gchar *path,
>> 0
>> );
>> if (fd == -1) {
>> - error_setg_errno(errp, errno, "error opening channel");
>> + error_setg_errno(errp, errno, "error opening channel '%s'",
>> path);
>> return false;
>> }
>> #ifdef CONFIG_SOLARIS
>> @@ -163,7 +163,7 @@ static gboolean ga_channel_open(GAChannel *c, const
>> gchar *path,
>> assert(fd < 0);
>> fd = qga_open_cloexec(path, O_RDWR | O_NOCTTY | O_NONBLOCK, 0);
>> if (fd == -1) {
>> - error_setg_errno(errp, errno, "error opening channel");
>> + error_setg_errno(errp, errno, "error opening channel '%s'",
>> path);
>> return false;
>> }
>> tcgetattr(fd, &tio);
>> --
>> 2.36.2
>>
>>
