Re: [Qemu-devel] [PATCH] block/qcow.c : return real error code in qcow_open

2012-01-24 Thread Kevin Wolf
Am 15.12.2011 11:14, schrieb Li Zhi Hui: > Signed-off-by: Li Zhi Hui > --- > block/qcow.c | 56 +--- > 1 files changed, 37 insertions(+), 19 deletions(-) Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v2] block: Use bdrv functions to replace file operation in qcow.c

2012-01-24 Thread Kevin Wolf
Am 21.11.2011 08:40, schrieb Li Zhi Hui: > Since common file operation functions lack of error detection and use much > more I/O syscalls, > so change them to bdrv series functions and reduce I/O request. > > v2: avoid malloc a large memory > v1: convert file operation functions to bdrv function

Re: [Qemu-devel] [PATCH] scsi: restrict buffer length to req->cmd.xfer for responses to INQUIRY commands.

2012-01-24 Thread Kevin Wolf
Am 23.01.2012 18:15, schrieb Thomas Higdon: > This prevents the emulated SCSI device from trying to DMA more bytes to the > initiator than are expected. Without this, the SCRIPTS code in the emulated > LSI > device eventually raises a DMA interrupt for a data overrun when an INQUIRY > command whos

Re: [Qemu-devel] KVM call agenda for Tuesday 24

2012-01-24 Thread Kevin Wolf
Am 24.01.2012 15:08, schrieb Anthony Liguori: > On 01/24/2012 08:03 AM, Paolo Bonzini wrote: >> On 01/24/2012 02:57 PM, Anthony Liguori wrote: Please send in any agenda items you are interested in covering. >>> >>> I don't have anything pressing. I vote to cancel the call. >> >> Nothing that c

Re: [Qemu-devel] [PATCH v4 1/6] cutils: extract buffer_is_zero() from qemu-img.c

2012-01-24 Thread Kevin Wolf
Am 18.01.2012 15:59, schrieb Stefan Hajnoczi: > The qemu-img.c:is_not_zero() function checks if a buffer contains all > zeroes. This function will come in handy for zero-detection in the > block layer, so clean it up and move it to cutils.c. > > Note that the function now returns true if the buff

Re: [Qemu-devel] [PATCH v4 2/6] block: add .bdrv_co_write_zeroes() interface

2012-01-24 Thread Kevin Wolf
Am 18.01.2012 15:59, schrieb Stefan Hajnoczi: > The ability to zero regions of an image file is a useful primitive for > higher-level features such as image streaming or zero write detection. > > Image formats may support an optimized metadata representation instead > of writing zeroes into the im

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Kevin Wolf
Am 24.01.2012 21:03, schrieb Eric Blake: > On 01/24/2012 11:16 AM, Luiz Capitulino wrote: >> Libvirt wants to be notified when the guest ejects a medium, so that >> it can update its view of the guest. >> >> This code has been originally written by Daniel Berrange. It adds >> the event to IDE and S

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Kevin Wolf
Am 25.01.2012 13:42, schrieb Luiz Capitulino: > On Wed, 25 Jan 2012 09:41:20 +0100 > Kevin Wolf wrote: > >> Am 24.01.2012 21:03, schrieb Eric Blake: >>> On 01/24/2012 11:16 AM, Luiz Capitulino wrote: >>>> Libvirt wants to be notified when the guest ejects a me

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-25 Thread Kevin Wolf
Am 25.01.2012 14:32, schrieb Paolo Bonzini: > On 01/25/2012 02:23 PM, Kevin Wolf wrote: >>>>> Please, note that this only covers guest initiated ejects, that's, >>>>> the QMP/HMP commands 'eject' and 'change' are not covered. >>>

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Kevin Wolf
Am 25.01.2012 16:57, schrieb Eric Blake: > On 01/24/2012 11:47 PM, ronnie sahlberg wrote: >> Read from an arbitrary filedescriptor inherited from the parent process : >> 9> vnc=127.0.0.1:0 -drive file=iscsi://127.0.0.1/iqn.ronnie.test/1 >> -readconfig /proc/self/fd/9 > > That requires the existenc

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Kevin Wolf
Am 26.01.2012 10:18, schrieb ronnie sahlberg: > Kevin, > > Collissions are bad, but what about > > IF ! STRNCMP (filename, "/proc/self/fd/", 14) THEN > fopen(filename, "r") > ELSE > fdopen(atoi(filename+14), "r") > FI > > modulo better validation for the atio() arguments. > >

Re: [Qemu-devel] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command

2012-01-26 Thread Kevin Wolf
Am 26.01.2012 08:50, schrieb Paolo Bonzini: > On 01/24/2012 06:19 PM, Thomas Higdon wrote: >> I agree that it's better to get this into a more general place. However, >> I wasn't willing to pull the MIN statement up into scsi_send_command >> because I don't understand the interplay between 'len' in

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Kevin Wolf
Am 25.01.2012 23:39, schrieb Ronnie Sahlberg: > This patch adds configuration variables for iSCSI to set > initiator-name to use when logging in to the target, > which type of header-digest to negotiate with the target > and username and password for CHAP authentication. > > This allows specifying

[Qemu-devel] [PATCH 14/22] block: add bdrv_find_backing_image

2012-01-26 Thread Kevin Wolf
From: Marcelo Tosatti Add bdrv_find_backing_image: given a BlockDriverState pointer, and an id, traverse the backing image chain to locate the id. Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 18 ++ block.h |2

[Qemu-devel] [PATCH 06/22] block: add BlockJob interface for long-running operations

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 48 block_int.h | 40 2 files changed, 88 insertions(+), 0 deletions(-) diff --git a/block.c b

[Qemu-devel] [PATCH 18/22] virtio-blk: add virtio_blk_handle_read trace event

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi There already exists a virtio_blk_handle_write trace event as well as completion events. Add the virtio_blk_handle_read event so it's easy to trace virtio-blk requests for both read and write operations. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --

[Qemu-devel] [PATCH 08/22] block: rate-limit streaming operations

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi This patch implements rate-limiting for image streaming. If we've exceeded the bandwidth quota for a 100 ms time slice we sleep the coroutine until the next slice begins. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/stream.c |

[Qemu-devel] [PATCH 04/22] block: check bdrv_in_use() before blockdev operations

2012-01-26 Thread Kevin Wolf
. This patch adds the missing bdrv_in_use() checks so that block migration and image streaming never have the rug pulled out from underneath them. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c|4 blockdev.c | 16 +++- 2 files changed, 19 insertions

[Qemu-devel] [PATCH 20/22] qcow: Return real error code in qcow_open

2012-01-26 Thread Kevin Wolf
From: Li Zhi Hui Signed-off-by: Li Zhi Hui Signed-off-by: Kevin Wolf --- block/qcow.c | 56 +--- 1 files changed, 37 insertions(+), 19 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index b16955d..e0d0b88 100644 --- a/block/qcow.c

[Qemu-devel] [PATCH 03/22] coroutine: add co_sleep_ns() coroutine sleep function

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- Makefile.objs |1 + qemu-coroutine-sleep.c | 38 ++ qemu-coroutine.h |9 + 3 files changed, 48 insertions(+), 0 deletions(-) create mode

[Qemu-devel] [PULL 00/22] Block patches

2012-01-26 Thread Kevin Wolf
The following changes since commit 331636431af32ece373f4b1fb7c3ae9d0615e2a6: vga: compile cirrus_vga in hwlib (2012-01-25 18:32:59 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Gregory Farnum (1): rbd: wire up snapshot removal and rollback f

[Qemu-devel] [PATCH 02/22] block: replace unchecked strdup/malloc/calloc with glib

2012-01-26 Thread Kevin Wolf
Alan Gilbert Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/blkdebug.c |4 ++-- block/blkverify.c |4 ++-- qemu-io.c | 48 3 files changed, 28 insertions(+), 28 deletions(-) diff --git a/block/blkdebug.c b

[Qemu-devel] [PATCH 21/22] qcow: Use bdrv functions to replace file operation

2012-01-26 Thread Kevin Wolf
From: Li Zhi Hui Since common file operation functions lack of error detection and use much more I/O syscalls, so change them to bdrv series functions and reduce I/O request. Signed-off-by: Li Zhi Hui Signed-off-by: Kevin Wolf --- block/qcow.c | 48

[Qemu-devel] [PATCH 22/22] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command

2012-01-26 Thread Kevin Wolf
arge enough for the result of the command. Signed-off-by: Thomas Higdon Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/scsi-disk.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 5d8bf53..11cfe73 100644 --

[Qemu-devel] [PATCH 01/22] rbd: wire up snapshot removal and rollback functionality

2012-01-26 Thread Kevin Wolf
From: Gregory Farnum Signed-off-by: Greg Farnum Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/rbd.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index db5abf2..46a8579 100644 --- a/block/rbd.c

[Qemu-devel] [PATCH 15/22] add QERR_BASE_NOT_FOUND

2012-01-26 Thread Kevin Wolf
From: Marcelo Tosatti This qerror will be raised when a given streaming base (backing file) cannot be found. Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi Acked-by: Luiz Capitulino Signed-off-by: Kevin Wolf --- qapi-schema.json |1 + qerror.c |4

[Qemu-devel] [PATCH 09/22] qmp: add block_stream command

2012-01-26 Thread Kevin Wolf
running streaming operations. Signed-off-by: Stefan Hajnoczi Acked-by: Luiz Capitulino Signed-off-by: Kevin Wolf --- QMP/qmp-events.txt | 29 ++ blockdev.c | 67 hmp-commands.hx| 13 ++ hmp.c

[Qemu-devel] [PATCH 12/22] qmp: add query-block-jobs

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Add query-block-jobs, which shows the progress of ongoing block device operations. Signed-off-by: Stefan Hajnoczi Acked-by: Luiz Capitulino Signed-off-by: Kevin Wolf --- blockdev.c | 33 + hmp.c| 36

[Qemu-devel] [PATCH 19/22] block/vdi: Zero unused parts when allocating a new block (fix #919242)

2012-01-26 Thread Kevin Wolf
://bugs.launchpad.net/qemu/+bug/919242). Now the unused parts of the new block which are before and after the data are always filled with zero, so it is no longer necessary to zero the whole block with g_malloc0. I also updated the copyright comment. Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 11/22] qmp: add block_job_cancel command

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Add block_job_cancel, which stops an active block streaming operation. When the operation has been cancelled the new BLOCK_JOB_CANCELLED event is emitted. Signed-off-by: Stefan Hajnoczi Acked-by: Luiz Capitulino Signed-off-by: Kevin Wolf --- QMP/qmp-events.txt | 24

[Qemu-devel] [PATCH 17/22] docs: describe live block operations

2012-01-26 Thread Kevin Wolf
From: Marcelo Tosatti Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- docs/live-block-ops.txt | 58 +++ 1 files changed, 58 insertions(+), 0 deletions(-) create mode 100644 docs/live-block-ops.txt

[Qemu-devel] [PATCH 13/22] blockdev: make image streaming safe across hotplug

2012-01-26 Thread Kevin Wolf
igned-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- blockdev.c | 38 ++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index d026cd4..2fa0151 100644 --- a/blockdev.c +++ b/blockdev.c @@ -202,6 +202,37 @@

[Qemu-devel] [PATCH 10/22] qmp: add block_job_set_speed command

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Add block_job_set_speed, which sets the maximum speed for a background block operation. Signed-off-by: Stefan Hajnoczi Acked-by: Luiz Capitulino Signed-off-by: Kevin Wolf --- blockdev.c | 25 + hmp-commands.hx | 14

[Qemu-devel] [PATCH 05/22] block: make copy-on-read a per-request flag

2012-01-26 Thread Kevin Wolf
d-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 49 ++--- block.h |2 ++ block_int.h |3 +++ trace-events |3 ++- 4 files changed, 45 insertions(+), 12 deletions(-) diff --git a/block.c b/block.c index 43

[Qemu-devel] [PATCH 07/22] block: add image streaming block job

2012-01-26 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- Makefile.objs |1 + block/stream.c | 133 block_int.h|3 + trace-events |4 ++ 4 files changed, 141 insertions(+), 0 deletions

[Qemu-devel] [PATCH 16/22] block: add support for partial streaming

2012-01-26 Thread Kevin Wolf
From: Marcelo Tosatti Add support for streaming data from an intermediate section of the image chain (see patch and documentation for details). Signed-off-by: Marcelo Tosatti Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/stream.c | 91

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-27 Thread Kevin Wolf
Am 26.01.2012 18:57, schrieb Luiz Capitulino: > On Wed, 25 Jan 2012 10:42:04 -0200 > Luiz Capitulino wrote: > >> On Wed, 25 Jan 2012 09:41:20 +0100 >> Kevin Wolf wrote: >> >>> Am 24.01.2012 21:03, schrieb Eric Blake: >>>> On 01/24/2012 11:16 AM,

Re: [Qemu-devel] [PATCH] To support scsi Virtual Adapter while creating VMDK images

2012-01-27 Thread Kevin Wolf
in OBS: > > https://build.opensuse.org/package/view_file?file=qemu-img-vmdk-scsi.patch&package=virt-utils&project=Virtualization&rev=34c58db02d6bfdb1a9dd49fc3c7fa9d4 > > There were also patches by Soren Hansen and Kevin Wolf back in 2008, by > Pantelis Koukousoulas in 2009, by Aaron Mason and

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-30 Thread Kevin Wolf
Am 30.01.2012 16:18, schrieb Luiz Capitulino: > On Fri, 27 Jan 2012 10:52:15 +0100 > Kevin Wolf wrote: > >> Am 26.01.2012 18:57, schrieb Luiz Capitulino: >>> On Wed, 25 Jan 2012 10:42:04 -0200 >>> Luiz Capitulino wrote: >>> >>>> On

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-31 Thread Kevin Wolf
Am 30.01.2012 16:55, schrieb Paolo Bonzini: > On 01/30/2012 04:43 PM, Kevin Wolf wrote: >>>>>> >>>>>> If we had force=true in the initial eject command, bdrv_close is called, >>>>>> which in turn goes through bdrv_dev_change_media_cb wher

Re: [Qemu-devel] [help]how to make qemu-img utility to support writting file or directory to the image file

2012-01-31 Thread Kevin Wolf
Am 29.01.2012 10:02, schrieb 马磊: > Hi, > qemu-img is only to support create/info and so on whithout writting > operation to the image file. > I have ported the reading operation for a image file form grub2 to > qemu-img. But NTFS document online is not detailed enough, how to do > inorder

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add a section for the host OS and a W32 maintainer

2012-01-31 Thread Kevin Wolf
Am 27.01.2012 18:53, schrieb Stefan Weil: > Up to now, there was no special section for the different > host operating systems used with QEMU. > > scripts/get_maintainer.pl did not show a maintainer for > OS specific files and patches. > > Therefore I added three hosts systems: > > * POSIX for t

Re: [Qemu-devel] [PATCH] multiboot: mh_load_end_addr and mh_bss_end_addr may be zero

2012-01-31 Thread Kevin Wolf
Am 23.01.2012 13:49, schrieb Göran Weinholt: > There are two special cases in the address fields of the multiboot > format. If mh_load_end_addr is zero then the whole image file should > be loaded and if mh_bss_end_addr is zero then there is no bss segment. > With this change it is again possible t

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add a section for the host OS and a W32 maintainer

2012-01-31 Thread Kevin Wolf
Am 31.01.2012 15:40, schrieb Peter Maydell: > On 31 January 2012 13:35, Kevin Wolf wrote: >> Am 27.01.2012 18:53, schrieb Stefan Weil: >>> +Hosts: >>> +-- >>> + >>> +LINUX >>> +L: qemu-devel@nongnu.org >>> +S: Maintained >&

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-01 Thread Kevin Wolf
Am 01.02.2012 00:04, schrieb Charles Arnold: > Thanks Andreas, > > The 'TODO uuid is missing' comment in the patch is from the > original sources (as well as many '//' comments). The vhd footer > and header data structures contain a field for a UUID but no code > was ever developed to generate

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-02 Thread Kevin Wolf
Am 01.02.2012 17:51, schrieb Charles Arnold: >>>> On 2/1/2012 at 05:15 AM, in message <4f292cd0.20...@redhat.com>, Kevin Wolf > wrote: >> Am 01.02.2012 00:04, schrieb Charles Arnold: >>> Thanks Andreas, >>> >>> The 'TODO uuid is missing&

Re: [Qemu-devel] [RFC Patch 0/7]Qemu: Dynamic host pagecache change

2012-02-02 Thread Kevin Wolf
Am 01.02.2012 23:41, schrieb Eric Blake: > On 01/31/2012 08:05 PM, Supriya Kannery wrote: >> For changing host pagecache setting of a running VM, it is >> important to have a safe way of reopening its image file. >> >> Following patchset introduces: >> * a generic way to reopen image files saf

Re: [Qemu-devel] [RFC Patch 3/7]Qemu: Cmd "block_set_hostcache" for dynamic cache change

2012-02-02 Thread Kevin Wolf
Am 02.02.2012 01:09, schrieb Michael Roth: > On 01/31/2012 09:06 PM, Supriya Kannery wrote: >> New command "block_set_hostcache" added for dynamically changing >> host pagecache setting of a block device. >> >> Usage: >> block_set_hostcache >> = block device >> = on/off >> >> Exampl

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Kevin Wolf
Am 03.02.2012 01:16, schrieb Charles Arnold: > Next version of the patch with fixes, cleanups, and suggestions. > - Charles > > > The Virtual Hard Disk Image Format Specification allows for three > types of hard disk formats, Fixed, Dynamic, and Differencing. Qemu > currently only supports Dyna

Re: [Qemu-devel] [PATCH v4 2/6] block: add .bdrv_co_write_zeroes() interface

2012-02-06 Thread Kevin Wolf
Am 06.02.2012 16:50, schrieb Stefan Hajnoczi: > On Tue, Jan 24, 2012 at 3:16 PM, Kevin Wolf wrote: >>> +/* >>> + * Efficiently zero a region of the disk image. Note that this is a >>> regular >>> + * I/O request like read or write and should have a reasona

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Kevin Wolf
Am 06.02.2012 17:22, schrieb Charles Arnold: >>>> On 2/6/2012 at 08:46 AM, in message <4f2ff5b9.9090...@redhat.com>, Kevin >>>> Wolf > wrote: >> >> Somehow you lost the ret = -EFBIG here. >> >> Otherwise the patch looks good enough fo

[Qemu-devel] [PATCH] vpc: Round up image size during fixed image creation

2012-02-07 Thread Kevin Wolf
s. Signed-off-by: Kevin Wolf --- block/vpc.c | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index db6b14b..6b4816f 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -685,24 +685,21 @@ static int vpc_create(const char

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Kevin Wolf
Am 07.02.2012 11:29, schrieb Ori Mamluk: > Repagent is a new module that allows an external replication system to > replicate a volume of a Qemu VM. > > This RFC patch adds the repagent client module to Qemu. > > > > Documentation of the module role and API is in the patch at > replication/qem

[Qemu-devel] [PATCH 2/2] qcow2: Keep unknown header extension when rewriting header

2012-02-07 Thread Kevin Wolf
If we want header extensions to work as compatible extensions, we can't destroy yet unknown header extensions when rewriting the header (e.g. for changing the backing file). Save all unknown header extensions in a list of blobs and include them in a new header. Signed-off-by: Kevin

[Qemu-devel] [PATCH 1/2] qcow2: Update whole header at once

2012-02-07 Thread Kevin Wolf
same time, this gives us a reusable functions that updates all fields of the qcow2 header and not only the backing file. Signed-off-by: Kevin Wolf --- block/qcow2.c | 154 +++-- block/qcow2.h |1 + 2 files changed, 95 insertions(+), 60 dele

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Kevin Wolf
Am 07.02.2012 15:40, schrieb Paolo Bonzini: > On 02/07/2012 03:06 PM, Ori Mamluk wrote: >> The main issue about it is that the Rephub also needs the other >> direction - to read the protected volume. I get the feeling that with >> live block copy and NBD there's probably something that might fit >>

Re: [Qemu-devel] [PATCH 06/19] gdbstub: Error locations for -gdb

2012-02-07 Thread Kevin Wolf
Am 07.02.2012 15:09, schrieb Markus Armbruster: > Stash away the option argument with add_device_config(), so we still > have its location when we get around to parsing it. > > This doesn't improve any messages I can see just yet, but that'll > change shortly. > > Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 10/19] qemu-char: Chardev open error reporting, !_WIN32 part

2012-02-07 Thread Kevin Wolf
Am 07.02.2012 15:09, schrieb Markus Armbruster: > This part takes care of backends "file", "pipe", "pty" and "stdio". > Unlike many other backends, these leave open error reporting to their > caller. Because the caller doesn't know what went wrong, this results > in a pretty useless error message.

Re: [Qemu-devel] [PATCH 00/19] Fix and improve chardev open error messages

2012-02-07 Thread Kevin Wolf
op. I also think that introducing Error** to these functions can (or actually should) be a separate step. Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH 0/2] qcow2: Rework header updates

2012-02-07 Thread Kevin Wolf
improvements are a prerequisite for any qcow3 code. Kevin Wolf (2): qcow2: Update whole header at once qcow2: Keep unknown header extension when rewriting header block/qcow2.c | 194 +++-- block/qcow2.h |9 +++ 2 files changed, 143

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Kevin Wolf
Am 08.02.2012 07:10, schrieb Ori Mamluk: > On 07/02/2012 17:47, Paolo Bonzini wrote: >> On 02/07/2012 03:48 PM, Ori Mamluk wrote: The current streaming code in QEMU only deals with the former. Streaming to a remote server would not be supported. >>> I need it at the same time. The Re

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Kevin Wolf
Am 08.02.2012 10:47, schrieb Ori Mamluk: > On 08/02/2012 10:55, Kevin Wolf wrote: >> Am 08.02.2012 07:10, schrieb Ori Mamluk: >>> On 07/02/2012 17:47, Paolo Bonzini wrote: >>>> >>>> Why can't QEMU itself stream the full volume in the background, and &

Re: [Qemu-devel] [PATCH v5 0/6] block: zero writes

2012-02-08 Thread Kevin Wolf
Am 07.02.2012 14:27, schrieb Stefan Hajnoczi: > This series adds an interface for efficient writes when data contains all > zeros. It also takes advantage of this new interface by extending the > copy-on-read feature to perform zero-detection. > > The details of efficient zero representations dep

Re: [Qemu-devel] Support for multiboot images in elf64 (EM_X86_64) format

2012-02-08 Thread Kevin Wolf
Am 08.02.2012 10:53, schrieb Goswin von Brederlow: > Stefan Hajnoczi writes: > >> On Sat, Feb 4, 2012 at 5:38 PM, Goswin von Brederlow >> wrote: >>> Description: Allow 64bit elf binaries in multiboot format >>> This patch allows 64bit elf files with multiboot header to be loaded. >>> The entr

Re: [Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

2012-02-08 Thread Kevin Wolf
Am 20.12.2011 10:03, schrieb Dong Xu Wang: > From: Dong Xu Wang > > On some platforms, __LINE__ will not expand to real number in > QEMU_BUILD_BUG_ON, > so if using QEMU_BUILD_BUG_ON twice, compiler will report errors. This patch > will > fix it. > > BTW, I got error message on RHEL 6.1/gcc 4.

Re: [Qemu-devel] [RFC Patch 5/7]Qemu: raw-posix image file reopen

2012-02-08 Thread Kevin Wolf
Am 01.02.2012 04:07, schrieb Supriya Kannery: > raw-posix driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. > > Signed-off-by: Supriya Kannery > > Index: qemu/block/raw.c > ===

Re: [Qemu-devel] [RFC Patch 6/7]Qemu: raw-win32 image file reopen

2012-02-08 Thread Kevin Wolf
Am 01.02.2012 04:07, schrieb Supriya Kannery: > win32 driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. > > Signed-off-by: Supriya Kannery > > Index: qemu/block/raw-win32.c > =

Re: [Qemu-devel] [RFC Patch 4/7]Qemu: Framework for reopening image files safely

2012-02-08 Thread Kevin Wolf
Am 01.02.2012 04:06, schrieb Supriya Kannery: > Struct BDRVReopenState along with three reopen related functions > introduced for handling reopening of images safely. This can be > extended by each of the block drivers to reopen respective > image files. > > Signed-off-by: Supriya Kannery > > In

Re: [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-02-09 Thread Kevin Wolf
Am 30.01.2012 23:29, schrieb Alexander Graf: > When using Windows 8 with an AHCI disk drive, it issues a blue screen. > The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not > supported by our ATA implementation, but Windows expects it to be there. Is there anything that makes Window

Re: [Qemu-devel] [PATCH] AHCI: Masking of IRQs actually masks them

2012-02-09 Thread Kevin Wolf
Am 30.01.2012 23:29, schrieb Alexander Graf: > When masking IRQ lines, we should actually mask them out and not declare > them active anymore. Once we mask them in again, they are allowed to trigger > again. > > Signed-off-by: Alexander Graf > --- > hw/ide/ahci.c |2 ++ > 1 files changed, 2

Re: [Qemu-devel] [PATCH] AHCI: Fix port reset race

2012-02-09 Thread Kevin Wolf
Am 30.01.2012 23:29, schrieb Alexander Graf: > bdrv_aio_cancel() can trigger bdrv_aio_flush() which makes all aio > that is currently in flight finish. So what we do is: > > port reset > detect ncq in flight > cancel ncq > delete ncq sg list > > at which point we have double freed the sg

Re: [Qemu-devel] [PATCH] sheepdog: fix co_recv coroutine context

2012-02-09 Thread Kevin Wolf
Am 30.01.2012 18:10, schrieb MORITA Kazutaka: > The co_recv coroutine has two things that will try to enter it: > > 1. The select(2) read callback on the sheepdog socket. > 2. The aio_add_request() blocking operations, including a coroutine > mutex. > > This patch fixes it by setting NUL

Re: [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-02-09 Thread Kevin Wolf
Am 09.02.2012 15:49, schrieb Alexander Graf: > > On 09.02.2012, at 15:28, Kevin Wolf wrote: > >> Am 30.01.2012 23:29, schrieb Alexander Graf: >>> When using Windows 8 with an AHCI disk drive, it issues a blue screen. >>> The reason is that WIN_SECURITY_FR

Re: [Qemu-devel] [PATCH 10/19] qemu-char: Chardev open error reporting, !_WIN32 part

2012-02-09 Thread Kevin Wolf
Am 09.02.2012 16:16, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 07.02.2012 15:09, schrieb Markus Armbruster: >>> This part takes care of backends "file", "pipe", "pty" and "stdio". >>> Unlike many other backen

[Qemu-devel] [PULL 00/15] Block patches

2012-02-10 Thread Kevin Wolf
AHCI: Masking of IRQs actually masks them Charles Arnold (1): vpc: Add support for Fixed Disk type Dong Xu Wang (1): rewrite QEMU_BUILD_BUG_ON Kevin Wolf (3): vpc: Round up image size during fixed image creation qcow2: Update whole header at once qcow2: Keep unknown

[Qemu-devel] [PATCH 01/15] cutils: extract buffer_is_zero() from qemu-img.c

2012-02-10 Thread Kevin Wolf
the double-negatives (i.e. !is_not_zero()) that the old function can cause in callers. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- cutils.c | 35 +++ qemu-common.h |2 ++ qemu-img.c| 46

[Qemu-devel] [PATCH 15/15] AHCI: Masking of IRQs actually masks them

2012-02-10 Thread Kevin Wolf
From: Alexander Graf When masking IRQ lines, we should actually mask them out and not declare them active anymore. Once we mask them in again, they are allowed to trigger again. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- hw/ide/ahci.c |2 ++ 1 files changed, 2 insertions

[Qemu-devel] [PATCH 09/15] vpc: Round up image size during fixed image creation

2012-02-10 Thread Kevin Wolf
s. Signed-off-by: Kevin Wolf --- block/vpc.c | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index db6b14b..6b4816f 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -685,24 +685,21 @@ static int vpc_create(const char

[Qemu-devel] [PATCH 11/15] qcow2: Keep unknown header extension when rewriting header

2012-02-10 Thread Kevin Wolf
If we want header extensions to work as compatible extensions, we can't destroy yet unknown header extensions when rewriting the header (e.g. for changing the backing file). Save all unknown header extensions in a list of blobs and include them in a new header. Signed-off-by: Kevin

[Qemu-devel] [PATCH 03/15] block: perform zero-detection during copy-on-read

2012-02-10 Thread Kevin Wolf
From: Stefan Hajnoczi Copy-on-Read populates the image file with data read from a backing image. In order to avoid bloating the image file when all zeroes are read we should scan the buffer and perform an optimized zero write operation. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 12/15] rewrite QEMU_BUILD_BUG_ON

2012-02-10 Thread Kevin Wolf
From: Dong Xu Wang On some platforms, __LINE__ will not expand to real number in QEMU_BUILD_BUG_ON, so if using QEMU_BUILD_BUG_ON twice, compiler will report errors. This patch will fix it. BTW, I got error message on RHEL 6.1/gcc 4.4.5. Signed-off-by: Dong Xu Wang Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 05/15] qed: add .bdrv_co_write_zeroes() support

2012-02-10 Thread Kevin Wolf
this for the QED image format is fairly straightforward. The only issue is that when a zero write touches an existing cluster we have to allocate a bounce buffer and perform a regular write. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qed.c | 110

[Qemu-devel] [PATCH 10/15] qcow2: Update whole header at once

2012-02-10 Thread Kevin Wolf
same time, this gives us a reusable functions that updates all fields of the qcow2 header and not only the backing file. Signed-off-by: Kevin Wolf --- block/qcow2.c | 154 +++-- block/qcow2.h |1 + 2 files changed, 95 insertions(+), 60 dele

[Qemu-devel] [PATCH 06/15] qemu-io: add write -z option for bdrv_co_write_zeroes

2012-02-10 Thread Kevin Wolf
From: Stefan Hajnoczi Extend the qemu-io write command with the -z option to call bdrv_co_write_zeroes(). Exposing the zero write interface from qemu-io allows us to write tests that exercise this new block layer interface. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu

[Qemu-devel] [PATCH 08/15] vpc: Add support for Fixed Disk type

2012-02-10 Thread Kevin Wolf
type=fixed [size] Example 2: qemu-img convert -O vpc -o type=fixed While it is also allowed to specify '-o type=dynamic', the default disk type remains Dynamic and is what is used when the type is left unspecified. Signed-off-by: Charles Arnold Signed-off-by: Kevin Wolf --- b

[Qemu-devel] [PATCH 02/15] block: add .bdrv_co_write_zeroes() interface

2012-02-10 Thread Kevin Wolf
may leave the contents of the region indeterminate. That means discarded blocks are not guaranteed to contain zeroes and may contain junk data instead. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 53 +++-- block.h

[Qemu-devel] [PATCH 13/15] AHCI: Fix port reset race

2012-02-10 Thread Kevin Wolf
: port reset detect ncq in flight cancel ncq check if we are really still in flight delete ncq sg list which makes things work and gets rid of the race. Signed-off-by: Alexander Graf Signed-off-by: Kevin Wolf --- hw/ide/ahci.c |5 + 1 files changed, 5 insertions(+), 0 deletions

[Qemu-devel] [PATCH 14/15] sheepdog: fix co_recv coroutine context

2012-02-10 Thread Kevin Wolf
. In future, we should make the sheepdog driver fully coroutine-based and simplify request handling. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index

[Qemu-devel] [PATCH 04/15] qed: replace is_write with flags field

2012-02-10 Thread Kevin Wolf
be hard to distinguish the meaning of each bool. Instead use a flags field with bitmask constants. This will be used when zero write support is added. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qed.c | 15 --- block/qed.h |6 +- trace-events

[Qemu-devel] [PATCH 07/15] iSCSI: add configuration variables for iSCSI

2012-02-10 Thread Kevin Wolf
readconfig iscsi.conf Signed-off-by: Ronnie Sahlberg Signed-off-by: Kevin Wolf --- block/iscsi.c | 139 +++ qemu-config.c | 27 +++ qemu-doc.texi | 54 +- qemu-options.hx | 16 +-- vl.c|8 ++

Re: [Qemu-devel] [RFC 0/5]: QMP: Introduce GUEST_MEDIUM_EJECT & BLOCK_MEDIUM_CHANGED

2012-02-10 Thread Kevin Wolf
Am 10.02.2012 18:04, schrieb Luiz Capitulino: > This reminds me about an earlier try where I did the following, iirc: > > 1. added commands blockdev-tray-open, blockdev-tray-close, > blockdev-medium-insert, > blockdev-medium-remove > 2. added the events: BLOCK_TRAY_OPEN, BLOCK_TRAY_CLOSE, B

Re: [Qemu-devel] [PATCH 1/1] char: Add a QemuChrHandlers struct to initialise chardev handlers

2012-02-10 Thread Kevin Wolf
Am 10.02.2012 18:22, schrieb Anthony Liguori: > On 02/10/2012 11:09 AM, Amit Shah wrote: >> On (Fri) 10 Feb 2012 [07:28:19], Anthony Liguori wrote: >>> On 02/10/2012 07:19 AM, Amit Shah wrote: Instead of passing each handler in the qemu_add_handlers() function, create a struct of handlers

Re: [Qemu-devel] [PATCH 2/3] coroutine: adding control flags (enable/disable) for ucontext compilation

2012-02-13 Thread Kevin Wolf
Am 13.02.2012 15:42, schrieb Alex Barcelo: > Configure tries, as a default, ucontext functions for the > coroutines. But now the user can force its use or disable > it at all (enable and disable flags) > > Signed-off-by: Alex Barcelo I think a better approach would be to have a --coroutines=[uco

Re: [Qemu-devel] [PATCH v4 07/11] pc: add 1.1 machine type

2012-02-14 Thread Kevin Wolf
Am 06.02.2012 22:29, schrieb Hervé Poussineau: > > Signed-off-by: Hervé Poussineau > --- > hw/pc_piix.c | 11 ++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/hw/pc_piix.c b/hw/pc_piix.c > index c06f1b5..400c6b6 100644 > --- a/hw/pc_piix.c > +++ b/hw/pc_piix.c

Re: [Qemu-devel] [PATCH v4 09/11] fdc: check if media rate is correct before doing any transfer

2012-02-14 Thread Kevin Wolf
Am 06.02.2012 22:29, schrieb Hervé Poussineau: > The programmed rate has to be the same as the required rate for the > floppy format ; if that's not the case, the transfer should abort. > This check can be disabled by using the 'check_media_rate' property. > > Save media rate value only if media r

Re: [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation

2012-02-14 Thread Kevin Wolf
Am 06.02.2012 22:29, schrieb Hervé Poussineau: > Here are misc fixes done by VirtualBox team. > With these patches, floppy emulation is now good enough to run Xenix. > > Changes v3->v4: > - added pc-1.1 machine type > - disable media transfer rate check on older machine types > - save/restore medi

Re: [Qemu-devel] [PATCH v4 09/11] fdc: check if media rate is correct before doing any transfer

2012-02-14 Thread Kevin Wolf
Am 14.02.2012 16:28, schrieb Paolo Bonzini: > On 02/14/2012 04:16 PM, Kevin Wolf wrote: >> Juan, Paolo, this is a subsection in a struct array. Does this work >> meanwhile or is it still broken? > > Juan fixed it. Oh, cool. :-) Then I'll apply the other four patches as well. Kevin

Re: [Qemu-devel] [PULL 00/15] Block patches

2012-02-15 Thread Kevin Wolf
Am 10.02.2012 13:47, schrieb Kevin Wolf: > The following changes since commit 57c83dacfe179bf061b8fa79d9553ebabe4d2ff4: > > make: Remove duplicate use of GLIB_CFLAGS (2012-02-09 20:44:38 +0400) > > are available in the git repository at: > git://repo.or.cz/qemu/kev

Re: [Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-16 Thread Kevin Wolf
Am 15.02.2012 15:34, schrieb Anthony Liguori: > Please respond to this note with an '+1', or an Ack, to vote for this icon. +1

Re: [Qemu-devel] [Bug 932487] [NEW] win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Kevin Wolf
Am 16.02.2012 10:34, schrieb Stefan Hajnoczi: > This is interesting because the code is a straightforward usage of > coroutines: > > co = qemu_coroutine_create(bdrv_rw_co_entry); > qemu_coroutine_enter(co, &rwco); <--- boom > > Please make test-coroutine and try ./test-coroutine. That performs

<    1   2   3   4   5   6   7   8   9   10   >