Am 27.01.2012 17:19, schrieb Andreas Färber: > Am 27.01.2012 00:46, schrieb praveen_palad...@dell.com: >> According to VMDK specification, while using virtual scsi adapter, the value >> of adapterType has to be set to "lsilogic" or "buslogic". When the user adds >> "scsi" to the list of qemu-img options (Example: qemu-img create -f vmdk foo >> -o scsi,size=100M) this patch will set the value of adapterType to >> "lsilogic". >> >> When the "scsi" is not passed, the default "ide" value is used. > >> Signed-off-by: Praveen K Paladugu <praveen_palad...@dell.com> > > SoB should be above the patch so that it gets committed. Please cc the > block maintainer, scripts/get_maintainer.pl can help with that. > > We're carrying a pretty similar patch from 2009 in OBS: > > https://build.opensuse.org/package/view_file?file=qemu-img-vmdk-scsi.patch&package=virt-utils&project=Virtualization&rev=34c58db02d6bfdb1a9dd49fc3c7fa9d4 > > There were also patches by Soren Hansen and Kevin Wolf back in 2008, by > Pantelis Koukousoulas in 2009, by Aaron Mason and Alex Graf in 2010; are > these all independent or is someone's SoB missing here?
I think they are all independent. Aaron's patch came closest, it just had some coding style issues (I would fix these myself) and was missing a Signed-off-by (I can't do anything about that). The other patches (just like this one) all didn't allow both buslogic and lsilogic, but hardcoded one of them. Kevin
