Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-06 Thread Kevin Wolf
Am 03.08.2012 00:21, schrieb Corey Bryant: >>> @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...) >>> int ret; >>> int mode = 0; >>> >>> +#ifndef _WIN32 >>> +const char *fdset_id_str; >>> + >>> +/* Attempt dup of fd from fd set */ >>> +if (strstart(name, "/d

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-06 Thread Kevin Wolf
Am 01.08.2012 17:15, schrieb Paolo Bonzini: > Il 01/08/2012 16:59, Kevin Wolf ha scritto: >> Block jobs aren't really different from guests in that respect. Maybe >> the BB needs a second iostatus field that must explicitly be reset, and >> the old one keeps

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-06 Thread Kevin Wolf
Am 02.08.2012 09:20, schrieb Kevin Shanahan: > On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: >> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: >>> On Thu, Aug 02, 2012 at 11:02:42AM +0930, Kevin Shanahan wrote: Set the block driver read_only flag for cdrom de

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-06 Thread Kevin Wolf
Am 06.08.2012 11:44, schrieb Paolo Bonzini: > Il 06/08/2012 11:29, Kevin Wolf ha scritto: >>>>>> Block jobs aren't really different from guests in that respect. Maybe >>>>>> the BB needs a second iostatus field that must explicitly be reset, and >>

Re: [Qemu-devel] [PATCH V2] qemu-img: use QemuOpts instead of QEMUOptionParameter in resize function

2012-08-06 Thread Kevin Wolf
Am 06.08.2012 12:14, schrieb Stefan Hajnoczi: > On Mon, Aug 6, 2012 at 3:18 AM, Dong Xu Wang > wrote: >> >> Signed-off-by: Dong Xu Wang >> --- >> v1->v2: fix param leak. >> >> qemu-img.c | 28 +--- >> 1 files changed, 17 insertions(+), 11 deletions(-) > > Reviewed-by:

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-06 Thread Kevin Wolf
Am 06.08.2012 15:32, schrieb Corey Bryant: > On 08/06/2012 05:15 AM, Kevin Wolf wrote: >> Am 03.08.2012 00:21, schrieb Corey Bryant: >>>>> @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...) >>>>>int ret; >>>>

[Qemu-devel] [PATCH 11/12] qemu-iotests: Be more flexible with image creation options

2012-08-06 Thread Kevin Wolf
. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/039.out |6 +++--- tests/qemu-iotests/common.rc |8 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/039.out b/tests/qemu-iotests/039.out index 8ad570d..155a05e 100644 --- a/tests/qemu-iotests/039

[Qemu-devel] [PATCH 12/12] qemu-img: use QemuOpts instead of QEMUOptionParameter in resize function

2012-08-06 Thread Kevin Wolf
From: Dong Xu Wang Signed-off-by: Dong Xu Wang Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-img.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index b866f80..94a31ad 100644 --- a/qemu-img.c

[Qemu-devel] [PATCH 05/12] qcow2: introduce dirty bit

2012-08-06 Thread Kevin Wolf
table entries. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2.c | 50 +-- block/qcow2.h |8 +++ tests/qemu-iotests/031.out | 20 tests/qemu-iotests/036.out |4 +- 4 files

[Qemu-devel] [PATCH 02/12] qapi: generalize documentation of streaming commands

2012-08-06 Thread Kevin Wolf
From: Paolo Bonzini Talk about background operations in general, rather than specifically about streaming. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hmp-commands.hx |2 +- qapi-schema.json | 17 - 2 files changed, 9 insertions(+), 10 deletions(-) diff

[Qemu-devel] [PATCH 03/12] qemu-iotests: add qed.py image manipulation utility

2012-08-06 Thread Kevin Wolf
to share broken image files without revealing data in bug reports. This has lived in my local repo for a long time but could be useful to others. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/qed.py | 235 + 1 files

[Qemu-devel] [PATCH 06/12] docs: add lazy refcounts bit to qcow2 specification

2012-08-06 Thread Kevin Wolf
From: Stefan Hajnoczi The lazy refcounts bit indicates that this image can take advantage of the dirty bit and that refcount updates can be postponed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- docs/specs/qcow2.txt |7 ++- 1 files changed, 6 insertions(+), 1

[Qemu-devel] [PATCH 07/12] qemu-iotests: ignore qemu-img create lazy_refcounts output

2012-08-06 Thread Kevin Wolf
introduces the lazy_refcounts=on|off option. This ensures git-bisect(1) continues to work. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.rc |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu

[Qemu-devel] [PATCH 08/12] qcow2: implement lazy refcounts

2012-08-06 Thread Kevin Wolf
che=writethrough Update qemu-iotests 031 and 036 since the extension header size changes when we add feature bit table entries. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |5 ++- block/qcow2.c |

[Qemu-devel] [PATCH 04/12] docs: add dirty bit to qcow2 specification

2012-08-06 Thread Kevin Wolf
be an incompatible feature bit. We don't want old programs accessing a file with stale refcounts. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- docs/specs/qcow2.txt |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/

[Qemu-devel] [PATCH 10/12] qemu-iotests: add 039 qcow2 lazy refcounts test

2012-08-06 Thread Kevin Wolf
. Written data can be read back successfully. b. The image file can be repaired and will be marked clean again. c. The image file is automatically repaired when opened read/write. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/039 | 136

[Qemu-devel] [PATCH 09/12] qemu-io: add "abort" command to simulate program crash

2012-08-06 Thread Kevin Wolf
grity test cases. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-io.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 8f3b94b..d0f4fb7 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -1652,6 +1652,17 @@ static const cmdinfo

[Qemu-devel] [PULL 00/12] Block patches

2012-08-06 Thread Kevin Wolf
QEMUOptionParameter in resize function Kevin Wolf (1): qemu-iotests: Be more flexible with image creation options Markus Armbruster (1): ide scsi: Mess with geometry only for hard disk devices Paolo Bonzini (1): qapi: generalize documentation of streaming commands Stefan Hajnoczi (8

[Qemu-devel] [PATCH 01/12] ide scsi: Mess with geometry only for hard disk devices

2012-08-06 Thread Kevin Wolf
From: Markus Armbruster Legacy -drive cyls=... are now ignored completely when the drive doesn't back a hard disk device. Before, they were first checked against a hard disk's limits, then ignored. Signed-off-by: Markus Armbruster Acked-by: Paolo Bonzini Signed-off-by: Kevin Wol

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-09 Thread Kevin Wolf
Am 07.08.2012 10:47, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 02.08.2012 09:20, schrieb Kevin Shanahan: >>> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: >>>> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: >>

Re: [Qemu-devel] [v2 Patch 1/9]block: Framework for reopening image files safely

2012-08-09 Thread Kevin Wolf
Am 09.08.2012 06:26, schrieb Jeff Cody: > On 07/30/2012 05:34 PM, Supriya Kannery wrote: >> Struct BDRVReopenState along with three reopen related functions >> introduced for handling reopening of images safely. This can be >> extended by each of the block drivers to reopen respective >> image file

Re: [Qemu-devel] [v2 Patch 5/9]block: qcow2 image file reopen

2012-08-09 Thread Kevin Wolf
Am 09.08.2012 06:26, schrieb Jeff Cody: > On 07/30/2012 05:35 PM, Supriya Kannery wrote: >> qcow2 driver changes for bdrv_reopen_xx functions to >> safely reopen image files. Reopening of image files while >> changing hostcache dynamically is handled here. >> >> Signed-off-by: Supriya Kannery >> >

Re: [Qemu-devel] ahci live migration

2012-08-09 Thread Kevin Wolf
Am 07.08.2012 18:13, schrieb Andreas Färber: > Hi Jason, > > Am 07.08.2012 18:01, schrieb Jason Baron: >> Hi, >> >> vmstate_ahci has its 'unmigratable' bit set. Gerd suggested that there was >> work >> in this area. Anybody know the status on it? > > That was me working on it. I have a branch co

Re: [Qemu-devel] [PATCH v2] ahci: fix cdrom read corruption

2012-08-09 Thread Kevin Wolf
Am 03.08.2012 21:57, schrieb Jason Baron: > Hi, > > While testing q35 I found data corruption on reads from the cdrom on the ahci > controller. The first patch addresses this issue. I also noticed that there is > a memory leak in the ahci code, which is addressed in the second patch. > > Thanks,

Re: [Qemu-devel] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-09 Thread Kevin Wolf
Am 07.08.2012 18:49, schrieb Eric Blake: > On 08/07/2012 09:58 AM, Corey Bryant wrote: >> This patch adds support that enables passing of file descriptors >> to the QEMU monitor where they will be stored in specified file >> descriptor sets. >> >> A file descriptor set can be used by a client like

Re: [Qemu-devel] [PATCH 11/12] qemu-iotests: Be more flexible with image creation options

2012-08-09 Thread Kevin Wolf
Am 06.08.2012 23:57, schrieb Eric Blake: > On 08/06/2012 03:54 PM, Eric Blake wrote: >> On 08/06/2012 02:44 PM, Kevin Wolf wrote: >>> qemu-iotests already filters out image creation options that may be >>> present or not in order to get the same output in both cases.

Re: [Qemu-devel] [PATCH 0/3] final patches for cache=writeback

2012-08-09 Thread Kevin Wolf
Am 09.08.2012 16:07, schrieb Paolo Bonzini: > Kevin, > > here is a resend of the virtio-blk patches plus the one-liner for > flipping the default cache mode from writethrough to writeback. > > Paolo Bonzini (3): > virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE > virtio-blk: disable write cache i

[Qemu-devel] [PATCH] qemu-iotests: Save some sed processes

2012-08-09 Thread Kevin Wolf
Instead of building a huge pipeline, just pass all expressions to a single sed process. Suggested-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.rc | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/qemu-iotests/common.rc

Re: [Qemu-devel] [PATCH v2 0/4] qcow2: clean-ups around lazy refcounts

2012-08-09 Thread Kevin Wolf
Am 09.08.2012 14:05, schrieb Stefan Hajnoczi: > The qcow2 lazy refcount feature was merged with two pending clean-ups > suggested > by Kevin: > > 1. Ensure that qemu-iotests/check -nocache 039 does not fail. > > 2. Fix qemu-img check output when a dirty image file is opened. It currently >o

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-10 Thread Kevin Wolf
Am 09.08.2012 12:12, schrieb Wenchao Xia: > This patch is the API design. > > Signed-off-by: Wenchao Xia > --- > libqblock.c | 670 > +++ > libqblock.h | 447 +++ > 2 files changed, 1117 insertions(+

Re: [Qemu-devel] [PATCH v8 2/7] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-10 Thread Kevin Wolf
Am 10.08.2012 04:10, schrieb Corey Bryant: > This patch adds support that enables passing of file descriptors > to the QEMU monitor where they will be stored in specified file > descriptor sets. > > A file descriptor set can be used by a client like libvirt to > store file descriptors for the same

Re: [Qemu-devel] [PATCH v8 7/7] block: Enable qemu_open/close to work with fd sets

2012-08-10 Thread Kevin Wolf
Am 10.08.2012 04:10, schrieb Corey Bryant: > When qemu_open is passed a filename of the "/dev/fdset/nnn" > format (where nnn is the fdset ID), an fd with matching access > mode flags will be searched for within the specified monitor > fd set. If the fd is found, a dup of the fd will be returned >

Re: [Qemu-devel] [PATCH v8 0/7] file descriptor passing using fd sets

2012-08-10 Thread Kevin Wolf
Am 10.08.2012 04:10, schrieb Corey Bryant: > libvirt's sVirt security driver provides SELinux MAC isolation for > Qemu guest processes and their corresponding image files. In other > words, sVirt uses SELinux to prevent a QEMU process from opening > files that do not belong to it. > > sVirt provi

[Qemu-devel] [PATCH 05/11] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE

2012-08-10 Thread Kevin Wolf
From: Paolo Bonzini Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with the spec. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/virtio-blk.c | 16 ++-- hw/virtio-blk.h |4 +++- 2 files changed, 17 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH 07/11] blockdev: flip default cache mode from writethrough to writeback

2012-08-10 Thread Kevin Wolf
better idea, with a breakpoint on bdrv_open and all cache choices one by one. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- blockdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index 8669142..7c83baa 100644 --- a/blockdev.c +++ b

[Qemu-devel] [PATCH 03/11] ahci: Fix sglist memleak in ahci_dma_rw_buf()

2012-08-10 Thread Kevin Wolf
epath that tries to free the sglist. Signed-off-by: Jason Baron Signed-off-by: Kevin Wolf --- dma-helpers.c |1 + hw/ide/ahci.c |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index 35cb500..13593d1 100644 --- a/dma-helpers.c +++ b/dma

[Qemu-devel] [PULL 00/11] Block patches

2012-08-10 Thread Kevin Wolf
while handling scsi commands Jason Baron (2): ahci: Fix ahci cdrom read corruptions for reads > 128k ahci: Fix sglist memleak in ahci_dma_rw_buf() Kevin Wolf (1): qemu-iotests: Save some sed processes Paolo Bonzini (3): virtio-blk: support VIRTIO_BLK_F_CONFIG_

[Qemu-devel] [PATCH 01/11] virtio-blk: fix use-after-free while handling scsi commands

2012-08-10 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- hw/virtio-blk.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index f21757e..552b3b6 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -254,6 +254,7 @@ static void virtio_blk_handle_scsi(VirtIOBlockReq

[Qemu-devel] [PATCH 10/11] block: add BLOCK_O_CHECK for qemu-img check

2012-08-10 Thread Kevin Wolf
sts 039 to reflect the new qemu-img check output. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.h|1 + block/qcow2.c |4 ++-- block/qed.c|2 +- qemu-img.c |2 +- tests/qemu-iotests/039.out |6 +

[Qemu-devel] [PATCH 06/11] virtio-blk: disable write cache if not negotiated

2012-08-10 Thread Kevin Wolf
: Kevin Wolf --- hw/virtio-blk.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 97bb4bd..fd8fa90 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -543,6 +543,19 @@ static uint32_t virtio_blk_get_features(VirtIODevice

[Qemu-devel] [PATCH 08/11] qed: mark image clean after repair succeeds

2012-08-10 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qed-check.c | 26 ++ block/qed.c |9 + block/qed.h |5 + 3 files changed, 32 insertions(+), 8 deletions(-) diff --git a/block/qed-check.c b/block/qed-check.c index 5edf607..b473dcd 100644 --- a/block

[Qemu-devel] [PATCH 09/11] qcow2: mark image clean after repair succeeds

2012-08-10 Thread Kevin Wolf
: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2.c | 28 +++- 1 files changed, 15 insertions(+), 13 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index fd5e214..5896fd6 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -270,6 +270,20 @@ static int

[Qemu-devel] [PATCH 11/11] qemu-iotests: skip 039 with ./check -nocache

2012-08-10 Thread Kevin Wolf
From: Stefan Hajnoczi When the qemu-io --nocache option is used the 039 test case cannot abort QEMU at a point where the image is dirty. Skip the test case. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/039 |1 + tests/qemu-iotests/common.rc

[Qemu-devel] [PATCH 02/11] ahci: Fix ahci cdrom read corruptions for reads > 128k

2012-08-10 Thread Kevin Wolf
ulate_sglist() to take a new 3rd offset argument, so that the sglist is property initialized. I've tested this patch using 'dd' testing, and Fedora 17 now correctly boots and installs on q35 with the cdrom ahci controller. Signed-off-by: Jason Baron Tested-by: Andreas Färber Si

[Qemu-devel] [PATCH 04/11] qemu-iotests: Save some sed processes

2012-08-10 Thread Kevin Wolf
Instead of building a huge pipeline, just pass all expressions to a single sed process. Suggested-by: Eric Blake Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- tests/qemu-iotests/common.rc | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH] iov_send_recv(): Handle zero bytes case even if OS does not

2012-08-13 Thread Kevin Wolf
Am 12.08.2012 12:32, schrieb Michael Tokarev: > On 12.08.2012 01:24, Peter Maydell wrote: >> POSIX allows sendmsg() and recvmsg() to fail EMSGSIZE if passed a zero >> msg.msg_iovlen (in particular the MacOS X implementation will do this). >> Handle the case where iov_send_recv() is passed a zero by

Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

2012-08-13 Thread Kevin Wolf
Am 10.08.2012 19:48, schrieb Benoît Canet: > Le Tuesday 07 Aug 2012 à 20:30:09 (+), Blue Swirl a écrit : >> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet wrote: >>> Signed-off-by: Benoit Canet >>> --- >>> block/quorum.c | 62 >>> >>>

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Kevin Wolf
Am 12.08.2012 04:48, schrieb Kevin Shanahan: > So qmp_change_blockdev uses bdrv_is_read_only() to check whether to > try and open the backing file read only, which uses the ->read_only > member of struct BlockDriverState to decide whether to pass the > BDRV_O_RDRW flag to qmp_bdrv_open_encypted() a

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-13 Thread Kevin Wolf
Am 09.08.2012 15:02, schrieb Bharata B Rao: > block: Support GlusterFS as a QEMU block backend. > > From: Bharata B Rao > > This patch adds gluster as the new block backend in QEMU. This gives > QEMU the ability to boot VM images from gluster volumes. Its already > possible to boot from VM image

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Kevin Wolf
Am 13.08.2012 13:57, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 12.08.2012 04:48, schrieb Kevin Shanahan: >>> So qmp_change_blockdev uses bdrv_is_read_only() to check whether to >>> try and open the backing file read only, which uses the -&

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-14 Thread Kevin Wolf
Am 14.08.2012 06:38, schrieb Bharata B Rao: > Kevin, Thanks for your review. I will address all of your comments > in the next iteration, but have a few questions/comments on the others... > > On Mon, Aug 13, 2012 at 02:50:29PM +0200, Kevin Wolf wrote: >>> +static int parse_s

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-14 Thread Kevin Wolf
Am 14.08.2012 11:34, schrieb Bharata B Rao: > On Tue, Aug 14, 2012 at 10:29:26AM +0200, Kevin Wolf wrote: >>> >>> Yes, and that will result in port=0, which is default. So this is to >>> cater for cases like gluster://[1:2:3:4:5]:/volname/image >> >> So y

Re: [Qemu-devel] [PATCH v10 0/7] file descriptor passing using fd sets

2012-08-14 Thread Kevin Wolf
Am 13.08.2012 20:39, schrieb Corey Bryant: > > > On 08/13/2012 02:02 PM, Eric Blake wrote: >> On 08/13/2012 08:08 AM, Corey Bryant wrote: >>> libvirt's sVirt security driver provides SELinux MAC isolation for >>> Qemu guest processes and their corresponding image files. In other >>> words, sVirt

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-08-14 Thread Kevin Wolf
Am 14.08.2012 13:13, schrieb Supriya Kannery: > On 08/10/2012 07:15 PM, Corey Bryant wrote: >> >> >> On 07/30/2012 05:34 PM, Supriya Kannery wrote: > >>> +static int raw_reopen_prepare(BlockDriverState *bs, BDRVReopenState >>> **prs, >>> + int flags) >>> +{ >>> + BDRVRawReopenState *raw_rs = g_ma

Re: [Qemu-devel] [PATCH v10 6/7] block: Enable qemu_open/close to work with fd sets

2012-08-14 Thread Kevin Wolf
Am 13.08.2012 16:08, schrieb Corey Bryant: > When qemu_open is passed a filename of the "/dev/fdset/nnn" > format (where nnn is the fdset ID), an fd with matching access > mode flags will be searched for within the specified monitor > fd set. If the fd is found, a dup of the fd will be returned >

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release

2012-08-14 Thread Kevin Wolf
Am 14.08.2012 15:32, schrieb Anthony Liguori: > To be replaced with live block copy. > > Signed-off-by: Anthony Liguori Might be worth adding a deprecation note in qapi-schema.json. > --- > migration.c |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/migra

Re: [Qemu-devel] [PATCH] iscsi: fix race between task completition and task abortion

2012-08-14 Thread Kevin Wolf
Am 14.08.2012 14:11, schrieb Stefan Hajnoczi: > On Tue, Aug 14, 2012 at 1:09 PM, ronnie sahlberg > wrote: >> Is a reply with the text >> >> Acked-by: Ronnie Sahlberg >> >> sufficient ? > > Yes But is this only meant as a question or a real Acked-by and I should pick it up? (Still for 1.2, I gue

Re: [Qemu-devel] [PATCH] iscsi: fix race between task completition and task abortion

2012-08-14 Thread Kevin Wolf
Am 14.08.2012 08:44, schrieb Stefan Priebe: > From: spriebe > > --- > block/iscsi.c | 36 > 1 files changed, 20 insertions(+), 16 deletions(-) It would be nice to have your full name and a valid email address in the From: line (needs an update of your git

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release

2012-08-14 Thread Kevin Wolf
Am 14.08.2012 16:52, schrieb Luiz Capitulino: > On Tue, 14 Aug 2012 15:48:37 +0200 > Kevin Wolf wrote: > >> Am 14.08.2012 15:32, schrieb Anthony Liguori: >>> To be replaced with live block copy. >>> >>> Signed-off-by: Anthony Liguori >> >

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release

2012-08-14 Thread Kevin Wolf
Am 14.08.2012 17:48, schrieb Luiz Capitulino: > On Tue, 14 Aug 2012 17:02:26 +0200 > Kevin Wolf wrote: > >> Am 14.08.2012 16:52, schrieb Luiz Capitulino: >>> On Tue, 14 Aug 2012 15:48:37 +0200 >>> Kevin Wolf wrote: >>> >>>> Am 14.08.2012 15:

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-15 Thread Kevin Wolf
Am 15.08.2012 07:21, schrieb Bharata B Rao: > On Tue, Aug 14, 2012 at 10:29:26AM +0200, Kevin Wolf wrote: >>>>> +static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret, void >>>>> *arg) >>>>> +{ >>>>> +GlusterAIOCB *

Re: [Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Kevin Wolf
Am 15.08.2012 10:13, schrieb ronnie sahlberg: > Acked-by: Ronnie Sahlberg > > > > On Wed, Aug 15, 2012 at 5:09 PM, Stefan Priebe wrote: >> Signed-off-by: Stefan Priebe >> >> --- >> block/iscsi.c | 55 +++ >> 1 files changed, 23 insertions

Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

2012-08-15 Thread Kevin Wolf
Am 14.08.2012 18:56, schrieb Benoît Canet: > Le Monday 13 Aug 2012 à 09:41:00 (+0200), Kevin Wolf a écrit : >> Am 10.08.2012 19:48, schrieb Benoît Canet: >>> Le Tuesday 07 Aug 2012 à 20:30:09 (+), Blue Swirl a écrit : >>>> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Ca

[Qemu-devel] [PATCH] block: Flush parent to OS with cache=unsafe

2012-08-15 Thread Kevin Wolf
only flush_to_disk. It starts to matter when drivers that are not on top implement flush_to_os. Signed-off-by: Kevin Wolf --- block.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 016858b..470bdcc 100644 --- a/block.c +++ b/block.c @@ -3534,7

[Qemu-devel] [PATCH] qemu-iotests: Fix 030 after switch to GenericError

2012-08-15 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/030 |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index cc671dd..f71ab8d 100755 --- a/tests/qemu-iotests/030 +++ b/tests/qemu-iotests/030 @@ -225,8 +225,7 @@ class

Re: [Qemu-devel] TRIM, UNMAP and QCOW2 release of block information - Thin provisioning

2012-08-15 Thread Kevin Wolf
> This has recently been discussed, please search the list for more info > from Kevin Wolf or Paolo Bonzini. > > qcow2 marks the discarded blocks as free and will reuse them in future > allocations. It does *not* discard at the OS level. > > For raw files you can get disc

[Qemu-devel] [PATCH 01/10] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-08-15 Thread Kevin Wolf
From: Corey Bryant Set the close-on-exec flag for the file descriptor received via SCM_RIGHTS. Signed-off-by: Corey Bryant Signed-off-by: Kevin Wolf --- qemu-char.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 382c71e

[Qemu-devel] [PATCH 04/10] block: Convert open calls to qemu_open

2012-08-15 Thread Kevin Wolf
From: Corey Bryant This patch converts all block layer open calls to qemu_open. Note that this adds the O_CLOEXEC flag to the changed open paths when the O_CLOEXEC macro is defined. Signed-off-by: Corey Bryant Signed-off-by: Kevin Wolf --- block/raw-posix.c | 18 +- block

[Qemu-devel] [PULL 00/10] Block patches

2012-08-15 Thread Kevin Wolf
th fd sets monitor: Clean up fd sets on monitor disconnect Kevin Wolf (2): block: Flush parent to OS with cache=unsafe qemu-iotests: Fix 030 after switch to GenericError Stefan Priebe (1): iscsi: Fix NULL dereferences / races between task completion and abort Makefile

[Qemu-devel] [PATCH 08/10] iscsi: Fix NULL dereferences / races between task completion and abort

2012-08-15 Thread Kevin Wolf
From: Stefan Priebe Signed-off-by: Stefan Priebe Acked-by: Ronnie Sahlberg Signed-off-by: Kevin Wolf --- block/iscsi.c | 55 +++ 1 files changed, 23 insertions(+), 32 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 219f927

[Qemu-devel] [PATCH 02/10] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-15 Thread Kevin Wolf
h the existing getfd and closefd QMP commands. Signed-off-by: Corey Bryant Signed-off-by: Kevin Wolf --- monitor.c| 189 ++ qapi-schema.json | 98 qmp-commands.hx | 122

[Qemu-devel] [PATCH 05/10] block: Convert close calls to qemu_close

2012-08-15 Thread Kevin Wolf
From: Corey Bryant This patch converts all block layer close calls, that correspond to qemu_open calls, to qemu_close. Signed-off-by: Corey Bryant Signed-off-by: Kevin Wolf --- block/raw-posix.c | 24 block/raw-win32.c |2 +- block/vmdk.c |4

[Qemu-devel] [PATCH 07/10] monitor: Clean up fd sets on monitor disconnect

2012-08-15 Thread Kevin Wolf
associated with a client disconnect prior to using a passed fd. Signed-off-by: Corey Bryant Signed-off-by: Kevin Wolf --- monitor.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index a4a29b9..ce42466 100644 --- a/monitor.c

[Qemu-devel] [PATCH 09/10] block: Flush parent to OS with cache=unsafe

2012-08-15 Thread Kevin Wolf
only flush_to_disk. It starts to matter when drivers that are not on top implement flush_to_os. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 016858b..470bdcc 100644 --- a

[Qemu-devel] [PATCH 06/10] block: Enable qemu_open/close to work with fd sets

2012-08-15 Thread Kevin Wolf
ned-off-by: Corey Bryant Signed-off-by: Kevin Wolf --- Makefile |6 ++-- cutils.c |5 +++ monitor.c | 86 +++- monitor.h |5 +++ osdep.c| 111 qemu-common

[Qemu-devel] [PATCH 03/10] block: Prevent detection of /dev/fdset/ as floppy

2012-08-15 Thread Kevin Wolf
From: Corey Bryant Signed-off-by: Corey Bryant Signed-off-by: Kevin Wolf --- block/raw-posix.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 0dce089..f606211 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c

[Qemu-devel] [PATCH 10/10] qemu-iotests: Fix 030 after switch to GenericError

2012-08-15 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/030 |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index cc671dd..f71ab8d 100755 --- a/tests/qemu-iotests/030 +++ b/tests/qemu-iotests/030

[Qemu-devel] [PATCH 0/2] vmdk: Fix streamOptimized images

2012-08-16 Thread Kevin Wolf
d.net/qemu/+bug/1028908 [1] http://downloads.puppetlabs.com/learning/learn_puppet_centos_pe2.5.1_ovf.2012.04.18.zip Kevin Wolf (2): vmdk: Fix header structure vmdk: Read footer for streamOptimized images block/vmdk.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) -- 1.7.6.5

[Qemu-devel] [PATCH 2/2] vmdk: Read footer for streamOptimized images

2012-08-16 Thread Kevin Wolf
The footer takes precedence over the header when it exists. It contains the real grain directory offset that is missing in the header. Without this patch, streamOptimized images with a footer cannot be read. Signed-off-by: Kevin Wolf --- block/vmdk.c | 16 1 files changed, 16

[Qemu-devel] [PATCH 1/2] vmdk: Fix header structure

2012-08-16 Thread Kevin Wolf
Commit bb45ded9 swapped gd_offset and rgd_offset. This is wrong. Signed-off-by: Kevin Wolf --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index daee426..9648398 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -57,8 +57,8

[Qemu-devel] [PATCH] Documentation: Warn against qemu-img on active image

2012-08-16 Thread Kevin Wolf
ff-by: Kevin Wolf --- qemu-img.texi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qemu-img.texi b/qemu-img.texi index 77c6d0b..0b363e7 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -4,6 +4,14 @@ usage: qemu-img command [command options] @c man end @end ex

Re: [Qemu-devel] [PATCH for-1.2] virtio-blk: hide VIRTIO_BLK_F_CONFIG_WCE from old machine types

2012-08-16 Thread Kevin Wolf
t VIRTIO_BLK_F_CONFIG_WCE > > Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with > the spec. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Kevin Wolf > > Anthony Liguori reported: > > This broke qemu-test becaus

[Qemu-devel] [PATCH v2 2/2] vmdk: Read footer for streamOptimized images

2012-08-16 Thread Kevin Wolf
The footer takes precedence over the header when it exists. It contains the real grain directory offset that is missing in the header. Without this patch, streamOptimized images with a footer cannot be read. Signed-off-by: Kevin Wolf --- v2: - Enough footer sanity checks, I hope? :-) block

Re: [Qemu-devel] [PATCH] Documentation: Warn against qemu-img on active image

2012-08-16 Thread Kevin Wolf
Am 16.08.2012 14:56, schrieb Eric Blake: > On 08/16/2012 04:00 AM, Peter Maydell wrote: >> On 16 August 2012 10:00, Kevin Wolf wrote: >>> People have repeatedly expected that you can do things like snapshotting >>> an image with qemu-img while a qemu instance is ru

Re: [Qemu-devel] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-08-16 Thread Kevin Wolf
Am 16.08.2012 15:50, schrieb Markus Armbruster: >> Although I'm not sure it qualifies for hard-freeze... > > I didn't tag my series "for-1.2". I understand that fixes to > not-so-important stuff aren't welcome at this time even when they're > really simple. It's a clear bug fix, easy to understa

Re: [Qemu-devel] [PATCH] block: handle filenames with colons better

2012-08-17 Thread Kevin Wolf
Am 17.08.2012 09:15, schrieb Iustin Pop: > On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote: >> On 16.08.2012 18:58, Iustin Pop wrote: >>> Commit 947995c (block: protect path_has_protocol from filenames with >>> colons) introduced a way to handle filenames with colons based on >>> wh

Re: [Qemu-devel] [PATCH V3 2/2] qemu-img: Add json output option to the info command.

2012-08-17 Thread Kevin Wolf
Am 15.08.2012 20:48, schrieb Benoît Canet: > This additionnal --machine=json option make qemu-img info output on > stdout a JSON formated representation of the image informations. > > --machine=json was choosen instead of --format=json because the > info command already have a -f parameter. Which

Re: [Qemu-devel] [PATCH] block: handle filenames with colons better

2012-08-17 Thread Kevin Wolf
Am 17.08.2012 12:05, schrieb Iustin Pop: > On Fri, Aug 17, 2012 at 09:56:35AM +0200, Kevin Wolf wrote: >> Am 17.08.2012 09:15, schrieb Iustin Pop: >>> On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote: >>>> On 16.08.2012 18:58, Iustin Pop wrote: >&g

Re: [Qemu-devel] [PATCH 4/6] sheepdog: don't leak socket file descriptor upon connection failure

2012-08-17 Thread Kevin Wolf
Am 17.08.2012 15:30, schrieb Jim Meyering: > Kevin Wolf wrote: >> Am 16.05.2012 15:07, schrieb Jim Meyering: >>> From: Jim Meyering >>> >>> Signed-off-by: Jim Meyering >> >> Acked-by: Kevin Wolf > > Hi Kevin, > > AFAICS, only one of

[Qemu-devel] [PULL 0/4] Block patches for 1.2-rc1

2012-08-17 Thread Kevin Wolf
The following changes since commit 731dc9ecd4f2c3041538f7eb2d10eee0cb82da1b: Update version to 1.2.0-rc0 (2012-08-16 13:56:34 -0500) are available in the git repository at: http://repo.or.cz/r/qemu/kevin.git for-anthony Kevin Wolf (3): vmdk: Fix header structure vmdk: Read

[Qemu-devel] [PATCH 2/4] vmdk: Read footer for streamOptimized images

2012-08-17 Thread Kevin Wolf
The footer takes precedence over the header when it exists. It contains the real grain directory offset that is missing in the header. Without this patch, streamOptimized images with a footer cannot be read. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody

[Qemu-devel] [PATCH 1/4] vmdk: Fix header structure

2012-08-17 Thread Kevin Wolf
Commit bb45ded9 swapped gd_offset and rgd_offset. This is wrong. Signed-off-by: Kevin Wolf --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index daee426..9648398 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -57,8 +57,8

[Qemu-devel] [PATCH 3/4] Documentation: Warn against qemu-img on active image

2012-08-17 Thread Kevin Wolf
ff-by: Kevin Wolf --- qemu-img.texi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qemu-img.texi b/qemu-img.texi index 77c6d0b..77b2c47 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -4,6 +4,14 @@ usage: qemu-img command [command options] @c man end @end ex

[Qemu-devel] [PATCH 4/4] virtio-blk: hide VIRTIO_BLK_F_CONFIG_WCE from old machine types

2012-08-17 Thread Kevin Wolf
spec. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf Anthony Liguori reported: This broke qemu-test because it changed the pc-1.0 machine type: Setting guest RANDOM seed to 47167 *** Running tests *** Running test /tests/finger-print.sh...OK ---

Re: [Qemu-devel] [PATCH] ATAPI: Add support for ASCQ in sense codes

2012-08-27 Thread Kevin Wolf
Am 31.07.2012 09:14, schrieb Paolo Bonzini: > Il 31/07/2012 04:07, Ronnie Sahlberg ha scritto: >> Add support for setting the ASCQ for SCSI sense codes in the ATAPI driver. >> Use this to set ASCQ==2 for the medium removal prevention that is >> recommended in MMC for this condition. >> >> asc:0x53

Re: [Qemu-devel] [PATCH] ATAPI: STARTSTOPUNIT only eject/load media if powercondition is 0

2012-08-27 Thread Kevin Wolf
Am 31.07.2012 03:28, schrieb Ronnie Sahlberg: > The START STOP UNIT command will only eject/load media if > power condition is zero. > > If power condition is !0 then LOEJ and START will be ignored. > > From MMC (sbc contains similar wordings too) > The Power Conditions field requests the block

Re: [Qemu-devel] qcow2: online snasphots : internal vs external ?

2012-08-27 Thread Kevin Wolf
Am 27.08.2012 11:04, schrieb Stefan Hajnoczi: > On Sun, Aug 26, 2012 at 10:56 AM, Alexandre DERUMIER > wrote: >> It is possible to achieve the same behaviour with external snapshot ? (I >> would like to do it online) >> I don't see how I can rollback to the point of time of the snapshot. > > The

Re: [Qemu-devel] [PATCH for-1.2] qed: refuse unaligned zero writes with a backing file

2012-08-28 Thread Kevin Wolf
Am 28.08.2012 15:25, schrieb Paolo Bonzini: > Il 28/08/2012 15:04, Stefan Hajnoczi ha scritto: >> Zero writes have cluster granularity in QED. Therefore they can only be >> used to zero entire clusters. >> >> If the zero write request leaves sectors untouched, zeroing the entire >> cluster would o

Re: [Qemu-devel] [PATCH v2 for-1.2 0/2] stream: complete early if end of backing file is reached

2012-08-28 Thread Kevin Wolf
Am 28.08.2012 16:26, schrieb Stefan Hajnoczi: > Image streaming hangs if the backing image is smaller than the image file. > The > problem is that the image streaming loop makes no progress when > bdrv_co_is_allocated() returns 0 with pnum=0. More details in the actual > patch. > > I have also

Re: [Qemu-devel] buildbot failure in qemu on block_x86_64_debian_6_0

2012-01-24 Thread Kevin Wolf
Am 24.01.2012 07:53, schrieb Andreas Färber: > Am 24.01.2012 04:12, schrieb q...@buildbot.b1-systems.de: >> The Buildbot has detected a new failure on builder block_x86_64_debian_6_0 >> while building qemu. >> Full details are available at: >> >> http://buildbot.b1-systems.de/qemu/builders/block

  1   2   3   4   5   6   7   8   9   10   >