Am 14.08.2012 08:44, schrieb Stefan Priebe:
> From: spriebe <g...@profihost.ag>
>
> ---
> block/iscsi.c | 36 ++++++++++++++++++++----------------
> 1 files changed, 20 insertions(+), 16 deletions(-)
It would be nice to have your full name and a valid email address in the
From: line (needs an update of your git config) and a more detailed
explanation of the problem that you're fixing.
Having a Signed-off-by line, however, is absolutely required and the
patch can't be merged without it.
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 12ca76d..257f97f 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -76,6 +76,10 @@ static void
> iscsi_abort_task_cb(struct iscsi_context *iscsi, int status, void
> *command_data,
> void *private_data)
> {
> + IscsiAIOCB *acb = (IscsiAIOCB *)private_data;
> +
> + scsi_free_scsi_task(acb->task);
> + acb->task = NULL;
Please use scripts/checkpatch.pl. qemu uses an indentation of four
spaces, more coding style violations follow.
Kevin
