Am 06.08.2012 23:57, schrieb Eric Blake: > On 08/06/2012 03:54 PM, Eric Blake wrote: >> On 08/06/2012 02:44 PM, Kevin Wolf wrote: >>> qemu-iotests already filters out image creation options that may be >>> present or not in order to get the same output in both cases. However, >>> often it only considers the default value of the option. Cover all valid >>> values instead so that ./check -o name=value can be used successfull for >>> all of them. >>> >> >>> +++ b/tests/qemu-iotests/common.rc >>> @@ -110,11 +110,11 @@ _make_test_img() >>> sed -e "s#$IMGFMT#IMGFMT#g" | \ >>> sed -e "s# encryption=off##g" | \ >>> sed -e "s# cluster_size=[0-9]\\+##g" | \ >>> - sed -e "s# table_size=0##g" | \ >>> + sed -e "s# table_size=[0-9]\\+##g" | \ >> >> Technically, use of \+ in a sed expression is undefined by POSIX. > > Oh, one other thing. This wastes a lot of processes by making a huge > pipeline. Why not just do it with one sed process instead? > > sed -e "s# encryption=off##g" \ > -e "s# cluster_size=..." \ > -e ...
Makes sense, I'll send a patch. Kevin
