Public bug reported:
I try to run an emulation with qemu-system-arm under a cpu cortex-m3 but
any execution under the processor result by a segmentation fault.
My command is : qemu-system-arm -m 256 -M versatilepb -cpu cortex-m3
-kernel ~/qemu/wheezy/vmlinuz-3.2.0-4-versatile -initrd
~/qemu/wheez
Thank you for you answer.
I wanted to emulate under cortex-M3 because I need to exéutute an
executable who will install a kernel but only runs under cortex-M3, for
then realized fuzzing on this kernel.
But, I will try with freeRTOS.
--
You received this bug notification because you are a member
Public bug reported:
Hi guys,
I try to emulate FreeRTOS with this guide :
http://wiki.csie.ncku.edu.tw/embedded/Lab32
But, the keys on my keyboard are not taken into account.
- Command line : qemu_stm32/arm-softmmu/qemu-system-arm -M stm32-p103 -monitor
stdio -kernel build/main.bin -semihosti
lobal instead of per-monitor. Is there a
reason why each monitor has its own set of fds? (Also I'm wondering
if they survive a monitor disconnect this way?)
2. Save a monitor reference with the fdset information.
Allowing to send file descriptors on every monitor, but making only
those of the default monitor actually usable, sounds like a bad choice
to me.
Kevin
Am 01.08.2012 17:15, schrieb Paolo Bonzini:
> Il 01/08/2012 16:59, Kevin Wolf ha scritto:
>> Block jobs aren't really different from guests in that respect. Maybe
>> the BB needs a second iostatus field that must explicitly be reset, and
>> the old one keeps
Am 02.08.2012 09:20, schrieb Kevin Shanahan:
> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote:
>> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote:
>>> On Thu, Aug 02, 2012 at 11:02:42AM +0930, Kevin Shanahan wrote:
>>>> Set the block d
Am 06.08.2012 11:44, schrieb Paolo Bonzini:
> Il 06/08/2012 11:29, Kevin Wolf ha scritto:
>>>>>> Block jobs aren't really different from guests in that respect. Maybe
>>>>>> the BB needs a second iostatus field that must explicitly be reset, and
>>
17 insertions(+), 11 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi
Thanks, applied to the block branch.
(But why do we even use any of the option functions instead of calling
strtosz_suffix?)
Kevin
Am 06.08.2012 15:32, schrieb Corey Bryant:
> On 08/06/2012 05:15 AM, Kevin Wolf wrote:
>> Am 03.08.2012 00:21, schrieb Corey Bryant:
>>>>> @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...)
>>>>>int ret;
>>>>
.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/039.out |6 +++---
tests/qemu-iotests/common.rc |8
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/qemu-iotests/039.out b/tests/qemu-iotests/039.out
index 8ad570d..155a05e 100644
--- a/tests/qemu-iotests/039
From: Dong Xu Wang
Signed-off-by: Dong Xu Wang
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
qemu-img.c | 28 +---
1 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index b866f80..94a31ad 100644
--- a/qemu-img.c
table entries.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 50 +--
block/qcow2.h |8 +++
tests/qemu-iotests/031.out | 20
tests/qemu-iotests/036.out |4 +-
4 files
From: Paolo Bonzini
Talk about background operations in general, rather than specifically
about streaming.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
hmp-commands.hx |2 +-
qapi-schema.json | 17 -
2 files changed, 9 insertions(+), 10 deletions(-)
diff
to share
broken image files without revealing data in bug reports.
This has lived in my local repo for a long time but could be useful
to others.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/qed.py | 235 +
1 files
From: Stefan Hajnoczi
The lazy refcounts bit indicates that this image can take advantage of
the dirty bit and that refcount updates can be postponed.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
docs/specs/qcow2.txt |7 ++-
1 files changed, 6 insertions(+), 1
introduces the
lazy_refcounts=on|off option. This ensures git-bisect(1) continues to
work.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/common.rc |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu
che=writethrough
Update qemu-iotests 031 and 036 since the extension header size changes
when we add feature bit table entries.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c |5 ++-
block/qcow2.c |
be an incompatible feature bit. We don't
want old programs accessing a file with stale refcounts.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
docs/specs/qcow2.txt |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/docs/specs/qcow2.txt b/docs/
. Written data can be read back successfully.
b. The image file can be repaired and will be marked clean again.
c. The image file is automatically repaired when opened read/write.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/039 | 136
grity test cases.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
qemu-io.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 8f3b94b..d0f4fb7 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -1652,6 +1652,17 @@ static const cmdinfo
QEMUOptionParameter in resize function
Kevin Wolf (1):
qemu-iotests: Be more flexible with image creation options
Markus Armbruster (1):
ide scsi: Mess with geometry only for hard disk devices
Paolo Bonzini (1):
qapi: generalize documentation of streaming commands
Stefan Hajnoczi (8
From: Markus Armbruster
Legacy -drive cyls=... are now ignored completely when the drive
doesn't back a hard disk device. Before, they were first checked
against a hard disk's limits, then ignored.
Signed-off-by: Markus Armbruster
Acked-by: Paolo Bonzini
Signed-off-by: Kevin Wol
Am 07.08.2012 10:47, schrieb Markus Armbruster:
> Kevin Wolf writes:
>
>> Am 02.08.2012 09:20, schrieb Kevin Shanahan:
>>> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote:
>>>> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote:
>>
bdrv_flush(bs);
>> +if (ret != 0) {
>> +error_set(errp, QERR_IO_ERROR);
>> +return;
>> +}
>> +
>
> We also need to reopen bs->file, so maybe something like this:
>
> /* open any file images */
> if (bs->file) {
> bdrv_reopen(bs->file, bdrv_flags, errp);
> if (errp && *errp) {
> goto exit;
> }
> }
>
> This will necessitate making the handlers in the raw.c file just stubs
> (I'll respond to that patch as well).
Doesn't this break the transactional semantics? I think you should only
prepare the bs->file reopen here and commit it when committing this one.
Kevin
; +cleanup_unknown_header_ext(bs);
>> +
>> +g_free(stashed_s->cluster_cache);
>> +qemu_vfree(stashed_s->cluster_data);
>
>
>
>> +qcow2_refcount_close(bs);
>> +qcow2_free_snapshots(bs);
>
> I assume these are unintentional? I believe this is what is causing your
> double-free issue.
This whole patch looks a bit complicated and brittle. What qcow2 state
do you actually expect to change with a new qcow2_open()? Is it even
required to do more than just modifying bs->file? qcow2 doesn't really
do anything with the flags.
Kevin
?
>
> That was me working on it. I have a branch corresponding to an RFC I
> sent around Christmas - issue being how to model the variable number of
> ports in VMSD - that I need to update to the latest suggestion by Igor.
>
> Jason/Kevin, should I prioritize that for 1.2?
w_buf()
>
> dma-helpers.c |1 +
> hw/ide/ahci.c | 44 +---
> hw/ide/internal.h |1 +
> 3 files changed, 39 insertions(+), 7 deletions(-)
>
Thanks, applied both to the block branch.
Kevin
> +#
>> +# Since: 1.2.0
>> +##
>> +{ 'type': 'FdsetFdInfo', 'data': {'fd': 'int', 'removed': 'bool'} }
>
> Is it worth providing any additional information? For example, knowing
> whether the fd is O_RDONLY, O_WRONLY, or O_RDWR might be beneficial to
> management apps trying to discover what fds are already present after a
> reconnection, in order to decide whether to close them without having to
> resort to /proc/$qemupid/fdinfo/nnn lookups. It might even be worth
> marking such information optional, present only when 'removed':false.
Why do we even include removed=true file descriptors in query-fdsets?
Shouldn't they appear to be, well, removed from a clients POV?
The problem with adding flags is the same as with errno numbers: How to
do it in a platform independent way? The management application might
run on a different OS than qemu, so a numeric 'flags' field could have
an entirely different meaning there.
We could add bools for some flags and an enum for
O_RDONLY/O_WRONLY/O_RDWR, but it's probably better to wait until we know
which of them we really need.
Kevin
Am 06.08.2012 23:57, schrieb Eric Blake:
> On 08/06/2012 03:54 PM, Eric Blake wrote:
>> On 08/06/2012 02:44 PM, Kevin Wolf wrote:
>>> qemu-iotests already filters out image creation options that may be
>>> present or not in order to get the same output in both cases.
> fix any issues poping up in testing.
> - roll out seabios release by end of august, so it can be included
> into qemu 1.2
>
> Anthony? Kevin? Fine are you ok with this?
Would the above schedule be realistic? I'm be inclined to just go
with seabios 1.7.0 in 1.2 and arrange for an upgrade for the next qemu
release.
-Kevin
Am 09.08.2012 16:07, schrieb Paolo Bonzini:
> Kevin,
>
> here is a resend of the virtio-blk patches plus the one-liner for
> flipping the default cache mode from writethrough to writeback.
>
> Paolo Bonzini (3):
> virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE
> virtio-
Instead of building a huge pipeline, just pass all expressions to a
single sed process.
Suggested-by: Eric Blake
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/common.rc | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/qemu-iotests/common.rc
Am 09.08.2012 14:05, schrieb Stefan Hajnoczi:
> The qcow2 lazy refcount feature was merged with two pending clean-ups
> suggested
> by Kevin:
>
> 1. Ensure that qemu-iotests/check -nocache 039 does not fail.
>
> 2. Fix qemu-img check output when a dirty image file is
/* information */
> +/* image related info, static information, from user perspective. */
> +/* now it is a plain structure, wonder if it could be foldered into embbed
> one
> + to reflect that format related information better. */
> +struct QBlockInfoImage {
> +int struct_size;
> +char *filename;
> +enum QBlockProtocol protocol;
> +enum QBlockFormat format;
> +size_t virt_size;
> +/* advance info */
> +size_t allocated_size;
> +bool encrypt;
> +char *backing_filename;
> +};
What about things like cluster size, dirty state etc. that only some
image formats have?
> +
> +/* image info */
> +/*
> + get image info.
> + params:
> + qbs: in, pointer to QBlockState.
> + info, out, pointer that would receive the information.
> + return:
> + negative on fail, 0 on success.
> + */
> +int qb_infoimage_get(struct QBlockState *qbs, struct QBlockInfoImage **info);
> +
> +/*
> + free image info.
> + params:
> + info, in, pointer, *info would be set to NULL after function called.
> + return:
> + void.
> + */
> +void qb_infoimage_free(struct QBlockInfoImage **info);
> +
> +/* misc */
> +bool qb_supports_format(enum QBlockFormat fmt);
> +bool qb_supports_protocol(enum QBlockProtocol proto);
> +
> +const char *qb_error_get_detail(struct QBlockState *qbs, int *err_num);
This needs a more detailed description. I also think that you'll want to
add a const char** parameter for human readable error messages (as
printed with qerror_report or error_set in qemu).
Kevin
LIST_ENTRY(MonFdset) next;
> +};
> +
> typedef struct MonitorControl {
> QObject *id;
> JSONMessageParser parser;
> @@ -211,6 +229,8 @@ static inline int mon_print_count_get(const Monitor *mon)
> { return 0; }
> #define QMP_ACCEPT_UNKNOWNS 1
>
> static QLIST_HEAD(mon_list, Monitor) mon_list;
> +static QLIST_HEAD(mon_fdsets, MonFdset) mon_fdsets;
> +static int mon_refcount;
You introduce mon_refcount in this patch and check it against 0 in one
place, but it never gets changed until patch 3 is applied. Would it make
sense to do both in the same patch?
Kevin
}
qemu_open() is supposed to add O_CLOEXEC by itself, so I think we should
execute the then branch unconditionally (or we would have to change the
qemu_dup() call below to add it - but the fact that O_CLOEXEC isn't even
necessarily defined doesn't help with that).
Kevin
> monitor.h |5 +
> osdep.c | 117 +
> qapi-schema.json | 98 ++
> qemu-char.c | 12 ++-
> qemu-common.h |2 +
> qemu-tool.c | 20
> qmp-commands.hx | 117 +++++
> savevm.c |4 +-
> 16 files changed, 721 insertions(+), 55 deletions(-)
Apart from the few comments I made, I like this series. Maybe v9 will be
the last one. :-)
Kevin
From: Paolo Bonzini
Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with
the spec.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
hw/virtio-blk.c | 16 ++--
hw/virtio-blk.h |4 +++-
2 files changed, 17 insertions(+), 3 deletions(-)
diff
better idea, with a breakpoint on bdrv_open
and all cache choices one by one.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
blockdev.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 8669142..7c83baa 100644
--- a/blockdev.c
+++ b
epath that tries to free the sglist.
Signed-off-by: Jason Baron
Signed-off-by: Kevin Wolf
---
dma-helpers.c |1 +
hw/ide/ahci.c |3 +++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/dma-helpers.c b/dma-helpers.c
index 35cb500..13593d1 100644
--- a/dma-helpers.c
+++ b/dma
while handling scsi commands
Jason Baron (2):
ahci: Fix ahci cdrom read corruptions for reads > 128k
ahci: Fix sglist memleak in ahci_dma_rw_buf()
Kevin Wolf (1):
qemu-iotests: Save some sed processes
Paolo Bonzini (3):
virtio-blk: support VIRTIO_BLK_F_CONFIG_
Signed-off-by: Kevin Wolf
---
hw/virtio-blk.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index f21757e..552b3b6 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -254,6 +254,7 @@ static void virtio_blk_handle_scsi(VirtIOBlockReq
sts 039 to reflect the new
qemu-img check output.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block.h|1 +
block/qcow2.c |4 ++--
block/qed.c|2 +-
qemu-img.c |2 +-
tests/qemu-iotests/039.out |6 +
: Kevin Wolf
---
hw/virtio-blk.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 97bb4bd..fd8fa90 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -543,6 +543,19 @@ static uint32_t virtio_blk_get_features(VirtIODevice
Signed-off-by: Kevin Wolf
---
block/qed-check.c | 26 ++
block/qed.c |9 +
block/qed.h |5 +
3 files changed, 32 insertions(+), 8 deletions(-)
diff --git a/block/qed-check.c b/block/qed-check.c
index 5edf607..b473dcd 100644
--- a/block
: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 28 +++-
1 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index fd5e214..5896fd6 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -270,6 +270,20 @@ static int
From: Stefan Hajnoczi
When the qemu-io --nocache option is used the 039 test case cannot abort
QEMU at a point where the image is dirty. Skip the test case.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/039 |1 +
tests/qemu-iotests/common.rc
ulate_sglist() to take a new
3rd offset argument, so that the sglist is property initialized.
I've tested this patch using 'dd' testing, and Fedora 17 now correctly boots
and installs on q35 with the cdrom ahci controller.
Signed-off-by: Jason Baron
Tested-by: Andreas Färber
Si
Instead of building a huge pipeline, just pass all expressions to a
single sed process.
Suggested-by: Eric Blake
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/common.rc | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a
On Thu, Aug 09, 2012 at 10:42:51AM +0200, Kevin Wolf wrote:
> Am 07.08.2012 10:47, schrieb Markus Armbruster:
> > Kevin Wolf writes:
> >
> >> Am 02.08.2012 09:20, schrieb Kevin Shanahan:
> >>> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote:
ion was to declare that a zero bytecount was illegal, I guess.
>
> Acked-by: Michael Tokarev
>
> Kevin, does this fix the test-iov failure you're seeing on one of
> the build bots?
It's not on a build bot but on my test machine, but yes, this does fix
it indeed. Thanks for looking into it, Peter!
Kevin
>> paths would not be possible. How about comma as separator?
>
> I just tried comma but it fail because the qemu command line parsing
> catch it believing that the string next to the coma is another "file="
> like options.
>
> Is there any other separator we can use ?
I would ignore that for now, or you can introduce your own escaping of
colons. The real solution is, once again, -blockdev.
Kevin
Am 12.08.2012 04:48, schrieb Kevin Shanahan:
> So qmp_change_blockdev uses bdrv_is_read_only() to check whether to
> try and open the backing file read only, which uses the ->read_only
> member of struct BlockDriverState to decide whether to pass the
> BDRV_O_RDRW flag to qmp_bdr
> +
> +out:
> +s->qemu_aio_count--;
> +qemu_aio_release(acb);
> +return NULL;
> +}
> +
> +static BlockDriverAIOCB *qemu_gluster_aio_readv(BlockDriverState *bs,
> + int64_t sector_num, QEMUIOVector *qiov, int nb_sectors,
> +BlockDriverCompletionFunc *cb, void *opaque)
> +{
> +return qemu_gluster_aio_rw(bs, sector_num, qiov, nb_sectors, cb, opaque,
> 0);
> +}
> +
> +static BlockDriverAIOCB *qemu_gluster_aio_writev(BlockDriverState *bs,
> +int64_t sector_num, QEMUIOVector *qiov, int nb_sectors,
> +BlockDriverCompletionFunc *cb, void *opaque)
> +{
> +return qemu_gluster_aio_rw(bs, sector_num, qiov, nb_sectors, cb, opaque,
> 1);
> +}
> +
> +static BlockDriverAIOCB *qemu_gluster_aio_flush(BlockDriverState *bs,
> +BlockDriverCompletionFunc *cb, void *opaque)
> +{
> +int ret;
> +GlusterAIOCB *acb;
> +BDRVGlusterState *s = bs->opaque;
> +
> +acb = qemu_aio_get(&gluster_aio_pool, bs, cb, opaque);
> +acb->size = 0;
> +acb->ret = 0;
> +acb->canceled = false;
> +s->qemu_aio_count++;
> +
> +ret = glfs_fsync_async(s->fd, &gluster_finish_aiocb, acb);
> +if (ret < 0) {
> +goto out;
> +}
> +return &acb->common;
> +
> +out:
> +s->qemu_aio_count--;
> +qemu_aio_release(acb);
> +return NULL;
> +}
> +
> +static int64_t qemu_gluster_getlength(BlockDriverState *bs)
> +{
> +BDRVGlusterState *s = bs->opaque;
> +struct stat st;
> +int ret;
> +
> +ret = glfs_fstat(s->fd, &st);
> +if (ret < 0) {
> +return -errno;
> +} else {
> +return st.st_size;
> +}
> +}
> +
> +static void qemu_gluster_close(BlockDriverState *bs)
> +{
> +BDRVGlusterState *s = bs->opaque;
> +
> +if (s->fd) {
> +glfs_close(s->fd);
> +s->fd = NULL;
> +}
> +glfs_fini(s->glfs);
> +}
> +
> +static QEMUOptionParameter qemu_gluster_create_options[] = {
> +{
> +.name = BLOCK_OPT_SIZE,
> +.type = OPT_SIZE,
> +.help = "Virtual disk size"
> +},
> +{ NULL }
> +};
> +
> +static BlockDriver bdrv_gluster = {
> +.format_name = "gluster",
> +.protocol_name = "gluster",
> +.instance_size = sizeof(BDRVGlusterState),
> +.bdrv_file_open = qemu_gluster_open,
> +.bdrv_close = qemu_gluster_close,
> +.bdrv_create = qemu_gluster_create,
> +.bdrv_getlength = qemu_gluster_getlength,
> +
> +.bdrv_aio_readv = qemu_gluster_aio_readv,
> +.bdrv_aio_writev = qemu_gluster_aio_writev,
> +.bdrv_aio_flush = qemu_gluster_aio_flush,
> +
> +.create_options = qemu_gluster_create_options,
Please align the = on the same column.
> +};
> +
> +static void bdrv_gluster_init(void)
> +{
> +bdrv_register(&bdrv_gluster);
> +}
> +
> +block_init(bdrv_gluster_init);
Kevin
Am 13.08.2012 13:57, schrieb Markus Armbruster:
> Kevin Wolf writes:
>
>> Am 12.08.2012 04:48, schrieb Kevin Shanahan:
>>> So qmp_change_blockdev uses bdrv_is_read_only() to check whether to
>>> try and open the backing file read only, which uses the -&
biggest concern. If you want to do this, I suggest we pull the
current SeaBIOS snapshot now (as Gerd's plan calls for), and I'll
immediately start a bugfix only mode.
-Kevin
Am 14.08.2012 06:38, schrieb Bharata B Rao:
> Kevin, Thanks for your review. I will address all of your comments
> in the next iteration, but have a few questions/comments on the others...
>
> On Mon, Aug 13, 2012 at 02:50:29PM +0200, Kevin Wolf wrote:
>>> +static int parse_s
Am 14.08.2012 11:34, schrieb Bharata B Rao:
> On Tue, Aug 14, 2012 at 10:29:26AM +0200, Kevin Wolf wrote:
>>>
>>> Yes, and that will result in port=0, which is default. So this is to
>>> cater for cases like gluster://[1:2:3:4:5]:/volname/image
>>
>> So y
: Clean up fd sets on monitor disconnect
Thanks, applied all to the block branch.
>> Hooray - I think we're there! Series:
>>
>> Reviewed-by: Eric Blake
>>
>
> Thanks again!!
>
> Btw, In the case that no new versions of the patches need to be
> submitted, how does your Reviewed-by get added? Do I need to do
> anything to add it?
No, I picked it up.
Kevin
;
>>> + } else {
>>> + s->open_flags &= ~O_DIRECT;
>>> + }
>>> + ret = fcntl_setfl(s->fd, s->open_flags);
>>> + } else {
>>> +
>>> + /* close and reopen using new flags */
>>> + bs->drv->bdrv_close(bs);
>&
ash the following in (linking vscclient and qtests
with qemu-tool.o). Any objections?
Kevin
diff --git a/Makefile b/Makefile
index d736ea5..a11a7f4 100644
--- a/Makefile
+++ b/Makefile
@@ -148,9 +148,6 @@ install-libcacard: libcacard.la
$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -
eems to be uninitialised if
!has_blk. I think this needs to be fixed. (Why does qmp-marshal.c even
compile when it can use blk uninitialised...?)
Kevin
> +qerror_report(ERROR_CLASS_GENERIC_ERROR,
> + "Block migration is deprecated. "
> +
and I should
pick it up? (Still for 1.2, I guess?)
Kevin
t; + scsi_free_scsi_task(acb->task);
> + acb->task = NULL;
Please use scripts/checkpatch.pl. qemu uses an indentation of four
spaces, more coding style violations follow.
Kevin
Am 14.08.2012 16:52, schrieb Luiz Capitulino:
> On Tue, 14 Aug 2012 15:48:37 +0200
> Kevin Wolf wrote:
>
>> Am 14.08.2012 15:32, schrieb Anthony Liguori:
>>> To be replaced with live block copy.
>>>
>>> Signed-off-by: Anthony Liguori
>>
>
Am 14.08.2012 17:48, schrieb Luiz Capitulino:
> On Tue, 14 Aug 2012 17:02:26 +0200
> Kevin Wolf wrote:
>
>> Am 14.08.2012 16:52, schrieb Luiz Capitulino:
>>> On Tue, 14 Aug 2012 15:48:37 +0200
>>> Kevin Wolf wrote:
>>>
>>>> Am 14.08.2012 15:
Am 15.08.2012 07:21, schrieb Bharata B Rao:
> On Tue, Aug 14, 2012 at 10:29:26AM +0200, Kevin Wolf wrote:
>>>>> +static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret, void
>>>>> *arg)
>>>>> +{
>>>>> +GlusterAIOCB *
sk = NULL;
>> }
Fixed the indentation here (which checkpatch unfortunately doesn't seem
to recognise) and applied to the block branch. Thanks.
Kevin
Am 14.08.2012 18:56, schrieb Benoît Canet:
> Le Monday 13 Aug 2012 à 09:41:00 (+0200), Kevin Wolf a écrit :
>> Am 10.08.2012 19:48, schrieb Benoît Canet:
>>> Le Tuesday 07 Aug 2012 à 20:30:09 (+), Blue Swirl a écrit :
>>>> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Ca
only flush_to_disk. It starts to matter when drivers that
are not on top implement flush_to_os.
Signed-off-by: Kevin Wolf
---
block.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index 016858b..470bdcc 100644
--- a/block.c
+++ b/block.c
@@ -3534,7
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/030 |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
index cc671dd..f71ab8d 100755
--- a/tests/qemu-iotests/030
+++ b/tests/qemu-iotests/030
@@ -225,8 +225,7 @@ class
> This has recently been discussed, please search the list for more info
> from Kevin Wolf or Paolo Bonzini.
>
> qcow2 marks the discarded blocks as free and will reuse them in future
> allocations. It does *not* discard at the OS level.
>
> For raw files you can get disc
From: Corey Bryant
Set the close-on-exec flag for the file descriptor received
via SCM_RIGHTS.
Signed-off-by: Corey Bryant
Signed-off-by: Kevin Wolf
---
qemu-char.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 382c71e
From: Corey Bryant
This patch converts all block layer open calls to qemu_open.
Note that this adds the O_CLOEXEC flag to the changed open paths
when the O_CLOEXEC macro is defined.
Signed-off-by: Corey Bryant
Signed-off-by: Kevin Wolf
---
block/raw-posix.c | 18 +-
block
th fd sets
monitor: Clean up fd sets on monitor disconnect
Kevin Wolf (2):
block: Flush parent to OS with cache=unsafe
qemu-iotests: Fix 030 after switch to GenericError
Stefan Priebe (1):
iscsi: Fix NULL dereferences / races between task completion and abort
Makefile
From: Stefan Priebe
Signed-off-by: Stefan Priebe
Acked-by: Ronnie Sahlberg
Signed-off-by: Kevin Wolf
---
block/iscsi.c | 55 +++
1 files changed, 23 insertions(+), 32 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 219f927
h the existing getfd
and closefd QMP commands.
Signed-off-by: Corey Bryant
Signed-off-by: Kevin Wolf
---
monitor.c| 189 ++
qapi-schema.json | 98
qmp-commands.hx | 122
From: Corey Bryant
This patch converts all block layer close calls, that correspond
to qemu_open calls, to qemu_close.
Signed-off-by: Corey Bryant
Signed-off-by: Kevin Wolf
---
block/raw-posix.c | 24
block/raw-win32.c |2 +-
block/vmdk.c |4
associated with a client disconnect prior to using a passed fd.
Signed-off-by: Corey Bryant
Signed-off-by: Kevin Wolf
---
monitor.c | 23 ++-
1 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/monitor.c b/monitor.c
index a4a29b9..ce42466 100644
--- a/monitor.c
only flush_to_disk. It starts to matter when drivers that
are not on top implement flush_to_os.
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
---
block.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index 016858b..470bdcc 100644
--- a
ned-off-by: Corey Bryant
Signed-off-by: Kevin Wolf
---
Makefile |6 ++--
cutils.c |5 +++
monitor.c | 86 +++-
monitor.h |5 +++
osdep.c| 111
qemu-common
From: Corey Bryant
Signed-off-by: Corey Bryant
Signed-off-by: Kevin Wolf
---
block/raw-posix.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 0dce089..f606211 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
---
tests/qemu-iotests/030 |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
index cc671dd..f71ab8d 100755
--- a/tests/qemu-iotests/030
+++ b/tests/qemu-iotests/030
d.net/qemu/+bug/1028908
[1]
http://downloads.puppetlabs.com/learning/learn_puppet_centos_pe2.5.1_ovf.2012.04.18.zip
Kevin Wolf (2):
vmdk: Fix header structure
vmdk: Read footer for streamOptimized images
block/vmdk.c | 18 +-
1 files changed, 17 insertions(+), 1 deletions(-)
--
1.7.6.5
The footer takes precedence over the header when it exists. It contains
the real grain directory offset that is missing in the header. Without
this patch, streamOptimized images with a footer cannot be read.
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 16
1 files changed, 16
Commit bb45ded9 swapped gd_offset and rgd_offset. This is wrong.
Signed-off-by: Kevin Wolf
---
block/vmdk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index daee426..9648398 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -57,8 +57,8
ff-by: Kevin Wolf
---
qemu-img.texi |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/qemu-img.texi b/qemu-img.texi
index 77c6d0b..0b363e7 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -4,6 +4,14 @@ usage: qemu-img command [command options]
@c man end
@end ex
t VIRTIO_BLK_F_CONFIG_WCE
>
> Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with
> the spec.
>
> Signed-off-by: Paolo Bonzini
> Signed-off-by: Kevin Wolf
>
> Anthony Liguori reported:
>
> This broke qemu-test becaus
The footer takes precedence over the header when it exists. It contains
the real grain directory offset that is missing in the header. Without
this patch, streamOptimized images with a footer cannot be read.
Signed-off-by: Kevin Wolf
---
v2:
- Enough footer sanity checks, I hope? :-)
block
Am 16.08.2012 14:56, schrieb Eric Blake:
> On 08/16/2012 04:00 AM, Peter Maydell wrote:
>> On 16 August 2012 10:00, Kevin Wolf wrote:
>>> People have repeatedly expected that you can do things like snapshotting
>>> an image with qemu-img while a qemu instance is ru
t; really simple.
It's a clear bug fix, easy to understand and low risk, and even rc0
isn't out yet. I think this would still be fine for 1.2.
Kevin
r these two, and from the code it looks like this difference is rather
> accidental than intentional.
It was probably accidental in the beginning, but it's now a well-known
misfeature that we can't get rid of for compatibility reasons. People
rely on devices with colons being accessible this way. (We once changed
that, but had to take this part back)
Kevin
_filename);
> +image_info->backing_filename_format =
> +g_strdup(bdrv_get_format_name(backing_bs));
> +bdrv_delete(backing_bs);
> +PRINTH(human, "backing file: %s", backing_filename);
> if (strcmp(backing_filename, backing_filename2) != 0) {
> -printf(" (actual path: %s)", backing_filename2);
> +PRINTH(human, " (actual path: %s)", backing_filename2);
> +}
> +if (human) {
> +putchar('\n');
> }
> -putchar('\n');
> +image_info->has_backing_filename = true;
> +image_info->has_backing_filename_format = true;
> }
> -dump_snapshots(bs);
> +
> +if (human) {
> +dump_snapshots(bs);
> +} else {
> +collect_snapshots(bs, image_info);
> +dump_json_image_info(image_info);
> +}
> +
> +qapi_free_ImageInfo(image_info);
> bdrv_delete(bs);
> return 0;
> }
I'm not sure if mixing both modes this way is a great idea. Maybe it's
better to have separate functions for either filling the ImageInfo
struct or human output, that are called only in the appropriate mode.
Kevin
Am 17.08.2012 12:05, schrieb Iustin Pop:
> On Fri, Aug 17, 2012 at 09:56:35AM +0200, Kevin Wolf wrote:
>> Am 17.08.2012 09:15, schrieb Iustin Pop:
>>> On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote:
>>>> On 16.08.2012 18:58, Iustin Pop wrote:
>&g
Am 17.08.2012 15:30, schrieb Jim Meyering:
> Kevin Wolf wrote:
>> Am 16.05.2012 15:07, schrieb Jim Meyering:
>>> From: Jim Meyering
>>>
>>> Signed-off-by: Jim Meyering
>>
>> Acked-by: Kevin Wolf
>
> Hi Kevin,
>
> AFAICS, only one of
The following changes since commit 731dc9ecd4f2c3041538f7eb2d10eee0cb82da1b:
Update version to 1.2.0-rc0 (2012-08-16 13:56:34 -0500)
are available in the git repository at:
http://repo.or.cz/r/qemu/kevin.git for-anthony
Kevin Wolf (3):
vmdk: Fix header structure
vmdk: Read
The footer takes precedence over the header when it exists. It contains
the real grain directory offset that is missing in the header. Without
this patch, streamOptimized images with a footer cannot be read.
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Jeff Cody
Commit bb45ded9 swapped gd_offset and rgd_offset. This is wrong.
Signed-off-by: Kevin Wolf
---
block/vmdk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index daee426..9648398 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -57,8 +57,8
ff-by: Kevin Wolf
---
qemu-img.texi |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/qemu-img.texi b/qemu-img.texi
index 77c6d0b..77b2c47 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -4,6 +4,14 @@ usage: qemu-img command [command options]
@c man end
@end ex
spec.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
Anthony Liguori reported:
This broke qemu-test because it changed the pc-1.0 machine type:
Setting guest RANDOM seed to 47167
*** Running tests ***
Running test /tests/finger-print.sh...OK
---
1 - 100 of 25553 matches
Mail list logo
